Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-14 Thread Steven Hartland
Any thoughts on my previous reply? On Mon, 4 Jul 2022 at 23:33, Steven Hartland wrote: > I'm not sure we're on the same page, so let me try and clarify. > > The files have multiple tracks, the standard audio and video and 3 > metadata tracks. I'm using the c

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-04 Thread Steven Hartland
I'm not sure we're on the same page, so let me try and clarify. The files have multiple tracks, the standard audio and video and 3 metadata tracks. I'm using the command line option -map 0:m:handler_name:"" to identify the tracks to copy. Given a single file this works as expected, but as soon as

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-02 Thread Steven Hartland
I should mention that this one of a few fixes needed to enable successful copying of GoPro metadata when using concat to join files, but wanted to start with from its size was the simplest one :) On Sat, 2 Jul 2022 at 11:44, Steven Hartland wrote: > I'm using concat to join multiple fi

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-02 Thread Steven Hartland
8x ... I believe the reason for the failure is that this early return prevents the metadata from being preserved. On Sun, 19 Jun 2022 at 21:18, Marton Balint wrote: > > > On Sun, 12 Jun 2022, Steven Hartland wrote: > > > Remove return after copying extradata as this prevents

[FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-06-12 Thread Steven Hartland
Remove return after copying extradata as this prevents metadata being duplicated correctly. Signed-off-by: Steven Hartland --- libavformat/concatdec.c | 1 - tests/ref/fate/concat-demuxer-simple2-lavf-ts | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a