Re: [FFmpeg-devel] [PATCH v10 06/15] fftools/textformat: Introduce AVTextFormatOptions for avtext_context_open()

2025-05-08 Thread Stefano Sabatini
On date Thursday 2025-05-08 00:25:28 +, softworkz . wrote: > > -Original Message- > > From: Stefano Sabatini > > Sent: Donnerstag, 8. Mai 2025 02:06 > > To: FFmpeg development discussions and patches > > Cc: softworkz > > Subject: Re: [FFm

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-05-08 Thread Stefano Sabatini
On date Wednesday 2025-05-07 23:42:53 +, softworkz . wrote: > > -Original Message- > > From: Stefano Sabatini > > Sent: Donnerstag, 8. Mai 2025 01:31 > > To: softworkz . > > Cc: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-d

Re: [FFmpeg-devel] [PATCH v10 06/15] fftools/textformat: Introduce AVTextFormatOptions for avtext_context_open()

2025-05-07 Thread Stefano Sabatini
On date Sunday 2025-05-04 02:57:17 +, softworkz wrote: > From: softworkz > > This allows future addition of options without > changes to the signature of avtext_context_open(). > > Reviewed-by: Stefano Sabatini > Signed-off-by: softworkz > --- > fftools/ffp

Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting and whitespace changes

2025-05-07 Thread Stefano Sabatini
On date Wednesday 2025-05-07 23:59:39 +, softworkz . wrote: > > > > -Original Message- > > From: Stefano Sabatini > > Sent: Donnerstag, 8. Mai 2025 01:45 > > To: FFmpeg development discussions and patches > > Cc: softworkz > > Subject: Re

Re: [FFmpeg-devel] [PATCH v10 05/15] fftools/avtextformat: Re-use BPrint in loop

2025-05-07 Thread Stefano Sabatini
On date Sunday 2025-05-04 02:57:16 +, softworkz wrote: > From: softworkz > > Instead of initializing a new BPrint in each iteration of > the loop, a new BPrint in case of UTF decode error > re-use the same BPrint struct and just clear it > for each iteration. > > Signed-off-by: softworkz

Re: [FFmpeg-devel] [PATCH v10 03/15] fftools/textformat: Remove unused print_rational() pointer from AVTextFormatter

2025-05-07 Thread Stefano Sabatini
On date Sunday 2025-05-04 02:57:14 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/textformat/avtextformat.h | 1 - > fftools/textformat/avtextwriters.h | 5 - > 2 files changed, 6 deletions(-) > > diff --git a/fftools/textformat/avtextformat.h > b/

Re: [FFmpeg-devel] [PATCH v10 04/15] fftools/textformat: Rename name param to key for API consistency

2025-05-07 Thread Stefano Sabatini
On date Sunday 2025-05-04 02:57:15 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/textformat/avtextformat.c | 14 +++--- > fftools/textformat/avtextformat.h | 6 +++--- > 2 files changed, 10 insertions(+), 10 deletions(-) LGTM. _

Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting and whitespace changes

2025-05-07 Thread Stefano Sabatini
On date Sunday 2025-05-04 02:57:12 +, softworkz wrote: > From: softworkz [...] nit: use verb-object form in topic line - as in "apply formatting and whitespace changes" - for consistency and easier human readers processing. ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-05-07 Thread Stefano Sabatini
On date Saturday 2025-05-03 08:55:42 +, softworkz . wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of softworkz > > . > > Sent: Dienstag, 29. April 2025 01:24 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [RFC] Shaping the AVTextFo

Re: [FFmpeg-devel] [PATCH v10 01/15] fftools/textformat: Formatting and whitespace changes

2025-05-07 Thread Stefano Sabatini
On date Sunday 2025-05-04 02:57:12 +, softworkz wrote: > From: softworkz > > Reviewed-by: Stefano Sabatini > Signed-off-by: softworkz > --- > fftools/textformat/avtextformat.c | 92 +++--- > fftools/textformat/avtextformat.h | 20 +++

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-05-07 Thread Stefano Sabatini
On date Monday 2025-05-05 16:32:08 +0200, Nicolas George wrote: > Stefano Sabatini (HE12025-05-04): > > I don't understand this claim. There is a root, and each section can > > have several subsections, so it is a tree in my view, although we set > > a maximum depth. Wher

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-05-04 Thread Stefano Sabatini
On date Tuesday 2025-04-29 10:30:55 +0200, Nicolas George wrote: > Stefano Sabatini (HE12025-04-27): > > Elaborating on this. ffprobe/textformat is based on a notion of > > hierarchical tree-like data > > No, this is not true. FFprobe and all its supporting code is ba

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-04-28 Thread Stefano Sabatini
On date Sunday 2025-04-27 17:54:21 +, softworkz . wrote: > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > Stefano Sabatini > > Sent: Sonntag, 27. April 2025 12:42 > > To: FFmpeg development discussions and patches > de...@ffm

Re: [FFmpeg-devel] [PATCH v7 02/13] fftools/textformat: Apply quality improvements

2025-04-28 Thread Stefano Sabatini
On date Monday 2025-04-28 20:40:37 +, softworkz . wrote: [...] > > > > > /* validate replace string */ > > > > > { > > > > > -const uint8_t *p = tctx->string_validation_replacement; > > > > > -const uint8_t *endp = p + strlen(p); > > > > > +const uint8_t *p = (

Re: [FFmpeg-devel] [PATCH v7 02/13] fftools/textformat: Apply quality improvements

2025-04-28 Thread Stefano Sabatini
On date Monday 2025-04-28 20:05:25 +, softworkz . wrote: > > > > -Original Message- > > From: Stefano Sabatini > > Sent: Montag, 28. April 2025 21:56 > > To: FFmpeg development discussions and patches > > Cc: softworkz > > Subject: R

Re: [FFmpeg-devel] [PATCH v7 02/13] fftools/textformat: Apply quality improvements

2025-04-28 Thread Stefano Sabatini
On date Friday 2025-04-25 23:30:57 +, softworkz wrote: > From: softworkz > > Perform multiple improvements to increase code robustness. > In particular: > - favor unsigned counters for loops > - add missing checks > - avoid possible leaks > - move variable declarations to inner scopes when fe

Re: [FFmpeg-devel] [PATCH v7 01/13] fftools/textformat: Formatting and whitespace changes

2025-04-27 Thread Stefano Sabatini
On date Friday 2025-04-25 23:30:56 +, softworkz wrote: > From: softworkz > @@ -484,15 +481,14 @@ void avtext_print_time(AVTextFormatContext *tctx, const > char *key, > > void avtext_print_ts(AVTextFormatContext *tctx, const char *key, int64_t ts, > int is_duration) > { > -if ((!is_du

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-04-27 Thread Stefano Sabatini
On date Friday 2025-04-25 13:16:59 +, softworkz . wrote: [...] > Tell me what I should check for and what not in those four groups of > functions and for those things which should be checked, tell me which > way (return error, return silently, allow segfault or use an assertion). > > Then I'l

Re: [FFmpeg-devel] [RFC] Shaping the AVTextFormat API Surface

2025-04-27 Thread Stefano Sabatini
On date Thursday 2025-04-24 19:12:09 +0200, Nicolas George wrote: > softworkz . (HE12025-04-22): [...] > ffprobe has a concept of sections, and no more. XML does not have a > concept of sections. JSON does not have a concept of sections. CSV does > not have a concept of sections. Other parts of FFm

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: add avformat_query_seekable

2025-04-23 Thread Stefano Sabatini
On date Tuesday 2025-04-22 10:24:01 +0530, Gyan Doshi wrote: > On 2025-04-21 11:59 pm, Stefano Sabatini wrote: > > On date Tuesday 2025-04-15 16:09:56 +0530, Gyan Doshi wrote: > > > Utility function to report seekability features for a given input. > > > > > &

Re: [FFmpeg-devel] [PATCH v5 03/14] fftools/avtextformat: Re-use BPrint in loop

2025-04-23 Thread Stefano Sabatini
On date Tuesday 2025-04-22 21:55:32 +, softworkz wrote: > From: softworkz > > Instead of initializing a new BPrint in each iteration of > the loop, re-use the same BPrint struct and just clear it > for each iteration. > > Signed-off-by: softworkz > --- > fftools/textformat/avtextformat.c |

Re: [FFmpeg-devel] [PATCH v5 06/14] fftools/textformat: AVTextWriter change writer_printf signature

2025-04-23 Thread Stefano Sabatini
On date Tuesday 2025-04-22 21:55:35 +, softworkz wrote: > From: softworkz > > Using va_list provides greater flebility flebility typo Also this looks more about factorization than flexibility (for an API used directly by users the ... format is better). > > Signed-off-by: softworkz > --

Re: [FFmpeg-devel] [PATCH v5 07/14] fftools/tf_internal: Use av_default_item_name

2025-04-23 Thread Stefano Sabatini
On date Tuesday 2025-04-22 21:55:36 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/textformat/tf_internal.h | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/fftools/textformat/tf_internal.h > b/fftools/textformat/tf_internal

Re: [FFmpeg-devel] [PATCH v4 05/11] fftools/textformat: Add function avtext_print_integer_flags()

2025-04-23 Thread Stefano Sabatini
On date Sunday 2025-04-20 22:59:08 +, softworkz wrote: > From: softworkz > > This function works analog to the avtext_print_string() which already > has a flags parameter. > > Signed-off-by: softworkz > --- > fftools/textformat/avtextformat.c | 21 + > fftools/textforma

Re: [FFmpeg-devel] [PATCH v5 05/14] fftools/textformat: Introduce common header and deduplicate code

2025-04-23 Thread Stefano Sabatini
On date Tuesday 2025-04-22 21:55:34 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/textformat/tf_compact.c | 32 +--- > fftools/textformat/tf_default.c | 27 +++--- > fftools/textformat/tf_flat.c | 25 +++--- > fftools/textformat/tf_

Re: [FFmpeg-devel] [PATCH v5 04/14] fftools/textformat: Introduce AVTextFormatOptions for avtext_context_open()

2025-04-23 Thread Stefano Sabatini
On date Tuesday 2025-04-22 21:55:33 +, softworkz wrote: > From: softworkz > > This allows future addition of options without > changes to the signature of avtext_context_open(). > > Signed-off-by: softworkz > --- > fftools/ffprobe.c | 13 + > fftools/textformat/

Re: [FFmpeg-devel] [PATCH v5 02/14] fftools/textformat: Apply quality improvements

2025-04-23 Thread Stefano Sabatini
On date Tuesday 2025-04-22 21:55:31 +, softworkz wrote: > From: softworkz > > Perform multiple improvements to increase code robustness. > In particular: > - favor unsigned counters for loops > - add missing checks > - avoid possibly leaks my typo: possible leaks > - move variable declarat

Re: [FFmpeg-devel] [PATCH v5 01/14] fftools/textformat: Formatting and whitespace changes

2025-04-23 Thread Stefano Sabatini
On date Tuesday 2025-04-22 21:55:30 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/textformat/avtextformat.c | 86 ++-- > fftools/textformat/avtextformat.h | 16 +++--- > fftools/textformat/avtextwriters.h | 11 ++-- > fftools/te

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: add avformat_query_seekable

2025-04-21 Thread Stefano Sabatini
On date Tuesday 2025-04-15 16:09:56 +0530, Gyan Doshi wrote: > Utility function to report seekability features for a given input. > > Useful for ffprobe and to extend seek possibilities in fftools. > --- > v2: >made constants more descriptive >add exception for rtsp false negative seekabil

Re: [FFmpeg-devel] [PATCH v4 04/11] fftools/tf_internal: Use ac_default_item_name

2025-04-21 Thread Stefano Sabatini
On date Sunday 2025-04-20 22:59:07 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/textformat/tf_internal.h | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) Typo in commit headling: ac_default... -> av_default... > > diff --git a/fftools/tex

Re: [FFmpeg-devel] [PATCH v4 03/11] fftools/textformat: Introduce common header and deduplicate code

2025-04-21 Thread Stefano Sabatini
On date Sunday 2025-04-20 22:59:06 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz first part should be good [...] > diff --git a/fftools/textformat/tw_avio.c b/fftools/textformat/tw_avio.c > index d1b494b7b4..48868ebf5d 100644 > --- a/fftools/textformat/tw_avio.c > ++

Re: [FFmpeg-devel] [PATCH v4 02/11] fftools/textformat: Quality improvements

2025-04-21 Thread Stefano Sabatini
On date Sunday 2025-04-20 22:59:05 +, softworkz wrote: > From: softworkz > Nazigrammar commit log nit: use verb to specify the change action, like in: apply quality improvements Also probably want to have some more details below the headline, like: Perform multiple improvements to increase

Re: [FFmpeg-devel] [PATCH 1/9] fftools/textformat: Formatting and whitespace changes

2025-04-21 Thread Stefano Sabatini
On date Monday 2025-04-14 12:46:58 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/textformat/avtextformat.c | 104 +++-- > fftools/textformat/avtextformat.h | 16 ++--- > fftools/textformat/avtextwriters.h | 11 ++- > fftools/t

Re: [FFmpeg-devel] [PATCH v3] fftools/ffprobe: Print size of attachments

2025-04-21 Thread Stefano Sabatini
On date Sunday 2025-04-20 20:15:41 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/ffprobe: Print size of attachments > > > Versions > > > V2 > > Fix spurious commit message text as noted by Andreas (thanks!)

Re: [FFmpeg-devel] [REFUND-REQUEST] Ryzen 9 CPU + Mainboard + RAM

2025-04-21 Thread Stefano Sabatini
On date Wednesday 2025-04-09 17:44:29 +0200, Niklas Haas wrote: > Hi all, > > I ordered the parts as discussed and approved in the previous thread: > https://ffmpeg.org//pipermail/ffmpeg-devel/2025-April/341873.html > > The total cost was 1381.28 EUR. This is approved on my side, pending Michael

Re: [FFmpeg-devel] [PATCH v8 0/4] print_graphs: Complete Filtergraph Printing

2025-04-07 Thread Stefano Sabatini
In date Monday 2025-03-31 19:27:13 +, softworkz . wrote: [...] > > I'm fine with the changes assuming it passes fate. > > > > I don't know if you have push commit rights, if needed I will locally > > test and push them after a few days to let other developers to > > comment. > > Hi Stefano, >

Re: [FFmpeg-devel] [RFC] FFmpeg Execution Graph Visualization

2025-03-26 Thread Stefano Sabatini
On date Friday 2025-03-21 20:11:29 +, Soft Works wrote: [...] > > What it's not clear to me is how this builds up on top of text > > formatters, since they are meant to render a tree structure in a > > generic way. From this you can have a description of a graph, but then > > you need specializ

Re: [FFmpeg-devel] [PATCH v8 0/4] print_graphs: Complete Filtergraph Printing

2025-03-21 Thread Stefano Sabatini
On date Wednesday 2025-03-19 17:04:09 +, ffmpegagent wrote: > Due to the additional work on graph visualization (see > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2025-March/341296.html), I > have removed the two graph printing commits from this patchset rather than > adding to it, as to av

Re: [FFmpeg-devel] [RFC] FFmpeg Execution Graph Visualization

2025-03-21 Thread Stefano Sabatini
On date Tuesday 2025-03-18 02:32:13 +, Soft Works wrote: > Hello everybody, > > working on the subject of writing out filtergraph information > obviously implies the goal of being able to visualize that data in > some way. While I do have something for long, it's tailored for > specific workf

Re: [FFmpeg-devel] [PATCH v6 4/8] fftools/ffmpeg_filter: Move some declaration to new header file

2025-03-15 Thread Stefano Sabatini
On date Saturday 2025-03-08 20:16:30 +, softworkz wrote: > From: softworkz > > to allow print_graph to access the information. > > Signed-off-by: softworkz > --- > fftools/ffmpeg_filter.c | 188 +--- > fftools/ffmpeg_filter.h | 232 ++

Re: [FFmpeg-devel] [PATCH v5 8/8] fftools/ffprobe: Rename AVTextFormatContext variables (w => tc)

2025-03-11 Thread Stefano Sabatini
Typo in the subject line (should be "tfc"). On date Saturday 2025-03-08 17:55:35 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/ffprobe.c | 534 +++--- > 1 file changed, 267 insertions(+), 267 deletions(-) > > st

Re: [FFmpeg-devel] [PATCH v6 5/8] avfilter/avfilter: Add avfilter_link_get_hw_frames_ctx()

2025-03-11 Thread Stefano Sabatini
On date Saturday 2025-03-08 20:16:31 +, softworkz wrote: > From: softworkz > > --- > doc/APIchanges | 3 +++ > libavfilter/avfilter.c | 9 + > libavfilter/avfilter.h | 12 > libavfilter/version.h | 2 +- > 4 files changed, 25 insertions(+), 1 deletion(-) > >

Re: [FFmpeg-devel] [PATCH] avutil/refstruct: Fix documentation

2025-03-10 Thread Stefano Sabatini
On date Monday 2025-03-10 05:39:30 +0100, Andreas Rheinhardt wrote: > Patch attached. > > - Andreas > From 0601964cbc4a9b1e5d78b8a8da76f1259cc56b52 Mon Sep 17 00:00:00 2001 > From: Andreas Rheinhardt > Date: Mon, 10 Mar 2025 05:38:18 +0100 > Subject: [PATCH] avutil/refstruct: Fix documentation >

Re: [FFmpeg-devel] [PATCH v6 7/8] fftools: Enable filtergraph printing and update docs

2025-03-10 Thread Stefano Sabatini
On date Saturday 2025-03-08 20:16:33 +, softworkz wrote: > From: softworkz > > Enables filtergraph printing and adds the options to the docs > > Signed-off-by: softworkz > --- > doc/ffmpeg.texi | 10 ++ > fftools/ffmpeg.c| 4 > fftools/ffmpeg_filter.c | 5 +++

Re: [FFmpeg-devel] [PATCH v6 6/8] fftools/ffmpeg_graphprint: Add options for filtergraph printing

2025-03-10 Thread Stefano Sabatini
On date Saturday 2025-03-08 20:16:32 +, softworkz wrote: > From: softworkz > > The key benefits are: > > - Different to other graph printing methods, this is outputting: > - all graphs with runtime state > (including auto-inserted filters) > - each graph with its inputs and outputs >

Re: [FFmpeg-devel] [PATCH v6 0/8] print_graphs: Complete Filtergraph Printing

2025-03-10 Thread Stefano Sabatini
On date Saturday 2025-03-08 20:16:26 +, ffmpegagent wrote: > This new version of the patchset starts by extracting the text formatting > and writing APIs from ffprobe.c into a subfolder under fftools. The type > naming follows public API naming style, ramping up for making it a public > API in

Re: [FFmpeg-devel] [PATCH v3 1/7] fftools/textformat: Extract and generalize textformat api from ffprobe.c

2025-03-08 Thread Stefano Sabatini
On date Saturday 2025-03-08 15:30:28 +, Soft Works wrote: > > > > -Original Message- > > From: Stefano Sabatini > > Sent: Samstag, 8. März 2025 15:37 > > To: FFmpeg development discussions and patches > > Cc: Soft Works ; softworkz > >

Re: [FFmpeg-devel] [PATCH v5 3/8] fftools/ffprobe: Rename writer_print_section_* and WriterContext

2025-03-08 Thread Stefano Sabatini
On date Saturday 2025-03-08 17:55:30 +, softworkz wrote: > From: softworkz > > separated for better clarity of the preceding commit > > Signed-off-by: softworkz > ren > --- > fftools/ffprobe.c | 361 +++--- > 1 file changed, 178 insertions(+), 183 de

Re: [FFmpeg-devel] [PATCH v5 2/8] fftools/ffprobe: Change to use textformat api

2025-03-08 Thread Stefano Sabatini
On date Saturday 2025-03-08 17:55:29 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/Makefile | 12 + > fftools/ffprobe.c | 1849 - > 2 files changed, 142 insertions(+), 1719 deletions(-) Should still be good

Re: [FFmpeg-devel] [PATCH v5 1/8] fftools/textformat: Extract and generalize textformat api from ffprobe.c

2025-03-08 Thread Stefano Sabatini
On date Saturday 2025-03-08 17:55:28 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/textformat/avtextformat.c | 672 + > fftools/textformat/avtextformat.h | 171 > fftools/textformat/avtextwriters.h | 68 +++ > ffto

Re: [FFmpeg-devel] [PATCH 2/2] docs: Add documentation about YAML output writer

2025-03-08 Thread Stefano Sabatini
On date Wednesday 2025-02-19 20:07:56 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > doc/ffprobe.texi | 16 > 1 file changed, 16 insertions(+) > > diff --git a/doc/ffprobe.texi b/doc/ffprobe.texi > index ceedc8793b..106d865e18 100644 > --- a/doc

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: Add YAML output writer

2025-03-08 Thread Stefano Sabatini
On date Wednesday 2025-02-19 20:07:55 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/ffprobe.c | 147 +- > 1 file changed, 146 insertions(+), 1 deletion(-) Should this be postponed to the ffprobe.c formats refa

Re: [FFmpeg-devel] [PATCH v3 3/7] fftools/ffprobe: Rename writer_print_section_* and WriterContext

2025-03-08 Thread Stefano Sabatini
On date Saturday 2025-03-01 10:02:00 +, softworkz wrote: > From: softworkz > > separated for better clarity of the preceding commit > > Signed-off-by: softworkz > ren > --- > fftools/ffprobe.c | 361 +++--- > 1 file changed, 178 insertions(+), 183 de

Re: [FFmpeg-devel] [PATCH v3 1/7] fftools/textformat: Extract and generalize textformat api from ffprobe.c

2025-03-08 Thread Stefano Sabatini
On date Saturday 2025-03-01 10:01:58 +, softworkz wrote: [...] > +int avtext_context_open(AVTextFormatContext **ptctx, const AVTextFormatter > *formatter, AVTextWriterContext *writer, const char *args, > +const struct AVTextFormatSection *sections, int > nb_sections,

Re: [FFmpeg-devel] [PATCH v3 2/7] fftools/ffprobe: Change to use textformat api

2025-03-08 Thread Stefano Sabatini
On date Saturday 2025-03-01 10:01:59 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/Makefile | 12 + > fftools/ffprobe.c | 1849 - > 2 files changed, 142 insertions(+), 1719 deletions(-) [...] Overall makes

Re: [FFmpeg-devel] [PATCH v3 1/7] fftools/textformat: Extract and generalize textformat api from ffprobe.c

2025-03-08 Thread Stefano Sabatini
Sorry for delayed review, due to a sickness on my side for the past three days. On date Saturday 2025-03-01 10:01:58 +, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > fftools/textformat/avtextformat.c | 671 + > fftools/textformat/avtex

Re: [FFmpeg-devel] [PATCH v3 1/7] fftools/textformat: Extract and generalize textformat api from ffprobe.c

2025-03-05 Thread Stefano Sabatini
On date Sunday 2025-03-02 19:44:34 +, Soft Works wrote: > > > > -Original Message- > > From: Stefano Sabatini > > Sent: Sonntag, 2. März 2025 18:55 > > To: FFmpeg development discussions and patches > > Cc: Soft Works ; softworkz > >

Re: [FFmpeg-devel] [PATCH v3 1/7] fftools/textformat: Extract and generalize textformat api from ffprobe.c

2025-03-02 Thread Stefano Sabatini
Hi, I'll have a look at this in the week. There are a few things which I want to doublecheck (there is some ad-hoc application logic which might be broken when generalizing this), but I like the overall direction of this changeset. On date Saturday 2025-03-01 10:01:58 +, softworkz wrote: > Fr

Re: [FFmpeg-devel] [REFUND-REQUEST] FOSDEM '25 Expenses

2025-02-12 Thread Stefano Sabatini
In date Monday 2025-02-10 17:29:49 +0100, Lynne wrote: > Hi, > > I am requesting reimbursement for the following expenses made attending > FOSDEM 2025, where I attended the meeting and discussed development topics > with fellow developers. > > Eurostar tickets: 178.33 GBP > Hotel: 97.04 GBP Look

Re: [FFmpeg-devel] GSoC Mentor Summit Reimbursement Request

2024-11-10 Thread Stefano Sabatini
On Wed, Nov 6, 2024 at 2:16 PM Thilo Borgmann via ffmpeg-devel wrote: > > Hi, > > I also request reimbursement for this years GSoC summit. > > My costs included: > > 903,91 EUR Flight (BER to SFO) > 248,71 EUR Hotel > - > 1152,62 EUR Total > ==

Re: [FFmpeg-devel] GSoC Mentor Summit Reimbursement Request

2024-10-28 Thread Stefano Sabatini
On Wed, Oct 23, 2024 at 1:54 PM Michael Niedermayer wrote: > > On Thu, Oct 10, 2024 at 07:29:32PM +0100, Frank Plowman wrote: > > Hello, > > > > I would like to request reimbursement for the following expenses > > incurred attending the Google Summer of Code mentor summit. > > > > Description

Re: [FFmpeg-devel] [REFUND-REQUEST] BananaPi BPI-F3 SpacemiT K1 RISC-V Devboard

2024-08-04 Thread Stefano Sabatini
On date Thursday 2024-08-01 17:14:52 +0200, Niklas Haas wrote: > Hi all, > > I would like to request reimbursement on the named RISC-V development board. > It will be used to develop and test H.264 RVV routines, and probably more in > the future (e.g. swscale). > > The total cost including tax an

Re: [FFmpeg-devel] [PATCH v4] avformat/dvdvideodec: Fix incorrect padding cell trim logic

2024-07-13 Thread Stefano Sabatini
On Fri, Jul 12, 2024 at 5:31 AM Marth64 wrote: > > Ping to apply on this set of 3, so I can send seeking and additional > cleanup set (as a collection). Thank you! Applied patches: eb07a59 avformat/dvdvideodec: Don't add chapter markers for empty/dummy PTTs f37f86a avformat/dvdvideodec: Remove re

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 10:17:26 +0200, Paul B Mahol wrote: [...] > Source filters should use .activate instead. Can someone elaborate about why .activate is favoured in this case (sorry I missed the activate discussion altogether and I cannot graps it from the docs)? Also, is the direct AVFil

Re: [FFmpeg-devel] [PATCH 8/8] fftools/ffprobe: only print AVStereo3D.view when it's defined

2024-07-06 Thread Stefano Sabatini
On date Saturday 2024-06-22 00:37:01 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/ffprobe.c | 3 ++- > tests/ref/fate/matroska-spherical-mono | 1 - > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffpr

Re: [FFmpeg-devel] Development process for explaining contexts (was Re: [PATCH v6 1/4] doc: Explain what "context" means)

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 10:56:34 +0100, Andrew Sayers wrote: > On Tue, Jul 02, 2024 at 12:16:21AM +0200, Stefano Sabatini wrote: > > On date Sunday 2024-06-16 19:02:51 +0100, Andrew Sayers wrote: > [...] > > > > Andrew, sorry again for the slow reply. Thinking about the

Re: [FFmpeg-devel] [PATCH v4] avformat/dvdvideodec: Fix incorrect padding cell trim logic

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 01:41:31 -0500, Marth64 wrote: > When -trim option is used (by default), padding cells > at the beginning of the title are supposed to be ignored. > The current implementation does the ignoring after we > have locked on to the PGC navigation event stream, > but does not s

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: Remove redundant ret initializations

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 01:03:29 -0500, Marth64 wrote: > Remove initializing ret = 0, in areas where ret is > only used to hold an error value, immediately returned, > and the function would otherwise return a literal 0. > > Signed-off-by: Marth64 > --- > libavformat/dvdvideodec.c | 12 ++

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: Don't add chapter markers for empty/dummy PTTs

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 00:41:39 -0500, Marth64 wrote: > Some discs (usually same ones with padding cells), also have empty > padding PTTs / chapters to accompany them. This results, for example, > in an extra chapter marker that starts and ends at 0 (no duration). > > Don't add these empty cha

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-07-06 Thread Stefano Sabatini
On date Saturday 2024-07-06 12:40:55 +0200, Paul B Mahol wrote: > On Sat, Jul 6, 2024 at 11:19 AM Stefano Sabatini wrote: [...] > Not interested in your marginal toys or project. Good, so the next time avoid the rant and save even more time. ___

Re: [FFmpeg-devel] [PATCH v4 1/3] lavu/opt: Rename AV_OPT_FLAG_RUNTIME_PARAM to ...POST_INIT_SETTABLE_PARAM

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 10:08:38 +0100, Andrew Sayers wrote: > The old name could be misread as the opposite of "AV_OPT_FLAG_READONLY" - > some things can be set at runtime, others are read-only. Clarify that > this refers to options that can be set after the struct is initialized. > --- > doc

Re: [FFmpeg-devel] [PATCH v3 1/3] lavu/opt: Rename AV_OPT_FLAG_RUNTIME_PARAM to ...POST_INIT_SETTABLE_PARAM

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 11:58:09 +0800, Zhao Zhili wrote: > > > 在 2024年7月2日,上午6:33,Stefano Sabatini 写道: > > > > On date Sunday 2024-06-16 18:08:29 +0100, Andrew Sayers wrote: > >> The old name could be misread as the opposite of "AV_OPT_FLAG_READONL

Re: [FFmpeg-devel] [PATCH v4 0/3] s/RUNTIME/POST_INIT_SETTABLE/

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 10:08:37 +0100, Andrew Sayers wrote: > Some notes about this version: > > As previously mentioned, I think this is better with all three patches, > but can live without #2. > > I think I've followed the deprecation instructions, but editing APIchanges > seems to imply

Re: [FFmpeg-devel] [PATCH] lavfi/perlin: Fix out of bounds stack buffer write

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 20:38:00 +0200, Marvin Scholz wrote: > An incorrect calculation in ff_perlin_init causes a write to the > stack array at index 256, which is out of bounds. > > Fixes: CID1608711 > --- > libavfilter/perlin.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-07-06 Thread Stefano Sabatini
On date Thursday 2024-07-04 17:29:16 +0200, Michael Koch wrote: > Tested and working fine. It would be nice if you could add the default > values to the documentation. Will do, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 10:17:26 +0200, Paul B Mahol wrote: > No need for query function. > This implementation is so blatantly slow and inefficient that is not useful. > Source filters should use .activate instead. > Many more other issues... It was pending reviews for more than two weeks. Ab

Re: [FFmpeg-devel] [PATCH v3 1/3] lavu/opt: Rename AV_OPT_FLAG_RUNTIME_PARAM to ...POST_INIT_SETTABLE_PARAM

2024-07-01 Thread Stefano Sabatini
On date Sunday 2024-06-16 18:08:29 +0100, Andrew Sayers wrote: > The old name could be misread as the opposite of "AV_OPT_FLAG_READONLY" - > some things can be set at runtime, others are read-only. Clarify that > this refers to options that can be set after the struct is initialized. > --- > liba

Re: [FFmpeg-devel] [PATCH v3 0/3] s/RUNTIME/POST_INIT_SETTABLE/

2024-07-01 Thread Stefano Sabatini
On date Sunday 2024-06-16 18:08:28 +0100, Andrew Sayers wrote: > AV_OPT_FLAG_POST_INIT_SETTABLE_PARAM is fine by me, here's a patch. > I've added a "@deprecated" comment for the old name, but would this > need to be queued up for 8.0? Technically this is a backwards-incompatible > change to the e

Re: [FFmpeg-devel] Development process for explaining contexts (was Re: [PATCH v6 1/4] doc: Explain what "context" means)

2024-07-01 Thread Stefano Sabatini
On date Sunday 2024-06-16 19:02:51 +0100, Andrew Sayers wrote: > Meta note #1: I've replied in this thread but changed the subject line. > That's because it needs to stay focussed on solving this thread's problem, > but may be of more general interest. > > Meta note #2: Stefano, I appreciate your

Re: [FFmpeg-devel] [PATCH] avfilter/af_afade: fix opt_type for nb_samples/ns

2024-07-01 Thread Stefano Sabatini
On date Saturday 2024-06-22 15:20:52 +0200, Andreas Rheinhardt wrote: > Andrew Sayers: > > The actual value is an int64_t, and is accessed elsewhere as > > AV_OPT_TYPE_INT64. > > > > Accessing it as INT will likely cause bugs on some 32-bit architectures. > > Whether this works or not will depen

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-07-01 Thread Stefano Sabatini
On date Monday 2024-06-24 16:44:33 +0200, Vittorio Giovara wrote: > On Sun, Jun 23, 2024 at 7:57 PM James Almer wrote: > > > On 6/22/2024 7:19 PM, Vittorio Giovara wrote: > > > Needless to say I support the plan of renaming the library so that it can > > > be inline with the other libraries names

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: Fix duration logic with 1 chapter and validate chapter range

2024-07-01 Thread Stefano Sabatini
On date Monday 2024-07-01 22:49:42 +0200, Stefano Sabatini wrote: > On date Wednesday 2024-06-26 22:05:46 -0500, Marth64 wrote: > > Chapters and duration are calculated together in dvdvideo demuxer. > > Previous chapter calculation logic treated extraction of 1 chapter > > us

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: Fix duration logic with 1 chapter and validate chapter range

2024-07-01 Thread Stefano Sabatini
On date Wednesday 2024-06-26 22:05:46 -0500, Marth64 wrote: > Chapters and duration are calculated together in dvdvideo demuxer. > Previous chapter calculation logic treated extraction of 1 chapter > using chapter_start and chapter_end switches incorrectly, returning > the duration of the entire ti

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: Do not EOF on WAIT events

2024-07-01 Thread Stefano Sabatini
On date Wednesday 2024-06-26 20:34:35 -0500, Marth64 wrote: > A DVDNAV_WAIT event by itself should not warrant an > EOF when navigating the program stream. Some discs > have WAIT events in the middle of a title, causing > playback to end prematurely prior to this fix. > > Signed-off-by: Marth64 >

Re: [FFmpeg-devel] [PATCH 5/5] avfilter/vf_showinfo: don't use sizeof(AVSphericalMapping)

2024-07-01 Thread Stefano Sabatini
On date Wednesday 2024-06-26 11:10:14 -0300, James Almer wrote: > It's not part of the libavutil ABI. > > Signed-off-by: James Almer > --- > libavfilter/vf_showinfo.c | 5 - > 1 file changed, 5 deletions(-) All patches look good to me, thanks. ___

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-07-01 Thread Stefano Sabatini
On date Sunday 2024-06-16 17:37:09 +0200, Stefano Sabatini wrote: > On date Thursday 2024-06-13 16:45:48 +0100, Andrew Sayers wrote: [...] > Applied other fixes as well, thanks. > From 7d9ffbdb8e419ca01e60604038d5534a3ca8ae0e Mon Sep 17 00:00:00 2001 > From: Stefano Sabatini > Da

Re: [FFmpeg-devel] [PATCH v2] lavu/opt: Discuss AV_OPT_FLAG_RUNTIME_PARAM more explicitly

2024-06-16 Thread Stefano Sabatini
On date Thursday 2024-06-06 17:02:06 +0100, Andrew Sayers wrote: > After a struct is initialized, only options with the > AV_OPT_FLAG_RUNTIME_PARAM flag can be modified. > > Make that clearer, for the sake of readers who would otherwise > assume all options can be modified at any time. > --- > li

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-06-16 Thread Stefano Sabatini
random_seed), AV_OPT_TYPE_UINT, {.i64=0}, 0, UINT_MAX, FLAGS }, > > +{ "seed","set the seed for filling the initial grid randomly", > > OFFSET(random_seed), AV_OPT_TYPE_UINT, {.i64=0}, 0, UINT_MAX, FLAGS }, > > Nit: "set the seed

Re: [FFmpeg-devel] [PATCH v6 1/4] doc: Explain what "context" means

2024-06-15 Thread Stefano Sabatini
On date Thursday 2024-06-13 15:20:38 +0100, Andrew Sayers wrote: > On Wed, Jun 12, 2024 at 10:52:00PM +0200, Stefano Sabatini wrote: [...] > > > +@section Context_general “Context” as a general concept > [...] > > I'd skip all this part, as we assume the reader is a

Re: [FFmpeg-devel] [PATCH v6 1/4] doc: Explain what "context" means

2024-06-12 Thread Stefano Sabatini
On date Tuesday 2024-06-04 15:47:21 +0100, Andrew Sayers wrote: > Derived from explanations kindly provided by Stefano Sabatini and others: > https://ffmpeg.org/pipermail/ffmpeg-devel/2024-April/325903.html > --- > doc/context.md | 430 +++

Re: [FFmpeg-devel] [PATCH] doc/faq: Provide information about git send-email and gmail

2024-06-12 Thread Stefano Sabatini
On date Wednesday 2024-06-12 19:46:59 +0200, Michael Niedermayer wrote: > The 2 links are the clearest i found. > > Signed-off-by: Michael Niedermayer > --- > doc/faq.texi | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/doc/faq.texi b/doc/faq.texi > index 477cc60533a..d07ed533dd7

Re: [FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display

2024-06-12 Thread Stefano Sabatini
coders and muxers, and about dealing with a variable number of outputs, I'm attaching this very old proof-of-concept patch for reference. This approach would be possibly much more complex, but should provide a single bridge in place of having a different sink for every output devic

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-06-12 Thread Stefano Sabatini
On date Monday 2024-06-03 11:41:59 +0200, Stefano Sabatini wrote: > On date Tuesday 2024-05-28 18:58:28 +0200, Stefano Sabatini wrote: > > On date Monday 2024-05-27 23:37:33 +0200, Stefano Sabatini wrote: > > > Hi, > > > > > > still missing documentation and mi

Re: [FFmpeg-devel] [PATCH v6] avcodec: add farbfeld encoder

2024-06-05 Thread Stefano Sabatini
On date Wednesday 2024-06-05 13:14:01 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: [...] > >> One does not need two checks as long as int is 32 bits (because then one > >> can just perform the addition in 64bits). > > > > sizeof(int) is not defined by the

Re: [FFmpeg-devel] [PATCH v6] avcodec: add farbfeld encoder

2024-06-05 Thread Stefano Sabatini
On date Wednesday 2024-06-05 12:02:08 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: > > On date Tuesday 2024-06-04 17:28:35 -0500, Marcus B Spencer wrote: [...] > >> +#define HEADER_SIZE 16 > >> + > >> +static int farbfeld_encode_fram

Re: [FFmpeg-devel] [PATCH v6 2/4] lavu: Clarify relationship between AVClass, AVOption and context

2024-06-05 Thread Stefano Sabatini
On date Tuesday 2024-06-04 15:47:22 +0100, Andrew Sayers wrote: > --- > libavutil/log.h | 16 +--- > libavutil/opt.h | 26 +- > 2 files changed, 34 insertions(+), 8 deletions(-) > > diff --git a/libavutil/log.h b/libavutil/log.h > index ab7ceabe22..88b35897c6 1

Re: [FFmpeg-devel] [PATCH] avfilter/trim: flag trim filter as metadata only

2024-06-04 Thread Stefano Sabatini
On date Tuesday 2024-06-04 23:41:05 +0530, Gyan Doshi wrote: > Similar to select filter for video - it can only pass through or drop frames > --- > libavfilter/trim.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/trim.c b/libavfilter/trim.c > index 4c1a2b4f48..4afc4c74bb 10

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-06-03 Thread Stefano Sabatini
On date Tuesday 2024-05-28 18:58:28 +0200, Stefano Sabatini wrote: > On date Monday 2024-05-27 23:37:33 +0200, Stefano Sabatini wrote: > > Hi, > > > > still missing documentation and might be optimized (and maybe extended > > to support gray16 - this should be si

Re: [FFmpeg-devel] [PATCH v4 1/4] doc: Explain what "context" means

2024-05-29 Thread Stefano Sabatini
On date Wednesday 2024-05-29 11:50:40 +0100, Andrew Sayers wrote: > Posting this separately, as these are practical "how does FFmpeg work" issues > vaguely inspired by recent discussions. > > > *How do namespaces work in FFmpeg?* > > We've talked a bit about function namespaces recently. One re

Re: [FFmpeg-devel] [PATCH v4 1/4] doc: Explain what "context" means

2024-05-28 Thread Stefano Sabatini
fully that will keep > the big questions contained in one place. > > On Sat, May 25, 2024 at 11:49:48AM +0200, Stefano Sabatini wrote: > > What perplexes me is that "context" is not part of the standard OOP > > jargon, so this is probably adding more to the confusio

  1   2   3   4   5   6   7   8   9   10   >