[FFmpeg-devel] [PATCH v3] avformat/mov: Correctly read EIA608 packets if multiple boxes or non-field 1 data is present

2023-06-07 Thread Sebastian Dröge
From: Sebastian Dröge The payload of EIA608 samples in MOV is one or more cdat or cdt2 boxes. cdat contains EIA608 byte pairs for field 1, cdt2 for field 2. Previously any box following the first was treated as EIA608 byte pairs instead of parsing them correctly, and all data was handled as

[FFmpeg-devel] [PATCH v2] avformat/mov: Correctly read EIA608 packets if multiple boxes or non-field 1 data is present

2023-06-07 Thread Sebastian Dröge
From: Sebastian Dröge The payload of EIA608 samples in MOV is one or more cdat or cdt2 boxes. cdat contains EIA608 byte pairs for field 1, cdt2 for field 2. Previously any box following the first was treated as EIA608 byte pairs instead of parsing them correctly, and all data was handled as

[FFmpeg-devel] [PATCH] avformat/mov: Correctly read EIA608 packets if multiple boxes or non-field 1 data is present

2023-05-15 Thread Sebastian Dröge
From: Sebastian Dröge The payload of EIA608 samples in MOV is one or more cdat or cdt2 boxes. cdat contains EIA608 byte pairs for field 1, cdt2 for field 2. Previously any box following the first was treated as EIA608 byte pairs instead of parsing them correctly, and all data was handled as

[FFmpeg-devel] [PATCH] avdevice/decklink_dec: Handle time code data presence in CDP packets

2020-11-25 Thread Sebastian Dröge
From: Sebastian Dröge Instead of failing to parse such CDP packets, simply skip over the time code data and read the CC data following it. Also add some more length checks in related to this and the existing parsing code to prevent reading out of bounds memory. --- libavdevice/decklink_dec.cpp

[FFmpeg-devel] [PATCH] avfilter/af_loudnorm: Don't mix dB and linear values when calculating linear offset with inputs <3s

2020-04-26 Thread Sebastian Dröge
From: Sebastian Dröge s->target_i and global are in dB but s->target_tp and true_peak are linear. Instead of mixing these in the calculations, convert the former first to have all following calculations in the same unit. --- libavfilter/af_loudnorm.c | 5 ++--- 1 file changed, 2 inse

[FFmpeg-devel] [PATCHv2] Revert "do not write f2 if not interlaced"

2016-01-29 Thread Sebastian Dröge
From: Sebastian Dröge This reverts commit 8ed82d8174a666f80ab8834e3617cbe91ae740a9. SMPTE S377-1-2009c defines in F.4.1 that the Video Line Map should always be an array with two 32 bit integers as elements. This is repeated in G.2.12 with actual examples for progressive content, where the

Re: [FFmpeg-devel] [PATCH] Revert "do not write f2 if not interlaced"

2016-01-29 Thread Sebastian Dröge
On Fr, 2016-01-29 at 13:31 +0100, Michael Niedermayer wrote: > > --- > >  libavformat/mxfenc.c | 8 > >  1 file changed, 4 insertions(+), 4 deletions(-) > > breaks fate > (you need to update the checksums if these chnages are intended) Ah sure, forgot to update those. Thanks! The checksum

[FFmpeg-devel] [PATCH] Revert "do not write f2 if not interlaced"

2016-01-29 Thread Sebastian Dröge
From: Sebastian Dröge This reverts commit 8ed82d8174a666f80ab8834e3617cbe91ae740a9. SMPTE S377-1-2009c defines in F.4.1 that the Video Line Map should always be an array with two 32 bit integers as elements. This is repeated in G.2.12 with actual examples for progressive content, where the

Re: [FFmpeg-devel] mxfenc: Writes incomplete Video Line Map for progressive content

2016-01-29 Thread Sebastian Dröge
On Do, 2016-01-28 at 15:25 +0100, Sebastian Dröge wrote: > Hi everybody, > > since the following commit > https://git.videolan.org/?p=ffmpeg.git;a=commit;h=8ed82d8174a666f80ab8834e3617cbe91ae740a9 > mxfenc is only writing one value for progressive content. > Unfortunately the co

[FFmpeg-devel] mxfenc: Writes incomplete Video Line Map for progressive content

2016-01-28 Thread Sebastian Dröge
Hi everybody, since the following commit https://git.videolan.org/?p=ffmpeg.git;a=commit;h=8ed82d8174a666f80ab8834e3617cbe91ae740a9 mxfenc is only writing one value for progressive content. Unfortunately the commit comes without any explanation at all. SMPTE S377-1-2009c (the version I have) def

Re: [FFmpeg-devel] [PATCH] avcodec/h264: Set CORRUPT flag on output frames that are not fully recovered

2015-12-08 Thread Sebastian Dröge
On Di, 2015-12-08 at 01:28 +0100, Michael Niedermayer wrote: >  > this breaks "-flags2 showall", many (ugly) frames are no longer shown > one sample showing this is: Indeed, I changed behaviour here. It should work the same as before now. Before and after my patch there is no difference between A

[FFmpeg-devel] [PATCHv2] avcodec/h264: Set CORRUPT flag on output frames that are not fully recovered

2015-12-08 Thread Sebastian Dröge
From: Sebastian Dröge In the merge commit 78265fcfeee153e5e26ad4dbc7831a84ade447d6 this behaviour was broken and the CORRUPT flag would never ever be set on a frame. However the flag on the AVCodecContext was taken into account properly, including AV_CODEC_FLAG2_SHOW_ALL. The reason for this

[FFmpeg-devel] [PATCH] avcodec/h264: Set CORRUPT flag on output frames that are not fully recovered

2015-12-07 Thread Sebastian Dröge
From: Sebastian Dröge In the merge commit 78265fcfeee153e5e26ad4dbc7831a84ade447d6 this behaviour was broken and the CORRUPT flag would never ever be set on a frame. However the flag on the AVCodecContext was taken into account properly, including AV_CODEC_FLAG2_SHOW_ALL. The reason for this

[FFmpeg-devel] [PATCH] mpegtsenc: Fix off-by-one in indexing into Opus channel mapping arrays

2015-12-03 Thread Sebastian Dröge
From: Sebastian Dröge --- libavformat/mpegtsenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 8591e8c..27cd89f 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -401,11 +401,11 @@ static int

[FFmpeg-devel] [PATCHv3 1/2] mpegtsenc: Add support for muxing Opus in MPEG-TS

2015-11-05 Thread Sebastian Dröge
From: Sebastian Dröge Signed-off-by: Sebastian Dröge --- libavformat/mpegtsenc.c | 180 +++- 1 file changed, 179 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 4d74252..96d277e 100644 --- a

Re: [FFmpeg-devel] [PATCHv2 1/2] mpegtsenc: Add support for muxing Opus in MPEG-TS

2015-11-05 Thread Sebastian Dröge
On So, 2015-11-01 at 23:44 +0200, Sebastian Dröge wrote: >  > +} else if (st->codec->extradata[18] == 1 && st- > >codec->channels <= 8 && > +   st->codec->extradata_size >= 22 + st- > >codec-&

Re: [FFmpeg-devel] [PATCHv3 2/2] mpegtsenc: Implement writing of Opus trim_start/trim_end control values

2015-11-02 Thread Sebastian Dröge
On Mo, 2015-11-02 at 15:12 +, Carl Eugen Hoyos wrote: > Sebastian Dröge coaxion.net> writes: > > > +if (ts_st->opus_pending_trim_start) > > +  ctrl_header_size += 2; > > +if (trim_end) > > +  ctrl_heade

[FFmpeg-devel] [PATCHv3 2/2] mpegtsenc: Implement writing of Opus trim_start/trim_end control values

2015-11-01 Thread Sebastian Dröge
From: Sebastian Dröge Signed-off-by: Sebastian Dröge --- libavformat/mpegtsenc.c | 43 --- 1 file changed, 40 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 0674064..11ce130 100644 --- a/libavformat

[FFmpeg-devel] [PATCHv2 2/2] mpegtsenc: Implement writing of Opus trim_start/trim_end control values

2015-11-01 Thread Sebastian Dröge
From: Sebastian Dröge Signed-off-by: Sebastian Dröge --- libavformat/mpegtsenc.c | 47 --- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 0674064..51d1a0b 100644 --- a

[FFmpeg-devel] [PATCHv2 1/2] mpegtsenc: Add support for muxing Opus in MPEG-TS

2015-11-01 Thread Sebastian Dröge
From: Sebastian Dröge Signed-off-by: Sebastian Dröge --- libavformat/mpegtsenc.c | 180 +++- 1 file changed, 179 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 4d74252..0674064 100644 --- a

Re: [FFmpeg-devel] [PATCH 1/2] mpegtsenc: Add support for muxing Opus in MPEG-TS

2015-11-01 Thread Sebastian Dröge
On So, 2015-11-01 at 22:20 +0200, Sebastian Dröge wrote: > +data = av_malloc(pkt->size + 2 + pkt->size / 255 + 1); > [...] > +n = pkt->size; > +i = 2; > +do { > +data[i] = FFMIN(n, 255);

[FFmpeg-devel] [PATCH 2/2] mpegtsenc: Implement writing of Opus trim_start/trim_end control values

2015-11-01 Thread Sebastian Dröge
From: Sebastian Dröge Signed-off-by: Sebastian Dröge --- libavformat/mpegtsenc.c | 47 --- 1 file changed, 44 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index a7e78ac..023ca02 100644 --- a

[FFmpeg-devel] [PATCH 1/2] mpegtsenc: Add support for muxing Opus in MPEG-TS

2015-11-01 Thread Sebastian Dröge
From: Sebastian Dröge Signed-off-by: Sebastian Dröge --- libavformat/mpegtsenc.c | 180 +++- 1 file changed, 179 insertions(+), 1 deletion(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 4d74252..a7e78ac 100644 --- a

[FFmpeg-devel] [PATCH 0/2] mpegtsenc: Add support for muxing Opus into MPEG-TS

2015-11-01 Thread Sebastian Dröge
Hi everybody, the following patches are adding support for muxing Opus into MPEG-TS. ffmpeg could already demux such files since a while, but I guess it would also be nice to be able to create them. Please review carefully, thanks! Sebastian ___ ffmpe