Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-05-03 Thread Russell Greene
xactly what I posted. > Set array to non-NULL, set nb to the array size you're giving it, and > you'll get UP TO nb, no more, even if the driver has more. Right, but what if the modifier you need info on is after nb? On Sat, May 3, 2025 at 10:11 AM Russell Greene wrote: >

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-05-03 Thread Russell Greene
> > If we're OK with a practical "we don't support drivers with more than > > X modifiers because we doubt it'll ever exist" then that's a valid > > answer as well. > If that's your concern, just fetch all info for all modifiers in the > init function. Works for me. I'm new to ffmpeg devel, I assu

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-05-03 Thread Russell Greene
> vkGetPhysicalDeviceToolPropertiesEXT(dev, nb, array) > If pToolProperties is NULL, then the number of tools currently active on > physicalDevice is returned in pToolCount. Otherwise, pToolCount must > point to a variable set by the application to the number of elements in > the pToolProperties ar

Re: [FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-05-02 Thread Russell Greene
at 6:10 PM Lynne wrote: > > On 01/05/2025 07:05, Russell Greene wrote: > > From: Russell Greene > > > > Previously, it was assumed that `drmFormatModifierPlaneCount` was one > > for all modifiers when exporting, which is not always the case, in > > particular fo

[FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-04-30 Thread Russell Greene
From: Russell Greene Previously, it was assumed that `drmFormatModifierPlaneCount` was one for all modifiers when exporting, which is not always the case, in particular for AMD GPUs and maybe others. Fetch the number of memory planes and fill the structs appropriately in this situation. The

[FFmpeg-devel] [PATCH] hwcontext_vulkan: fix exporting multi-plane DRM modifiers

2025-04-29 Thread Russell Greene
Previously, it was assumed that `drmFormatModifierPlaneCount` was one for all modifiers when exporting, which is not always the case, in particular for AMD GPUs and maybe others. Fetch the number of memory planes and fill the structs appropriately in this situation. The encoded stream is still ba