On Wed, 18 Nov 2020 at 20:11, Marton Balint wrote:
>
>
> On Sun, 15 Nov 2020, Ross Nicholson wrote:
>
> > On Sat, 14 Nov 2020 at 23:40, Marton Balint wrote:
> >
> >> mpegts_read_header stops parsing the file at the first PMT. However the
> >> chec
On Sat, 14 Nov 2020 at 23:40, Marton Balint wrote:
> mpegts_read_header stops parsing the file at the first PMT. However the
> check
> that ensured this was wrong because streams can also be added before the
> first
> PMT is received (e.g. EIT).
>
> So let's make sure we are in the header reading
> On 20 Apr 2020, at 02:42, Andreas Rheinhardt
> wrote:
>
> In this example, the difference in length between the shortest and
> longest string is three, so that not using pointers to strings saves
> space even on 32bit systems.
>
> Moreover, there is no need to use a sentinel here; it can b
> On 20 Apr 2020, at 08:53, Marton Balint wrote:
>
>
>
>> On Mon, 20 Apr 2020, Andreas Rheinhardt wrote:
>>
>> Fixes Coverity ID 1462307.
>>
>> Signed-off-by: Andreas Rheinhardt
>> ---
>> I intend to apply this soon if there are no objections.
>>
>> libavformat/rtsp.c | 2 +-
>> 1 file ch
> On 19 Apr 2020, at 20:30, Carl Eugen Hoyos wrote:
>
> Am So., 19. Apr. 2020 um 20:45 Uhr schrieb Ross Nicholson
> :
>>
>> That’s really strange all my git config’s are just phunkyfish.
>>
>> I don’t really mind which name is used but I guess I’ll update
:28, Ross Nicholson wrote:
>> How do you mean? What’s that problem?
>
> You've used Ross Nicholson for committing, and now you
> only use
> phunkyfish .
>
> Since you are not anonymous, why not use your actual name?
>
>
> --
>
email and name?
>
> Thanks
>
>> On Fri, Apr 17, 2020, at 13:07, Ross Nicholson wrote:
>> Ping
>>
>>>> On 15 Apr 2020, at 17:21, Ross Nicholson wrote:
>>>
>>>
>>> Ping to hopefully apply this patch!
>>>
>>>>
Ping
> On 15 Apr 2020, at 17:21, Ross Nicholson wrote:
>
>
> Ping to hopefully apply this patch!
>
>>> On 12 Apr 2020, at 16:54, Ross Nicholson wrote:
>>>
>>
>> User testing has been completed successfully so this is ready to be applied.
&g
Ping to hopefully apply this patch!
> On 12 Apr 2020, at 16:54, Ross Nicholson wrote:
>
>
> User testing has been completed successfully so this is ready to be applied.
>
> Thanks
>
>>> On 7 Apr 2020, at 23:50, Ross Nicholson wrote:
>>>
>>
User testing has been completed successfully so this is ready to be applied.
Thanks
> On 7 Apr 2020, at 23:50, Ross Nicholson wrote:
>
>
> Thank you for the explanation Marton. It's make perfect sense to me know. So
> UNLIMITED would be the right choice here.
&g
Thank you for the explanation Marton. It's make perfect sense to me know.
So UNLIMITED would be the right choice here.
All of your other comments are addressed in the latest version. Thanks
again for reviewing.
On Tue, 7 Apr 2020 at 22:03, Marton Balint wrote:
>
>
> On Tue, 7
Great, thanks again.
A question about AV_BPRINT_SIZE_AUTOMATIC. Is there a heuristic for when to use
this versus unlimited?
Or is it that generally if you would have used a buffer of 1000 or less
automatic is the right choice?
> On 7 Apr 2020, at 20:50, Marton Balint wrote:
>
>
>
>> On T
Hey Nicolas,
Thanks for the review. I have incorporated your comments in the latest
version.
I have to get some users local to the problematic streams to do the
testing, they are not available in my region. It has made it somewhat
problematic to get this far ;)
phunkyfish
On Mon, 6 Apr 2020 at
Ok, latest patch uses AVBPrint. Please let me know if my usage is correct,
I have not used it before.
In the meantime I will get some users to test this.
On Mon, 6 Apr 2020 at 20:57, Marton Balint wrote:
>
>
> On Mon, 6 Apr 2020, phunkyfish wrote:
>
> > ---
> > libavformat/rtsp.c | 47 +
> sdp_length is used uninitialized here it is used uninitialized in the
> version that was merged as b71685865fe761925feedda3cd0b288224d9a509. The
> newer versions [2], [3] don't exhibit this flaw.
>
> [3] and [1] also have a flaw in common that [2] and this one are
> lacking: The semicolon of the
This patch will correctly pass any sources or block filters from the URL via
SDP to the underlying protocol.
Example URL: rtp://232.0.10.234:1?sources=87.141.215.251
Prior to this patch the sources params would be ignored and the stream reading
would fail.
> On 4 Mar 2020, at 23:47, phunky
Ping
> On 2 Mar 2020, at 21:30, Ross Nicholson wrote:
>
> phunkyfish in the history is fine thanks ;)
>
>> On 2 Mar 2020, at 21:00, Marton Balint wrote:
>>
>>
>>
>>>> On Mon, 2 Mar 2020, Ross Nicholson wrote:
>>>
>>> U
phunkyfish in the history is fine thanks ;)
> On 2 Mar 2020, at 21:00, Marton Balint wrote:
>
>
>
>> On Mon, 2 Mar 2020, Ross Nicholson wrote:
>>
>> Updated to correct header.
>
> Can you resend the patch with the proper author (e.g. Ross Nicholson inste
Updated to correct header.
On Mon, 2 Mar 2020 at 19:53, Marton Balint wrote:
>
>
> On Mon, 2 Mar 2020, phunkyfish wrote:
>
> > ---
> > compat/w32pthreads.h | 8
> > libavformat/udp.c| 6 +-
> > 2 files changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/compat/w32pthread
Thanks!
On Mon, 2 Mar 2020 at 14:16, Andriy Gelman wrote:
> On Mon, 02. Mar 13:38, phunkyfish wrote:
> > ---
> > compat/w32pthreads.h | 10 ++
> > libavformat/udp.c| 8 +++-
> > 2 files changed, 17 insertions(+), 1 deletion(-)
> >
> > diff --git a/compat/w32pthreads.h b/compat/
This should allow the use of w32pthreads compat layer to be used for UDP.
For windows this would mean not needing to change the underlying
threading impl.
On Mon, 2 Mar 2020 at 12:53, phunkyfish wrote:
> ---
> compat/w32pthreads.h | 8
> libavformat/udp.c| 8 +++-
> 2 files cha
Ping...
> On 26 Feb 2020, at 08:57, Ross Nicholson wrote:
>
>
> Thanks, just thought you might have another idea, as it works just was not
> sure if I was accomplishing it in the right way.
>
> Ya, I submitted the patch formally. Let’s see what’s a review comes b
Tue, Feb 25, 2020 at 5:01 AM Ross Nicholson wrote:
>> Hey Jun Li,
>>
>> I noticed you have submitted some patches which work around the same code
>> area's that I submitted for. Your patches look quite tidy and well thought
>> out so I was wondering if you co
area of ffmpeg currently has a maintainer currently so
the patches may be difficult to progress.
Ross
On Tue, 11 Feb 2020 at 22:42, Ross Nicholson wrote:
> The patch was created as a workaround to an issue from in kodi (apologies,
> it's a rather long thread):
> https://forum.kodi
The patch was created as a workaround to an issue from in kodi (apologies,
it's a rather long thread):
https://forum.kodi.tv/showthread.php?tid=350901&pid=2923550#pid2923550
As an example, here is a URL: rtp://87.141.215.251@232.0.10.234:1
Taking this URL we should be able to either reformat
Can this be applied?
> On 19 Sep 2019, at 16:14, Ross Nicholson wrote:
>
> Updated to v4 of patch after learning from Aman Gupta that 'rt' did not need
> to be checked in the context of this function.
>
> Should be good to go now.
>
>> On Thu, 19
Makes sense. Latest version of patch v4 should reflect this.
> On 18 Sep 2019, at 21:42, phunkyfish wrote:
>
> ---
> libavformat/rtsp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
> index c153cac88b..5e8adfaf3c 100644
> --- a/libavformat/rt
Updated to v4 of patch after learning from Aman Gupta that 'rt' did not
need to be checked in the context of this function.
Should be good to go now.
On Thu, 19 Sep 2019 at 16:12, phunkyfish wrote:
> ---
> libavformat/rtsp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/libavform
Checking other functions I don't see this checked for so I guess latest
patch is fine.
On Wed, 18 Sep 2019 at 21:51, Ross Nicholson wrote:
> Technically this function should also return an error is rt is NULL. Which
> error code would apply for this?
>
> On Wed, 18 Sep 2019 at
Technically this function should also return an error is rt is NULL. Which
error code would apply for this?
On Wed, 18 Sep 2019 at 21:42, phunkyfish wrote:
> ---
> libavformat/rtsp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
> index c153
Sorry, my name is Ross Nicholson. But the alias is fine too.
> On 18 Sep 2019, at 21:14, Michael Niedermayer wrote:
>
>> On Wed, Sep 18, 2019 at 07:54:27AM +0100, phunkyfish wrote:
>> ---
>> libavformat/rtsp.c | 3 +++
>> 1 file changed, 3 insertions(+)
>
>
Updated patch to add return after variable definitions.
On Wed, 18 Sep 2019 at 07:54, phunkyfish wrote:
> ---
> libavformat/rtsp.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
> index c153cac88b..3e8606dade 100644
> --- a/libavformat/rtsp.c
This can be closed. New patch created which returns an error instead to
prevent crash.
On Thu, 12 Sep 2019 at 08:21, Ross Nicholson wrote:
> Ping, any update?
>
> On Thu, 5 Sep 2019 at 06:33, Ross Nicholson wrote:
>
>> Hey All,
>>
>> Anything needed from me to
Ping, any update?
On Thu, 5 Sep 2019 at 06:33, Ross Nicholson wrote:
> Hey All,
>
> Anything needed from me to progress this?
>
> Thanks in advance,
>
> Ross
>
> On 29 Aug 2019, at 17:04, Ross Nicholson wrote:
>
> Hey Jun,
>
> So I got kodi running
Hey All,
Anything needed from me to progress this?
Thanks in advance,
Ross
> On 29 Aug 2019, at 17:04, Ross Nicholson wrote:
>
> Hey Jun,
>
> So I got kodi running with FFmpeg n4.2 and the issue persists. Here's the
> debugger output after trying to play the
ug 2019 at 00:20, Jun Li wrote:
> On Wed, Aug 28, 2019 at 3:09 PM Carl Eugen Hoyos
> wrote:
>
> > Am Mo., 5. Aug. 2019 um 09:19 Uhr schrieb Ross Nicholson <
> > phunkyf...@gmail.com>:
> > >
> > > Example stream that does not work: rtsp://
> > >
3:09 PM Carl Eugen Hoyos
> wrote:
>
> > Am Mo., 5. Aug. 2019 um 09:19 Uhr schrieb Ross Nicholson <
> > phunkyf...@gmail.com>:
> > >
> > > Example stream that does not work: rtsp://
> > > 184.72.239.149/vod/mp4:BigBuckBunny_115k.mov
> >
> &
Hey guys, if there is anything else required to progress this please let me
know.
It’s my first patch submission to FFMpeg so not sure how long it should take.
> On 23 Aug 2019, at 20:10, Ross Nicholson wrote:
>
> Ping
>
>> On 17 Aug 2019, at 14:57, Ross Nicholson wrote:
Ping
> On 17 Aug 2019, at 14:57, Ross Nicholson wrote:
>
> Ok, thanks Moritz.
>
>>> On 17 Aug 2019, at 14:10, Moritz Barsnick wrote:
>>>
>>> On Fri, Aug 16, 2019 at 10:35:43 -0700, Ross Nicholson wrote:
>>> Need anything else Moritz?
>>
Ok, thanks Moritz.
> On 17 Aug 2019, at 14:10, Moritz Barsnick wrote:
>
>> On Fri, Aug 16, 2019 at 10:35:43 -0700, Ross Nicholson wrote:
>> Need anything else Moritz?
>
> No. I only made one remark ("can't understand your issue"), hoping to
> push t
Need anything else Moritz?
> On 14 Aug 2019, at 09:54, Ross Nicholson wrote:
>
> I would imagine that the way Kodi handles the stream, rtsp_hd_out is null as
> per the following:
>
> URLContext * rtsp_hd_out
> Additional output handle, used when input and output a
On Wed, 14 Aug 2019 at 07:20, Moritz Barsnick wrote:
> On Mon, Aug 05, 2019 at 08:18:32 +0100, Ross Nicholson wrote:
> > Example stream that does not work: rtsp://
> 184.72.239.149/vod/mp4:BigBuckBunny_115k.mov
> >
> > Extending the condition allows the stream to be proc
ional output handle, used when input and output are done separately,
eg for HTTP tunneling.
In your case it would not be.
On Wed, 14 Aug 2019 at 09:50, Ross Nicholson wrote:
>
>
> On Wed, 14 Aug 2019 at 07:20, Moritz Barsnick wrote:
>
>> On Mon, Aug 05, 2019 at 08:18:32 +0100, Ross
Ping.
If I’m missing something I should have provided for this patch please let me
know. It’s my first patch to FFmpeg.
> On 11 Aug 2019, at 10:39, Ross Nicholson wrote:
>
> 3rd time lucky, can anyone take a look at this? It’s a minor patch and is
> required for kodi.
>
>
3rd time lucky, can anyone take a look at this? It’s a minor patch and is
required for kodi.
Thanks in advance
> On 8 Aug 2019, at 11:46, Ross Nicholson wrote:
>
> Any feedback on this patch?
>
>> On Mon, 5 Aug 2019 at 00:18, Ross Nicholson wrote:
>> Example s
Any feedback on this patch?
On Mon, 5 Aug 2019 at 00:18, Ross Nicholson wrote:
> Example stream that does not work: rtsp://
> 184.72.239.149/vod/mp4:BigBuckBunny_115k.mov
>
> Extending the condition allows the stream to be processed correctly.
>
> On Mon, 5 Aug 2019 at 08:
Example stream that does not work: rtsp://
184.72.239.149/vod/mp4:BigBuckBunny_115k.mov
Extending the condition allows the stream to be processed correctly.
On Mon, 5 Aug 2019 at 08:17, Ross Nicholson wrote:
> From: phunkyfish
>
> ---
> libavformat/rtspdec.c | 2 +-
> 1
From: phunkyfish
---
libavformat/rtspdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c
index 32dff2319c..3a79d1b175 100644
--- a/libavformat/rtspdec.c
+++ b/libavformat/rtspdec.c
@@ -57,7 +57,7 @@ static int rtsp_read_close(AV
Wrong commit message/subject. Please ignore. Will send new patch shortly.
On Sun, 4 Aug 2019 at 22:41, Ross Nicholson wrote:
> Example stream that does not work: rtsp://
> 184.72.239.149/vod/mp4:BigBuckBunny_115k.mov
>
> Extending the condition allows the stream to be process
From: phunkyfish
---
libavformat/rtspdec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c
index 32dff2319c..3a79d1b175 100644
--- a/libavformat/rtspdec.c
+++ b/libavformat/rtspdec.c
@@ -57,7 +57,7 @@ static int rtsp_read_close(AV
Example stream that does not work: rtsp://
184.72.239.149/vod/mp4:BigBuckBunny_115k.mov
Extending the condition allows the stream to be processed correctly.
On Sun, 4 Aug 2019 at 22:39, Ross Nicholson wrote:
> From: phunkyfish
>
> ---
> libavformat/rtspdec.c | 2 +-
> 1
Example: rtsp://184.72.239.149/vod/mp4:BigBuckBunny_115k.mov
Extending the condition allows the stream to be processed correctly.
0001-Don-t-send-teardown-if-rtsp_hd_out-is-null.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@
52 matches
Mail list logo
