Re: [FFmpeg-devel] [PATCH v4] avfilter/vf_zoompan: fix shaking when zooming

2020-02-13 Thread Robert Deibel
On 07.02.20 21:23, Paul B Mahol wrote: On 2/6/20, Robert Deibel wrote: Would appreciate further review or info. Are you sure this change does not break older scripts? You were right, it did break older scripts. Clips that were upscaled in a previous filter would be transformed in a worse

Re: [FFmpeg-devel] [PATCH v4] avfilter/vf_zoompan: fix shaking when zooming

2020-02-06 Thread Robert Deibel
Would appreciate further review or info. On 29.01.20 10:54, Robert Deibel wrote: Fix shaking of image when zoom is applied by the zoompan filter. Resolves ticket https://trac.ffmpeg.org/ticket/4298 --- Fixed a typo/bug where dy was dx. Removed request for oversized frame from filter, instead

Re: [FFmpeg-devel] [PATCH v4] avfilter/vf_zoompan: fix shaking when zooming

2020-01-29 Thread Robert Deibel
On 29.01.20 11:49, Paul B Mahol wrote: On 1/29/20, Robert Deibel wrote: - -av_opt_set_int(s->sws, "srcw", w, 0); -av_opt_set_int(s->sws, "srch", h, 0); +av_opt_set_int(s->sws, "srcw", crop_w, 0); +av_opt_set_int(s->sws,

[FFmpeg-devel] [PATCH v4] avfilter/vf_zoompan: fix shaking when zooming

2020-01-29 Thread Robert Deibel
Fix shaking of image when zoom is applied by the zoompan filter. Resolves ticket https://trac.ffmpeg.org/ticket/4298 --- Fixed a typo/bug where dy was dx. Removed request for oversized frame from filter, instead allocate internal frame and copy contents to out frame once dimensions are correct.

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_zoompan: fix shaking when zooming

2020-01-28 Thread Robert Deibel
On 28.01.20 15:46, Paul B Mahol wrote: On 1/28/20, Robert Deibel wrote: On 27.01.20 16:44, Paul B Mahol wrote: On 1/27/20, Robert Deibel wrote: -y = *dy = av_clipd(*dy, 0, FFMAX(in->height - h, 0)); -var_values[VAR_Y] = *dy; -y &= ~((1 << s->desc->log2_chroma_

Re: [FFmpeg-devel] [PATCH v3] avfilter/vf_zoompan: fix shaking when zooming

2020-01-28 Thread Robert Deibel
On 27.01.20 16:44, Paul B Mahol wrote: On 1/27/20, Robert Deibel wrote: -y = *dy = av_clipd(*dy, 0, FFMAX(in->height - h, 0)); -var_values[VAR_Y] = *dy; -y &= ~((1 << s->desc->log2_chroma_h) - 1); - -out = ff_get_video_buffer(outlink, outlink->w,

[FFmpeg-devel] [PATCH v3] avfilter/vf_zoompan: fix shaking when zooming

2020-01-27 Thread Robert Deibel
Fix shaking of image when zoom is applied by the zoompan filter. Resolves ticket https://trac.ffmpeg.org/ticket/4298 --- Fixed the style issues and modified the comment of scale_to_grid() to correctly specify the functionality. libavfilter/vf_zoompan.c | 82 --

[FFmpeg-devel] [PATCH] avfilter/vf_zoompan: fix shaking when zooming

2020-01-23 Thread Robert Deibel
Fix shaking of image when zoom is applied by the zoompan filter. Resolves ticket https://trac.ffmpeg.org/ticket/4298 --- libavfilter/vf_zoompan.c | 81 1 file changed, 57 insertions(+), 24 deletions(-) diff --git a/libavfilter/vf_zoompan.c b/libavfilter/vf

[FFmpeg-devel] [PATCH] zoompan filter: fix shaking when zooming

2020-01-23 Thread Robert Deibel
Fix shaking of image when zoom is applied by the zoompan filter. Resolves ticket https://trac.ffmpeg.org/ticket/4298 --- libavfilter/vf_zoompan.c | 93 ++-- 1 file changed, 70 insertions(+), 23 deletions(-) diff --git a/libavfilter/vf_zoompan.c b/libavfilter/vf