Re: [FFmpeg-devel] Matroska and output_ts_offset

2022-08-29 Thread Peter Zebühr
> On 29 Aug 2022, at 16:37, Andreas Rheinhardt > wrote: > > The Matroska muxer is buggy wrt. to the ts_offset relating to codec > delay. You can see it in lines 1839-1841 which are commented out. > Commenting them out happened in commit > 82e4f39883932c1b1e5c7792a1be12dec6ab603d, merging the lib

[FFmpeg-devel] Matroska and output_ts_offset

2022-08-29 Thread Peter Zebühr
Hello, I noticed the other day that if I try to mux opus in webm with a timestamp offset set I don't get the expected timestamps out on my packets. Example: ffmpeg -f lavfi -i "sine=frequency=1000:duration=60" -output_ts_offset 200ms -c:a libopus sine_200ms_offset.webm Now if I inspect

Re: [FFmpeg-devel] Issue with ogg page termination on full last page with even last segment size

2021-01-25 Thread Peter Zebühr
Ping > On 14 Jan 2021, at 18:13, Peter Zebühr wrote: > > Hi, > > I had a look at different options on how to fix the regression, though I am > not sure what I arrived at is what you had in mind. > > I tried to read up a bit on opus as well and I assume you are ta

Re: [FFmpeg-devel] Issue with ogg page termination on full last page with even last segment size

2021-01-14 Thread Peter Zebühr
Hi, I had a look at different options on how to fix the regression, though I am not sure what I arrived at is what you had in mind. I tried to read up a bit on opus as well and I assume you are talking about the frame length coding allowing coding of zero-byte frames? If so, my understanding

Re: [FFmpeg-devel] Issue with ogg page termination on full last page with even last segment size

2021-01-07 Thread Peter Zebühr
> On 5 Jan 2021, at 16:22, Lynne wrote: > > Was going to respond to this but forgot. > Opus can have 0 byte packets to signal silence. So you'll have to fix this > for real. Ok, sounds reasonable. Was also thinking that 0 byte packets would be reasonable to support from the containers perspect

Re: [FFmpeg-devel] Issue with ogg page termination on full last page with even last segment size

2021-01-05 Thread Peter Zebühr
ring if it makes sense to send in a zero sized packet for muxing or not. That is, should I try to fix that or should I rather try to compensate for this in oggenc.c? Regards, Peter > On 15 Dec 2020, at 14:35, Peter Zebühr wrote: > > Hello! > > I have stumbled on an issue with th

[FFmpeg-devel] Issue with ogg page termination on full last page with even last segment size

2020-12-15 Thread Peter Zebühr
Hello! I have stumbled on an issue with the ogg page termination in a probably quite rare case. If the last page ends up full (255 segments) and the last packet that is written is an even multiple of 255 that needs to be terminated with a lacing value of zero that spills over to the next page,