Re: [FFmpeg-devel] [PATCH] avformat/iff: fix EOF check

2025-08-04 Thread Peter Ross
On Mon, Aug 04, 2025 at 07:54:41PM -0300, James Almer wrote: > The check to return on EOF should not be inside a block that will not be > entered after reaching EOF. > Should fix "libavcodec/bytestream.h:144:27: runtime error: applying zero > offset to null pointer". > > Signed-off-by: James Alm

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: squelch uninitialized variable warnings

2025-07-08 Thread Peter Ross
On Mon, Jul 07, 2025 at 12:41:34PM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > Fixes CID1655273 and CID1655274. > > --- > > libavcodec/adpcm.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/libavcodec/adpcm.c b/libavcodec/a

[FFmpeg-devel] [PATCHv2] avcodec/adpcm: squelch uninitialized variable warnings

2025-07-08 Thread Peter Ross
Fixes CID1655273 and CID1655274. --- v2: Use the new av_unreachable() macro libavcodec/adpcm.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 92ab248f3d..83ef7c780a 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -877,6 +877,8 @@

[FFmpeg-devel] [PATCH 4/4] tests/fate/audio: Sanyo LD-ADPCM test case

2025-07-05 Thread Peter Ross
--- tests/fate/audio.mak | 12 + tests/ref/fate/sanyo-3bit | 36 + tests/ref/fate/sanyo-4bit | 46 +++ tests/ref/fate/sanyo-5bit | 57 +++ 4 files changed, 151 insertions(+) create mode 100644 tes

[FFmpeg-devel] [PATCH 3/4] tests/fate/video: LEAD MCMP test case

2025-07-05 Thread Peter Ross
--- tests/fate/video.mak | 15 +++ tests/ref/fate/lead-yuv420p | 6 ++ tests/ref/fate/lead-yuv420p-half | 6 ++ tests/ref/fate/lead-yuv420p-zero | 6 ++ tests/ref/fate/lead-yuv444p | 6 ++ 5 files changed, 39 insertions(+) create mode 100644 t

[FFmpeg-devel] [PATCH 2/4] tests/fate/demux: IFF ANIM test case

2025-07-05 Thread Peter Ross
--- tests/fate/demux.mak | 3 +++ tests/ref/fate/iff-demux | 32 2 files changed, 35 insertions(+) create mode 100644 tests/ref/fate/iff-demux diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak index 715e64bfac..a2cb45aa7e 100644 --- a/tests/fate/demux

[FFmpeg-devel] [PATCH 1/4] tests/fate/audio: G.728 test case

2025-07-05 Thread Peter Ross
--- tests/fate/audio.mak | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak index 1a2d07304b..c21578947a 100644 --- a/tests/fate/audio.mak +++ b/tests/fate/audio.mak @@ -42,6 +42,12 @@ fate-dsf-dst: CMD = pcm -i $(TARGET_SAMPLES)/dst/dst-64fs44-2

[FFmpeg-devel] [PATCH] avcodec/adpcm: squelch uninitialized variable warnings

2025-07-05 Thread Peter Ross
Fixes CID1655273 and CID1655274. --- libavcodec/adpcm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 92ab248f3d..527384b86d 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -877,6 +877,9 @@ static int adpcm_sanyo_expand3(ADPCMCh

Re: [FFmpeg-devel] [PATCH] avcodec/rv60dec: Check ofs for overflows

2025-06-28 Thread Peter Ross
On Sat, Jun 28, 2025 at 02:21:57AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 30 + 2147483647 cannot be represented in type > 'int' > Fixes: > 418335931/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-6568264620900352 > > Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCHv2] avcodec/adpcm: Sanyo LD-ADPCM decoder

2025-06-27 Thread Peter Ross
Peter Ross (pr...@xvid.org) * * This file is part of FFmpeg. * @@ -260,6 +261,9 @@ static av_cold int adpcm_decode_init(AVCodecContext * avctx) case AV_CODEC_ID_ADPCM_IMA_AMV: max_channels = 1; break; +case AV_CODEC_ID_ADPCM_SANYO: +max_channels = 2

[FFmpeg-devel] [PATCH 1/2] avcodec/adpcm: Sanyo LD-ADPCM decoder

2025-06-25 Thread Peter Ross
hannels, int16_t **samples_p); + #endif /* AVCODEC_ADPCM_H */ diff --git a/libavcodec/adpcm_le.c b/libavcodec/adpcm_le.c new file mode 100644 index 00..df8eb3dd90 --- /dev/null +++ b/libavcodec/adpcm_le.c @@ -0,0 +1,205 @@ +/* + * Copyright (c) 2025 Peter Ross + * + * This file is part o

[FFmpeg-devel] [PATCH 2/2] tests/fate: Sanyo LD-ADPCM test case

2025-06-25 Thread Peter Ross
--- tests/fate/audio.mak | 11 tests/ref/fate/sanyo-3bit | 36 + tests/ref/fate/sanyo-4bit | 46 +++ tests/ref/fate/sanyo-5bit | 57 +++ 4 files changed, 150 insertions(+) create mode 100644 test

Re: [FFmpeg-devel] [PATCH] avcodec/g728dec: Remove AVCodec.sample_fmts

2025-06-23 Thread Peter Ross
On Mon, Jun 23, 2025 at 12:43:54PM +0200, Andreas Rheinhardt wrote: > Patch attached. > > - Andreas > From e2b8892a583a09ca4aa607af8813b4947c2e6fc1 Mon Sep 17 00:00:00 2001 > From: Andreas Rheinhardt > Date: Mon, 23 Jun 2025 12:41:36 +0200 > Subject: [PATCH] avcodec/g728dec: Remove AVCodec.sampl

[FFmpeg-devel] [PATCH] tools/pktdumper: dump extradata buffers

2025-06-23 Thread Peter Ross
--- useful for re'ing files with extradata tools/pktdumper.c | 28 ++-- 1 file changed, 26 insertions(+), 2 deletions(-) diff --git a/tools/pktdumper.c b/tools/pktdumper.c index c51f5c8922..d7d3147b22 100644 --- a/tools/pktdumper.c +++ b/tools/pktdumper.c @@ -37,6 +37,7

Re: [FFmpeg-devel] [PATCH 4/5] avformat/iff: Check nb_channels == 0 in CHNL

2025-06-21 Thread Peter Ross
On Sat, Jun 21, 2025 at 11:15:20PM +0200, Michael Niedermayer wrote: > Fixes: division by 0 > Fixes: > 418396712/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-6104388018176000 > Fixes: > 418478219/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-4569544410857472 > > Found-by: continuo

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/rv60dec: Check sum in read_slice_sizes()

2025-06-21 Thread Peter Ross
On Sat, Jun 21, 2025 at 11:15:19PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 2147483647 + 1913651185 cannot be represented > in type 'int' > Fixes: > 418335931/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-6568264620900352 > > Found-by: continuous fuzzin

[FFmpeg-devel] [PATCH] avcodec/rv60dec: drop unused sum variable in read_slice_sizes

2025-06-21 Thread Peter Ross
--- libavcodec/rv60dec.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/rv60dec.c b/libavcodec/rv60dec.c index 2bbcb1d620..6075598861 100644 --- a/libavcodec/rv60dec.c +++ b/libavcodec/rv60dec.c @@ -390,14 +390,14 @@ static int read_frame_header(RV60Context *

[FFmpeg-devel] [PATCHv4] avcodec/g728dec: G.728 decoder

2025-06-18 Thread Peter Ross
3e --- /dev/null +++ b/libavcodec/g728dec.c @@ -0,0 +1,220 @@ +/* + * G.728 decoder + * Copyright (c) 2025 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as publis

[FFmpeg-devel] [PATCHv2] avcodec/mips: fix build failure when specific decoder/encoder enabled

2025-06-18 Thread Peter Ross
acelp_kelvin, g729, qcelp, sipr and wmavoice decoders all depend upon mips/{acelp_filters_mips,celp_filters_mips,acelp_vectors_mips}.o when arch is mips. g723_1 depends on mips/{celp_filters_mips,acelp_vectors_mips}.o. comfortnoise, evrc, ra144 and ra288 depend on mips/celp_filters_mips.o. --- P

[FFmpeg-devel] [PATCH 2/2] configure: h264_vulkan_encoder depends on atsc_a53

2025-06-17 Thread Peter Ross
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index bfe5f5bbee..4dfe0c7114 100755 --- a/configure +++ b/configure @@ -3411,7 +3411,7 @@ h264_qsv_encoder_select="atsc_a53 qsvenc" h264_rkmpp_decoder_deps="rkmpp" h264_rkmpp_decoder_select="h

[FFmpeg-devel] [PATCH 1/2] configure: cbs_apv depends on cbs

2025-06-17 Thread Peter Ross
--- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index e2e9fc26d8..bfe5f5bbee 100755 --- a/configure +++ b/configure @@ -2869,6 +2869,7 @@ w32threads_deps="atomics_native" threads_if_any="$THREADS_LIST" # subsystems +cbs_apv_select="cbs" cbs_av1_select="

Re: [FFmpeg-devel] [PATCH] avcodec/osq: Request a coding mode 2 sample

2025-06-17 Thread Peter Ross
On Tue, Jun 17, 2025 at 10:32:16PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/osq.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/osq.c b/libavcodec/osq.c > index 025be667a35..0de9af5f623 100644 > --- a/libavcodec/osq.c > +++

[FFmpeg-devel] [PATCH] avcodec/mips: fix build failure when only specific decoders enabled

2025-06-16 Thread Peter Ross
acelp_kelvin, g729, qcelp, sipr and wmavoice decoders all depend upon mips/{acelp_filters_mips,celp_filters_mips,acelp_vectors_mips}.o when arch is mips. --- libavcodec/mips/Makefile | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavcodec/mips/Makefile b/libavcodec/mips/Mak

[FFmpeg-devel] [PATCHv2] configure: add celp_math component

2025-06-14 Thread Peter Ross
libavcodec/tests/celp_math depends on libavcodec/celp_math.o This fixes fate when configuring with --disable-everything --- patch v2: also add celp_math component to libavcodec/mips/Makefile configure | 13 - libavcodec/Makefile | 17 + libavcod

Re: [FFmpeg-devel] [PATCHv3 7/8] avformat/aiff: G.728 muxing and demuxing

2025-06-09 Thread Peter Ross
On Tue, Jun 10, 2025 at 12:25:24AM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > --- > > libavformat/aiff.c| 1 + > > libavformat/aiffdec.c | 3 +++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/libavformat/aiff.c b/libavformat/aiff.c

[FFmpeg-devel] [PATCH] avcodec/tests/dct: add CONFIG_PRORES_DECODER guard

2025-06-09 Thread Peter Ross
Only enable the proresdsp check when the prores decoder is enabled. This fixes fate when configuring with --disable-everything --- libavcodec/tests/dct.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/tests/dct.c b/libavcodec/tests/dct.c index 76ad42bdfa..784b49276c 100644 -

[FFmpeg-devel] [PATCH] configure: add celp_math component

2025-06-09 Thread Peter Ross
libavcodec/tests/celp_math depends on libavcodec/celp_math.o This fixes fate when configuring with --disable-everything --- configure | 13 - libavcodec/Makefile | 17 + tests/fate/libavcodec.mak | 2 +- 3 files changed, 18 insertions(+), 14 dele

[FFmpeg-devel] [PATCHv3 6/8] avformat/riff: G.728 muxing and demuxing

2025-06-09 Thread Peter Ross
--- libavformat/riff.c| 2 ++ libavformat/riffenc.c | 1 + 2 files changed, 3 insertions(+) diff --git a/libavformat/riff.c b/libavformat/riff.c index 017a0658ef..151563e9f2 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -555,6 +555,7 @@ const AVCodecTag ff_codec_wav_tags[] = {

[FFmpeg-devel] [PATCHv3 2/8] avcodec/g728_template: make hist parameter constant

2025-06-09 Thread Peter Ross
--- libavcodec/g728_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/g728_template.c b/libavcodec/g728_template.c index b60122ee37..dd1b1a4415 100644 --- a/libavcodec/g728_template.c +++ b/libavcodec/g728_template.c @@ -39,7 +39,7 @@ static void convolve(fl

[FFmpeg-devel] [PATCHv3 3/8] avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters

2025-06-09 Thread Peter Ross
--- libavcodec/aac/aacdec_dsp_template.c | 2 +- libavcodec/aacenc_tns.c | 2 +- libavcodec/lpc.c | 2 +- libavcodec/lpc_functions.h | 18 +- libavcodec/ra288.c | 2 +- 5 files changed, 17 insertions(+), 9 deletions(-

[FFmpeg-devel] [PATCHv3 8/8] avformat/rtp: G.728 muxing and demuxing

2025-06-09 Thread Peter Ross
--- libavformat/rtp.c| 2 +- libavformat/rtpenc.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/rtp.c b/libavformat/rtp.c index 564489b613..5bde171cf4 100644 --- a/libavformat/rtp.c +++ b/libavformat/rtp.c @@ -53,7 +53,7 @@ static const struct { {13, "CN",

[FFmpeg-devel] [PATCHv3 7/8] avformat/aiff: G.728 muxing and demuxing

2025-06-09 Thread Peter Ross
--- libavformat/aiff.c| 1 + libavformat/aiffdec.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/libavformat/aiff.c b/libavformat/aiff.c index 1ceac69a70..907f7d8d28 100644 --- a/libavformat/aiff.c +++ b/libavformat/aiff.c @@ -40,6 +40,7 @@ const AVCodecTag ff_codec_aiff_tags[] = {

[FFmpeg-devel] [PATCHv3 5/8] avformat/g728dec: raw G.728 demuxer

2025-06-09 Thread Peter Ross
--- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/g728dec.c| 58 3 files changed, 60 insertions(+) create mode 100644 libavformat/g728dec.c diff --git a/libavformat/Makefile b/libavformat/Makefile index 9884b4a4cb..2e73

[FFmpeg-devel] [PATCHv3 4/8] avcodec/g728dec: G.728 decoder

2025-06-09 Thread Peter Ross
dev/null +++ b/libavcodec/g728dec.c @@ -0,0 +1,220 @@ +/* + * G.728 decoder + * Copyright (c) 2025 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as publis

[FFmpeg-devel] [PATCHv3 1/8] avcodec/g728_template: do_hybrid_window() template

2025-06-09 Thread Peter Ross
intended for use by RealAudio 2.0 (28.8k) and G.728 decoders. --- libavcodec/g728_template.c | 65 ++ libavcodec/ra288.c | 50 ++--- 2 files changed, 68 insertions(+), 47 deletions(-) create mode 100644 libavcodec/g728_template.c

[FFmpeg-devel] [PATCHv3 0/8] G.728 decoding

2025-06-09 Thread Peter Ross
Sample: https://pross.sdf.org/sandpit/CW5.g728 Peter Ross (8): avcodec/g728_template: do_hybrid_window() template avcodec/g728_template: make hist parameter constant avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters avcodec/g728dec: G.728

Re: [FFmpeg-devel] [PATCH] avcodec/rv60dec: Avoid branch when decoding cbp16

2025-05-19 Thread Peter Ross
On Mon, May 19, 2025 at 12:06:02AM +0200, Andreas Rheinhardt wrote: > Patch attached. > > - Andreas > From 02724d5792348bea618c049034dc0febf24a46ac Mon Sep 17 00:00:00 2001 > From: Andreas Rheinhardt > Date: Sun, 18 May 2025 23:12:03 +0200 > Subject: [PATCH] avcodec/rv60dec: Avoid branch when de

Re: [FFmpeg-devel] [PATCH 6/7] avcodec/rv60dec: inter also fails with qp >= 32

2025-05-09 Thread Peter Ross
On Thu, May 08, 2025 at 11:57:37PM +0200, Michael Niedermayer wrote: > Fixes: out of array read in decode_cu_16x16() > Fixes: > 398049430/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-5525836849807360 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/t

Re: [FFmpeg-devel] [PATCH 4/7] avformat/iff: Check nb_channels == 0 in MHDR

2025-05-09 Thread Peter Ross
On Thu, May 08, 2025 at 11:57:35PM +0200, Michael Niedermayer wrote: > Fixes: division by 0 > Fixes: > 395163171/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-542604339373670 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/mmvideo: fix paltte index

2025-05-09 Thread Peter Ross
On Thu, May 08, 2025 at 11:57:32PM +0200, Michael Niedermayer wrote: > Fixes: > 391935573/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MMVIDEO_fuzzer-4655048979709952 > Fixes: out of array access > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/proje

Re: [FFmpeg-devel] Addition of encoder functionality in libavcodec/vpx_rac.h and corresponding commit in vpx_rac.c

2025-04-27 Thread Peter Ross
Hi Amogh, On Sun, Apr 27, 2025 at 10:38:57PM +0530, Amogh Kumar Sinha wrote: >Dear Sir, >I am sending this patch for adding encoder functionality, as the >Qualification Task for GSoC 2025. Kindly look into it: Ok, this "diff" comes at the last minute and its not quite ready for inclus

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/vp8: Fix wrong #endif comment

2025-03-08 Thread Peter Ross
On Sat, Mar 08, 2025 at 04:29:06AM +0100, Andreas Rheinhardt wrote: > Patches attached > > - Andreas > From 54e27b588e18fdfe277a77b0f385cb02731022b9 Mon Sep 17 00:00:00 2001 > From: Andreas Rheinhardt > Date: Thu, 6 Mar 2025 17:56:08 +0100 > Subject: [PATCH 1/4] avcodec/vp8: Fix wrong #endif com

Re: [FFmpeg-devel] [PATCH 1/1] Add vpx range encoder support

2025-03-06 Thread Peter Ross
On Wed, Mar 05, 2025 at 09:59:34PM +0530, MihirGore wrote: > From: MihirGore23 > Hi, comments below. > --- > libavcodec/vpx_rac.h | 75 ++-- > 1 file changed, 59 insertions(+), 16 deletions(-) > > diff --git a/libavcodec/vpx_rac.h b/libavcodec/vpx_rac.

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/rv60dec: Initialize slice gb with actually allocated size

2025-02-08 Thread Peter Ross
On Sun, Feb 09, 2025 at 03:24:21AM +0100, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 385170375/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-4710055187906560 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects

Re: [FFmpeg-devel] [PATCH 5/6] avformat/iff: Check that we have a stream in read_dst_frame()

2025-02-08 Thread Peter Ross
On Sun, Feb 09, 2025 at 03:24:20AM +0100, Michael Niedermayer wrote: > Fixes: null pointer dereference > Fixes: > 385644864/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-4551049565765632 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffm

[FFmpeg-devel] [PATCHv2] avcodec/g728dec: G.728 decoder

2025-02-05 Thread Peter Ross
00..f932a50f6c --- /dev/null +++ b/libavcodec/g728dec.c @@ -0,0 +1,220 @@ +/* + * G.728 decoder + * Copyright (c) 2025 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public +

Re: [FFmpeg-devel] [PATCHv2] avcodec/leaddec: support format 0x1006

2025-02-05 Thread Peter Ross
On Sun, Jan 19, 2025 at 08:49:50PM +1100, Peter Ross wrote: > Fixes ticket #10658. > --- > > Tested with some different vertical resolution alignments. > > When the vertical resolution is not aligned to macroblock height, the > reference encoder & decoder performs buggy

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/wtvdec: Initialize buf

2025-01-22 Thread Peter Ross
On Tue, Jan 21, 2025 at 09:57:43PM +, Michael Niedermayer wrote: > ffmpeg | branch: master | Michael Niedermayer | Thu > Dec 26 02:53:45 2024 +0100| [17b019c517af26c6d2f0c6266938c60d36db1fa3] | > committer: Michael Niedermayer > > avformat/wtvdec: Initialize buf > > ff_parse_mpeg2_descript

[FFmpeg-devel] [PATCHv2] avcodec/leaddec: support format 0x1006

2025-01-19 Thread Peter Ross
Fixes ticket #10658. --- Tested with some different vertical resolution alignments. When the vertical resolution is not aligned to macroblock height, the reference encoder & decoder performs buggy placement of the initial field. Its an internal bug, but because the encoder and decoder are aligned

[FFmpeg-devel] [PATCH] avcodec/leaddec: support format 0x1006

2025-01-14 Thread Peter Ross
Fixes ticket #10658. --- libavcodec/leaddec.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c index 88387902ca..12e27061e9 100644 --- a/libavcodec/leaddec.c +++ b/libavcodec/leaddec.c @@ -164,6 +164,10 @@ static int lead_d

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

2025-01-13 Thread Peter Ross
On Sun, Jan 12, 2025 at 02:48:00PM +0100, Andreas Rheinhardt wrote: > Peter Ross: > > --- > > libavcodec/Makefile | 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/codec_desc.c | 7 ++ > > libavcodec/codec_id.h | 1 + &

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

2025-01-13 Thread Peter Ross
On Sun, Jan 12, 2025 at 12:42:05AM -0300, James Almer wrote: > On 1/11/2025 11:37 PM, Peter Ross wrote: > > --- > > libavcodec/Makefile | 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/codec_desc.c | 7 ++ > > libavcodec/codec_id.h |

[FFmpeg-devel] [PATCH 8/8] avformat/rtp: G.728 muxing and demuxing

2025-01-11 Thread Peter Ross
--- libavformat/rtp.c| 2 +- libavformat/rtpenc.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/rtp.c b/libavformat/rtp.c index 564489b613..5bde171cf4 100644 --- a/libavformat/rtp.c +++ b/libavformat/rtp.c @@ -53,7 +53,7 @@ static const struct { {13, "CN",

[FFmpeg-devel] [PATCH 7/8] avformat/aiff: G.728 muxing and demuxing

2025-01-11 Thread Peter Ross
--- libavformat/aiff.c| 1 + libavformat/aiffdec.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/libavformat/aiff.c b/libavformat/aiff.c index 1ceac69a70..907f7d8d28 100644 --- a/libavformat/aiff.c +++ b/libavformat/aiff.c @@ -40,6 +40,7 @@ const AVCodecTag ff_codec_aiff_tags[] = {

[FFmpeg-devel] [PATCH 6/8] avformat/riff: G.728 muxing and demuxing

2025-01-11 Thread Peter Ross
--- libavformat/riff.c| 2 ++ libavformat/riffenc.c | 1 + 2 files changed, 3 insertions(+) diff --git a/libavformat/riff.c b/libavformat/riff.c index 017a0658ef..151563e9f2 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -555,6 +555,7 @@ const AVCodecTag ff_codec_wav_tags[] = {

[FFmpeg-devel] [PATCH 5/8] avformat/g728dec: raw G.728 demuxer

2025-01-11 Thread Peter Ross
--- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/g728dec.c| 58 3 files changed, 60 insertions(+) create mode 100644 libavformat/g728dec.c diff --git a/libavformat/Makefile b/libavformat/Makefile index 074efc118a..e6a9

[FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

2025-01-11 Thread Peter Ross
dev/null +++ b/libavcodec/g728dec.c @@ -0,0 +1,213 @@ +/* + * G.728 decoder + * Copyright (c) 2025 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as publis

[FFmpeg-devel] [PATCH 3/8] avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters

2025-01-11 Thread Peter Ross
--- libavcodec/aac/aacdec_dsp_template.c | 2 +- libavcodec/aacenc_tns.c | 2 +- libavcodec/lpc.c | 2 +- libavcodec/lpc_functions.h | 18 +- libavcodec/ra288.c | 2 +- 5 files changed, 17 insertions(+), 9 deletions(-

[FFmpeg-devel] [PATCH 2/8] avcodec/g728_template: make hist parameter constant

2025-01-11 Thread Peter Ross
--- libavcodec/g728_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/g728_template.c b/libavcodec/g728_template.c index 72eb5fde80..0c83b0dbdc 100644 --- a/libavcodec/g728_template.c +++ b/libavcodec/g728_template.c @@ -39,7 +39,7 @@ static void convolve(fl

[FFmpeg-devel] [PATCH 0/8] G.728 decoding

2025-01-11 Thread Peter Ross
Sample: https://pross.sdf.org/sandpit/CW5.g728 Peter Ross (8): avcodec/g728_template: do_hybrid_window() template avcodec/g728_template: make hist parameter constant avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters avcodec/g728dec: G.728

[FFmpeg-devel] [PATCH 1/8] avcodec/g728_template: do_hybrid_window() template

2025-01-11 Thread Peter Ross
intended for use by RealAudio 2.0 (28.8k) and G.728 decoders. --- libavcodec/g728_template.c | 65 ++ libavcodec/ra288.c | 50 ++--- 2 files changed, 68 insertions(+), 47 deletions(-) create mode 100644 libavcodec/g728_template.c

Re: [FFmpeg-devel] [PATCHv2 1/3] avformat/mlvdec: demux LJ92 huffman comressed frames

2025-01-08 Thread Peter Ross
On Sun, Dec 22, 2024 at 06:40:31PM +1100, Peter Ross wrote: > A minimal DNG header is added to each LJ92 compressed frame, allowing > thme to be decoded by the TIFF decoder. The TIFF decoder is responsible > for setting up the MJPEG decoder, signalling the correct s->bayer flag, &

Re: [FFmpeg-devel] [PATCH] configure: update copyright year

2025-01-01 Thread Peter Ross
On Wed, Jan 01, 2025 at 06:03:51PM +0900, Lynne via ffmpeg-devel wrote: > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 0a7ce31e09..6c1829ab8e 100755 > --- a/configure > +++ b/configure > @@ -8230,7 +8230,7 @@ cat > $TMPH <

[FFmpeg-devel] [PATCH] avformat/iff: ignore FVER tag when not processing DSD/DST files

2024-12-28 Thread Peter Ross
Fixes ticket #10030. --- libavformat/iff.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavformat/iff.c b/libavformat/iff.c index ab0488dd31..19420c21a2 100644 --- a/libavformat/iff.c +++ b/libavformat/iff.c @@ -692,13 +692,15 @@ static int iff_read_header

Re: [FFmpeg-devel] [PATCH v2] Add SRV3 decoder/demuxer

2024-12-27 Thread Peter Ross
On Fri, Dec 27, 2024 at 12:16:04AM +0100, fishhh wrote: > > instructions on how to obtain a srv3 sample file would be helpful too. > > this is so we can actually test your patch. > > downloading the file from YouTube is probably the easiest way, > you can achieve this by the means of yt-dlp like t

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mlvdec: Check avio_read()

2024-12-25 Thread Peter Ross
On Wed, Dec 25, 2024 at 05:26:57AM +0100, Michael Niedermayer wrote: > Fixes: use-of-uninitialized-value > Fixes: > 383170476/clusterfuzz-testcase-minimized-ffmpeg_dem_MLV_fuzzer-4696002884337664 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/f

Re: [FFmpeg-devel] [PATCH v2] Add SRV3 decoder/demuxer

2024-12-25 Thread Peter Ross
On Wed, Dec 25, 2024 at 11:29:24PM +0100, Hubert Głuchowski wrote: > This commit adds preliminary support for decoding the SRV3 subtitle format. > SRV3 is the internal format YouTube uses for their captions. Supporting it > in ffmpeg allows video players to play a significant subset of SRV3 > mostl

[FFmpeg-devel] [PATCH] avformat/wtvenc: do not output negative 'third timestamp' field

2024-12-24 Thread Peter Ross
Fixes ticket #3659. --- libavformat/wtvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/wtvenc.c b/libavformat/wtvenc.c index 02fe84573f..0c0ef05bbe 100644 --- a/libavformat/wtvenc.c +++ b/libavformat/wtvenc.c @@ -450,7 +450,7 @@ static void write_timestamp(AVF

[FFmpeg-devel] [PATCH] avformat/iff: remove surplus if statement

2024-12-22 Thread Peter Ross
Fixes CID 1636854 --- libavformat/iff.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/iff.c b/libavformat/iff.c index ab0488dd31..de58b93421 100644 --- a/libavformat/iff.c +++ b/libavformat/iff.c @@ -1007,8 +1007,6 @@ static int iff_read_packet(AVFormatContext *s, av_as

[FFmpeg-devel] [PATCHv2 2/3] avformat/mlvdec: process VERS block

2024-12-21 Thread Peter Ross
--- libavformat/mlvdec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c index 22c94c6c58..a786f73fba 100644 --- a/libavformat/mlvdec.c +++ b/libavformat/mlvdec.c @@ -259,6 +259,10 @@ static int scan_file(AVFormatContext *avctx, AVStream *vst, A

[FFmpeg-devel] [PATCHv2 3/3] avformat/mlvdec: skip over some other known block types

2024-12-21 Thread Peter Ross
--- libavformat/mlvdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c index a786f73fba..96a666e243 100644 --- a/libavformat/mlvdec.c +++ b/libavformat/mlvdec.c @@ -263,9 +263,12 @@ static int scan_file(AVFormatContext *avctx, AVStream *vst, AV

[FFmpeg-devel] [PATCHv2 1/3] avformat/mlvdec: demux LJ92 huffman comressed frames

2024-12-21 Thread Peter Ross
A minimal DNG header is added to each LJ92 compressed frame, allowing thme to be decoded by the TIFF decoder. The TIFF decoder is responsible for setting up the MJPEG decoder, signalling the correct s->bayer flag, and setting pix_fmt. The LJ92 compressed frames can be muxed out to DNG files, and m

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: include aom_film_grain.o file for h264_sei component

2024-12-20 Thread Peter Ross
On Sat, Dec 21, 2024 at 12:02:06AM +0200, Jan Ekström wrote: > On Thu, Dec 19, 2024 at 4:34 AM Peter Ross wrote: > > > > h264_sei depends on h2645_sei, which in turn depends on aom_film_grain for > > ff_aom_uninit_film_grain_params() > > Set LGTM. > > Thanks f

Re: [FFmpeg-devel] [PATCH 2/2] avformat/riff: map 0069 twocc to ADPCM IMA XBOX decoder

2024-12-20 Thread Peter Ross
On Thu, Dec 12, 2024 at 09:25:55AM +1100, Peter Ross wrote: > --- > Using AV_CODEC_ID_ADPCM_IMA_WAV for twocc 0x0069 causes subtle artefacts > during > playback. The correct decoder is AV_CODEC_ID_ADPCM_IMA_XBOX. > > Sample .wav and ref flac file: > <https://github.com/v

Re: [FFmpeg-devel] [PATCHv2 1/2] avformat/iff: SndAnim decoding

2024-12-19 Thread Peter Ross
On Wed, Dec 11, 2024 at 09:27:51AM +1100, Peter Ross wrote: > Fixes ticket #5553. > --- > Additional hardening thanks to target_dem_fuzzer.c > > libavformat/iff.c | 311 +++--- > 1 file changed, 210 insertions(+), 101 deletions(-) >

[FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: include aom_film_grain.o file for h264_sei component

2024-12-18 Thread Peter Ross
h264_sei depends on h2645_sei, which in turn depends on aom_film_grain for ff_aom_uninit_film_grain_params() --- libavcodec/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index fd8e312fc8..350f50108a 100644 --- a/libavcodec/Ma

[FFmpeg-devel] [PATCH 1/2] avformat/Makefile: include object files for image_vbn_pipe demuxer

2024-12-18 Thread Peter Ross
--- found to be missing as the result of exhaustive configure options search. if image_vbn_pipe is selected on its own, build fails. libavformat/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/Makefile b/libavformat/Makefile index 691738eb4b..074efc118a 100644 --- a/libav

Re: [FFmpeg-devel] [PATCH] avformat/Makefile: add iso_writer golomb_tab from shared library dependency

2024-12-18 Thread Peter Ross
On Wed, Dec 18, 2024 at 05:21:33PM -0300, James Almer wrote: > On 12/18/2024 5:17 PM, Peter Ross wrote: > > --- > > libavformat/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/Makefile b/libavformat/Makefile

[FFmpeg-devel] [PATCH] avformat/Makefile: add iso_writer golomb_tab from shared library dependency

2024-12-18 Thread Peter Ross
--- libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index dd96bf7ba8..a6935ad244 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@ -728,7 +728,7 @@ OBJS-$(CONFIG_LIBZMQ_PROTOCOL) += libzmq.

Re: [FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

2024-12-17 Thread Peter Ross
On Wed, Dec 18, 2024 at 02:28:26PM +0900, Lynne via ffmpeg-devel wrote: > > > On 16/12/2024 20:00, Peter Ross wrote: > > since commit fce0622d0b1f69a85fe8ce61e1189dd57a8b0fcc, libavformat/hevc.c > > depends on golomb vlc tables. > > --- > > i often build with -

[FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

2024-12-16 Thread Peter Ross
since commit fce0622d0b1f69a85fe8ce61e1189dd57a8b0fcc, libavformat/hevc.c depends on golomb vlc tables. --- i often build with --disable-all and only turn on the components that i am working on. this dependency would otherwise go unnoticed since many codecs drag in golomb. configure | 1 + 1 file

[FFmpeg-devel] [PATCH 3/3] avformat/mlvdec: skip over some other known block types

2024-12-12 Thread Peter Ross
--- libavformat/mlvdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c index 830e416f57..4f708a7705 100644 --- a/libavformat/mlvdec.c +++ b/libavformat/mlvdec.c @@ -253,9 +253,12 @@ static int scan_file(AVFormatContext *avctx, AVStream *vst, AV

[FFmpeg-devel] [PATCH 2/3] avformat/mlvdec: process VERS block

2024-12-12 Thread Peter Ross
--- libavformat/mlvdec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c index 269f211e9f..830e416f57 100644 --- a/libavformat/mlvdec.c +++ b/libavformat/mlvdec.c @@ -249,6 +249,10 @@ static int scan_file(AVFormatContext *avctx, AVStream *vst, A

[FFmpeg-devel] [PATCH 1/3] avformat/mlvdec: demux LJ92 huffman comressed frames

2024-12-12 Thread Peter Ross
A minimal DNG header is added to each LJ92 compressed frame, allowing thme to be decoded by the TIFF decoder. The TIFF decoder is responsible for setting up the MJPEG decoder, signalling the correct s->bayer flag, and setting pix_fmt. The LJ92 compressed frames can be muxed out to DNG files, and m

[FFmpeg-devel] [PATCH 2/2] avformat/riff: map 0069 twocc to ADPCM IMA XBOX decoder

2024-12-11 Thread Peter Ross
--- Using AV_CODEC_ID_ADPCM_IMA_WAV for twocc 0x0069 causes subtle artefacts during playback. The correct decoder is AV_CODEC_ID_ADPCM_IMA_XBOX. Sample .wav and ref flac file: libavformat/riff.c | 2 +- tests/ref/fat

[FFmpeg-devel] [PATCH 1/2] avcodec: add ADPCM IMA XBOX decoder

2024-12-11 Thread Peter Ross
From: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/adpcm.c | 41 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + libavcodec/utils.c | 6 ++ 6 files changed, 57 insertions

[FFmpeg-devel] [PATCHv2 2/2] tests/fate/demux: IFF test case

2024-12-10 Thread Peter Ross
--- Test file: https://pross.sdf.org/sandpit/Hammer2.sndanim tests/fate/demux.mak | 3 +++ tests/ref/fate/iff-demux | 32 2 files changed, 35 insertions(+) create mode 100644 tests/ref/fate/iff-demux diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak

[FFmpeg-devel] [PATCHv2 1/2] avformat/iff: SndAnim decoding

2024-12-10 Thread Peter Ross
Fixes ticket #5553. --- Additional hardening thanks to target_dem_fuzzer.c libavformat/iff.c | 311 +++--- 1 file changed, 210 insertions(+), 101 deletions(-) diff --git a/libavformat/iff.c b/libavformat/iff.c index 7601baa629..ab0488dd31 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/rv60dec: Check NEXT/LAST availability

2024-12-07 Thread Peter Ross
On Sun, Dec 08, 2024 at 04:57:01AM +0100, Michael Niedermayer wrote: > Fixes: NULL ptr use > Fixes: > 378634700/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-5008344043028480 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/rv60dec: Use get_bits_long()

2024-12-07 Thread Peter Ross
On Sun, Dec 08, 2024 at 04:57:00AM +0100, Michael Niedermayer wrote: > Fixes: > 378634700/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-5008344043028480 > Fixes: assertion failure > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/f

[FFmpeg-devel] [PATCH] avformat/iff: SndAnim decoding

2024-12-07 Thread Peter Ross
Fixes ticket #5553. --- libavformat/iff.c | 302 ++ 1 file changed, 201 insertions(+), 101 deletions(-) diff --git a/libavformat/iff.c b/libavformat/iff.c index 7601baa629..9ab1252e67 100644 --- a/libavformat/iff.c +++ b/libavformat/iff.c @@ -111,6 +111

[FFmpeg-devel] [PATCH 2/2] configure: add leaddec blockdsp dependency

2024-12-04 Thread Peter Ross
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 8168fed6b8..bf55ba67fa 100755 --- a/configure +++ b/configure @@ -3004,7 +3004,7 @@ ipu_decoder_select="mpegvideodec" jpegls_decoder_select="mjpeg_decoder" jv_decoder_select="blockdsp"

[FFmpeg-devel] [PATCH 1/2] avcodec/leaddec: support format 0x6

2024-12-04 Thread Peter Ross
Fixes ticket #10657. --- libavcodec/leaddec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c index 2f5152c226..88387902ca 100644 --- a/libavcodec/leaddec.c +++ b/libavcodec/leaddec.c @@ -157,6 +157,7 @@ static int lead_decode_frame(AVCodecContext *a

[FFmpeg-devel] [PATCH] avformat/mm: fix packets pts generation and add seek support

2024-12-01 Thread Peter Ross
Signed-off-by: Peter Ross --- Author: Paul B Mahol Date: Wed Jun 26 09:07:29 2024 +0200 libavformat/mm.c | 31 ++ tests/ref/fate/alg-mm | 62 +-- 2 files changed, 45 insertions(+), 48 deletions(-) diff --git a/libavformat/mm.c

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/rv60dec: Check qp for intra

2024-12-01 Thread Peter Ross
On Mon, Dec 02, 2024 at 12:24:53AM +0100, Michael Niedermayer wrote: > The rv60_qp_to_idx table only supports qp up to 31 on intra > > Fixes: global-buffer-overflow > Fixes: > 377543818/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-5160167345291264 > > Found-by: continuous fuzzin

[FFmpeg-devel] [PATCH] avcodec/ac4dec: process immersive stereo

2024-11-26 Thread Peter Ross
--- This doesn't apply to git master, but is for anyone with AC-4 decoder branch. libavcodec/ac4dec.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/ac4dec.c b/libavcodec/ac4dec.c index 9ac866eb4f..e9f7991c9e 100644 --- a/libavcodec/ac4dec.c +++ b/libavcodec/ac4dec.c @@ -11

Re: [FFmpeg-devel] [PATCH] avformat/icodec: fix integer overflow with nb_pal

2024-11-24 Thread Peter Ross
On Thu, Nov 21, 2024 at 03:39:05PM +0100, Kacper Michajlow wrote: > On Sun, 3 Nov 2024 at 11:24, Michael Niedermayer > wrote: > > > > Fixes: runtime error: signed integer overflow > > Fixes: > > 42536949/clusterfuzz-testcase-minimized-fuzzer_loadfile-6199846684393472 > > Found-by: ossfuzz > > Re

[FFmpeg-devel] [PATCH] avformat/mm: add fallthrough comment

2024-11-21 Thread Peter Ross
Fixes CID 1634888 --- libavformat/mm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mm.c b/libavformat/mm.c index 74e2716926..07ba6ac4f5 100644 --- a/libavformat/mm.c +++ b/libavformat/mm.c @@ -190,6 +190,7 @@ static int read_packet(AVFormatContext *s, default :

[FFmpeg-devel] [PATCH 0/3] Quram Qmage image decoder

2024-11-21 Thread Peter Ross
. Samples: https://www.mediafire.com/folder/sa1r8iprkckm7/Bootanimations Peter Ross (3): avcodec/qmagedec: Quram Qmage decoder avformat/qmagedec: Quram Qmage demuxer fate/qmage: add tests libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/sanm: fix XPAL handling

2024-11-20 Thread Peter Ross
On Fri, Nov 08, 2024 at 09:55:04AM +0100, Manuel Lauss wrote: > Outlaws' RAE.SAN file did not properly fade out in certain scenes, > but simply turned to black as soon as the first XPAL chunk with > the apply command was encountered. > > Signed-off-by: Manuel Lauss i have tested this with few Ou

  1   2   3   4   5   6   >