Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/wtvdec: Initialize buf

On Tue, Jan 21, 2025 at 09:57:43PM +, Michael Niedermayer wrote: > ffmpeg | branch: master | Michael Niedermayer | Thu > Dec 26 02:53:45 2024 +0100| [17b019c517af26c6d2f0c6266938c60d36db1fa3] | > committer: Michael Niedermayer > > avformat/wtvdec: Initialize buf > > ff_parse_mpeg2_descript

[FFmpeg-devel] [PATCHv2] avcodec/leaddec: support format 0x1006

Fixes ticket #10658. --- Tested with some different vertical resolution alignments. When the vertical resolution is not aligned to macroblock height, the reference encoder & decoder performs buggy placement of the initial field. Its an internal bug, but because the encoder and decoder are aligned

[FFmpeg-devel] [PATCH] avcodec/leaddec: support format 0x1006

Fixes ticket #10658. --- libavcodec/leaddec.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c index 88387902ca..12e27061e9 100644 --- a/libavcodec/leaddec.c +++ b/libavcodec/leaddec.c @@ -164,6 +164,10 @@ static int lead_d

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

On Sun, Jan 12, 2025 at 02:48:00PM +0100, Andreas Rheinhardt wrote: > Peter Ross: > > --- > > libavcodec/Makefile | 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/codec_desc.c | 7 ++ > > libavcodec/codec_id.h | 1 + &

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

On Sun, Jan 12, 2025 at 12:42:05AM -0300, James Almer wrote: > On 1/11/2025 11:37 PM, Peter Ross wrote: > > --- > > libavcodec/Makefile | 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/codec_desc.c | 7 ++ > > libavcodec/codec_id.h |

[FFmpeg-devel] [PATCH 8/8] avformat/rtp: G.728 muxing and demuxing

--- libavformat/rtp.c| 2 +- libavformat/rtpenc.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/rtp.c b/libavformat/rtp.c index 564489b613..5bde171cf4 100644 --- a/libavformat/rtp.c +++ b/libavformat/rtp.c @@ -53,7 +53,7 @@ static const struct { {13, "CN",

[FFmpeg-devel] [PATCH 7/8] avformat/aiff: G.728 muxing and demuxing

--- libavformat/aiff.c| 1 + libavformat/aiffdec.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/libavformat/aiff.c b/libavformat/aiff.c index 1ceac69a70..907f7d8d28 100644 --- a/libavformat/aiff.c +++ b/libavformat/aiff.c @@ -40,6 +40,7 @@ const AVCodecTag ff_codec_aiff_tags[] = {

[FFmpeg-devel] [PATCH 6/8] avformat/riff: G.728 muxing and demuxing

--- libavformat/riff.c| 2 ++ libavformat/riffenc.c | 1 + 2 files changed, 3 insertions(+) diff --git a/libavformat/riff.c b/libavformat/riff.c index 017a0658ef..151563e9f2 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -555,6 +555,7 @@ const AVCodecTag ff_codec_wav_tags[] = {

[FFmpeg-devel] [PATCH 5/8] avformat/g728dec: raw G.728 demuxer

--- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/g728dec.c| 58 3 files changed, 60 insertions(+) create mode 100644 libavformat/g728dec.c diff --git a/libavformat/Makefile b/libavformat/Makefile index 074efc118a..e6a9

[FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

dev/null +++ b/libavcodec/g728dec.c @@ -0,0 +1,213 @@ +/* + * G.728 decoder + * Copyright (c) 2025 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as publis

[FFmpeg-devel] [PATCH 3/8] avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters

--- libavcodec/aac/aacdec_dsp_template.c | 2 +- libavcodec/aacenc_tns.c | 2 +- libavcodec/lpc.c | 2 +- libavcodec/lpc_functions.h | 18 +- libavcodec/ra288.c | 2 +- 5 files changed, 17 insertions(+), 9 deletions(-

[FFmpeg-devel] [PATCH 2/8] avcodec/g728_template: make hist parameter constant

--- libavcodec/g728_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/g728_template.c b/libavcodec/g728_template.c index 72eb5fde80..0c83b0dbdc 100644 --- a/libavcodec/g728_template.c +++ b/libavcodec/g728_template.c @@ -39,7 +39,7 @@ static void convolve(fl

[FFmpeg-devel] [PATCH 0/8] G.728 decoding

Sample: https://pross.sdf.org/sandpit/CW5.g728 Peter Ross (8): avcodec/g728_template: do_hybrid_window() template avcodec/g728_template: make hist parameter constant avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters avcodec/g728dec: G.728

[FFmpeg-devel] [PATCH 1/8] avcodec/g728_template: do_hybrid_window() template

intended for use by RealAudio 2.0 (28.8k) and G.728 decoders. --- libavcodec/g728_template.c | 65 ++ libavcodec/ra288.c | 50 ++--- 2 files changed, 68 insertions(+), 47 deletions(-) create mode 100644 libavcodec/g728_template.c

Re: [FFmpeg-devel] [PATCHv2 1/3] avformat/mlvdec: demux LJ92 huffman comressed frames

On Sun, Dec 22, 2024 at 06:40:31PM +1100, Peter Ross wrote: > A minimal DNG header is added to each LJ92 compressed frame, allowing > thme to be decoded by the TIFF decoder. The TIFF decoder is responsible > for setting up the MJPEG decoder, signalling the correct s->bayer flag, &

Re: [FFmpeg-devel] [PATCH] configure: update copyright year

On Wed, Jan 01, 2025 at 06:03:51PM +0900, Lynne via ffmpeg-devel wrote: > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 0a7ce31e09..6c1829ab8e 100755 > --- a/configure > +++ b/configure > @@ -8230,7 +8230,7 @@ cat > $TMPH <

[FFmpeg-devel] [PATCH] avformat/iff: ignore FVER tag when not processing DSD/DST files

Fixes ticket #10030. --- libavformat/iff.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavformat/iff.c b/libavformat/iff.c index ab0488dd31..19420c21a2 100644 --- a/libavformat/iff.c +++ b/libavformat/iff.c @@ -692,13 +692,15 @@ static int iff_read_header

Re: [FFmpeg-devel] [PATCH v2] Add SRV3 decoder/demuxer

On Fri, Dec 27, 2024 at 12:16:04AM +0100, fishhh wrote: > > instructions on how to obtain a srv3 sample file would be helpful too. > > this is so we can actually test your patch. > > downloading the file from YouTube is probably the easiest way, > you can achieve this by the means of yt-dlp like t

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mlvdec: Check avio_read()

On Wed, Dec 25, 2024 at 05:26:57AM +0100, Michael Niedermayer wrote: > Fixes: use-of-uninitialized-value > Fixes: > 383170476/clusterfuzz-testcase-minimized-ffmpeg_dem_MLV_fuzzer-4696002884337664 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/f

Re: [FFmpeg-devel] [PATCH v2] Add SRV3 decoder/demuxer

On Wed, Dec 25, 2024 at 11:29:24PM +0100, Hubert Głuchowski wrote: > This commit adds preliminary support for decoding the SRV3 subtitle format. > SRV3 is the internal format YouTube uses for their captions. Supporting it > in ffmpeg allows video players to play a significant subset of SRV3 > mostl

[FFmpeg-devel] [PATCH] avformat/wtvenc: do not output negative 'third timestamp' field

Fixes ticket #3659. --- libavformat/wtvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/wtvenc.c b/libavformat/wtvenc.c index 02fe84573f..0c0ef05bbe 100644 --- a/libavformat/wtvenc.c +++ b/libavformat/wtvenc.c @@ -450,7 +450,7 @@ static void write_timestamp(AVF

[FFmpeg-devel] [PATCH] avformat/iff: remove surplus if statement

Fixes CID 1636854 --- libavformat/iff.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavformat/iff.c b/libavformat/iff.c index ab0488dd31..de58b93421 100644 --- a/libavformat/iff.c +++ b/libavformat/iff.c @@ -1007,8 +1007,6 @@ static int iff_read_packet(AVFormatContext *s, av_as

[FFmpeg-devel] [PATCHv2 2/3] avformat/mlvdec: process VERS block

--- libavformat/mlvdec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c index 22c94c6c58..a786f73fba 100644 --- a/libavformat/mlvdec.c +++ b/libavformat/mlvdec.c @@ -259,6 +259,10 @@ static int scan_file(AVFormatContext *avctx, AVStream *vst, A

[FFmpeg-devel] [PATCHv2 3/3] avformat/mlvdec: skip over some other known block types

--- libavformat/mlvdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c index a786f73fba..96a666e243 100644 --- a/libavformat/mlvdec.c +++ b/libavformat/mlvdec.c @@ -263,9 +263,12 @@ static int scan_file(AVFormatContext *avctx, AVStream *vst, AV

[FFmpeg-devel] [PATCHv2 1/3] avformat/mlvdec: demux LJ92 huffman comressed frames

A minimal DNG header is added to each LJ92 compressed frame, allowing thme to be decoded by the TIFF decoder. The TIFF decoder is responsible for setting up the MJPEG decoder, signalling the correct s->bayer flag, and setting pix_fmt. The LJ92 compressed frames can be muxed out to DNG files, and m

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: include aom_film_grain.o file for h264_sei component

On Sat, Dec 21, 2024 at 12:02:06AM +0200, Jan Ekström wrote: > On Thu, Dec 19, 2024 at 4:34 AM Peter Ross wrote: > > > > h264_sei depends on h2645_sei, which in turn depends on aom_film_grain for > > ff_aom_uninit_film_grain_params() > > Set LGTM. > > Thanks f

Re: [FFmpeg-devel] [PATCH 2/2] avformat/riff: map 0069 twocc to ADPCM IMA XBOX decoder

On Thu, Dec 12, 2024 at 09:25:55AM +1100, Peter Ross wrote: > --- > Using AV_CODEC_ID_ADPCM_IMA_WAV for twocc 0x0069 causes subtle artefacts > during > playback. The correct decoder is AV_CODEC_ID_ADPCM_IMA_XBOX. > > Sample .wav and ref flac file: > <https://github.com/v

Re: [FFmpeg-devel] [PATCHv2 1/2] avformat/iff: SndAnim decoding

On Wed, Dec 11, 2024 at 09:27:51AM +1100, Peter Ross wrote: > Fixes ticket #5553. > --- > Additional hardening thanks to target_dem_fuzzer.c > > libavformat/iff.c | 311 +++--- > 1 file changed, 210 insertions(+), 101 deletions(-) >

[FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: include aom_film_grain.o file for h264_sei component

h264_sei depends on h2645_sei, which in turn depends on aom_film_grain for ff_aom_uninit_film_grain_params() --- libavcodec/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index fd8e312fc8..350f50108a 100644 --- a/libavcodec/Ma

[FFmpeg-devel] [PATCH 1/2] avformat/Makefile: include object files for image_vbn_pipe demuxer

--- found to be missing as the result of exhaustive configure options search. if image_vbn_pipe is selected on its own, build fails. libavformat/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/Makefile b/libavformat/Makefile index 691738eb4b..074efc118a 100644 --- a/libav

Re: [FFmpeg-devel] [PATCH] avformat/Makefile: add iso_writer golomb_tab from shared library dependency

On Wed, Dec 18, 2024 at 05:21:33PM -0300, James Almer wrote: > On 12/18/2024 5:17 PM, Peter Ross wrote: > > --- > > libavformat/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/Makefile b/libavformat/Makefile

[FFmpeg-devel] [PATCH] avformat/Makefile: add iso_writer golomb_tab from shared library dependency

--- libavformat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index dd96bf7ba8..a6935ad244 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile @@ -728,7 +728,7 @@ OBJS-$(CONFIG_LIBZMQ_PROTOCOL) += libzmq.

Re: [FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

On Wed, Dec 18, 2024 at 02:28:26PM +0900, Lynne via ffmpeg-devel wrote: > > > On 16/12/2024 20:00, Peter Ross wrote: > > since commit fce0622d0b1f69a85fe8ce61e1189dd57a8b0fcc, libavformat/hevc.c > > depends on golomb vlc tables. > > --- > > i often build with -

[FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

since commit fce0622d0b1f69a85fe8ce61e1189dd57a8b0fcc, libavformat/hevc.c depends on golomb vlc tables. --- i often build with --disable-all and only turn on the components that i am working on. this dependency would otherwise go unnoticed since many codecs drag in golomb. configure | 1 + 1 file

[FFmpeg-devel] [PATCH 3/3] avformat/mlvdec: skip over some other known block types

--- libavformat/mlvdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c index 830e416f57..4f708a7705 100644 --- a/libavformat/mlvdec.c +++ b/libavformat/mlvdec.c @@ -253,9 +253,12 @@ static int scan_file(AVFormatContext *avctx, AVStream *vst, AV

[FFmpeg-devel] [PATCH 2/3] avformat/mlvdec: process VERS block

--- libavformat/mlvdec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mlvdec.c b/libavformat/mlvdec.c index 269f211e9f..830e416f57 100644 --- a/libavformat/mlvdec.c +++ b/libavformat/mlvdec.c @@ -249,6 +249,10 @@ static int scan_file(AVFormatContext *avctx, AVStream *vst, A

[FFmpeg-devel] [PATCH 1/3] avformat/mlvdec: demux LJ92 huffman comressed frames

A minimal DNG header is added to each LJ92 compressed frame, allowing thme to be decoded by the TIFF decoder. The TIFF decoder is responsible for setting up the MJPEG decoder, signalling the correct s->bayer flag, and setting pix_fmt. The LJ92 compressed frames can be muxed out to DNG files, and m

[FFmpeg-devel] [PATCH 2/2] avformat/riff: map 0069 twocc to ADPCM IMA XBOX decoder

--- Using AV_CODEC_ID_ADPCM_IMA_WAV for twocc 0x0069 causes subtle artefacts during playback. The correct decoder is AV_CODEC_ID_ADPCM_IMA_XBOX. Sample .wav and ref flac file: libavformat/riff.c | 2 +- tests/ref/fat

[FFmpeg-devel] [PATCH 1/2] avcodec: add ADPCM IMA XBOX decoder

From: Paul B Mahol --- libavcodec/Makefile | 1 + libavcodec/adpcm.c | 41 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + libavcodec/utils.c | 6 ++ 6 files changed, 57 insertions

[FFmpeg-devel] [PATCHv2 2/2] tests/fate/demux: IFF test case

--- Test file: https://pross.sdf.org/sandpit/Hammer2.sndanim tests/fate/demux.mak | 3 +++ tests/ref/fate/iff-demux | 32 2 files changed, 35 insertions(+) create mode 100644 tests/ref/fate/iff-demux diff --git a/tests/fate/demux.mak b/tests/fate/demux.mak

[FFmpeg-devel] [PATCHv2 1/2] avformat/iff: SndAnim decoding

Fixes ticket #5553. --- Additional hardening thanks to target_dem_fuzzer.c libavformat/iff.c | 311 +++--- 1 file changed, 210 insertions(+), 101 deletions(-) diff --git a/libavformat/iff.c b/libavformat/iff.c index 7601baa629..ab0488dd31 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/rv60dec: Check NEXT/LAST availability

On Sun, Dec 08, 2024 at 04:57:01AM +0100, Michael Niedermayer wrote: > Fixes: NULL ptr use > Fixes: > 378634700/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-5008344043028480 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/rv60dec: Use get_bits_long()

On Sun, Dec 08, 2024 at 04:57:00AM +0100, Michael Niedermayer wrote: > Fixes: > 378634700/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-5008344043028480 > Fixes: assertion failure > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/f

[FFmpeg-devel] [PATCH] avformat/iff: SndAnim decoding

Fixes ticket #5553. --- libavformat/iff.c | 302 ++ 1 file changed, 201 insertions(+), 101 deletions(-) diff --git a/libavformat/iff.c b/libavformat/iff.c index 7601baa629..9ab1252e67 100644 --- a/libavformat/iff.c +++ b/libavformat/iff.c @@ -111,6 +111

[FFmpeg-devel] [PATCH 2/2] configure: add leaddec blockdsp dependency

--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 8168fed6b8..bf55ba67fa 100755 --- a/configure +++ b/configure @@ -3004,7 +3004,7 @@ ipu_decoder_select="mpegvideodec" jpegls_decoder_select="mjpeg_decoder" jv_decoder_select="blockdsp"

[FFmpeg-devel] [PATCH 1/2] avcodec/leaddec: support format 0x6

Fixes ticket #10657. --- libavcodec/leaddec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c index 2f5152c226..88387902ca 100644 --- a/libavcodec/leaddec.c +++ b/libavcodec/leaddec.c @@ -157,6 +157,7 @@ static int lead_decode_frame(AVCodecContext *a

[FFmpeg-devel] [PATCH] avformat/mm: fix packets pts generation and add seek support

Signed-off-by: Peter Ross --- Author: Paul B Mahol Date: Wed Jun 26 09:07:29 2024 +0200 libavformat/mm.c | 31 ++ tests/ref/fate/alg-mm | 62 +-- 2 files changed, 45 insertions(+), 48 deletions(-) diff --git a/libavformat/mm.c

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/rv60dec: Check qp for intra

On Mon, Dec 02, 2024 at 12:24:53AM +0100, Michael Niedermayer wrote: > The rv60_qp_to_idx table only supports qp up to 31 on intra > > Fixes: global-buffer-overflow > Fixes: > 377543818/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV60_fuzzer-5160167345291264 > > Found-by: continuous fuzzin

[FFmpeg-devel] [PATCH] avcodec/ac4dec: process immersive stereo

--- This doesn't apply to git master, but is for anyone with AC-4 decoder branch. libavcodec/ac4dec.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavcodec/ac4dec.c b/libavcodec/ac4dec.c index 9ac866eb4f..e9f7991c9e 100644 --- a/libavcodec/ac4dec.c +++ b/libavcodec/ac4dec.c @@ -11

Re: [FFmpeg-devel] [PATCH] avformat/icodec: fix integer overflow with nb_pal

On Thu, Nov 21, 2024 at 03:39:05PM +0100, Kacper Michajlow wrote: > On Sun, 3 Nov 2024 at 11:24, Michael Niedermayer > wrote: > > > > Fixes: runtime error: signed integer overflow > > Fixes: > > 42536949/clusterfuzz-testcase-minimized-fuzzer_loadfile-6199846684393472 > > Found-by: ossfuzz > > Re

[FFmpeg-devel] [PATCH] avformat/mm: add fallthrough comment

Fixes CID 1634888 --- libavformat/mm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mm.c b/libavformat/mm.c index 74e2716926..07ba6ac4f5 100644 --- a/libavformat/mm.c +++ b/libavformat/mm.c @@ -190,6 +190,7 @@ static int read_packet(AVFormatContext *s, default :

[FFmpeg-devel] [PATCH 0/3] Quram Qmage image decoder

. Samples: https://www.mediafire.com/folder/sa1r8iprkckm7/Bootanimations Peter Ross (3): avcodec/qmagedec: Quram Qmage decoder avformat/qmagedec: Quram Qmage demuxer fate/qmage: add tests libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/sanm: fix XPAL handling

On Fri, Nov 08, 2024 at 09:55:04AM +0100, Manuel Lauss wrote: > Outlaws' RAE.SAN file did not properly fade out in certain scenes, > but simply turned to black as soon as the first XPAL chunk with > the apply command was encountered. > > Signed-off-by: Manuel Lauss i have tested this with few Ou

[FFmpeg-devel] [PATCH 2/3] avformat/qmagedec: Quram Qmage demuxer

+++ b/libavformat/qmagedec.c @@ -0,0 +1,244 @@ +/* + * Quram Qmage image format demuxer + * Copyright (c) 2024 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as

[FFmpeg-devel] [PATCH 1/3] avcodec/qmagedec: Quram Qmage decoder

0644 index 00..8c3d6cbc60 --- /dev/null +++ b/libavcodec/qmagedec.c @@ -0,0 +1,836 @@ +/* + * Quram Qmage image format decoder + * Copyright (c) 2024 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the

[FFmpeg-devel] [PATCH 3/3] fate/qmage: add tests

--- Test files: https://pross.sdf.org/sandpit/ani_alpha.qmg https://pross.sdf.org/sandpit/dynamic_table.qmg https://pross.sdf.org/sandpit/w2_pass.qmg tests/fate/video.mak | 11 +++ tests/ref/fate/qmage-ani_alpha | 10 ++ tests/ref/fate/qmage-dynamic_table | 15 +

Re: [FFmpeg-devel] [PATCH 01/11] avformat/spdifenc: parse headers for audio codecs

On Sun, Nov 17, 2024 at 11:04:13PM -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavformat/spdifdec.c |2 + subject line says avformat/spdifENC, but changes are only to the decoder. > tests/ref/fate/spdif-dca-core-remux| 14 +- > tests/ref/fa

Re: [FFmpeg-devel] [PATCHv2 1/4] avcodec/mm: set audio pts proportionally to audio offset

On Thu, Jun 27, 2024 at 08:08:14AM +1000, Peter Ross wrote: > --- > libavformat/mm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/mm.c b/libavformat/mm.c > index 23c025d852..a40b5c44bb 100644 > --- a/libavformat/mm.c > +++ b/liba

[FFmpeg-devel] [PATCH] configure: add rv60 decoder golomb dependency

Fixes standalone compilation of the rv60 decoder. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 0e9ed6dc3c..3a614c76c1 100755 --- a/configure +++ b/configure @@ -3071,7 +3071,7 @@ rv20_decoder_select="h263_decoder" rv20_encoder_selec

[FFmpeg-devel] [PATCH 1/2] avcodec/rv60: loosen fill_mv_skip_cand top right and bottom left criteria

Fixes ticket #11293. --- libavcodec/rv60dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/rv60dec.c b/libavcodec/rv60dec.c index 091018cc56..19cd0f2861 100644 --- a/libavcodec/rv60dec.c +++ b/libavcodec/rv60dec.c @@ -881,12 +881,12 @@ static void fill_mv_skip

[FFmpeg-devel] [PATCH 2/2] avcodec/rv60: simplify fill_mv_skip_cand

--- libavcodec/rv60dec.c | 54 ++-- 1 file changed, 17 insertions(+), 37 deletions(-) diff --git a/libavcodec/rv60dec.c b/libavcodec/rv60dec.c index 19cd0f2861..a54980f131 100644 --- a/libavcodec/rv60dec.c +++ b/libavcodec/rv60dec.c @@ -862,50 +862,30 @@ st

[FFmpeg-devel] [PATCH] avcodec/rv60: align calc_sel_qp with reference decoder

Fixes ticket #11290. --- libavcodec/rv60dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/rv60dec.c b/libavcodec/rv60dec.c index 0ce346fefb..96f121197a 100644 --- a/libavcodec/rv60dec.c +++ b/libavcodec/rv60dec.c @@ -2237,7 +2237,7 @@ static int calc_sel_qp(int o

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/rv60: prevent decode_cu_r deadlock

Fixes ticket #11289 (deadlock). --- continuation of patch set: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2024-November/335675.html libavcodec/rv60dec.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/rv60dec.c b/libavcodec/rv60dec.c index 8ec95e896

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/rv60: prevent decode_cu_r segfault

Fixes ticket #11289 (crash). --- continuation of patch set: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2024-November/335675.html libavcodec/rv60dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/rv60dec.c b/libavcodec/rv60dec.c index 86c7aefbca..8ec95e896f 100644 --- a/l

[FFmpeg-devel] [PATCHv2] avcodec/eatgq: decode motion vector macroblocks

Signed-off-by: Peter Ross --- added missing reference frame check. will apply soon. libavcodec/codec_desc.c | 2 +- libavcodec/eatgq.c | 54 ++--- 2 files changed, 51 insertions(+), 5 deletions(-) diff --git a/libavcodec/codec_desc.c b/libavcodec

[FFmpeg-devel] [PATCH 2/2] avcodec/rv60: check init_get_bits8 return value

Fixes CID 1634471 --- libavcodec/rv60dec.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/rv60dec.c b/libavcodec/rv60dec.c index d68fa66fa7..86c7aefbca 100644 --- a/libavcodec/rv60dec.c +++ b/libavcodec/rv60dec.c @@ -2263,7 +2263,8 @@ static int decode_slice(A

[FFmpeg-devel] [PATCH 1/2] avcodec/rv60: negative qp guard

Fixes CID 1634472 --- libavcodec/rv60dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/rv60dec.c b/libavcodec/rv60dec.c index d0cc10253b..d68fa66fa7 100644 --- a/libavcodec/rv60dec.c +++ b/libavcodec/rv60dec.c @@ -2270,6 +2270,8 @@ static int decode_slice(AVCodecContext *avctx

Re: [FFmpeg-devel] [PATCHv3] avcodec/rv60: RealVideo 6.0 decoder

On Tue, Oct 01, 2024 at 12:59:30PM +1000, Peter Ross wrote: > Reviewed-by: Anton Khirnov > Reviewed-by: Andreas Rheinhardt > Signed-off-by: Peter Ross > --- > > Have addressed all comments from earlier post (March 2024) > (https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2

Re: [FFmpeg-devel] [PATCHv2 1/2] avcodec/vp56: decode interlace content

On Fri, Oct 18, 2024 at 07:53:55PM +1100, Peter Ross wrote: > Modification of patch submitted by Aurelien Jacobs (November 2007). > > Fixes ticket #5581. > --- > v2: vp56_mc() modified to reproduce behaviour of reference VP6 decoder > > libavcodec/vp5.c | 5 +---

[FFmpeg-devel] [PATCH] avcodec/eatgq: decode motion vector macroblocks

--- sample: https://discmaster.textfiles.com/file/22091/SSERVCD_50A.bin/DEMOS/NBA97/NBA97.EXE/WESTERN.UV libavcodec/codec_desc.c | 2 +- libavcodec/eatgq.c | 50 + 2 files changed, 47 insertions(+), 5 deletions(-) diff --git a/libavcodec/codec_desc.

[FFmpeg-devel] [PATCHv2 1/2] avcodec/vp56: decode interlace content

Modification of patch submitted by Aurelien Jacobs (November 2007). Fixes ticket #5581. --- v2: vp56_mc() modified to reproduce behaviour of reference VP6 decoder libavcodec/vp5.c | 5 +--- libavcodec/vp56.c| 54 +++- libavcodec/vp56.h| 6 +++

[FFmpeg-devel] [PATCHv2 2/2] fate/vp60-interlace: add test

--- samples files to be copied into $SAMPLES/vp6/ https://pross.sdf.org/sandpit/interlaced32x32.avi https://pross.sdf.org/sandpit/interlaced32x64.avi tests/fate/vpx.mak | 6 ++ tests/ref/fate/vp60-interlace1 | 156 + tests/ref/fate/vp60-interlace2 |

[FFmpeg-devel] [PATCH] avcodec/vp56: decode interlace content

Modification of patch submitted by Aurelien Jacobs (November 2007). Fixes ticket #5581. --- libavcodec/vp5.c | 5 + libavcodec/vp56.c| 32 +++- libavcodec/vp56.h| 6 ++ libavcodec/vp6.c | 11 ++- libavcodec/vp6data.h | 11 +++

Re: [FFmpeg-devel] [PATCH 6/6] avformat/wtvdec: Check length of read mpeg2_descriptor

On Wed, Aug 07, 2024 at 12:18:53AM +0200, Michael Niedermayer wrote: > Fixes: Use of uninitialized value > Fixes: > 70900/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-6286909377150976 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpe

Re: [FFmpeg-devel] [PATCH 4/6] avformat/wtvdec: clear sectors

On Wed, Aug 07, 2024 at 12:18:51AM +0200, Michael Niedermayer wrote: > The code can leave uninitialized holes in the array. > Fixes: use of uninitialized values > Fixes: > 70883/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-6698694567591936 > > Found-by: continuous fuzzing process > https

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/adpcm: Remove setting min_channel to value it is already set to

On Fri, Jul 26, 2024 at 11:08:32PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/adpcm.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c > index 8f9a8a8c8e2..6c53d0bcf39 100644 > --- a/libavcodec/adpc

[FFmpeg-devel] [PATCH] avcodec/adpcm: only process right samples when decoding stereo

Fixes Coverity issue #1610760. --- libavcodec/adpcm.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index afdbeaa15e..58f2ef0dfb 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -1684,22 +1684,24 @@ static int

Re: [FFmpeg-devel] Mono ADPCM for EA WVE Files / Fix Framerate

On Sat, Jul 20, 2024 at 10:19:18AM -0400, Aaron wrote: > On Fri, Jul 19, 2024 at 07:54:37PM -0400, Peter Ross wrote: > > > can you post a sample file somewhere > > Of course. Here are some you can try out: > > gm_us.wve: (Stereo - 15 FPS) https://0x0.st/X97A.wve >

Re: [FFmpeg-devel] Mono ADPCM for EA WVE Files / Fix Framerate

On Fri, Jul 19, 2024 at 07:34:18AM -0400, redacted redacted wrote: > Hello there, > > The Sims 1: Unleashed makes use of WVE files for its intro videos. > Two of the files for the game use Mono ADPCM audio instead of Stereo. > However, FFmpeg's ADPCM_EA codec always expects the files to be in Ster

[FFmpeg-devel] [PATCHv2 4/4] avcodec/mm: decode raw chunk type and skip unknown audio chunk type

--- libavcodec/mmvideo.c | 11 +++ libavformat/mm.c | 9 +++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index d339967702..7313507deb 100644 --- a/libavcodec/mmvideo.c +++ b/libavcodec/mmvideo.c @@ -39,6 +39,7 @@

[FFmpeg-devel] [PATCHv2 3/4] avcodec/mm: don't fail if x offset exceeds frame width

--- libavcodec/mmvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index 933d895f96..d339967702 100644 --- a/libavcodec/mmvideo.c +++ b/libavcodec/mmvideo.c @@ -161,7 +161,7 @@ static int mm_decode_inter(MmContext * s, int half_

[FFmpeg-devel] [PATCHv2 2/4] avcodec/mm: decode partial palette

Reviewed-by: Andreas Rheinhardt --- libavcodec/mmvideo.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index 3038d9ea92..933d895f96 100644 --- a/libavcodec/mmvideo.c +++ b/libavcodec/mmvideo.c @@ -78,13 +78,10 @@ static

[FFmpeg-devel] [PATCHv2 1/4] avcodec/mm: set audio pts proportionally to audio offset

--- libavformat/mm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mm.c b/libavformat/mm.c index 23c025d852..a40b5c44bb 100644 --- a/libavformat/mm.c +++ b/libavformat/mm.c @@ -180,7 +180,8 @@ static int read_packet(AVFormatContext *s, if ((ret = av

[FFmpeg-devel] [PATCH 4/4] mm: decode raw chunk type and skip unknown audio chunk type

--- libavcodec/mmvideo.c | 11 +++ libavformat/mm.c | 9 +++-- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index 3b6b9ed580..2d006d58ba 100644 --- a/libavcodec/mmvideo.c +++ b/libavcodec/mmvideo.c @@ -39,6 +39,7 @@

[FFmpeg-devel] [PATCH 3/4] mm: don't fail if x offset exceeds frame width

--- libavcodec/mmvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index b5b6ffd25b..3b6b9ed580 100644 --- a/libavcodec/mmvideo.c +++ b/libavcodec/mmvideo.c @@ -162,7 +162,7 @@ static int mm_decode_inter(MmContext * s, int half_

[FFmpeg-devel] [PATCH 2/4] mm: decode partial palette

--- palette decoding now conforms to description at https://wiki.multimedia.cx/index.php/IBM_PhotoMotion libavcodec/mmvideo.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavcodec/mmvideo.c b/libavcodec/mmvideo.c index 3038d9ea92..b5b6ffd25b 100644 --- a/libav

[FFmpeg-devel] [PATCH 1/4] mm: set audio pts proportionally to audio offset

--- libavformat/mm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/mm.c b/libavformat/mm.c index 23c025d852..a40b5c44bb 100644 --- a/libavformat/mm.c +++ b/libavformat/mm.c @@ -180,7 +180,8 @@ static int read_packet(AVFormatContext *s, if ((ret = av

Re: [FFmpeg-devel] [PATCH 1/9] avcodec/vqcdec: Check init_get_bits8() for failure

On Sun, May 19, 2024 at 04:49:07AM +0200, Michael Niedermayer wrote: > Fixes: CID1516090 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/vqcdec.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/lib

Re: [FFmpeg-devel] [PATCH 9/9] avcodec/vp3: Replace check by assert

On Sat, May 18, 2024 at 05:57:43AM +0200, Michael Niedermayer wrote: > Fixes: CID1452425 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/vp3.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/dsddec: Fix decoding LSBF samples

On Tue, Apr 02, 2024 at 03:37:06AM +0200, Andreas Rheinhardt wrote: > ff_dsd2pcm_translate() works internally by converting LSBF input > to MSBF upon reading; its buffer is therefore always MSBF > and should therefore be initialized with MSBF silence; > but this is not true since e3d8963c3cb5b8cd31

[FFmpeg-devel] [PATCH 3/3] fate: rv60 test cases

--- samples: https://pross.sdf.org/sandpit/test72x72.rmhd (32 KiB) https://pross.sdf.org/sandpit/test512x512.rmhd (64 KiB) tests/fate/video.mak| 8 tests/ref/fate/rv60-512x512 | 9 + tests/ref/fate/rv60-72x72 | 40 + 3 files chang

[FFmpeg-devel] [PATCH 1/3] avformat/rmdec: support RMHD file format

Signed-off-by: Peter Ross --- libavformat/rmdec.c | 43 ++- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c index 0f1534b582..e7f2480464 100644 --- a/libavformat/rmdec.c +++ b/libavformat/rmdec.c

Re: [FFmpeg-devel] [PATCH] avutil/tx: Use proper default scale for double MDCT/RDFT

On Sat, Feb 17, 2024 at 08:44:47PM +0100, Andreas Rheinhardt wrote: > Fixes a bug and a Clang warning: > "use of logical '||' with constant operand [-Wconstant-logical-operand]" > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/tx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH] lead: support format 0x0

On Sun, Nov 12, 2023 at 11:41:23AM +1100, Peter Ross wrote: > Fixes ticket #10660. > --- > > thanks to the mysterious 'ami_stuff'. > > libavcodec/leaddec.c | 38 ++ > 1 file changed, 26 insertions(+), 12 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] lead: support unaligned blocks

On Sun, Nov 12, 2023 at 11:40:26AM +1100, Peter Ross wrote: > Fixed ticket #10656. > --- > libavcodec/leaddec.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c > index ede52fba5a..fd2018256d 1006

[FFmpeg-devel] [PATCH] av_tx_init: accept NULL scale for RDFT

Make av_tx_init() agree with documentation: * Real to complex and complex to real DFTs. * For the float and int32 variants, the scale type is 'float', while for * the double variant, it's a 'double'. If scale is NULL, 1.0 will be used * as a default. --- libavutil/tx.c | 4 ++-

[FFmpeg-devel] [PATCH] lead: support format 0x0

Fixes ticket #10660. --- thanks to the mysterious 'ami_stuff'. libavcodec/leaddec.c | 38 ++ 1 file changed, 26 insertions(+), 12 deletions(-) diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c index fd2018256d..4f2cc03e65 100644 --- a/libavcodec/leadde

[FFmpeg-devel] [PATCH] lead: support unaligned blocks

Fixed ticket #10656. --- libavcodec/leaddec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c index ede52fba5a..fd2018256d 100644 --- a/libavcodec/leaddec.c +++ b/libavcodec/leaddec.c @@ -192,8 +192,8 @@ static int lead_decode

Re: [FFmpeg-devel] [PATCHv2 1/2] avcodec: LEAD MCMP decoder

On Mon, Oct 16, 2023 at 08:43:30AM +1100, Peter Ross wrote: > Partially fixes ticket #798 > > Reviewed-by: James Almer > Reviewed-by: Michael Niedermayer > Signed-off-by: Peter Ross + Paul will push later tonight. thanks everyone for helping out. -- Peter (A907 E02F A6E5 0CD2

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/rv60: RealVideo 6.0 decoder

On Mon, Oct 23, 2023 at 12:14:52PM +0200, Anton Khirnov wrote: > Quoting Peter Ross (2023-10-22 01:31:32) > > On Wed, Oct 18, 2023 at 04:42:01PM +0200, Anton Khirnov wrote: > > > Quoting Peter Ross (2023-10-18 10:03:54) > > [..] > > > I think you can simplify this

  1   2   3   4   5   >