Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

2014-08-29 Thread Peter Kasting
On Fri, Aug 29, 2014 at 7:25 PM, Michael Niedermayer wrote: > On Fri, Aug 29, 2014 at 04:38:28PM -0700, Peter Kasting wrote: > > I think that reinforces why a change like this is important. These sorts > > of value truncations shouldn't just be invisibly, implicitly happenin

Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

2014-08-29 Thread Peter Kasting
On Fri, Aug 29, 2014 at 4:26 PM, Reimar Döffinger wrote: > First, this needs very, very careful review. I am not at all convinced > that these will not change behaviour. > I strongly agree that it needs careful review. I think that reinforces why a change like this is important. These sorts of

Re: [FFmpeg-devel] [PATCH] Fix MSVC warnings about possible value truncation.

2014-08-29 Thread Peter Kasting
On Fri, Aug 29, 2014 at 3:48 PM, Carl Eugen Hoyos wrote: > Peter Kasting google.com> writes: > > > The attached patch fixes instances of MSVC warning > > C4244 about possible value truncation (e.g. when > > assigning double to float or int64_t to int). > > This