Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: squelch uninitialized variable warnings

2025-07-08 Thread Peter Ross
On Mon, Jul 07, 2025 at 12:41:34PM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > Fixes CID1655273 and CID1655274. > > --- > > libavcodec/adpcm.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/libavcodec/adpcm.c b/libavcodec/a

[FFmpeg-devel] [PATCHv2] avcodec/adpcm: squelch uninitialized variable warnings

2025-07-08 Thread Peter Ross
@ -934,6 +936,8 @@ static int adpcm_sanyo_expand4(ADPCMChannelStatus *c, int bits) add = (25 * c->step) >> 1; c->step = 5 * c->step; break; +default: +av_unreachable("There are cases for all control paths when bits is 4-bit");

[FFmpeg-devel] [PATCH 4/4] tests/fate/audio: Sanyo LD-ADPCM test case

2025-07-05 Thread Peter Ross
, 403, 806, 0xaeb8e751 +0, 19344, 19344, 403, 806, 0x2fc320cf +0, 19747, 19747, 403, 806, 0x30e720c6 +0, 20150, 20150, 403, 806, 0x1d8f20c8 +0, 20553, 20553, 403, 806, 0x2fc920cd -- 2.47.2 -- Peter (A907 E02F A6E5

[FFmpeg-devel] [PATCH 3/4] tests/fate/video: LEAD MCMP test case

2025-07-05 Thread Peter Ross
index 00..68ddaae603 --- /dev/null +++ b/tests/ref/fate/lead-yuv444p @@ -0,0 +1,6 @@ +#tb 0: 1/24 +#media_type 0: video +#codec_id 0: rawvideo +#dimensions 0: 320x240 +#sar 0: 0/1 +0, 0, 0,1, 230400, 0xfe90096a -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2

[FFmpeg-devel] [PATCH 2/4] tests/fate/demux: IFF ANIM test case

2025-07-05 Thread Peter Ross
-- 2.47.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

[FFmpeg-devel] [PATCH 1/4] tests/fate/audio: G.728 test case

2025-07-05 Thread Peter Ross
-g728: FUZZ = 5 + FATE_SAMPLES_AUDIO-$(call PCM, AVI, IMC, ARESAMPLE_FILTER) += fate-imc fate-imc: CMD = pcm -i $(TARGET_SAMPLES)/imc/imc.avi fate-imc: CMP = oneoff -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature

[FFmpeg-devel] [PATCH] avcodec/adpcm: squelch uninitialized variable warnings

2025-07-05 Thread Peter Ross
m_sanyo_expand4(ADPCMChannelStatus *c, int bits) add = (25 * c->step) >> 1; c->step = 5 * c->step; break; +default: +av_assert0(0); /* never reach here when bits is 4-bit */ +return 0; } if (sign) -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2

Re: [FFmpeg-devel] [PATCH] avcodec/rv60dec: Check ofs for overflows

2025-06-28 Thread Peter Ross
i].size > INT32_MAX - ofs) > +return AVERROR_INVALIDDATA; > ofs += s->slice[i].size; > } please apply -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel

[FFmpeg-devel] [PATCHv2] avcodec/adpcm: Sanyo LD-ADPCM decoder

2025-06-27 Thread Peter Ross
Peter Ross (pr...@xvid.org) * * This file is part of FFmpeg. * @@ -260,6 +261,9 @@ static av_cold int adpcm_decode_init(AVCodecContext * avctx) case AV_CODEC_ID_ADPCM_IMA_AMV: max_channels = 1; break; +case AV_CODEC_ID_ADPCM_SANYO: +max_channels = 2

[FFmpeg-devel] [PATCH 1/2] avcodec/adpcm: Sanyo LD-ADPCM decoder

2025-06-25 Thread Peter Ross
hannels, int16_t **samples_p); + #endif /* AVCODEC_ADPCM_H */ diff --git a/libavcodec/adpcm_le.c b/libavcodec/adpcm_le.c new file mode 100644 index 00..df8eb3dd90 --- /dev/null +++ b/libavcodec/adpcm_le.c @@ -0,0 +1,205 @@ +/* + * Copyright (c) 2025 Peter Ross + * + * This file is part o

[FFmpeg-devel] [PATCH 2/2] tests/fate: Sanyo LD-ADPCM test case

2025-06-25 Thread Peter Ross
, 806, 0xaeb8e751 +0, 19344, 19344, 403, 806, 0x2fc320cf +0, 19747, 19747, 403, 806, 0x30e720c6 +0, 20150, 20150, 403, 806, 0x1d8f20c8 +0, 20553, 20553, 403, 806, 0x2fc920cd -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2

Re: [FFmpeg-devel] [PATCH] avcodec/g728dec: Remove AVCodec.sample_fmts

2025-06-23 Thread Peter Ross
t; FF_CODEC_DECODE_CB(g728_decode_frame), > .p.capabilities = AV_CODEC_CAP_CHANNEL_CONF | >AV_CODEC_CAP_DR1, > -.p.sample_fmts = (const enum AVSampleFormat[]) { AV_SAMPLE_FMT_FLT, > - AV_SAMPLE_FMT_NONE },

[FFmpeg-devel] [PATCH] tools/pktdumper: dump extradata buffers

2025-06-23 Thread Peter Ross
printf("FNTEMPLATE: '%s'\n", fntemplate); + while ((err = av_read_frame(fctx, pkt)) >= 0) { int fd; snprintf(pktfilename, sizeof(pktfilename), fntemplate, pktnum, -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.

Re: [FFmpeg-devel] [PATCH 4/5] avformat/iff: Check nb_channels == 0 in CHNL

2025-06-21 Thread Peter Ross
st->codecpar->ch_layout.nb_channels) > return AVERROR_INVALIDDATA; > if (st->codecpar->ch_layout.nb_channels > > FF_ARRAY_ELEMS(dsd_layout)) { > avpriv_request_sample(s, "

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/rv60dec: Check sum in read_slice_sizes()

2025-06-21 Thread Peter Ross
return AVERROR_INVALIDDATA; s->slice[i].data = avpkt->data + header_size + ofs; s->slice[i].data_size = FFMIN(s->slice[i].size, avpkt->size - header_size - ofs); ofs += s->slice[i].size; } -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5

[FFmpeg-devel] [PATCH] avcodec/rv60dec: drop unused sum variable in read_slice_sizes

2025-06-21 Thread Peter Ross
static int read_slice_sizes(RV60Context *s, GetBitContext *gb) if (last_size <= 0) return AVERROR_INVALIDDATA; s->slice[i].size = last_size; -sum += s->slice[i].size; } align_get_bits(gb); -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2

[FFmpeg-devel] [PATCHv4] avcodec/g728dec: G.728 decoder

2025-06-18 Thread Peter Ross
3e --- /dev/null +++ b/libavcodec/g728dec.c @@ -0,0 +1,220 @@ +/* + * G.728 decoder + * Copyright (c) 2025 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as publis

[FFmpeg-devel] [PATCHv2] avcodec/mips: fix build failure when specific decoder/encoder enabled

2025-06-18 Thread Peter Ross
/mpegaudiodsp_mips_float.o MIPSDSP-OBJS-$(CONFIG_MPEGAUDIODSP) += mips/mpegaudiodsp_mips_fixed.o -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel

[FFmpeg-devel] [PATCH 2/2] configure: h264_vulkan_encoder depends on atsc_a53

2025-06-17 Thread Peter Ross
h264_v4l2_m2m" h264_v4l2m2m_decoder_select="h264_mp4toannexb_bsf" h264_v4l2m2m_encoder_deps="v4l2_m2m h264_v4l2_m2m" -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature __

[FFmpeg-devel] [PATCH 1/2] configure: cbs_apv depends on cbs

2025-06-17 Thread Peter Ross
quot;cbs" cbs_av1_select="cbs" cbs_h264_select="cbs" cbs_h265_select="cbs" -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.o

Re: [FFmpeg-devel] [PATCH] avcodec/osq: Request a coding mode 2 sample

2025-06-17 Thread Peter Ross
return AVERROR_INVALIDDATA; > +if (cb->coding_mode == 2) > +avpriv_request_sample(avctx, "coding mode 2\n"); nit: there is no need for newline character with avpriv_request_sample() -- Peter (A907 E02F A6E5 0CD2

[FFmpeg-devel] [PATCH] avcodec/mips: fix build failure when only specific decoders enabled

2025-06-16 Thread Peter Ross
/mpegaudiodsp_mips_float.o MIPSDSP-OBJS-$(CONFIG_MPEGAUDIODSP) += mips/mpegaudiodsp_mips_fixed.o -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel

[FFmpeg-devel] [PATCHv2] configure: add celp_math component

2025-06-14 Thread Peter Ross
.mak +++ b/tests/fate/libavcodec.mak @@ -28,7 +28,7 @@ fate-cabac: libavcodec/tests/cabac$(EXESUF) fate-cabac: CMD = run libavcodec/tests/cabac$(EXESUF) fate-cabac: CMP = null -FATE_LIBAVCODEC-yes += fate-celp_math +FATE_LIBAVCODEC-$(CONFIG_CELP_MATH) += fate-celp_math fate-celp_math: libavcodec/tests/

Re: [FFmpeg-devel] [PATCHv3 7/8] avformat/aiff: G.728 muxing and demuxing

2025-06-09 Thread Peter Ross
On Tue, Jun 10, 2025 at 12:25:24AM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > --- > > libavformat/aiff.c| 1 + > > libavformat/aiffdec.c | 3 +++ > > 2 files changed, 4 insertions(+) > > > > diff --git a/libavformat/aiff.c b/libavformat/aiff.c

[FFmpeg-devel] [PATCH] avcodec/tests/dct: add CONFIG_PRORES_DECODER guard

2025-06-09 Thread Peter Ross
+#endif #if CONFIG_FAANIDCT { "FAANI", ff_faanidct, FF_IDCT_PERM_NONE }, #endif /* CONFIG_FAANIDCT */ -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ff

[FFmpeg-devel] [PATCH] configure: add celp_math component

2025-06-09 Thread Peter Ross
hashtable diff --git a/tests/fate/libavcodec.mak b/tests/fate/libavcodec.mak index 089ab11fb1..e2d616e307 100644 --- a/tests/fate/libavcodec.mak +++ b/tests/fate/libavcodec.mak @@ -28,7 +28,7 @@ fate-cabac: libavcodec/tests/cabac$(EXESUF) fate-cabac: CMD = run libavcodec/tests

[FFmpeg-devel] [PATCHv3 6/8] avformat/riff: G.728 muxing and demuxing

2025-06-09 Thread Peter Ross
par->codec_id == AV_CODEC_ID_G728 || par->codec_id == AV_CODEC_ID_MP2|| par->codec_id == AV_CODEC_ID_MP3|| par->codec_id == AV_CODEC_ID_GSM_MS) { -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Descr

[FFmpeg-devel] [PATCHv3 2/8] avcodec/g728_template: make hist parameter constant

2025-06-09 Thread Peter Ross
float *window) + const float *hist, float *out2, const float *window) { int i; float buffer1[MAX_BACKWARD_FILTER_ORDER + 1]; -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature

[FFmpeg-devel] [PATCHv3 3/8] avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters

2025-06-09 Thread Peter Ross
, temp, hist, rec, window); -if (!compute_lpc_coefs(temp, order, lpc, 0, 1, 1)) +if (!compute_lpc_coefs(temp, 0, order, lpc, 0, 1, 1, NULL)) ractx->vector_fmul(lpc, lpc, tab, FFALIGN(order, 16)); memmove(hist, hist + n, move_size*sizeof(*hist)); -- 2.47.2 -- Peter (A907 E02

[FFmpeg-devel] [PATCHv3 8/8] avformat/rtp: G.728 muxing and demuxing

2025-06-09 Thread Peter Ross
V_CODEC_ID_RAWVIDEO: case AV_CODEC_ID_BITPACKED: +case AV_CODEC_ID_G728: return 1; default: return 0; -- 2.47.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel

[FFmpeg-devel] [PATCHv3 7/8] avformat/aiff: G.728 muxing and demuxing

2025-06-09 Thread Peter Ross
ormatContext *s, int64_t size, case AV_CODEC_ID_GSM: par->block_align = 33; break; +case AV_CODEC_ID_G728: +par->block_align = 5; +break; default: aiff->block_duration = 1; break; -- 2.47.2

[FFmpeg-devel] [PATCHv3 5/8] avformat/g728dec: raw G.728 demuxer

2025-06-09 Thread Peter Ross
0; +return ret; +} + +const FFInputFormat ff_g728_demuxer = { +.p.name = "g728", +.p.long_name= NULL_IF_CONFIG_SMALL("raw G.728"), +.p.extensions = "g728", +.p.flags= AVFMT_GENERIC_INDEX, +.read_header = g728_read_header, +

[FFmpeg-devel] [PATCHv3 4/8] avcodec/g728dec: G.728 decoder

2025-06-09 Thread Peter Ross
dev/null +++ b/libavcodec/g728dec.c @@ -0,0 +1,220 @@ +/* + * G.728 decoder + * Copyright (c) 2025 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as publis

[FFmpeg-devel] [PATCHv3 1/8] avcodec/g728_template: do_hybrid_window() template

2025-06-09 Thread Peter Ross
do_hybrid_window(ractx, order, n, non_rec, temp, hist, rec, window); +do_hybrid_window(ractx->vector_fmul, order, n, non_rec, temp, hist, rec, window); if (!compute_lpc_coefs(temp, order, lpc, 0, 1, 1)) ractx->vector_fmul(lpc, lpc, tab, FFALIGN(order, 16)); -- 2.47.2 -- P

[FFmpeg-devel] [PATCHv3 0/8] G.728 decoding

2025-06-09 Thread Peter Ross
Sample: https://pross.sdf.org/sandpit/CW5.g728 Peter Ross (8): avcodec/g728_template: do_hybrid_window() template avcodec/g728_template: make hist parameter constant avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters avcodec/g728dec: G.728

Re: [FFmpeg-devel] [PATCH] avcodec/rv60dec: Avoid branch when decoding cbp16

2025-05-19 Thread Peter Ross
-else > -return decode_super_cbp(gb, cbp16_vlc[cb_set][subset - 1]); > +return decode_super_cbp(gb, cbp16_vlc[cb_set][subset]); > } > > static int decode_cu_r(RV60Context * s, AVFrame * frame, ThreadContext * > thread, GetBitContext * gb, int xpos, int ypos, int l

Re: [FFmpeg-devel] [PATCH 6/7] avcodec/rv60dec: inter also fails with qp >= 32

2025-05-09 Thread Peter Ross
_INTRA; > -if (is_intra && qp >= 32) > +if (qp >= 32) > return AVERROR_INVALIDDATA; > cu_pos = ((xpos & 63) >> 3) + ((ypos & 63) >> 3) * 8; please apply -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Descrip

Re: [FFmpeg-devel] [PATCH 4/7] avformat/iff: Check nb_channels == 0 in MHDR

2025-05-09 Thread Peter Ross
ut = > (AVChannelLayout)AV_CHANNEL_LAYOUT_STEREO; > +else if (sta->codecpar->ch_layout.nb_channels == 0) > +return AVERROR_INVALIDDATA; > break; > > case ID_ABIT: please apply -

Re: [FFmpeg-devel] [PATCH 1/7] avcodec/mmvideo: fix paltte index

2025-05-09 Thread Peter Ross
te[start+i] = 0xFFU << 24 | (bytestream2_get_be24(&s->gb) << > 2); > +s->palette[(start+i)&0xFF] = 0xFFU << 24 | > (bytestream2_get_be24(&s->gb) << 2); > } > please apply -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

Re: [FFmpeg-devel] Addition of encoder functionality in libavcodec/vpx_rac.h and corresponding commit in vpx_rac.c

2025-04-27 Thread Peter Ross
_rac_put(c, 0); >+if (ret < 0) >+return ret; >+} >+ >+if (c->output_start + 1 >= c->output_end) >+return AVERROR(ENOSPC); >+ >+if (c->output_start + 3 < c->output_end) { >+

Re: [FFmpeg-devel] [PATCH v2] avcodec/libwebpdec: Add libwebp WebP decoder.

2025-04-04 Thread Peter Xia
don’t know if there is ongoing work about this, I’m pretty new to the project. Thanks, Peter > On Apr 4, 2025, at 12:00 PM, Michael Niedermayer > wrote: > > Hi Peter > > On Thu, Apr 03, 2025 at 06:17:19PM -0700, Peter Xia wrote: >> Adds support of decoding animated webp. &

Re: [FFmpeg-devel] [PATCH] avcodec/libwebpdec: Add libwebp WebP decoder.

2025-04-03 Thread Peter Xia
Hi Leon, Thanks for the feedback! I’ve send a v2 of this patch. Peter > On Apr 3, 2025, at 12:11 AM, Leon Grutters wrote: > > On 4/1/25 12:29 PM, Peter Xia wrote: >> Adds support of decoding animated webp. >> >> Signed-off-by: Peter Xia >> --- &g

[FFmpeg-devel] [PATCH v2] avcodec/libwebpdec: Add libwebp WebP decoder.

2025-04-03 Thread Peter Xia
Adds support of decoding animated webp. Signed-off-by: Peter Xia --- Changelog | 1 + configure | 4 +- doc/general_contents.texi | 2 +- libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 3 +- libavcodec/libwebpdec.c | 192

Re: [FFmpeg-devel] [PATCH] avcodec/libwebpdec: Add libwebp WebP decoder.

2025-04-02 Thread Peter Xia
Can anyone take a look at this? This is my first patch so not entirely sure about the process. Thanks, Peter > On Apr 1, 2025, at 3:29 AM, Peter Xia wrote: > > Adds support of decoding animated webp. > > Signed-off-by: Peter Xia > --- > Changelog

[FFmpeg-devel] [PATCH] avcodec/libwebpdec: Add libwebp WebP decoder.

2025-04-01 Thread Peter Xia
Adds support of decoding animated webp. Signed-off-by: Peter Xia --- Changelog | 1 + configure | 4 +- doc/general_contents.texi | 2 +- libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 3 +- libavcodec/libwebpdec.c | 200

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/vp8: Fix wrong #endif comment

2025-03-08 Thread Peter Ross
VP8Context *s = avctx->priv_data; > -- > 2.45.2 > > From 105f5edaa24b5ad0b4b1431cb04f22f3f5a106a6 Mon Sep 17 00:00:00 2001 > From: Andreas Rheinhardt > Date: Thu, 6 Mar 2025 18:20:32 +0100 > Subject: [PATCH 4/4] avcodec/vp8: Remove always-false hwaccel checks for VP7 > >

Re: [FFmpeg-devel] [PATCH 1/1] Add vpx range encoder support

2025-03-06 Thread Peter Ross
> +*c->output_buffer++ = c->code_word >> 24; > +} > +c->code_word <<= 8; > +} > +} after calling vpx_rac_flush() how does the caller determine the final size of the output buffer? finally, does the output of your encoder work with the ex

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/rv60dec: Initialize slice gb with actually allocated size

2025-02-08 Thread Peter Ross
].data, > s->slice[cu_y].size)) < 0) > +if ((ret = init_get_bits8(&gb, s->slice[cu_y].data, > s->slice[cu_y].data_size)) < 0) > return ret; > > for (int cu_x = 0; cu_x < s->cu_width; cu_x++) { nice find. please apply,

Re: [FFmpeg-devel] [PATCH 5/6] avformat/iff: Check that we have a stream in read_dst_frame()

2025-02-08 Thread Peter Ross
vio_feof(pb)) { > chunk_pos = avio_tell(pb); > if (chunk_pos >= iff->body_end) > -- > 2.48.1 please apply, thanks. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature

[FFmpeg-devel] [PATCHv2] avcodec/g728dec: G.728 decoder

2025-02-05 Thread Peter Ross
00..f932a50f6c --- /dev/null +++ b/libavcodec/g728dec.c @@ -0,0 +1,220 @@ +/* + * G.728 decoder + * Copyright (c) 2025 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public +

Re: [FFmpeg-devel] [PATCHv2] avcodec/leaddec: support format 0x1006

2025-02-05 Thread Peter Ross
On Sun, Jan 19, 2025 at 08:49:50PM +1100, Peter Ross wrote: > Fixes ticket #10658. > --- > > Tested with some different vertical resolution alignments. > > When the vertical resolution is not aligned to macroblock height, the > reference encoder & decoder performs buggy

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/wtvdec: Initialize buf

2025-01-22 Thread Peter Ross
e understand why this is needed... the avio_read() call fills buf, and the call to ff_parse_mpeg2_descriptor specifies an "end" pointer (desc_list_end point) to prevent overreading. where is the uninitialised memory coming from? -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B

[FFmpeg-devel] [PATCHv2] avcodec/leaddec: support format 0x1006

2025-01-19 Thread Peter Ross
t;linesize[plane] + x, +(yuv20p_half && b < 2 ? 2 : 1) * fields * frame->linesize[plane]); if (ret < 0) return ret; -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Descr

[FFmpeg-devel] [PATCH] avcodec/leaddec: support format 0x1006

2025-01-14 Thread Peter Ross
(yuv20p_half && b < 2 ? 2 : 1) * fields * frame->linesize[plane]); if (ret < 0) return ret; -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

2025-01-13 Thread Peter Ross
On Sun, Jan 12, 2025 at 02:48:00PM +0100, Andreas Rheinhardt wrote: > Peter Ross: > > --- > > libavcodec/Makefile | 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/codec_desc.c | 7 ++ > > libavcodec/codec_id.h | 1 + &

Re: [FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

2025-01-13 Thread Peter Ross
On Sun, Jan 12, 2025 at 12:42:05AM -0300, James Almer wrote: > On 1/11/2025 11:37 PM, Peter Ross wrote: > > --- > > libavcodec/Makefile | 1 + > > libavcodec/allcodecs.c | 1 + > > libavcodec/codec_desc.c | 7 ++ > > libavcodec/codec_id.h |

[FFmpeg-devel] [PATCH 8/8] avformat/rtp: G.728 muxing and demuxing

2025-01-11 Thread Peter Ross
V_CODEC_ID_RAWVIDEO: case AV_CODEC_ID_BITPACKED: +case AV_CODEC_ID_G728: return 1; default: return 0; -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel

[FFmpeg-devel] [PATCH 7/8] avformat/aiff: G.728 muxing and demuxing

2025-01-11 Thread Peter Ross
ormatContext *s, int64_t size, case AV_CODEC_ID_GSM: par->block_align = 33; break; +case AV_CODEC_ID_G728: +par->block_align = 5; +break; default: aiff->block_duration = 1; break; -- 2.45.2

[FFmpeg-devel] [PATCH 6/8] avformat/riff: G.728 muxing and demuxing

2025-01-11 Thread Peter Ross
par->codec_id == AV_CODEC_ID_G728 || par->codec_id == AV_CODEC_ID_MP2|| par->codec_id == AV_CODEC_ID_MP3|| par->codec_id == AV_CODEC_ID_GSM_MS) { -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Descr

[FFmpeg-devel] [PATCH 5/8] avformat/g728dec: raw G.728 demuxer

2025-01-11 Thread Peter Ross
0; +return ret; +} + +const FFInputFormat ff_g728_demuxer = { +.p.name = "g728", +.p.long_name= NULL_IF_CONFIG_SMALL("raw G.728"), +.p.extensions = "g728", +.p.flags= AVFMT_GENERIC_INDEX, +.read_header = g728_read_header, +

[FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

2025-01-11 Thread Peter Ross
dev/null +++ b/libavcodec/g728dec.c @@ -0,0 +1,213 @@ +/* + * G.728 decoder + * Copyright (c) 2025 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as publis

[FFmpeg-devel] [PATCH 3/8] avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters

2025-01-11 Thread Peter Ross
, temp, hist, rec, window); -if (!compute_lpc_coefs(temp, order, lpc, 0, 1, 1)) +if (!compute_lpc_coefs(temp, 0, order, lpc, 0, 1, 1, NULL)) ractx->vector_fmul(lpc, lpc, tab, FFALIGN(order, 16)); memmove(hist, hist + n, move_size*sizeof(*hist)); -- 2.45.2 -- Peter (A907 E02

[FFmpeg-devel] [PATCH 2/8] avcodec/g728_template: make hist parameter constant

2025-01-11 Thread Peter Ross
float *window) + const float *hist, float *out2, const float *window) { int i; float buffer1[MAX_BACKWARD_FILTER_ORDER + 1]; -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature

[FFmpeg-devel] [PATCH 0/8] G.728 decoding

2025-01-11 Thread Peter Ross
Sample: https://pross.sdf.org/sandpit/CW5.g728 Peter Ross (8): avcodec/g728_template: do_hybrid_window() template avcodec/g728_template: make hist parameter constant avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters avcodec/g728dec: G.728

[FFmpeg-devel] [PATCH 1/8] avcodec/g728_template: do_hybrid_window() template

2025-01-11 Thread Peter Ross
-do_hybrid_window(ractx, order, n, non_rec, temp, hist, rec, window); +do_hybrid_window(ractx->vector_fmul, order, n, non_rec, temp, hist, rec, window); if (!compute_lpc_coefs(temp, order, lpc, 0, 1, 1)) ractx->vector_fmul(lpc, lpc, tab, FFALIGN(order, 16)); -- 2.45.2

Re: [FFmpeg-devel] [PATCHv2 1/3] avformat/mlvdec: demux LJ92 huffman comressed frames

2025-01-08 Thread Peter Ross
On Sun, Dec 22, 2024 at 06:40:31PM +1100, Peter Ross wrote: > A minimal DNG header is added to each LJ92 compressed frame, allowing > thme to be decoded by the TIFF decoder. The TIFF decoder is responsible > for setting up the MJPEG decoder, signalling the correct s->bayer flag, &

Re: [FFmpeg-devel] [PATCH] configure: update copyright year

2025-01-01 Thread Peter Ross
ATADIR "$(eval c_escape $datadir)" > #define AVCONV_DATADIR "$(eval c_escape $datadir)" > #define CC_IDENT "$(c_escape ${cc_ident:-Unknown compiler})" FFmpeg turns 25 this year. please apply :) -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signa

[FFmpeg-devel] [PATCH] avformat/iff: ignore FVER tag when not processing DSD/DST files

2024-12-28 Thread Peter Ross
%d.%d.%d.%d\n",version >> 24, (version >> 16) & 0xFF, (version >> 8) & 0xFF, version & 0xFF); +if (!new_stream(s, &sta, &iff->audio_stream_index, AVMEDIA_TYPE_AUDIO)) +return AVERROR(ENOMEM); +sta->codecp

Re: [FFmpeg-devel] [PATCH v2] Add SRV3 decoder/demuxer

2024-12-27 Thread Peter Ross
// TODO: Handle window styles > > > > use avpriv_report_missing_feature()? > > > > I can do that but it'll trigger on many subtitle files as it's > pretty commonly used, just doesn't usually change all that much > which is why it

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mlvdec: Check avio_read()

2024-12-25 Thread Peter Ross
gt; +int ret; > + > if (!value) { > avio_skip(pb, size); > return; > } > > -avio_read(pb, value, size); > -if (!value[0]) { > +ret = avio_read(pb, value, size); > +if (ret != size || !value[0]) { > av_free(v

Re: [FFmpeg-devel] [PATCH v2] Add SRV3 decoder/demuxer

2024-12-25 Thread Peter Ross
ret = AVERROR(ENOMEM); > + goto end; > +} > +sub->pts = start; > +sub->duration = duration; > + > +if ((ret = av_packet_add_side_data(sub, AV_PKT_DATA_SRV3_EVENT, > (uint8_t*)event, sizeof(SRV3EventMeta))

[FFmpeg-devel] [PATCH] avformat/wtvenc: do not output negative 'third timestamp' field

2024-12-24 Thread Peter Ross
== AV_NOPTS_VALUE ? 0 : pkt->pts); avio_wl64(pb, 0); avio_wl64(pb, par->codec_type == AVMEDIA_TYPE_VIDEO && (pkt->flags & AV_PKT_FLAG_KEY) ? 1 : 0); avio_wl64(pb, 0); -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

[FFmpeg-devel] [PATCH] avformat/iff: remove surplus if statement

2024-12-22 Thread Peter Ross
, av_assert0(0); } -if (ret < 0) -return ret; return ret; } -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org ht

[FFmpeg-devel] [PATCHv2 2/3] avformat/mlvdec: process VERS block

2024-12-21 Thread Peter Ross
','U','L','L')) { } else if (type == MKTAG('M','L','V','I')) { /* occurs when MLV and Mnn files are concatenated */ -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description:

[FFmpeg-devel] [PATCHv2 3/3] avformat/mlvdec: skip over some other known block types

2024-12-21 Thread Peter Ross
'L','V','I')) { /* occurs when MLV and Mnn files are concatenated */ + } else if (type == MKTAG('R','A','W','C')) { } else { av_log(avctx, AV_LOG_INFO, "unsupported tag %s, size %u\n",

[FFmpeg-devel] [PATCHv2 1/3] avformat/mlvdec: demux LJ92 huffman comressed frames

2024-12-21 Thread Peter Ross
_TIFF) +ret = get_packet_lj92(avctx, st, pb, pkt, size); +else +ret = av_get_packet(pb, pkt, (st->codecpar->width * st->codecpar->height * st->codecpar->bits_per_coded_sample + 7) >> 3); } else { // AVMEDIA_TYPE_AUDIO if (space > UINT_M

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: include aom_film_grain.o file for h264_sei component

2024-12-20 Thread Peter Ross
On Sat, Dec 21, 2024 at 12:02:06AM +0200, Jan Ekström wrote: > On Thu, Dec 19, 2024 at 4:34 AM Peter Ross wrote: > > > > h264_sei depends on h2645_sei, which in turn depends on aom_film_grain for > > ff_aom_uninit_film_grain_params() > > Set LGTM. > > Thanks f

Re: [FFmpeg-devel] [PATCH 2/2] avformat/riff: map 0069 twocc to ADPCM IMA XBOX decoder

2024-12-20 Thread Peter Ross
On Thu, Dec 12, 2024 at 09:25:55AM +1100, Peter Ross wrote: > --- > Using AV_CODEC_ID_ADPCM_IMA_WAV for twocc 0x0069 causes subtle artefacts > during > playback. The correct decoder is AV_CODEC_ID_ADPCM_IMA_XBOX. > > Sample .wav and ref flac file: > <https://github.com/v

Re: [FFmpeg-devel] [PATCHv2 1/2] avformat/iff: SndAnim decoding

2024-12-19 Thread Peter Ross
On Wed, Dec 11, 2024 at 09:27:51AM +1100, Peter Ross wrote: > Fixes ticket #5553. > --- > Additional hardening thanks to target_dem_fuzzer.c > > libavformat/iff.c | 311 +++--- > 1 file changed, 210 insertions(+), 101 deletions(-) >

[FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: include aom_film_grain.o file for h264_sei component

2024-12-18 Thread Peter Ross
)+= h2645_sei.o aom_film_grain.o \ dynamic_hdr_vivid.o -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] avformat/Makefile: include object files for image_vbn_pipe demuxer

2024-12-18 Thread Peter Ross
)+= img2dec.o img2.o +OBJS-$(CONFIG_IMAGE_VBN_PIPE_DEMUXER) += img2dec.o img2.o OBJS-$(CONFIG_IMAGE_WEBP_PIPE_DEMUXER)+= img2dec.o img2.o OBJS-$(CONFIG_IMAGE_XBM_PIPE_DEMUXER) += img2dec.o img2.o OBJS-$(CONFIG_IMAGE_XPM_PIPE_DEMUXER) += img2dec.o img2.o -- 2.45.2 -- Peter (A907 E02F

Re: [FFmpeg-devel] [PATCH] avformat/Makefile: add iso_writer golomb_tab from shared library dependency

2024-12-18 Thread Peter Ross
On Wed, Dec 18, 2024 at 05:21:33PM -0300, James Almer wrote: > On 12/18/2024 5:17 PM, Peter Ross wrote: > > --- > > libavformat/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/Makefile b/libavformat/Makefile

[FFmpeg-devel] [PATCH] avformat/Makefile: add iso_writer golomb_tab from shared library dependency

2024-12-18 Thread Peter Ross
)+= mpeg4audio_sample_rates.o SHLIBOBJS-$(CONFIG_HLS_DEMUXER) += ac3_channel_layout_tab.o SHLIBOBJS-$(CONFIG_IMAGE_JPEGXL_PIPE_DEMUXER)+= jpegxl_parse.o -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

2024-12-17 Thread Peter Ross
On Wed, Dec 18, 2024 at 02:28:26PM +0900, Lynne via ffmpeg-devel wrote: > > > On 16/12/2024 20:00, Peter Ross wrote: > > since commit fce0622d0b1f69a85fe8ce61e1189dd57a8b0fcc, libavformat/hevc.c > > depends on golomb vlc tables. > > --- > > i often build with -

[FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

2024-12-16 Thread Peter Ross
atsc_a53 golomb" +iso_writer_select="golomb" frame_thread_encoder_deps="encoders threads" iamfdec_deps="iamf" iamfdec_select="iso_media mpeg4audio" -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP sig

[FFmpeg-devel] [PATCH 3/3] avformat/mlvdec: skip over some other known block types

2024-12-12 Thread Peter Ross
'L','V','I')) { /* occurs when MLV and Mnn files are concatenated */ + } else if (type == MKTAG('R','A','W','C')) { } else { av_log(avctx, AV_LOG_INFO, "unsupported tag %s, size %u\n",

[FFmpeg-devel] [PATCH 2/3] avformat/mlvdec: process VERS block

2024-12-12 Thread Peter Ross
','U','L','L')) { } else if (type == MKTAG('M','L','V','I')) { /* occurs when MLV and Mnn files are concatenated */ -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description:

[FFmpeg-devel] [PATCH 1/3] avformat/mlvdec: demux LJ92 huffman comressed frames

2024-12-12 Thread Peter Ross
, pkt, (st->codecpar->width * st->codecpar->height * st->codecpar->bits_per_coded_sample + 7) >> 3); } else { // AVMEDIA_TYPE_AUDIO if (space > UINT_MAX - 24 || size < (24 + space)) return AVERROR_INVALIDDATA; -- 2.45.2 -- Peter (A907 E02F

[FFmpeg-devel] [PATCH 2/2] avformat/riff: map 0069 twocc to ADPCM IMA XBOX decoder

2024-12-11 Thread Peter Ross
c_id 1: adpcm_ima_xbox #sample_rate 1: 44100 #channel_layout_name 1: stereo 0, 0, 0,0, 1508, 0xefceba48 -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___

[FFmpeg-devel] [PATCH 1/2] avcodec: add ADPCM IMA XBOX decoder

2024-12-11 Thread Peter Ross
ID_ADPCM_IMA_XBOX: +if (bps != 4) +return 0; + tmp = blocks * ((ba - 4 * ch) / (bps * ch) * 8); +break; case AV_CODEC_ID_ADPCM_IMA_WAV: if (bps < 2 || bps > 5) return 0;

[FFmpeg-devel] [PATCHv2 2/2] tests/fate/demux: IFF test case

2024-12-10 Thread Peter Ross
, 1586, 0xbee30464, F=0x0 -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

[FFmpeg-devel] [PATCHv2 1/2] avformat/iff: SndAnim decoding

2024-12-10 Thread Peter Ross
sta = s->streams[iff->audio_stream_index]; +if (sta->codecpar->codec_tag == ID_DSD || iff->form_tag == ID_MAUD) { +ret = av_get_packet(pb, pkt, FFMIN(iff->body_end - pos, 1024 * sta->codecpar->block_align)); +} else if (sta->codecpar->codec_t

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/rv60dec: Check NEXT/LAST availability

2024-12-07 Thread Peter Ross
(s, frame->data, frame->linesize, s->last_frame[NEXT_PIC], > bx, by, bw, bh, mv.f_mv, 0); > break; > case MVREF_BREF: suggest also setting enum MVREF_NONE = 0 higher up in the file, so it is clear to readers these enums are ordered deliberately.

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/rv60dec: Use get_bits_long()

2024-12-07 Thread Peter Ross
+int diff = get_bits_long(gb, nbits); > if (s->slice[i].sign) > last_size += diff; > else please apply -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffm

[FFmpeg-devel] [PATCH] avformat/iff: SndAnim decoding

2024-12-07 Thread Peter Ross
if (sta->codecpar->codec_tag == ID_DSD || iff->form_tag == ID_MAUD) { +ret = av_get_packet(pb, pkt, FFMIN(iff->body_end - pos, 1024 * sta->codecpar->block_align)); +} else if (sta->codecpar->codec_tag == ID_DST) { return read_dst_fr

[FFmpeg-devel] [PATCH 2/2] configure: add leaddec blockdsp dependency

2024-12-04 Thread Peter Ross
der_select="blockdsp" lagarith_decoder_select="llviddsp" -lead_decoder_select="idctdsp jpegtables" +lead_decoder_select="blockdsp idctdsp jpegtables" ljpeg_encoder_select="jpegtables" lscr_decoder_select="inflate_wrapper" magicyuv_decoder

[FFmpeg-devel] [PATCH 1/2] avcodec/leaddec: support format 0x6

2024-12-04 Thread Peter Ross
*avctx, AVFrame * frame, zero = 1; avctx->pix_fmt = AV_PIX_FMT_YUV420P; break; +case 0x6: case 0x8000: yuv20p_half = 1; // fall-through -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description:

[FFmpeg-devel] [PATCH] avformat/mm: fix packets pts generation and add seek support

2024-12-01 Thread Peter Ross
Signed-off-by: Peter Ross --- Author: Paul B Mahol Date: Wed Jun 26 09:07:29 2024 +0200 libavformat/mm.c | 31 ++ tests/ref/fate/alg-mm | 62 +-- 2 files changed, 45 insertions(+), 48 deletions(-) diff --git a/libavformat/mm.c

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/rv60dec: Check qp for intra

2024-12-01 Thread Peter Ross
is_intra = cu.cu_type == CU_INTRA; > +if (is_intra && qp >= 32) > +return AVERROR_INVALIDDATA; > cu_pos = ((xpos & 63) >> 3) + ((ypos & 63) >> 3) * 8; nice find by clusterfuzz. please appl

[FFmpeg-devel] [PATCH] avcodec/ac4dec: process immersive stereo

2024-11-26 Thread Peter Ross
) +if (s->pinfo[i].presentation_version == 2) { +ssi->channel_mode = 1; /* immersive stereo */ +break; +} + if (ssi->channel_mode == 11 || ssi->channel_mode == 12 || ssi->channel_mode == 13 || -- 2.45.2 -- P

  1   2   3   4   5   6   7   >