Hi,
I've fixed the issues pointed out in the earlier discussion at
https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2021-September/285688.html
Are there still any problems that block this patch getting applied? I'm
happy to make any changes if needed.
__
mpeg-devel/2021-September/285843.html
See the review thread of this patch:
https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2021-September/285682.html
And for the bigger one:
https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2021-September/285685.html
Sincerely,
Hello,
I've fixed the issues and posted the patch in this same thread:
https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2021-September/285840.html
https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2021-September/285841.html
Please let me know if there are additional problems with the patch that
b
Adds support for 15-bit VQA3 videos used in Westwood Studios' games.
Signed-off-by: Pekka Väänänen
---
libavcodec/vqavideo.c | 268 -
libavformat/westwood_vqa.c | 10 ++
2 files changed, 248 insertions(+), 30 deletions(-)
diff --git a/libav
> Pekka Väänänen:
> > 1. Is it possible to preserve the pixels of a frame for easy delta
> > updates?
> > In that 2009 patch set they used an old "FF_BUFFER_HINTS_PRESERVE"
> > flag
> > that doesn't exist anymore.
> >
>
> You keep
s VQA Format Demuxer
- * Copyright (c) 2003 The FFmpeg project
+ * Copyright (c) 2003 Mike Melanson
+ * Copyright (c) 2021 Pekka Väänänen
*
* This file is part of FFmpeg.
*
@@ -30,6 +31,7 @@
#include "libavutil/intreadwrite.h"
#include "avformat.h"
+#include &q
Thank you for your patience with this patch.
> This code also reads the VQFR chunk before seeking back, so this needs
> to be changed or accounted for.
>
> > +ffio_ensure_seekback(pb, wsvqa->vqfl_chunk_size + 512 * 1024);
> > +avio_skip(pb, chunk_size + skip_byte);
That
s VQA Format Demuxer
- * Copyright (c) 2003 The FFmpeg project
+ * Copyright (c) 2003 Mike Melanson
+ * Copyright (c) 2021 Pekka Väänänen
*
* This file is part of FFmpeg.
*
@@ -30,6 +31,7 @@
#include "libavutil/intreadwrite.h"
#include "avformat.h"
+#include &q
> This is a cosmetic change. It should not be part of a commit for a
> functional change (unless you already have to touch that line anyway (in
> which case you should beautify the line)).
Fixed.
> > +if (av_get_packet(pb, pkt,
> > wsvqa->vqfl_chunk_size) < 0)
> > +
Thanks for the quick reply.
> It's fine, but you do want to use ffio_ensure_seekback() to guarantee
> success, preferably calling it at just the moment the stream is at the
> position you're planning on rewinding back to.
I realized that ffio_ensure_seekback() won't be enough because the
seek
Adds support for 15-bit VQA3 videos used in Westwood Studios' games.
Signed-off-by: Pekka Väänänen
---
libavcodec/vqavideo.c | 279 +
libavformat/westwood_vqa.c | 12 +-
2 files changed, 262 insertions(+), 29 deletions(-)
diff --git a/libav
Hello,
This patch adds support for 15-bit VQA3 files that are used in Westwood
Studios' video games such as Command & Conquer: Tiberian Sun and Blade
Runner. I have tested this change with all VQA files available at
http://samples.mplayerhq.hu/game-formats/vqa/
and every video except those in ky
s VQA Format Demuxer
- * Copyright (c) 2003 The FFmpeg project
+ * Copyright (c) 2003 Mike Melanson
+ * Copyright (c) 2021 Pekka Väänänen
*
* This file is part of FFmpeg.
*
@@ -40,6 +41,7 @@
#define SND1_TAG MKBETAG('S', 'N', 'D', '1')
#define
Greetings!
This small patch is required for high color 15-bit Westwood VQA3 videos
to be decoded properly. It just saves an offset of a VQFL chunk when it
sees one and then concatenates it with the packet of a later VQFR chunk
that contains full frame data. This way the (yet-to-be-merged) VQA3
dec
14 matches
Mail list logo
