On Sun, Jun 1, 2025 at 4:59 AM Frank Plowman wrote:
> Signed-off-by: Frank Plowman
> ---
> libavcodec/vvc/dec.c | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c
> index deb1b07b23..ac3f453440 100644
> --- a/libavcodec/v
On Mon, Jun 2, 2025 at 9:48 AM Nuo Mi wrote:
> From: Frank Plowman
>
> My OpenPGP key is available at
>
>
> https://keys.openpgp.org/vks/v1/by-fingerprint/34E248D6B7DF476970C7330403A84C6A098F2C6B
>
> and
>
>
> https://keyserver.ub
vp9 Ronald Bultje
vqavideo.cMike Melanson
- vvc [2] Nuo Mi, Wu Jianhua
+ vvc [2] Nuo Mi, Wu Jianhua, Frank Plowman
wmaprodec.c Sascha Sommer
wmavoi
David Conrad, Ronald Bultje
vp9 Ronald Bultje
vqavideo.cMike Melanson
- vvc [2] Nuo Mi
+ vvc [2] Nuo Mi, Wu Jianhua
wmaprodec.c Sascha Sommer
On Sat, May 24, 2025 at 10:02 PM Nuo Mi wrote:
>
>
> On Fri, May 9, 2025 at 2:37 AM Wu Jianhua wrote:
>
>> Andreas Rheinhardt:
>> > toq...@gmail.com:
>> >> From: Wu Jianhua
>> >>
>> >> Sign
On Tue, May 27, 2025 at 10:52 PM Gabriel Hege wrote:
> On 25.05.25 04:08, Nuo Mi wrote:
> > On Thu, May 22, 2025 at 4:35 PM Gabriel Hege wrote:
> >
> >>
> >> On 17.05.25 04:26, Nuo Mi wrote:
> >>> On Fri, May 16, 2025 at 7:05 PM Gabriel Hege wrot
100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -266,7 +266,7 @@ Codecs:
>vp8 David Conrad, Ronald Bultje
>vp9 Ronald Bultje
>vqavideo.cMike Melanson
> - vvc
On Thu, May 22, 2025 at 4:35 PM Gabriel Hege wrote:
>
> On 17.05.25 04:26, Nuo Mi wrote:
> > On Fri, May 16, 2025 at 7:05 PM Gabriel Hege wrote:
> >
> >> This is a resubmission with a corrected commit message.
> >>
> >>
> >> The default
On Sun, May 25, 2025 at 2:13 AM Michael Niedermayer
wrote:
> On Thu, May 22, 2025 at 07:43:02PM +0100, Frank Plowman wrote:
> > Signed-off-by: Frank Plowman
> > ---
> > Changes since v1: Spotted just after sending this that there was ongoing
> > effort to remove av_strerror calls in favour of av
On Sat, May 24, 2025 at 8:13 PM Frank Plowman wrote:
> Add three missing requirements on bitstream conformance from 7.4.3.19 of
> H.266 (V3). Issue found using fuzzing.
>
Thank you, Frank.
Applied with slight style changes.
>
> Signed-off-by: Frank Plowman
> ---
> libavcodec/vvc/ps.c | 18 +++
On Fri, May 9, 2025 at 2:37 AM Wu Jianhua wrote:
> Andreas Rheinhardt:
> > toq...@gmail.com:
> >> From: Wu Jianhua
> >>
> >> Signed-off-by: Wu Jianhua
> >> ---
> >> libavcodec/h274.c | 163 ++
> >> libavcodec/h274.h | 7 ++
> >> 2 files changed, 17
On Sun, May 18, 2025 at 9:16 PM Frank Plowman wrote:
> On 29/04/2025 14:24, Nuo Mi wrote:
> > Hi Frank,
> > Thank you for the detail.
> >
> > On Mon, Apr 28, 2025 at 10:35 PM Frank Plowman
> > wrote:
> >
> >> On 28/04/2025 14:33, Nuo Mi w
On Sun, May 18, 2025 at 2:51 PM Frank Plowman wrote:
> On 18/05/2025 02:42, Nuo Mi wrote:
> > Hi Frank,
> > 👍,your fuzzing infrastructure caught this issue as well.
> > How about this:
> >
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250517055150.807683-1-
Hi Frank,
👍,your fuzzing infrastructure caught this issue as well.
How about this:
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20250517055150.807683-1-nuomi2...@gmail.com/
On Sun, May 18, 2025 at 5:05 AM Frank Plowman wrote:
> "The value of CurrentPaletteSize[ startComp ] shall be in the r
Fixes a crash triggered by a fuzzed clip:
https://github.com/ffvvc/tests/tree/main/fuzz/passed/000256.bit
Reproduce with:
ffmpeg -i 000256.bit -f null -
---
libavcodec/vvc/ctu.c | 28 +++-
1 file changed, 23 insertions(+), 5 deletions(-)
diff --git a/libavcodec/vvc/ctu.c
On Wed, May 14, 2025 at 9:46 PM Wu Jianhua wrote:
> Wu Jianhua:
> > From: Wu Jianhua
> >
> > Signed-off-by: Wu Jianhua
> > ---
> > libavcodec/vvc/cabac.c | 21 +
> > 1 file changed, 21 insertions(+)
> >
> > diff --git a/libavcodec/vvc/cabac.c b/libavcodec/vvc/cabac.c
> > in
On Fri, May 16, 2025 at 7:05 PM Gabriel Hege wrote:
> This is a resubmission with a corrected commit message.
>
>
> The default behavior for VVenC (since v1.10.0) is to create an IDR with
> leading pictures for the first picture in decoding order (POC 32). This
> leads to FFmpeg generating an edi
m happy to make the change.
On Fri, May 16, 2025 at 4:31 AM softworkz . wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of Nuo Mi
> > Sent: Donnerstag, 15. Mai 2025 14:46
> > To: ffmpeg-devel@ffmpeg.org
> > Cc: Nuo Mi
> > Subj
On Thu, May 15, 2025 at 9:05 AM softworkz . wrote:
>
>
> > -Original Message-
> > From: ffmpeg-devel On Behalf Of Nuo Mi
> > Sent: Samstag, 3. Mai 2025 11:13
> > To: ffmpeg-devel@ffmpeg.org
> > Cc: Nuo Mi
> > Subject: [FFmpeg-dev
We defined CR to 2 in libavcodec/vvc/dec.h, but the CR used by
_IMAGE_ARM64_RUNTIME_FUNCTION_ENTRY winnt.h
reorder the header will avoid the issue.
---
tests/checkasm/vvc_sao.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tests/checkasm/vvc_sao.c b/tests/checkasm/vvc_sao.
On Sat, May 10, 2025 at 8:45 PM Nuo Mi wrote:
>
>
> On Wed, May 7, 2025 at 5:26 AM Martin Storsjö wrote:
>
>> On Sat, 3 May 2025, Nuo Mi wrote:
>>
>> > Hi Martin,Great, it works!
>> > HEVC is included in v2.
>>
>> Thanks great, thanks for l
On Thu, May 1, 2025 at 10:48 PM wrote:
> From: Wu Jianhua
>
> Signed-off-by: Wu Jianhua
> ---
> Changelog | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Changelog b/Changelog
> index a09dcd82c2..4f47b30038 100644
> --- a/Changelog
> +++ b/Changelog
> @@ -11,6 +11,8
On Wed, May 7, 2025 at 5:26 AM Martin Storsjö wrote:
> On Sat, 3 May 2025, Nuo Mi wrote:
>
> > Hi Martin,Great, it works!
> > HEVC is included in v2.
>
> Thanks great, thanks for looking into it! The checkasm aspects of patches
> 5-7/7 look good to me.
>
Thank yo
Hi Martin,
Great, it works!
HEVC is included in v2.
Thank you!
On Sat, May 3, 2025 at 4:45 AM Martin Storsjö wrote:
> On Fri, 2 May 2025, Nuo Mi wrote:
>
> > On Fri, May 2, 2025 at 3:49 PM Martin Storsjö wrote:
> > On Fri, 2 May 2025, Nuo Mi wrote:
> >
>
---
tests/checkasm/hevc_sao.c | 45 +--
1 file changed, 20 insertions(+), 25 deletions(-)
diff --git a/tests/checkasm/hevc_sao.c b/tests/checkasm/hevc_sao.c
index f597eb5254..37f6ba8c5c 100644
--- a/tests/checkasm/hevc_sao.c
+++ b/tests/checkasm/hevc_sao.c
@@ -
---
tests/checkasm/hevc_sao.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tests/checkasm/hevc_sao.c b/tests/checkasm/hevc_sao.c
index ad47423f10..f597eb5254 100644
--- a/tests/checkasm/hevc_sao.c
+++ b/tests/checkasm/hevc_sao.c
@@ -119,21 +119,21 @@ static vo
)
vvc_sao_edge_128_10_avx2: 6162.2 ( 7.63x)
vvc_sao_edge_128_12_c: 49647.3 ( 1.00x)
vvc_sao_edge_128_12_avx2: 6127.1 ( 8.10x)
Co-authored-by: Nuo Mi
---
tests/checkasm/Makefile | 2 +-
tests/checkasm
From: Shaun Loo
This is a part of Google Summer of Code 2023
Co-authored-by: Nuo Mi
---
libavcodec/x86/h26x/h2656_sao.asm | 8 +--
libavcodec/x86/vvc/Makefile | 2 +
libavcodec/x86/vvc/dsp_init.c | 41 +++
libavcodec/x86/vvc/sao.asm| 73
From: Shaun Loo
This is a part of Google Summer of Code 2023
Co-authored-by: Nuo Mi
---
libavcodec/x86/hevc/sao_10bit.asm | 100 ++
1 file changed, 48 insertions(+), 52 deletions(-)
diff --git a/libavcodec/x86/hevc/sao_10bit.asm
b/libavcodec/x86/hevc
From: Shaun Loo
This is a part of Google Summer of Code 2023
Co-authored-by: Nuo Mi
---
libavcodec/x86/h26x/h2656_sao.asm | 301
libavcodec/x86/h26x/h2656_sao_10bit.asm | 301
libavcodec/x86/hevc/sao.asm | 278
---
libavcodec/x86/vvc/dsp_init.c | 48 +--
1 file changed, 29 insertions(+), 19 deletions(-)
diff --git a/libavcodec/x86/vvc/dsp_init.c b/libavcodec/x86/vvc/dsp_init.c
index dc833bb0f1..bb68ba0b1e 100644
--- a/libavcodec/x86/vvc/dsp_init.c
+++ b/libavcodec/x86/vvc
From: Shaun Loo
This is a part of Google Summer of Code 2023
Co-authored-by: Nuo Mi
---
libavcodec/x86/h26x/h2656_sao.asm | 301
libavcodec/x86/h26x/h2656_sao_10bit.asm | 301
libavcodec/x86/hevc/sao.asm | 278
---
libavcodec/x86/vvc/dsp_init.c | 48 +--
1 file changed, 29 insertions(+), 19 deletions(-)
diff --git a/libavcodec/x86/vvc/dsp_init.c b/libavcodec/x86/vvc/dsp_init.c
index dc833bb0f1..bb68ba0b1e 100644
--- a/libavcodec/x86/vvc/dsp_init.c
+++ b/libavcodec/x86/vvc
On Fri, May 2, 2025 at 3:49 PM Martin Storsjö wrote:
> On Fri, 2 May 2025, Nuo Mi wrote:
>
> > From: Shaun Loo
> >
> > This is a part of Google Summer of Code 2023
> >
> > AVX2:
> > - vvc_sao.sao_band [OK]
> > - vvc_sao.sao_edge [OK]
> >
)
vvc_sao_edge_128_10_avx2: 6162.2 ( 7.63x)
vvc_sao_edge_128_12_c: 49647.3 ( 1.00x)
vvc_sao_edge_128_12_avx2: 6127.1 ( 8.10x)
Co-authored-by: Nuo Mi
---
tests/checkasm/Makefile | 2 +-
tests/checkasm
From: Shaun Loo
This is a part of Google Summer of Code 2023
Co-authored-by: Nuo Mi
---
libavcodec/x86/h26x/h2656_sao.asm | 8 +--
libavcodec/x86/vvc/Makefile | 2 +
libavcodec/x86/vvc/dsp_init.c | 41 +++
libavcodec/x86/vvc/sao.asm| 73
From: Shaun Loo
This is a part of Google Summer of Code 2023
Co-authored-by: Nuo Mi
---
libavcodec/x86/hevc/sao_10bit.asm | 100 ++
1 file changed, 48 insertions(+), 52 deletions(-)
diff --git a/libavcodec/x86/hevc/sao_10bit.asm
b/libavcodec/x86/hevc
From: Shaun Loo
This is a part of Google Summer of Code 2023
Co-authored-by: Nuo Mi
---
libavcodec/x86/h26x/h2656_sao.asm | 301
libavcodec/x86/h26x/h2656_sao_10bit.asm | 301
libavcodec/x86/hevc/sao.asm | 278
---
libavcodec/x86/vvc/dsp_init.c | 48 +--
1 file changed, 29 insertions(+), 19 deletions(-)
diff --git a/libavcodec/x86/vvc/dsp_init.c b/libavcodec/x86/vvc/dsp_init.c
index dc833bb0f1..bb68ba0b1e 100644
--- a/libavcodec/x86/vvc/dsp_init.c
+++ b/libavcodec/x86/vvc
Hi Frank,
Thank you for the detail.
On Mon, Apr 28, 2025 at 10:35 PM Frank Plowman
wrote:
> On 28/04/2025 14:33, Nuo Mi wrote:
> > Hi Frank,
> > Thank you for the v2.
> > Could we remove all asserts?
> > Asserts can cause the application to crash at runtime.
>
>
Hi Frank,
Thank you for the v2.
Could we remove all asserts?
Asserts can cause the application to crash at runtime.
On Sun, Apr 27, 2025 at 4:48 PM Frank Plowman wrote:
> In d5dbcc00d889fb17948b025a468b00ddbea9e058, it was hoped that detection
> of subpicture overlaps could be performed at the t
On Fri, Apr 18, 2025 at 10:40 PM Frank Plowman
wrote:
> In d5dbcc00d889fb17948b025a468b00ddbea9e058, it was hoped that detection
> of subpicture overlaps could be performed at the tile level, so as to
> avoid introducing per-CTU checks. Unfortunately since that patch,
> fuzzing has indicated ther
Hi Andreas,
Thank you for the review.
Hi Jianhua,
Thank you for the patches. I will merge this weekend if there are no
objections.
On Wed, Apr 2, 2025 at 2:11 AM Wu Jianhua wrote:
> Andreas Rheinhardt :
> > toq...@gmail.com:
> >> From: Wu Jianhua
> >>
> >> passed files:
> >> FIELD_A_Panas
LGTM,
Nit: Would a lookup table be better?
On Fri, Apr 18, 2025 at 12:42 AM James Almer wrote:
> And improve the vvencMsgLevel <-> AV_LOG_* mapping.
>
> Signed-off-by: James Almer
> ---
> libavcodec/libvvenc.c | 35 +++
> 1 file changed, 27 insertions(+), 8 dele
Thank you, Frank.
Hi samples-request,
could you help
On Wed, Apr 9, 2025 at 12:29 AM Frank Plowman wrote:
> On 24/03/2025 18:10, Frank Plowman wrote:
> > A sample with a particular partitioning structure that could not be read
> > correctly before 26c5d8cf5d6dcd520e781754d986e9907d74270e
> >
>
On Sat, Mar 29, 2025 at 6:21 AM Michael Niedermayer
wrote:
> Hi
>
> On Tue, Mar 25, 2025 at 10:59:28PM +0800, Nuo Mi wrote:
> > It is also referred to as:
> > SPI-FUJITSU
> > AUG-CCITT
> > CRC-CCITT (0x1D0F)
> > This CRC type used by
It is also referred to as:
SPI-FUJITSU
AUG-CCITT
CRC-CCITT (0x1D0F)
This CRC type used by H.274
---
libavutil/hash.c | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavutil/hash.c b/libavutil/hash.c
index fbc24194de..3659c71c7f 100644
--- a/libavutil/hash
+1 for VVC patches.
Thank you, Andreas
On Tue, Mar 18, 2025 at 4:00 PM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Patches attached.
>
> - Andreas
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman
On Thu, Mar 6, 2025 at 2:40 AM Frank Plowman wrote:
> If pps_single_slice_per_subpic_flag is 1,
> slice_{width,height}_in_tiles are undefined and we must instead get the
> dimensions of the slice by referring to the corresponding subpicture.
> Signed-off-by: Frank Plowman
> ---
> Changes since
On Sun, Mar 9, 2025 at 9:57 PM Nuo Mi wrote:
>
>
> On Thu, Mar 6, 2025 at 2:40 AM Frank Plowman
> wrote:
>
>> If pps_single_slice_per_subpic_flag is 1,
>> slice_{width,height}_in_tiles are undefined and we must instead get the
>> dimensions of the slice
On Thu, Mar 6, 2025 at 2:40 AM Frank Plowman wrote:
> If pps_single_slice_per_subpic_flag is 1,
> slice_{width,height}_in_tiles are undefined and we must instead get the
> dimensions of the slice by referring to the corresponding subpicture.
>
> Signed-off-by: Frank Plowman
> ---
> Changes since
On Sun, Mar 2, 2025 at 8:13 PM Frank Plowman wrote:
> When pps_num_exp_slices_in_tile[i] is nonzero, the ith tile is made up
> of pps_num_exp_slices_in_tile[i] slices stacked atop one another, where
> the height of the jth slice in the ith tile is given by
> pps_exp_slice_height_in_ctus_minus1[i]
On Fri, Mar 7, 2025 at 9:56 PM Martin Storsjö wrote:
> On Mon, 3 Mar 2025, Krzysztof Pyrkosz via ffmpeg-devel wrote:
>
> > This patch replaces integer widening with halving addition, and
> > multi-step "emulated" rounding shift with a single asm instruction doing
> > exactly that.
> >
> > Benchma
On Sun, Feb 23, 2025 at 8:05 PM Frank Plowman wrote:
> Signed-off-by: Frank Plowman
>
Applied this one.
Thank you, Frank
> ---
> libavcodec/vvc/ps.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/vvc/ps.c b/libavcodec/vvc/ps.c
> index fae6655cc0..603a6d42
On Sun, Feb 23, 2025 at 8:05 PM Frank Plowman wrote:
> If pps_single_slice_per_subpic_flag is 1,
> slice_{width,height}_in_ctus are undefined and we must instead get the
> dimensions of the slice by referring to the corresponding subpicture.
>
> Signed-off-by: Frank Plowman
> ---
> libavcodec/c
On Tue, Feb 25, 2025 at 3:16 AM Frank Plowman wrote:
> On 24/02/2025 02:23, James Almer wrote:
> > On 2/23/2025 9:04 AM, Frank Plowman wrote:
> >> Signed-off-by: Frank Plowman
> >> ---
> >> libavcodec/vvc/ps.c | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >>
> >> diff --git a
On Mon, Feb 24, 2025 at 2:44 AM Frank Plowman wrote:
> On 23/02/2025 13:37, Nuo Mi wrote:
> > This issue was introduced by commit
> bb8e95b650de30d6e07196761d1fc61857f5462d
> >
> > Reproduce steps:
> > ./configure --enable-ffmpeg --disable-everything --enable-dec
On Sun, Feb 23, 2025 at 1:36 AM Frank Plowman wrote:
> On 22/02/2025 07:51, Nuo Mi wrote:
> > From: Frank Plowman
> >
> > This is essentially a re-implementation of
> >
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20241005223955.54158-1-p...@frankplowman.c
This issue was introduced by commit bb8e95b650de30d6e07196761d1fc61857f5462d
Reproduce steps:
./configure --enable-ffmpeg --disable-everything --enable-decoder=vvc
--enable-parser=vvc --enable-demuxer=vvc --enable-protocol=file,pipe
--enable-encoder=rawvideo,wrapped_avframe --enable-muxer=rawvid
From: Frank Plowman
This is essentially a re-implementation of
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20241005223955.54158-1-p...@frankplowman.com/
That patch was not applied last time. Instead we opted to identify
issues which could be caused by invalid subpicture layouts and remedy
On Thu, Feb 20, 2025 at 4:29 AM Frank Plowman wrote:
> Hi,
>
> Thanks for your review.
>
> On 16/02/2025 15:19, Nuo Mi wrote:
> > Hi Frank,
> > Thank you for the patch.
> >
> > On Sun, Feb 9, 2025 at 11:45 PM Frank Plowman
> wrote:
> >
From: Frank Plowman
In the case pps_subpic_less_than_one_tile_slice is called, the
subpicture is smaller than the tile and so there are multiple
subpictures in the tile. Of course, then, not all the
subpictures can start in the top-left corner as the code before the
patch does. Patch fixes this
On Thu, Feb 20, 2025 at 4:33 AM Frank Plowman wrote:
> Ping
>
Sorry for missing this.
Thank you for the patch, applied
>
> On 02/02/2025 12:10, Frank Plowman wrote:
> > The clamping of idxYInv from H.266(V3) section 8.8.2.3 was missing.
> > This could lead to OOB reads from lmcs->pivot or input_
On Wed, Feb 19, 2025 at 5:38 AM Barry Warburton
wrote:
> LGTM.
>
Thank you, Barry,
Applied.
>
> On 03/02/2025 09:17, Nuo Mi wrote:
> > Previously, VUI information was not exposed.
> > If the container lacks HDR metadata, HDR videos appear washed out
> >
&g
Hi Frank,
Thank you for the patch.
On Sun, Feb 9, 2025 at 11:45 PM Frank Plowman wrote:
> This is essentially a re-implementation of
>
> https://patchwork.ffmpeg.org/project/ffmpeg/patch/20241005223955.54158-1-p...@frankplowman.com/
>
> That patch was not applied last time. Instead we opted to
On Sun, Feb 9, 2025 at 5:43 AM Frank Plowman wrote:
> In the fail: block of decode_nal_units, a check as to whether fc->ref is
> nonzero is used. Before this patch, fc->ref was set to NULL in
> frame_context_setup. The issue is that, by the time frame_context_setup
> is called, falliable functi
On Fri, Feb 7, 2025 at 4:25 AM Frank Plowman wrote:
> On 02/02/2025 21:17, Michael Niedermayer wrote:
> > Fixes:
> 390565846/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-4990028521996288
> > Fixes: Null pointer dereference
> >
> > Found-by: continuous fuzzing process
> https://git
Previously, VUI information was not exposed.
If the container lacks HDR metadata, HDR videos appear washed out
Command: mp4box -add hdr.mp4#video:colr=nclc,1,1,1 -new new.mp4 && ffprobe
new.mp4
Before: Stream #0:0[0x1](und): Video: vvc (vvc1 / 0x31637676),
yuv420p10le(bt709), 1920x1080, 12164 kb
---
libavcodec/vvc/dec.c | 1 -
libavcodec/vvc/ps.c | 29 +++--
2 files changed, 19 insertions(+), 11 deletions(-)
diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c
index 51dd60ae92..68fb26352e 100644
--- a/libavcodec/vvc/dec.c
+++ b/libavcodec/vvc/dec.c
@@ -812,7
On Wed, Jan 29, 2025 at 4:40 PM Frank Plowman wrote:
> On 26/01/2025 03:10, Nuo Mi wrote:
> > fixes https://github.com/ffvvc/tests/tree/main/fuzz/passed/000323.bit
> >
> > Co-authored-by: Frank Plowman
> > ---
> > libavcodec/vvc/ps.c | 11 +--
> &
On Sat, Jan 18, 2025 at 11:12 PM Nuo Mi wrote:
>
>
> On Sat, Jan 18, 2025 at 4:18 AM Frank Plowman
> wrote:
>
>> When the chroma format changes mid-sequence, c->pix_fmt and s->pix_fmt
>> can get out-of-sync. More specifically,
>> 1. export_frame_p
AVCodecContext->sw_pix_fmt is used to hold the software pixel format.
Co-authored-by: Frank Plowman
---
libavcodec/vvc/dec.c | 17 ++---
libavcodec/vvc/dec.h | 2 --
2 files changed, 6 insertions(+), 13 deletions(-)
diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c
index daf
fixes https://github.com/ffvvc/tests/tree/main/fuzz/passed/000323.bit
Co-authored-by: Frank Plowman
---
libavcodec/vvc/ps.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/libavcodec/vvc/ps.c b/libavcodec/vvc/ps.c
index c9f7c5c80f..01b4615eda 100644
--- a/libavcod
Downstream can determine the format from the output frame format
Co-authored-by: Frank Plowman
---
libavcodec/vvc/dec.c | 23 ++-
1 file changed, 2 insertions(+), 21 deletions(-)
diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c
index 1cb168de7e..daf537294f 100644
---
On Sun, Jan 19, 2025 at 12:40 AM Zhao Zhili <
quinkblack-at-foxmail@ffmpeg.org> wrote:
>
>
> > On Jan 18, 2025, at 23:30, Nuo Mi wrote:
> >
> > Hi Zhili,
> > Thank you for v2,
> > +1
> >
> > Nit: The if statement is too long. Move it afte
Hi Zhili,
Thank you for v2,
+1
Nit: The if statement is too long. Move it after generate_missing_ref and
break it up to simplify the logic.
like:
if (!ref) {
ref = generate_missing_ref(s, fc, poc);
if (!ref)
return AVERROR(ENOMEM);
}
+if (ref->flags &
uffers are not allocated for the
> new pixel format.
>
> Patch fixes this by not setting c->pix_fmt in set_output_format.
>
> Signed-off-by: Frank Plowman
> ---
> @Nuo Mi, Fei Wang:
> Does this look okay? I am not really sure why c->pix_fmt was set again
> in set_output_fo
On Mon, Jan 13, 2025 at 4:46 PM Zhao Zhili <
quinkblack-at-foxmail@ffmpeg.org> wrote:
> From: Zhao Zhili
>
> Hi Zhili,
Thank you for the patch.
This will fail on GDR clips, such as:
GDR_B_NOKIA_2.bit
GDR_C_NOKIA_2.bit
By design, a GDR frame refers to missing frames and gradually ref
e:
>
>> Sounds very good, thanks!
>>
>> Issue: https://trac.ffmpeg.org/ticket/11406
>>
>> I would be glad to try it.
>>
>>
>> On Wed, Jan 8, 2025 at 2:04 PM Nuo Mi wrote:
>>
>>>
>>>
>>> On Wed, Jan 8, 2025
information could be retrieved solely from the parser or the
CBS
>
>
>
>
> On Sun, Jan 12, 2025 at 4:38 AM Nuo Mi wrote:
>
> > On Sun, Jan 12, 2025 at 6:24 AM James Almer wrote:
> >
> > > On 1/11/2025 3:40 AM, Nuo Mi wrote:
> > > > Tested with:
&g
Thank you, Frank,
Applied with some minor changes.
On Sat, Jan 11, 2025 at 5:31 AM Frank Plowman wrote:
> The criteria for slice structure validity is similar to that of
> subpicture structure validity that we saw not too long ago [1].
> The relationship between tiles and slices must satisfy the
On Sat, Jan 11, 2025 at 11:49 PM James Almer wrote:
> As defined in
> https://github.com/ietf-wg-cellar/matroska-specification/blob/master/codec_specs.md#v_mpegiisovvc
>
> Signed-off-by: James Almer
> ---
> libavformat/matroska.c| 1 +
> libavformat/matroskaenc.c | 10 --
> 2 files
On Sat, Jan 11, 2025 at 9:18 PM Frank Plowman wrote:
> In some scenarios, the VVCContext.pix_fmt and the
> AVCodecContext.pix_fmt can get out-of-sync. It is more robust here
> to check the AVCodecContext.pix_fmt, as we already do for the width and
> height, seeing as the AVCodecContext.pix_fmt i
On Sun, Jan 12, 2025 at 6:24 AM James Almer wrote:
> On 1/11/2025 3:40 AM, Nuo Mi wrote:
> > Tested with:
> > ```
> > wget
> https://www.itu.int/wftp3/av-arch/jvet-site/bitstream_exchange/VVC/draft_conformance/draft6/CodingToolsSets_E_Tencent_1.zip
> > unzip C
Tested with:
```
wget
https://www.itu.int/wftp3/av-arch/jvet-site/bitstream_exchange/VVC/draft_conformance/draft6/CodingToolsSets_E_Tencent_1.zip
unzip CodingToolsSets_E_Tencent_1.zip CodingToolsSets_E_Tencent_1.bit
ffprobe -hide_banner CodingToolsSets_E_Tencent_1.bit -select_streams v
-show_fra
Tested with:
```
wget
https://www.itu.int/wftp3/av-arch/jvet-site/bitstream_exchange/VVC/draft_conformance/draft6/CodingToolsSets_E_Tencent_1.zip
unzip CodingToolsSets_E_Tencent_1.zip CodingToolsSets_E_Tencent_1.bit
ffprobe -hide_banner CodingToolsSets_E_Tencent_1.bit -select_streams v
-show_fra
LGTM.
On Wed, Jan 8, 2025 at 7:51 PM Frank Plowman wrote:
> This sample is rather difficult, containing a lot of subtle edge cases
>
Are we still encountering issues with the latest code?
> which revealed errors in the VVC decoder. It covers 88.4% of lines in
> libavcodec/vvc and brings the lin
On Wed, Jan 8, 2025 at 12:35 AM Rubén Gonzalez
wrote:
> Hi Nuo Mi,
>
> thanks for your feedback. Unfortunately I don't have enough knowledge/time
> to improve the patch. I only mimicked H.26[45].
>
> IMHO, reporting AV_FRAME_FLAG_KEY is better than nothing, so I will send
On Sat, Jan 4, 2025 at 9:51 PM Nuo Mi wrote:
>
>
> On Fri, Jan 3, 2025 at 2:01 AM Frank Plowman
> wrote:
>
>> Thank you for your review.
>>
>> On 01/01/2025 04:30, Nuo Mi wrote:
>> > 👍
>> >
>> > On Tue, Dec 31, 2024 at 2:02 AM Frank P
n would complicate ff_vvc_alf_filter, so I pushed Chris's
instead.
Thank you patch and ping.
>
> Thanks and happy new year,
> Frank
>
> On 03/12/2024 02:17, Nuo Mi wrote:
> > Hi Chris and Frank,
> > Thank you for the patch and review.
> >
> > On Mon, Dec 2, 2
On Fri, Jan 3, 2025 at 2:01 AM Frank Plowman wrote:
> Thank you for your review.
>
> On 01/01/2025 04:30, Nuo Mi wrote:
> > 👍
> >
> > On Tue, Dec 31, 2024 at 2:02 AM Frank Plowman
> wrote:
> >
> >> When the current subpicture has sps_subpic_treate
Hi Ruben,
Thank you for the patch.
A B/P frame's first slice may be an I slice, so it can't be used to
determine the picture type.
The ph_inter_slice_allowed_flag can quickly identify an I frame, but B/P
frame still requires checking all slices.
On Fri, Jan 3, 2025 at 12:19 AM Ruben Gonzalez
wrot
👍
On Tue, Dec 31, 2024 at 2:02 AM Frank Plowman wrote:
> When the current subpicture has sps_subpic_treated_as_pic_flag equal to
> 1, motion vectors are cropped such that they cannot point to other
> subpictures. This was accounted for in the prediction logic, but not
> in pred_get_y, which is
On Sun, Dec 29, 2024 at 6:24 PM Frank Plowman wrote:
> Hi,
>
> Thank you for your review.
>
> It seems your mail did not reach the ML for whatever reason. I have
> ensured your comments are all left verbatim below so that others may
> read them.
>
Thank you.
>
&g
Hi Frank,
Thank you for the patch.
On Sun, Dec 22, 2024 at 9:40 PM Frank Plowman wrote:
> When the current subpicture has sps_subpic_treated_as_pic_flag equal to
> 1, motion vectors are cropped such that they cannot point to other
> subpictures. This was accounted for in the prediction logic, b
On Mon, Dec 23, 2024 at 11:18 PM flow gg wrote:
> Hi, It looks like you submitted your review comments not long after the
> patch was merged.
>
> Previously, regarding the VVC avg patch, you mentioned "LGTM for the RISC-V
> side. No clue about the VVC side",
> so I contacted Nuomi in the hope tha
On Sat, Dec 21, 2024 at 9:42 PM Rémi Denis-Courmont wrote:
> Hi
>
> The RISC-V bits look ok. No opinion on x86.
>
Thank you for the review.
Pushed.
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg
On Sun, Dec 22, 2024 at 3:03 AM Ronald S. Bultje wrote:
> Hi,
>
> On Sat, Dec 21, 2024 at 5:02 AM Nuo Mi wrote:
>
>> rename from libavcodec/x86/hevc_add_res.asm
>> rename to libavcodec/x86/hevc/add_res.asm
>>
>
> Good idea - LGTM. I should probably do this
On Sat, Dec 21, 2024 at 2:06 PM flow gg wrote:
> Hi, other RISC-V assembly file names usually include the extensions being
> used, such as rvv, rvb, etc.
> How about naming them mc_rvv.S and sad_rvv.S?
>
Thank you for the comment.
Fixed by v2
>
> Nuo Mi 于202
---
libavcodec/x86/Makefile | 8
libavcodec/x86/hevc/Makefile | 12
.../x86/{hevc_add_res.asm => hevc/add_res.asm} | 0
.../x86/{hevc_deblock.asm => hevc/deblock.asm} | 0
libavcodec/x86/{hevcdsp_init.c => he
1 - 100 of 978 matches
Mail list logo
