Re: [FFmpeg-devel] [PATCH] libavutil/hwcontext_dxva2: Add check for possible errors from GetAdapterDisplayModeEx

2018-01-04 Thread Mont3z Claros
On Thu, Jan 4, 2018 at 7:49 AM, wm4 wrote: > On Wed, 3 Jan 2018 15:22:15 -0800 > Humberto Ribeiro wrote: > >> This prevents a possible crash in CreateDeviceEx when using faulty response >> from GetAdapterDisplayModeEx and allows ffmpeg to fallback to classic d3d9. >> --- ... >> > > Tested, slig

Re: [FFmpeg-devel] [PATCH] Prevents crash from CreateDeviceEx and proper fallback to classic d3d9.

2018-01-03 Thread Mont3z Claros
Thx for this inside. Unfortunately my application still crashes even after setting Size in modeex. In my case, IDirect3D9Ex_GetAdapterDisplayModeEx always returns D3DERR_INVALIDCALL. Humberto On Wed, Jan 3, 2018 at 4:17 PM, wm4 wrote: > On Thu, 4 Jan 2018 00:26:01 +0100 > Hendrik Leppkes wrote:

Re: [FFmpeg-devel] [PATCH] Prevents crash from CreateDeviceEx and proper fallback to classic d3d9.

2018-01-03 Thread Mont3z Claros
> LGTM, but when does it happen? Why would creation of IDirect3D9Ex > succeed, but this method fail? The strangest thing being that > CreateDeviceEx apparently fails, even though modeex is > zero-initialized and doesn't contain any pointers. > > Anyway, please format the commit message according to