mbedtls_x509_crt_parse_file returns an error with negative numbers, and
positive numbers indicate the number of failed certificates to load from
certificate specific issues, such as critical extensions.
This would fix ticket #11079.
Signed-off-by: Mohit Gupta
---
libavformat/tls_mbedtls.c
Interesting, I did not personally. I sent it by generating an .eml file
with git and then opening that in Thunderbird to send. I wonder if
Thunderbird editor mangled it or something. Let me try sending directly
via git as a -v3.
On 01/08/2024 05:50, Marth64 wrote:
Hi, good day,
I think somet
mbedtls_x509_crt_parse_file returns an error with negative numbers, and
positive numbers indicate the number of failed certificates to load from
certificate specific issues, such as critical extensions.
This would fix ticket #11079.
Signed-off-by: Mohit Gupta
---
libavformat/tls_mbedtls.c
Sounds good. Sorry first time contributing, should I make another patch
with the change and send that through again with git send-email?
Thanks
Mohit
On Tue, Jul 16, 2024 at 2:26 AM Marth64 wrote:
> > Could do. What level were you thinking? WARN?
>
> How about,
> ```
> av_log(h, AV_LOG_WARNING,
Could do. What level were you thinking? WARN?
On 14/07/2024 17:29, Marth64 wrote:
av_log(h, AV_LOG_DEBUG, "mbedtls_x509_crt_parse_file skipped %d
certificate(s)\n", ret);
Is it worth it making this a higher log level? Or is it too much noise?
Thinking if it’s important security information to
mbedtls_x509_crt_parse_file returns an error with negative numbers, and
positive numbers indicate the number of failed certificates to load from
certificate specific issues, such as critical extensions.
This would fix ticket #11079.
Signed-off-by: Mohit Gupta
---
libavformat/tls_mbedtls.c | 4