On 2017-06-01 09:04 PM, Michael Niedermayer wrote:
On Tue, May 30, 2017 at 09:29:53PM -0400, Micah Galizia wrote:
Hello,
I'd like to backport the HLS cookie authentication fixes to 3.3 so that Kodi 18
picks them up. Originally, this was a three patch set but the first fi
Signed-off-by: Micah Galizia
Signed-off-by: Michael Niedermayer
(cherry picked from commit 28b24670741e1de25bfc7b5ea7c1d6dbae1aef6f)
Signed-off-by: Micah Galizia
---
libavformat/http.c | 213 +++--
1 file changed, 156 insertions(+), 57 deletions
Signed-off-by: Micah Galizia
Signed-off-by: Michael Niedermayer
(cherry picked from commit c4c73020f4bbf261f0b263be82de575c17fa5a60)
Signed-off-by: Micah Galizia
---
libavformat/hls.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/libavformat/hls.c b
Hello,
I'd like to backport the HLS cookie authentication fixes to 3.3 so that Kodi 18
picks them up. Originally, this was a three patch set but the first fix (to
av_small_strptime) is already in 3.3 and doesn't need to be backported. The
two that are still required are:
- c4c73020f4bbf261f0b
On 2017-05-28 08:44 PM, Michael Niedermayer wrote:
On Fri, May 26, 2017 at 09:29:04PM -0400, Micah Galizia wrote:
On Sat, May 20, 2017 at 9:36 PM, Micah Galizia wrote:
On 2017-05-17 05:23 AM, wm4 wrote:
On Sat, 6 May 2017 14:28:10 -0400
Micah Galizia wrote:
On 2017-05-05 09:28 PM, wm4
On Sat, May 20, 2017 at 9:36 PM, Micah Galizia wrote:
> On 2017-05-17 05:23 AM, wm4 wrote:
>>
>> On Sat, 6 May 2017 14:28:10 -0400
>> Micah Galizia wrote:
>>
>>> On 2017-05-05 09:28 PM, wm4 wrote:
>>>>
>>>> On Fri, 5 May 2017 20:55:05
On 2017-05-17 05:23 AM, wm4 wrote:
On Sat, 6 May 2017 14:28:10 -0400
Micah Galizia wrote:
On 2017-05-05 09:28 PM, wm4 wrote:
On Fri, 5 May 2017 20:55:05 -0400
Micah Galizia wrote:
Signed-off-by: Micah Galizia
---
libavformat/hls.c | 12 ++--
1 file changed, 10 insertions
On 2017-05-16 04:57 PM, Michael Niedermayer wrote:
On Sat, May 06, 2017 at 02:28:10PM -0400, Micah Galizia wrote:
On 2017-05-05 09:28 PM, wm4 wrote:
Did you mean & instead of ^?
No, the original code was structured to set *u to null (and thus did
not copy cookies) iff AVFMT_FLAG_CUSTO
Signed-off-by: Micah Galizia
---
libavformat/hls.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index bac53a4350..42022690f1 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -630,8 +630,16 @@ static int open_url
On 2017-05-06 02:28 PM, Micah Galizia wrote:
On 2017-05-05 09:28 PM, wm4 wrote:
On Fri, 5 May 2017 20:55:05 -0400
Micah Galizia wrote:
Signed-off-by: Micah Galizia
---
libavformat/hls.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/libavformat/hls.c b
On 2017-05-05 09:28 PM, wm4 wrote:
On Fri, 5 May 2017 20:55:05 -0400
Micah Galizia wrote:
Signed-off-by: Micah Galizia
---
libavformat/hls.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index bac53a4350
Hi,
This is a simpler version of the other patch that still observes
AVFMT_FLAG_CUSTOM_IO.
Thanks in advance.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Signed-off-by: Micah Galizia
---
libavformat/hls.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index bac53a4350..bda9abecfa 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -630,8 +630,16 @@ static int open_url
On 2017-05-02 09:04 PM, wm4 wrote:
On Tue, 2 May 2017 20:47:06 -0400
Micah Galizia wrote:
Signed-off-by: Micah Galizia
---
libavformat/hls.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index bac53a4350..643d50e1da
Signed-off-by: Micah Galizia
---
libavformat/hls.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index bac53a4350..643d50e1da 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -630,8 +630,14 @@ static int open_url
Hi,
I was hoping to get this one in too so I've named the patch appropriately.
With this change, cookie authenticated streams (eg: Neulion) should play
properly again.
Thanks,
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mai
Hello,
Same patch with corrected name.
Thanks in advance.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Signed-off-by: Micah Galizia
---
libavformat/Makefile | 1 +
libavformat/tests/http.c | 186 +
tests/fate/libavformat.mak | 5 ++
tests/ref/fate/http| 30
4 files changed, 222 insertions(+)
create mode 100644 libavformat
On 2017-05-01 12:09 PM, Michael Niedermayer wrote:
On Sun, Apr 30, 2017 at 02:25:29PM -0400, Micah Galizia wrote:
Signed-off-by: Micah Galizia
---
libavformat/http.c | 213 +++--
1 file changed, 156 insertions(+), 57 deletions(-)
applied
thx
Signed-off-by: Micah Galizia
---
libavformat/http.c | 213 +++--
1 file changed, 156 insertions(+), 57 deletions(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index 293a8a7204..d06103ab6d 100644
--- a/libavformat/http.c
+++ b/libavformat
Hi,
This version fixes the cstr leak and explicitly frees tmp when allocating
cookies fails. Freeing tmp also means we don't need to free *cookies when ret
is less than zero.
I've also formatted the name properly, so it'll show up as a new thread.
Thanks in advance.
___
Thanks for the review, new fix checks av_dict_set return.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Signed-off-by: Micah Galizia
---
libavformat/http.c | 212 +++--
1 file changed, 155 insertions(+), 57 deletions(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index 293a8a7204..58fc3902ab 100644
--- a/libavformat/http.c
+++ b/libavformat
On 2017-04-08 09:05 PM, Micah Galizia wrote:
Is there something I can do to get this reviewed?
Thanks in advance.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 2017-04-08 09:05 PM, Micah Galizia wrote:
Signed-off-by: Micah Galizia
Hello,
Has anyone had a chance to review this? I was hoping to get the rework
(if needed) done this weekend.
Thanks,
___
ffmpeg-devel mailing list
ffmpeg-devel
Signed-off-by: Micah Galizia
---
libavformat/hls.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index bac53a4350..643d50e1da 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -630,8 +630,14 @@ static int open_url
Hi,
This one gets rid of the check against AVFMT_FLAG_CUSTOM_IO. Let me know if
anything else needs changing.
Thanks,
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
The original patch (possibly the implementation it replaced) had a bug that
would include whitespace (eg: newline) when evaluating Set-Cookie values (eg:
the domain).
This is corrected in the modified version of that patch.
Thanks
___
ffmpeg-devel mai
Signed-off-by: Micah Galizia
---
libavformat/http.c | 211 ++---
1 file changed, 154 insertions(+), 57 deletions(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index 293a8a7204..425711aab5 100644
--- a/libavformat/http.c
+++ b/libavformat
On 2017-04-07 02:48 AM, wm4 wrote:
On Thu, 6 Apr 2017 22:48:59 -0400
Micah Galizia <mailto:micahgali...@gmail.com> wrote:
Signed-off-by: Micah Galizia
<mailto:micahgali...@gmail.com>
---
libavformat/hls.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
Signed-off-by: Micah Galizia
---
libavformat/hls.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index bac53a4..ab81863 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -630,8 +630,14 @@ static int open_url
Hello,
I noticed some Set-Cookie headers are being ignored by the HLS demuxer. Patch
attached fixes it.
Previously, the cookies wouldn't get updated from the right AVIOContext, or not
at all if AVFMT_FLAG_CUSTOM_IO is set -- I'm not really sure why that was done
so please let me know if I over
Signed-off-by: Micah Galizia
---
libavformat/Makefile | 1 +
libavformat/tests/http.c | 186 +
tests/fate/libavformat.mak | 5 ++
tests/ref/fate/http| 30
4 files changed, 222 insertions(+)
create mode 100644 libavformat
Hi,
I didn't realize there was a year 2038 problem -- dates beyond it overflow a
32-bit time_t -- I've made the unit tests 32-bit compatible now.
Thank you!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg
Hi,
No more passing null to strcmp -- hopefully this addresses the crash.
Thanks in advance.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Signed-off-by: Micah Galizia
---
libavformat/Makefile | 1 +
libavformat/tests/http.c | 185 +
tests/fate/libavformat.mak | 5 ++
tests/ref/fate/http| 30
4 files changed, 221 insertions(+)
create mode 100644 libavformat
On 2017-03-31 06:10 AM, Michael Niedermayer wrote:
On Thu, Mar 30, 2017 at 09:33:48PM -0400, Micah Galizia wrote:
Signed-off-by: Micah Galizia
---
libavformat/Makefile | 1 +
libavformat/tests/http.c | 182 +
tests/fate
Signed-off-by: Micah Galizia
---
libavformat/http.c | 204 ++---
1 file changed, 147 insertions(+), 57 deletions(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index 293a8a7..a9f1b3f 100644
--- a/libavformat/http.c
+++ b/libavformat
Signed-off-by: Micah Galizia
---
libavformat/Makefile | 1 +
libavformat/tests/http.c | 182 +
tests/fate/libavformat.mak | 5 ++
tests/ref/fate/http| 30
4 files changed, 218 insertions(+)
create mode 100644 libavformat
Hello Again,
This is another attempt to get the http protocol not to send expired cookies
_and_ prevent it from updating good cookie values with expired cookie values
sent by misbehaving servers.
Previously its been recommended that we break each set-cookie into a dict to
parse it properly; t
Thanks for those comments -- I'll get rid of the strlen in the
upcoming patch but, Nicolas, you lost me there.
Anyway, this patch only does half the job -- I have a new one that is
unfortunately larger, but has taken prior advice to break cookies into
dicts.
On Thu, Mar 30, 2017 at 4:12 PM, Nicol
Micah Galizia wrote:
> Signed-off-by: Micah Galizia
> ---
> libavformat/http.c | 43 +++
> 1 file changed, 39 insertions(+), 4 deletions(-)
>
> diff --git a/libavformat/http.c b/libavformat/http.c
> index 293a8a7..53fae2a 100644
> ---
On Sat, Mar 25, 2017 at 10:51 AM, wm4 wrote:
> This can overflow sizeof(exp_buf).
Sorry, new patch cleans that up.
>> +
>> +// move the string beyond the day of week
>> +i = 0;
>> +while ((exp_buf[i] < '0' || exp_buf[i] > '9') && (i < j))
>> +
Signed-off-by: Micah Galizia
---
libavformat/http.c | 43 +++
1 file changed, 39 insertions(+), 4 deletions(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index 293a8a7..53fae2a 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -29,6
Signed-off-by: Micah Galizia
---
libavformat/http.c | 43 +++
1 file changed, 39 insertions(+), 4 deletions(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index 293a8a7..f7d1925 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -29,6
On 2017-03-25 07:11 AM, wm4 wrote:
>> -while ((param = av_strtok(cookie, "; ", &next_param))) {
>> +while ((param = av_strtok(cookie, ";", &next_param))) {
>> +
>> +// move past any leading whitespace
>> +param += strspn(param, WHITESPACES);
>> +
> Not qui
Signed-off-by: Micah Galizia
---
libavformat/http.c | 41 +
1 file changed, 37 insertions(+), 4 deletions(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index 293a8a7..37bdacf 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -29,6
Hi,
This is my second attempt at fixing how we are handling expired cookies. As a
reminder, on some authenticated Neulion streams, they send a cookie from the
past, like so:
Set-Cookie: nlqptid=""; Domain=.neulion.com; Expires=Thu, 01-Jan-1970 00:00:10
GMT; Path=/
These expired cookies are ig
On Sun, Feb 26, 2017 at 11:12 AM, Michael Niedermayer
wrote:
> On Thu, Feb 23, 2017 at 09:34:28PM -0500, Micah Galizia wrote:
>> Hello,
>>
>> Is someone able to take a look at this and accept or reject it -- its
>> been a few days since I submitted.
>
> applied
Hello,
Is someone able to take a look at this and accept or reject it -- its
been a few days since I submitted.
Sorry to pester -- thanks in advance.
On Mon, Feb 20, 2017 at 7:48 PM, Micah Galizia wrote:
> Signed-off-by: Micah Galizia
> ---
> libavutil/parseutils.c
Signed-off-by: Micah Galizia
---
libavutil/parseutils.c | 28
libavutil/tests/parseutils.c | 7 +++
tests/ref/fate/parseutils| 7 +++
3 files changed, 42 insertions(+)
diff --git a/libavutil/parseutils.c b/libavutil/parseutils.c
index 86d3dac
Signed-off-by: Micah Galizia
---
libavutil/parseutils.c | 28
libavutil/tests/parseutils.c | 7 +++
tests/ref/fate/parseutils| 7 +++
3 files changed, 42 insertions(+)
diff --git a/libavutil/parseutils.c b/libavutil/parseutils.c
index 86d3dac
Sorry about that -- this actually makes sense now -- I thought it was a bit odd
that the test program had no asserts or anything to validate the output...
I've addressed the fate issues in this patch -- thanks again for the review.
___
ffmpeg-devel mail
Signed-off-by: Micah Galizia
---
libavutil/parseutils.c | 28
libavutil/tests/parseutils.c | 7 +++
2 files changed, 35 insertions(+)
diff --git a/libavutil/parseutils.c b/libavutil/parseutils.c
index 86d3dac..7ca07b3 100644
--- a/libavutil/parseutils.c
---
libavutil/parseutils.c | 31 +++
libavutil/tests/parseutils.c | 5 +
2 files changed, 36 insertions(+)
diff --git a/libavutil/parseutils.c b/libavutil/parseutils.c
index 86d3dac..a273216 100644
--- a/libavutil/parseutils.c
+++ b/libavutil/parseutils.c
@@
Hello,
In preparation for evaluating cookie expiry values, av_small_strptime needs to
handle the month names. This patch adds said names (full and abbreviated).
Thanks in advance,
Micah
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmp
On Sun, Feb 12, 2017 at 6:28 AM, Nicolas George wrote:
> Thanks for the patch. See remarks below.
>
> Le tridi 23 pluviôse, an CCXXV, Micah Galizia a écrit :
>> On some authenticated Neulion streams, they send a cookie from the past,
>> like so:
>>
>> Set-Cookie
---
libavformat/http.c | 36 +++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index 944a6cf..24368aa 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -682,12 +682,46 @@ static int parse_icy(HTTPCon
This one fixes the memory leak -- sorry for all the spam.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Signed-off-by: Micah Galizia
---
libavformat/http.c | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/libavformat/http.c b/libavformat/http.c
index 944a6cf..e7b8ac3 100644
--- a/libavformat/http.c
+++ b/libavformat/http.c
@@ -682,12 +682,44
Appologies, gmail screwed up the patch.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
k of an immature man is that he wants to die nobly for a cause,
while the mark of the mature man is that he wants to live humbly for
one." --W. Stekel
From 1fecda5a7a36b530208a9428b86eebda66b0 Mon Sep 17 00:00:00 2001
From: Micah Galizia
Date: Sat, 11 Feb 2017 21:18:41 -0500
Subjec
On Tue, Aug 25, 2015 at 10:08 PM, Lucas Andrade wrote:
> I'm trying to run a HLS Live Stream on Kodi and I'm getting an error 403
> after 5 minutes. Checking the wireshark capture I did realize that the
> ffmpeg requests aren't changing a cookie that is set on every response.
>
> Do you guys confi
I've been watching an encrypted stream for the past 20 minutes and
everything seems to be working fine.
On Thu, Jul 30, 2015 at 1:10 PM, Michael Niedermayer
wrote:
> On Thu, Jul 30, 2015 at 12:39:53PM -0400, Micah Galizia wrote:
>> Cookies and user agent stuff all look the same to
Cookies and user agent stuff all look the same to me (I'll test with
an encrypted stream this weekend).
Also, its cool that he added renditions.
On Thu, Jul 30, 2015 at 12:14 PM, Michael Niedermayer
wrote:
> Hi all
>
> luca has reimplemented some of the option handling in hls like
> cookies and
tekel
From 629e9028f40cbf6f54c4b481a274aea5219d7c10 Mon Sep 17 00:00:00 2001
From: Micah Galizia
Date: Tue, 17 Mar 2015 20:22:59 +1100
Subject: [PATCH 3/3] avformat/http: replace cookies with updated values
instead of appending forever
Signed-off-by: Michael Niedermayer
(cherry picked f
2001
From: Micah Galizia
Date: Mon, 16 Mar 2015 20:26:29 +1100
Subject: [PATCH 2/3] avformat/hls: refactor repeated HLS option updates
Signed-off-by: Michael Niedermayer
(cherry picked from commit fca085187940a169b7a43d096009f7dac315f9ac)
Signed-off-by: Micah Galizia
---
libavformat/
2001
From: Micah Galizia
Date: Sun, 15 Mar 2015 09:31:59 +1100
Subject: [PATCH 1/3] avformat/hls: store cookies returned in HLS key response
Signed-off-by: Michael Niedermayer
(cherry picked from commit 7859618affe574c9de7f240d2ddc016f917c37bd)
Signed-off-by: Micah Galizia
---
libavformat
nts to die nobly for a
cause, while the mark of the mature man is that he wants to live
humbly for one." --W. Stekel
From dec8b5b1033c63906e7b1e783bd50a2be287d8d5 Mon Sep 17 00:00:00 2001
From: Micah Galizia
Date: Thu, 26 Mar 2015 20:16:34 +1100
Subject: [PATCH] backport hls a
Hi,
I had some code accepted on the master branch and I was wondering if
they'd be suitable for inclusion in the 2.6 branch. I'd like them in
the next version of xmbc. The commits were:
c59654d67d1afde3fac24021ef0fd9d18cf38455
fca085187940a169b7a43d096009f7dac315f9ac
7859618affe574c9de7f240d2ddc0
805d6b89eb96af371de94 Mon Sep 17 00:00:00 2001
From: Micah Galizia
Date: Tue, 17 Mar 2015 20:22:59 +1100
Subject: [PATCH 3/3] replace cookies with updated values instead of appending
forever
---
libavformat/http.c | 65 +++---
1 file changed, 52 in
Excellent. Thank you!
On Mon, Mar 16, 2015 at 11:02 PM, Michael Niedermayer wrote:
> On Mon, Mar 16, 2015 at 08:34:24PM +1100, Micah Galizia wrote:
>> Hi,
>>
>> Attached patch puts repeated code into a function.
>>
>> TIA
>> --
>> "The mark of a
00:00 2001
From: Micah Galizia
Date: Mon, 16 Mar 2015 20:26:29 +1100
Subject: [PATCH 2/2] refactor repeated HLS option updates
---
libavformat/hls.c | 28
1 file changed, 12 insertions(+), 16 deletions(-)
diff --git a/libavformat/hls.c b/libavformat/hls.c
index 5ed7a2
Excellent, thank you -- patch to refactor that repeated
free/opt_get/free code (it happens four times) will be submitted
shortly...
On Mon, Mar 16, 2015 at 12:00 PM, Michael Niedermayer wrote:
> On Sun, Mar 15, 2015 at 10:00:38AM +1100, Micah Galizia wrote:
>> Hello,
>>
>>
while the mark of the mature man is that he wants to live
humbly for one." --W. Stekel
From 7f2db07b91407a970b99655da96c8c2532e2c1ad Mon Sep 17 00:00:00 2001
From: Micah Galizia
Date: Sun, 15 Mar 2015 09:31:59 +1100
Subject: [PATCH] store cookies returned in HLS key response
---
libavf
On 18/08/14 21:36, Nicolas George wrote:
Le primidi 1er fructidor, an CCXXII, Micah Galizia a écrit :
Yes & no. I agree its not an ideal implementation (it actually was
mine to begin with) to just use a string full of cookies. But we can't
pass around complex structures through avopts,
On Sun, Aug 17, 2014 at 9:29 PM, Nicolas George wrote:
> Le decadi 30 thermidor, an CCXXII, Micah Galizia a écrit :
>> When new cookie values (with the same name as an existing cookie) are
>> returned in an HLS stream, the current implementation will append the
>> new
cases.
The patch attached resolves the issue.
--
"The mark of an immature man is that he wants to die nobly for a
cause, while the mark of the mature man is that he wants to live
humbly for one." --W. Stekel
From ad65b070a7b49698e623f08365ec7e751d0bae08 Mon Sep 17 00:00:00 2001
F
78 matches
Mail list logo
