Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

2018-04-09 Thread Mattias Amnefelt
On 2018-04-05 01:00, Mattias Amnefelt wrote: On 2018-04-04 09:22, Mattias Amnefelt wrote: On 2018-04-04 03:42, James Almer wrote: On 4/3/2018 10:40 PM, Carl Eugen Hoyos wrote: 2018-04-04 3:38 GMT+02:00, James Almer : On 4/3/2018 10:33 PM, Carl Eugen Hoyos wrote: The "-f aac" lo

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

2018-04-04 Thread Mattias Amnefelt
On 2018-04-04 09:22, Mattias Amnefelt wrote: On 2018-04-04 03:42, James Almer wrote: On 4/3/2018 10:40 PM, Carl Eugen Hoyos wrote: 2018-04-04 3:38 GMT+02:00, James Almer : On 4/3/2018 10:33 PM, Carl Eugen Hoyos wrote: The "-f aac" looks like a bad idea to me. It's also tru

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

2018-04-04 Thread Mattias Amnefelt
On 2018-04-04 03:42, James Almer wrote: On 4/3/2018 10:40 PM, Carl Eugen Hoyos wrote: 2018-04-04 3:38 GMT+02:00, James Almer : On 4/3/2018 10:33 PM, Carl Eugen Hoyos wrote: 2018-04-03 7:58 GMT+02:00, Mattias Amnefelt : Yes, my feeling was also that it's better to handle this when pos

Re: [FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

2018-04-02 Thread Mattias Amnefelt
y the test passes. In order to exercise your code change, the ID3v2 tags would have to be between ADTS frames. -Richard On Mon, Apr 2, 2018 at 4:35 AM, Mattias Amnefelt wrote: This is a follow-up to https://patchwork.ffmpeg.org/patch/7477/ and changes so all ID3 tags between ADTS frames gets p

[FFmpeg-devel] [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames

2018-04-02 Thread Mattias Amnefelt
2f681aa27c216a1aa8d8f2b643289dbf087de306 Mon Sep 17 00:00:00 2001 From: Mattias Amnefelt Date: Mon, 2 Apr 2018 11:30:40 +0200 Subject: [PATCH] libavformat/aac: Parse all ID3 tags present between ADTS frames Some ADTS streams can have multiple ID3 tags between frames. This change parses all of them, rather than just the first