[FFmpeg-devel] [PATCH v3] drawtext: Add basic text shaping using libfribidi - Fixes ticket #3758

2014-07-12 Thread Marc Jeffreys
Regarding positioning of the '|' operator: Unless anyone objects, I think it's fine being at the end of the line (if anything, that's the style used for '||' in vf_drawtext.c). ---8<--- --- configure |3 + doc/filters.texi | 11 libavfilter/vf_drawtext.c | 12

[FFmpeg-devel] [PATCH v2] drawtext: Add basic text shaping using libfribidi - Fixes ticket #3758

2014-07-10 Thread Marc Jeffreys
Changes since last time: I've made the changes to configure, and squashed the patches together. Option changed from fribidi=1 (default 0) to text_shaping=1 (default 1). (Ideas for better names are definitely welcome.) Hopefully I've made the documentation more understandable. No longer testing for

Re: [FFmpeg-devel] [PATCH 2/2] drawtext: Use libfribidi to correctly render Arabic text - Fixes ticket #3758

2014-07-09 Thread Marc Jeffreys
Date: Wed, 9 Jul 2014 18:31:22 +0200 From: geo...@nsup.org To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH 2/2] drawtext: Use libfribidi to correctly render Arabic text - Fixes ticket #3758 > Do you have any idea about what it could break? IMHO, if ffmpeg is capable > of correctl

[FFmpeg-devel] [PATCH 2/2] drawtext: Use libfribidi to correctly render Arabic text - Fixes ticket #3758

2014-07-09 Thread Marc Jeffreys
I've added this as a "fribidi=1" option to drawtext rather than enabling it by default, so as not to break anything. Difference can be seen by compiling with --enable-libfribidi and comparing: ffplay -loglevel debug -f lavfi -i "color=color=white,drawtext=fontfile=/usr/share/fonts/dejavu/DejaVu

[FFmpeg-devel] [PATCH 1/2] Add libfribidi support to configure script

2014-07-09 Thread Marc Jeffreys
--- configure | 22 ++ 1 file changed, 22 insertions(+) diff --git a/configure b/configure index e20bf8e..cb7d392 100755 --- a/configure +++ b/configure @@ -209,6 +209,7 @@ External library support: --enable-libfdk-aac enable AAC de/encoding via libfdk-aac [no] --en