Re: [FFmpeg-devel] [PATCH v4 0/4] add ARIB caption decoder using libaribcaption

2022-07-01 Thread Mao Hata
1280x720 osaka_15.mp4 The bitmap feature is a cool one. Its output quality is the same as the subtitles I usually watch on Japanese TV devices. I tested the feature with many personal files, no particular problem found. Mao Hata On 2022/06/24 19:06, TADANO Tokumei wrote: 3rd ping! Are ther

Re: [FFmpeg-devel] [PATCH v3 3/3] avformat/mpegtsenc: Write stream_id into PES after stream_id decision

2021-04-24 Thread Mao Hata
YPE_DATA, unless additionally conditioned by "st->codecpar->codec_id" parameter, basically, the "stream_id" value given as an argument is written to PES packets as it is. In this case, the behavior of the function should be fixed as you commented. v3 patch looks go

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-22 Thread Mao Hata
On 2021/04/22 12:36, zheng qian wrote: On Thu, Apr 22, 2021 at 12:11 PM Mao Hata wrote: PES_packet_length seems to be inaccurate, because "header_len + 3" has already been added to the variable "len". I'm sorry for that and I'll submit v3 patch set later.

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-21 Thread Mao Hata
On 2021/04/20 13:44, zheng qian wrote: Changes since v1: Separate if-statement and cosmetic changes into different commits According to the PES packet definition defined in Table 2-17 of ISO_IEC_13818-1 specification, some fields like PTS/DTS or pes_extension could only appears if the stream_

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: private_stream_1 is not asynchronous KLV

2021-04-19 Thread Mao Hata
On 2021/04/20 1:36, zheng qian wrote: I'm working on ARIB related patches for mpegtsenc.c and later I would like to provide a patch to fix the bug of private_stream_2. In current situation, mpegts_write_pes() incorrectly writes private_stream_2 with actually a private_stream_1-like PES header th

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: private_stream_1 is not asynchronous KLV

2021-04-19 Thread Mao Hata
On 2021/04/19 5:25, Marton Balint wrote: On Sat, 17 Apr 2021, Mao Hata wrote: According to ISO/IEC 13818-1, private_stream_1 is a synchronous (has PTS/DTS) stream. Asynchronous one is private_stream_2. Which section describes this? Also keep in mind that code was added so that

[FFmpeg-devel] [PATCH] avformat/mpegtsenc: private_stream_1 is not asynchronous KLV

2021-04-17 Thread Mao Hata
According to ISO/IEC 13818-1, private_stream_1 is a synchronous (has PTS/DTS) stream. Asynchronous one is private_stream_2. From c1663cbdbbd2178cb199e079ec9bb712d1d757d8 Mon Sep 17 00:00:00 2001 From: Mao Hata Date: Sat, 17 Apr 2021 19:55:22 +0900 Subject: [PATCH] avformat/mpegtsenc