Re: [FFmpeg-devel] [PATCH] Add picture attachment support to OGG Muxer

2020-06-08 Thread LRFLEW
>seems to break fate Ok, I spent some time looking into what's happening, and I've figured what's causing the failures. The issue isn't that it's producing *invalid* output, but that it's just *different* output. As I had said, I wrote this patch some time ago, so I had forgotten a decision I

Re: [FFmpeg-devel] [PATCH] Add picture attachment support to OGG Muxer

2020-06-07 Thread LRFLEW
>$ make SAMPLES=fate-suite fate-rsync >$ make SAMPLES=fate-suite fate That explains it. The "Contribute" documentation just says "make fate", so I didn't realize I wasn't running the entire suite. I re-ran the tests, and saw a different test fail, being lavf-fate-vp3.ogg. Looking at the hex data

Re: [FFmpeg-devel] [PATCH] Add picture attachment support to OGG Muxer

2020-06-07 Thread LRFLEW
>seems to break fate >--- ./tests/ref/fate/limited_input_seek-copyts    2020-05-28 >14:46:23.971547831 +0200 >+++ tests/data/fate/limited_input_seek-copyts    2020-06-07 22:10:38.303050886 >+0200 >@@ -1 +1 @@ >-ffe8a674bdf38e4f650f91963debc654 >+aae5603508b268cbb456b633b84a48af >Test limited_inp