Re: [FFmpeg-devel] [PATCH v2] avformat/rtsp: introduce get_sa_len() function

2016-11-24 Thread Kevin Lo
On Thu, Nov 24, 2016 at 10:48:38PM -0800, Dave Yeo wrote: > > On 11/24/16 07:47 PM, Kevin Lo wrote: > > Since the Linux implementation of sockaddr doesn't have sa_len as a member, > > but the FreeBSD version does, introduce a get_sa_len() function that > > determines

[FFmpeg-devel] [PATCH v3] avformat/rtsp: introduce get_sa_len() function

2016-11-24 Thread Kevin Lo
Since the Linux implementation of sockaddr doesn't have sa_len as a member, but the FreeBSD version does, introduce a get_sa_len() function that determines the size based on the address family. Signed-off-by: Kevin Lo --- v3: Check for the right feature when using a sockaddr_in6. Some sy

[FFmpeg-devel] [PATCH v2] avformat/rtsp: introduce get_sa_len() function

2016-11-24 Thread Kevin Lo
Since the Linux implementation of sockaddr doesn't have sa_len as a member, but the FreeBSD version does, introduce a get_sa_len() function that determines the size based on the address family. Signed-off-by: Kevin Lo --- diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index c6

[FFmpeg-devel] [PATCH] avformat/rtsp: introduce get_sa_len() function

2016-11-24 Thread Kevin Lo
Since the Linux implementation of sockaddr doesn't have sa_len as a member, but the FreeBSD version does, introduce a get_sa_len() function that determines the size based on the address family. Signed-off-by: Kevin Lo --- diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index c6

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: fix getnameinfo() call on FreeBSD

2016-11-24 Thread Kevin Lo
On Fri, Nov 25, 2016 at 07:13:50AM +0800, Kevin Lo wrote: > > On Thu, Nov 24, 2016 at 04:12:41PM +0100, Nicolas George wrote: > > Le quartidi 4 frimaire, an CCXXV, Kevin Lo a écrit : > > > FreeBSD's socket calls require the sockaddr struct length to agree > > >

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: fix getnameinfo() call on FreeBSD

2016-11-24 Thread Kevin Lo
On Thu, Nov 24, 2016 at 04:12:41PM +0100, Nicolas George wrote: > Le quartidi 4 frimaire, an CCXXV, Kevin Lo a écrit : > > FreeBSD's socket calls require the sockaddr struct length to agree > > with the address family, Linux does not. This patch fixes a failing > > get

[FFmpeg-devel] [PATCH] avformat/rtsp: fix getnameinfo() call on FreeBSD

2016-11-24 Thread Kevin Lo
FreeBSD's socket calls require the sockaddr struct length to agree with the address family, Linux does not. This patch fixes a failing getnameinfo() call on FreeBSD. Signed-off-by: Kevin Lo --- diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index c6292c5..15fe25d 100644 --- a/libavf