Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Kacper Michajlow
On Wed, 30 Jul 2025 at 21:53, Nicolas George wrote: > > Niklas Haas (HE12025-07-30): > > I disagree. Without this important context, the motivation behind the > > change is much less clear. > > It is not context, it is a dump of an exchange of mails that led to the > patch. It should have been rew

Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"

2025-07-30 Thread Kacper Michajlow
On Wed, 30 Jul 2025 at 19:53, Nicolas George wrote: > > Kacper Michajłow (HE12025-07-30): > > > Note that BIO_get_new_index() can only be used 127 times before it > > > returns an error. > > > > We cannot call it repeatedly, because it will fail eventually. > > > > To my understanding the index is

Re: [FFmpeg-devel] [PATCH] avformat/subfile: clip seek offset

2025-07-29 Thread Kacper Michajlow
On Tue, 29 Jul 2025 at 22:59, Nicolas George wrote: > > Alexander Strasser via ffmpeg-devel (HE12025-07-29): > > You are looking at the overview with latest events for that PR. > > > > To see the the individual commits select > > that view at the top. Or if you want to see > > the combined diff, c

Re: [FFmpeg-devel] [IMPORTANT] AI written TLS Code in WHIP patch

2025-07-29 Thread Kacper Michajlow
On Tue, 29 Jul 2025 at 22:11, James Almer wrote: > > On 7/29/2025 5:02 PM, Kieran Kunhya via ffmpeg-devel wrote: > > Hello, > > > > It seem there is strong evidence that AI wrote TLS code as part of the > > WHIP patch. It goes without saying why this is bad. Further discussion > > here: > > https:

Re: [FFmpeg-devel] [PATCH v3] avformat/avisynth: fix segfault when also compiled with libvmaf

2025-07-27 Thread Kacper Michajlow
On Mon, 28 Jul 2025 at 02:04, Daniel Bermond wrote: > > When FFmpeg is compiled with support for both avisynth and libvmaf, > a segmentation fault occurs when using avisynth (.avs) input. > > This happens because both avisynthplus and vmaf have the exactly > same C++ symbol 'Cache::~Cache()'[1][2]

Re: [FFmpeg-devel] [PATCH] avformat/asfdec_f: Check amount of value read

2025-07-27 Thread Kacper Michajlow
On Sun, 27 Jul 2025 at 22:57, Michael Niedermayer wrote: > > On Wed, Jul 23, 2025 at 05:51:35PM +0200, Kacper Michajlow wrote: > > On Wed, 23 Jul 2025 at 10:43, Michael Niedermayer > > wrote: > > > > > > Fixes: use of uninitialized memory > > >

Re: [FFmpeg-devel] [PATCH] web: announce code.ffmpeg.org

2025-07-27 Thread Kacper Michajlow
On Sun, 27 Jul 2025 at 11:39, Nicolas George wrote: > > Kacper Michajlow (HE12025-07-26): > > I don't think moving over is something that requires significant > > effort. It just needs clear communication about this. > > > > Also, I don't think the curr

Re: [FFmpeg-devel] [PATCH] web: announce code.ffmpeg.org

2025-07-26 Thread Kacper Michajlow
On Sat, 26 Jul 2025 at 22:42, Timo Rothenpieler wrote: > > On 7/26/2025 10:24 PM, Kacper Michajlow wrote: > > On Sat, 26 Jul 2025 at 22:14, Timo Rothenpieler > > wrote: > >> > >> On 7/26/2025 10:01 PM, Derek Buitenhuis wrote: > >>> On 7/26/20

Re: [FFmpeg-devel] [PATCH] web: announce code.ffmpeg.org

2025-07-26 Thread Kacper Michajlow
On Sat, 26 Jul 2025 at 22:23, Timo Rothenpieler wrote: > > On 7/26/2025 10:14 PM, Kacper Michajlow wrote: > > n Sat, 26 Jul 2025 at 21:29, Timo Rothenpieler > > wrote: > >> > >> On 7/26/2025 7:03 PM, Derek Buitenhuis wrote: > >>> On 7/22/202

Re: [FFmpeg-devel] [PATCH] web: announce code.ffmpeg.org

2025-07-26 Thread Kacper Michajlow
On Sat, 26 Jul 2025 at 22:14, Timo Rothenpieler wrote: > > On 7/26/2025 10:01 PM, Derek Buitenhuis wrote: > > On 7/26/2025 8:29 PM, Timo Rothenpieler wrote: > >> It's still an extended test. You cannot push to it, since it's just a > >> mirror. > > > > That's not what written in the announcement,

Re: [FFmpeg-devel] [PATCH] web: announce code.ffmpeg.org

2025-07-26 Thread Kacper Michajlow
n Sat, 26 Jul 2025 at 21:29, Timo Rothenpieler wrote: > > On 7/26/2025 7:03 PM, Derek Buitenhuis wrote: > > On 7/22/2025 4:53 AM, Lynne wrote: > >> --- > >> src/contact | 11 +++ > >> src/index | 52 > >> 2 files changed, 63 insert

Re: [FFmpeg-devel] [PATCH 01/10] avformat/os_support: check invalid socket value correctly on Windows

2025-07-25 Thread Kacper Michajlow
On Tue, 22 Jul 2025 at 21:16, Kacper Michajłow wrote: > > SOCKET defined in winsock2.h is unsigned and invalid value is defined as > INVALID_SOCKET. Check this explicity to avoid compiler warnings. > > See: > https://learn.microsoft.com/en-us/windows/win32/winsock/socket-data-type-2 > Signed-off-

Re: [FFmpeg-devel] [FFFjo] Re: [FFmpeg/FFmpeg] forgejo/workflows: generate coverage report (PR #20027)

2025-07-23 Thread Kacper Michajlow
On Thu, 24 Jul 2025 at 03:39, kasper93 wrote: > > *kasper93* force-pushed the *cov_report* from *d1d6603b3b* ( > https://code.ffmpeg.org/FFmpeg/FFmpeg/commit/d1d6603b3bdd98270cbac44c5384f575879c17c7 > ) to *ef39d2d144* ( > https://code.ffmpeg.org/FFmpeg/FFmpeg/commit/ef39d2d144658a1fb37ea0fc2cc

Re: [FFmpeg-devel] [PATCH v2 10/18] avcodec/jpegxl: parse and signal correct alpha mode

2025-07-23 Thread Kacper Michajlow
On Wed, 23 Jul 2025 at 15:57, Niklas Haas wrote: > > From: Niklas Haas > > This header bit ("alpha_associated") was incorrectly ignored. > --- > libavcodec/jpegxl_parse.c | 7 +-- > libavcodec/jpegxl_parse.h | 1 + > libavcodec/jpegxl_parser.c | 5 + > 3 files changed, 11 insertions(+)

Re: [FFmpeg-devel] [PATCH v2 03/18] avfilter/vf_showinfo: print alpha mode when relevant

2025-07-23 Thread Kacper Michajlow
On Wed, 23 Jul 2025 at 15:57, Niklas Haas wrote: > > From: Niklas Haas > > --- > libavfilter/vf_showinfo.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c > index c706d00c96..b564d03a84 100644 > --- a/libavfilter/vf_showinfo.

Re: [FFmpeg-devel] [PATCH v2 01/18] avutil/frame: add AVFrame.alpha_mode

2025-07-23 Thread Kacper Michajlow
On Wed, 23 Jul 2025 at 15:56, Niklas Haas wrote: > > From: Niklas Haas > > FFmpeg currently handles alpha in a quasi-arbitrary way. Some filters/codecs > assume alpha is premultiplied, others assume it is independent. If there is > to be any hope for order in this chaos, we need to start by defin

Re: [FFmpeg-devel] [PATCH] avformat/asfdec_f: Check amount of value read

2025-07-23 Thread Kacper Michajlow
On Wed, 23 Jul 2025 at 10:43, Michael Niedermayer wrote: > > Fixes: use of uninitialized memory > Fixes: > 403675492/clusterfuzz-testcase-minimized-ffmpeg_dem_ASF_fuzzer-4754281823797248 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > S

Re: [FFmpeg-devel] [PATCH 08/10] avcodec/x86/fdct: guard usage of undefined functions with preprocessor

2025-07-22 Thread Kacper Michajlow
On Tue, 22 Jul 2025 at 21:16, Kacper Michajłow wrote: > > The asumption is that DCE will remove references to those functions. > However some compilers with certain instrumentation enabled doesn't DCE > those at all, resulting in linking failure. Tested with cl.exe -RTCu -RTCs. > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avcodec/opus/silk: don't assume stereo when calling silk_decode_frame()

2025-07-22 Thread Kacper Michajlow
On Tue, 22 Jul 2025 at 18:25, James Almer wrote: > > Fixes use-of-uninitialized-value under MSAN. > > Signed-off-by: James Almer > --- > libavcodec/opus/silk.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/opus/silk.c b/libavcodec/opus/silk.c > index 9

Re: [FFmpeg-devel] [POLL] [VOTE] code.ffmpeg.org

2025-07-22 Thread Kacper Michajlow
On Tue, 22 Jul 2025 at 10:46, Hendrik Leppkes wrote: > > On Tue, Jul 22, 2025 at 9:13 AM Nicolas George wrote: > > > > Hendrik Leppkes (HE12025-07-22): > > > Can we work towards enabling merging? > > > > We refused merging with pure Git not for technical reasons. Has this > > changed? > > > > Mer

Re: [FFmpeg-devel] [PATCH] web: announce code.ffmpeg.org

2025-07-22 Thread Kacper Michajlow
On Tue, 22 Jul 2025 at 05:54, Lynne wrote: > > --- > src/contact | 11 +++ > src/index | 52 > 2 files changed, 63 insertions(+) > > diff --git a/src/contact b/src/contact > index 6943d06..8a59864 100644 > --- a/src/contact > +++ b/sr

Re: [FFmpeg-devel] [PATCH 1/3] avutil/xga_font_data: add getters to access the shared arrays

2025-07-21 Thread Kacper Michajlow
On Tue, 22 Jul 2025 at 04:45, Kacper Michajlow wrote: > > On Tue, 22 Jul 2025 at 02:47, James Almer wrote: > > > > And stop exposing the arrays on the next major bump. > > > > Signed-off-by: James Almer > > --- > > libavutil/xga_font_data.c | 16 +

Re: [FFmpeg-devel] [PATCH 1/3] avutil/xga_font_data: add getters to access the shared arrays

2025-07-21 Thread Kacper Michajlow
On Tue, 22 Jul 2025 at 02:47, James Almer wrote: > > And stop exposing the arrays on the next major bump. > > Signed-off-by: James Almer > --- > libavutil/xga_font_data.c | 16 > libavutil/xga_font_data.h | 6 ++ > 2 files changed, 22 insertions(+) > > diff --git a/libavuti

Re: [FFmpeg-devel] [PATCH] forgejo/workflows: add initial rudimentary CI

2025-07-21 Thread Kacper Michajlow
On Tue, 22 Jul 2025 at 00:40, Scott Theisen wrote: > On 2025/07/21 18:17, Michael Niedermayer wrote: > > On Mon, Jul 21, 2025 at 06:37:06PM +0200, Timo Rothenpieler wrote: > >> It runs basic fate with no special dependencies enabled on x86_64 and > >> aarch64. > >> --- > >> .forgejo/workflows/t

Re: [FFmpeg-devel] [PATCH] configure: filter link flags separately for MSVC

2025-07-20 Thread Kacper Michajlow
On Sun, 20 Jul 2025 at 19:23, Kacper Michajłow wrote: > This avoids adding flags that cl.exe doesn't understand. > > Signed-off-by: Kacper Michajłow > --- > configure | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index ed6430ea32..8

Re: [FFmpeg-devel] [PATCH v5 1/2] avfilter: add scale_d3d11 filter

2025-07-20 Thread Kacper Michajlow
On Sun, 20 Jul 2025 at 11:52, Hendrik Leppkes wrote: > On Sun, Jul 20, 2025 at 11:15 AM Dash Santosh Sathyanarayanan > wrote: > > > > Regarding the while loop in hwcontext_d3d11va get_buffer, I understand > > the concern about introducing an unbounded wait. However, there have been > > a couple

Re: [FFmpeg-devel] [PATCH] avformat/subfile: clip seek offset

2025-07-20 Thread Kacper Michajlow
On Fri, 11 Jul 2025 at 21:49, Kacper Michajłow wrote: > Fixes: signed integer overflow: 9223372036854737920 + 1649410 cannot be > represented in type 'int64_t' > > Fixes OSS-Fuzz: 410100610 > > Signed-off-by: Kacper Michajłow > --- > libavformat/subfile.c | 6 +++--- > 1 file changed, 3 inserti

Re: [FFmpeg-devel] [PATCH v2] avutil/avstring: shrink allocation from av_get_token to fit token

2025-07-20 Thread Kacper Michajlow
On Fri, 4 Jul 2025 at 20:52, Kacper Michajłow wrote: > av_get_token() allocates an output buffer with the same size as the > input. Generally, this is harmless, but when the input string is large > and consists of many small tokens, calling av_get_token() repeatedly to > extract all tokens will s

Re: [FFmpeg-devel] [PATCH] avfilter: add inverse tone mapping

2025-07-19 Thread Kacper Michajlow
On Sat, 19 Jul 2025 at 16:13, Sarthak Indurkhya via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > Hello FFmpeg developers, > This patch introduces a new video filter called inversetonemap for FFmpeg. > The filter performs SDR to HDR conversion by mapping SDR BT.709 video to > HDR BT.2020 PQ, us

Re: [FFmpeg-devel] [PATCH] avcodec/motion_est: don't add offsets to NULL pointers

2025-07-19 Thread Kacper Michajlow
On Sat, 19 Jul 2025 at 02:27, James Almer wrote: > On 7/18/2025 8:01 PM, Michael Niedermayer wrote: > > On Tue, Jul 15, 2025 at 10:33:10AM -0300, James Almer wrote: > >> Fixes: libavcodec/motion_est.c:94:31: runtime error: applying zero > offset to null pointer > >> Signed-off-by: James Almer >

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/sonic: remove dead code

2025-07-18 Thread Kacper Michajlow
On Fri, 18 Jul 2025 at 20:07, Michael Niedermayer wrote: > On Thu, Jul 17, 2025 at 01:57:03AM +0200, Kacper Michajłow wrote: > > This was in else branch of `#if 1` since ever. No need to keep dead code > > like that, if anyone needs it they can get it from git history. > > > > Signed-off-by: Kacp

Re: [FFmpeg-devel] [PATCH v2 1/5] configure: allow multiple sanitizers in --toolchain

2025-07-18 Thread Kacper Michajlow
On Fri, 18 Jul 2025 at 18:53, Michael Niedermayer wrote: > On Fri, Jul 18, 2025 at 06:49:24PM +0200, Kacper Michajlow wrote: > > On Fri, 18 Jul 2025 at 18:28, Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > > > On Thu, Jul 17, 2025 at 0

Re: [FFmpeg-devel] [PATCH v2 1/5] configure: allow multiple sanitizers in --toolchain

2025-07-18 Thread Kacper Michajlow
On Fri, 18 Jul 2025 at 18:28, Michael Niedermayer wrote: > On Thu, Jul 17, 2025 at 04:04:38AM +0200, Kacper Michajłow wrote: > > For example this allows --toolchain=clang-asan-usan. > > > > Signed-off-by: Kacper Michajłow > > --- > > configure | 13 +++-- > > 1 file changed, 11 insertio

Re: [FFmpeg-devel] [PATCH v5] gcc: Don't disable '-ftree-vectorize' if gcc version higher than 13.

2025-07-18 Thread Kacper Michajlow
On Fri, 11 Jul 2025 at 23:41, Michael Niedermayer wrote: > > Hi Martin > > On Thu, Jul 10, 2025 at 02:35:10PM +0300, Martin Storsjö wrote: > > On Thu, 10 Jul 2025, Jiawei wrote: > > > > > Hi Martin, > > > > > > Is there any progress for this patch, should I resend it to the mailing > > > list agai

Re: [FFmpeg-devel] [PATCH v3 1/3] avfilter/vf_colordetect: add new color range detection filter

2025-07-18 Thread Kacper Michajlow
On Fri, 18 Jul 2025 at 14:47, Niklas Haas wrote: > > On Fri, 18 Jul 2025 14:38:04 +0200 Kacper Michajlow wrote: > > > +static inline int ff_detect_range_c(const uint8_t *data, ptrdiff_t stride, > > > +ptrdiff_t

Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_blackdetect: add AVX2 SIMD version

2025-07-18 Thread Kacper Michajlow
On Fri, 18 Jul 2025 at 15:33, Kieran Kunhya via ffmpeg-devel wrote: > > On Fri, Jul 18, 2025 at 2:22 PM Kacper Michajlow wrote: > > > > On Fri, 18 Jul 2025 at 14:46, Kieran Kunhya via ffmpeg-devel > > wrote: > > > > > > On Fri, Jul 18, 2025

Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_blackdetect: add AVX2 SIMD version

2025-07-18 Thread Kacper Michajlow
On Fri, 18 Jul 2025 at 14:46, Kieran Kunhya via ffmpeg-devel wrote: > > On Fri, Jul 18, 2025 at 1:41 PM Kacper Michajlow wrote: > > > > On Fri, 18 Jul 2025 at 14:14, Kieran Kunhya via ffmpeg-devel > > wrote: > > > > > > > blackdetect8_c:

Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_blackdetect: add AVX2 SIMD version

2025-07-18 Thread Kacper Michajlow
On Fri, 18 Jul 2025 at 14:14, Kieran Kunhya via ffmpeg-devel wrote: > > > blackdetect8_c:820.8 ( 1.00x) > > blackdetect8_avx2: 219.2 ( 3.74x) > > blackdetect16_c: 372.8 ( 1.00x) > > bl

Re: [FFmpeg-devel] [PATCH v3 1/3] avfilter/vf_colordetect: add new color range detection filter

2025-07-18 Thread Kacper Michajlow
On Fri, 18 Jul 2025 at 11:57, Niklas Haas wrote: > > From: Niklas Haas > > This filter can detect various properties about the image, including > whether or not there are out-of-range values, or whether the input appears > to use straight or premultiplied alpha. > > Of course, these can only be h

Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_blackdetect: add AVX2 SIMD version

2025-07-18 Thread Kacper Michajlow
On Fri, 18 Jul 2025 at 14:14, Kieran Kunhya via ffmpeg-devel wrote: > > > blackdetect8_c:820.8 ( 1.00x) > > blackdetect8_avx2: 219.2 ( 3.74x) > > blackdetect16_c: 372.8 ( 1.00x) > > bl

Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_blackdetect: add AVX2 SIMD version

2025-07-18 Thread Kacper Michajlow
On Thu, 17 Jul 2025 at 12:45, Niklas Haas wrote: > > From: Niklas Haas > > Requested by a user. Even with autovectorization enabled, the compiler > performs a quite poor job of optimizing this function, due to not being > able to take advantage of the pmaxub + pcmpeqb trick for counting the numbe

Re: [FFmpeg-devel] [PATCH] configure: Update ossfuzz stuff to clang-12+

2025-07-16 Thread Kacper Michajlow
On Wed, 16 Jul 2025 at 15:26, Michael Niedermayer wrote: > > On Wed, Jul 16, 2025 at 11:58:14AM +0200, Kacper Michajlow wrote: > > On Tue, 15 Jul 2025 at 00:24, Michael Niedermayer > > wrote: > > > > > > --- > > > configure | 4 ++-- > &

Re: [FFmpeg-devel] [PATCH v2] configure: add -Wl when linker is called indirectly

2025-07-16 Thread Kacper Michajlow
On Fri, 20 Jun 2025 at 01:52, Kacper Michajłow wrote: > > It's possible to call linker indirectly through driver like Clang. In > which cases linker args has to be prefixed with -Wl. > > Signed-off-by: Kacper Michajłow > --- > configure | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-

Re: [FFmpeg-devel] [PATCH] checkasm/swscale: fix function prototypes

2025-07-16 Thread Kacper Michajlow
On Thu, 3 Jul 2025 at 23:08, Kacper Michajłow wrote: > > This aligns declared function types in checkasm with real definition. > > Fixes FATE: checkasm-{sw_rgb,sw_scale,sw_yuv2rgb,sw_yuv2yuv} > > Fixes: runtime error: call to function through pointer to incorrect > function type > Fixes: c1a0e65

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: add sanity check for frame size

2025-07-16 Thread Kacper Michajlow
On Tue, 15 Jul 2025 at 20:02, Leo Izen wrote: > > If a frame size is absolutely massive, this can spin the parser as it > attempts to decode a permuted TOC. We add a sanity check here for eight > times the size of the image for an internal frame to prevent malicious > bitstreams from slowing the p

Re: [FFmpeg-devel] [POLL] [VOTE] code.ffmpeg.org

2025-07-16 Thread Kacper Michajlow
On Sun, 13 Jul 2025 at 13:44, Michael Niedermayer wrote: > > Hi all > > Do people want Forgejo or Gitlab on code.ffmpeg.org for testing? > > F. code.ffmpeg.org should run Forgejo > G. code.ffmpeg.org should run Gitlab I cannot tell. While Forgejo looks fine on the surface, the devil is in the det

Re: [FFmpeg-devel] [PATCH] configure: Update ossfuzz stuff to clang-12+

2025-07-16 Thread Kacper Michajlow
On Tue, 15 Jul 2025 at 00:24, Michael Niedermayer wrote: > > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index fc082d5467e..e568eed55d3 100755 > --- a/configure > +++ b/configure > @@ -4606,8 +4606,8 @@ set >> $logfile > te

Re: [FFmpeg-devel] [RFC] Introducing policies regarding "AI" contributions

2025-07-05 Thread Kacper Michajlow
On Sat, 5 Jul 2025 at 13:21, Rémi Denis-Courmont wrote: > > Le tiistaina 1. heinäkuuta 2025, 13.58.23 Itä-Euroopan kesäaika Alexander > Strasser via ffmpeg-devel a écrit : > > (...) I want this thread to start a discussion, that eventually leads > > to a policy about submitting and integrating "AI

Re: [FFmpeg-devel] [PATCH] avutil/avstring: shrink allocation from av_get_token to fit token

2025-07-04 Thread Kacper Michajlow
On Fri, 4 Jul 2025 at 20:37, Kacper Michajlow wrote: > > On Fri, 4 Jul 2025 at 20:22, Andreas Rheinhardt > wrote: > > > > Kacper Michajłow: > > > av_get_token() allocates an output buffer with the same size as the > > > input. Generally, this is harml

Re: [FFmpeg-devel] [PATCH] avutil/avstring: shrink allocation from av_get_token to fit token

2025-07-04 Thread Kacper Michajlow
On Fri, 4 Jul 2025 at 20:22, Andreas Rheinhardt wrote: > > Kacper Michajłow: > > av_get_token() allocates an output buffer with the same size as the > > input. Generally, this is harmless, but when the input string is large > > and consists of many small tokens, calling av_get_token() repeatedly t

Re: [FFmpeg-devel] [RFC] Introducing policies regarding "AI" contributions

2025-07-01 Thread Kacper Michajlow
On Tue, 1 Jul 2025 at 12:58, Alexander Strasser via ffmpeg-devel wrote: > > > > > -- Forwarded message -- > From: Alexander Strasser > To: ffmpeg-devel@ffmpeg.org > Cc: > Bcc: > Date: Tue, 1 Jul 2025 12:58:23 +0200 > Subject: [RFC] Introducing policies regarding "AI" contributions

Re: [FFmpeg-devel] [PATCH] avfilter: add inverse tone mapping filter

2025-06-30 Thread Kacper Michajlow
On Mon, 30 Jun 2025 at 11:45, Sarthak Indurkhya via ffmpeg-devel wrote: > > > > > -- Forwarded message -- > From: Sarthak Indurkhya > To: "ffmpeg-devel@ffmpeg.org" > Cc: > Bcc: > Date: Mon, 30 Jun 2025 09:44:54 + > Subject: [PATCH] avfilter: add inverse tone mapping filter >

Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros

2025-06-29 Thread Kacper Michajlow
On Sun, 29 Jun 2025 at 09:05, Rémi Denis-Courmont wrote: > > Le sunnuntai 29. kesäkuuta 2025, 5.44.35 Itä-Euroopan kesäaika Kacper > Michajlow a écrit : > > No, I mean could you elaborate on the challenges why you need 4 nested > > generics that ultimately don't compile

Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros

2025-06-28 Thread Kacper Michajlow
On Sat, 28 Jun 2025 at 20:57, Rémi Denis-Courmont wrote: > > Le lauantaina 28. kesäkuuta 2025, 17.35.17 Itä-Euroopan kesäaika Kacper > Michajlow a écrit : > > On Mon, 2 Jun 2025 at 17:06, Rémi Denis-Courmont wrote: > > > Le 31 mai 2025 20:40:40 GMT+03:00

Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros

2025-06-28 Thread Kacper Michajlow
On Sat, 28 Jun 2025 at 16:35, Kacper Michajlow wrote: > > On Mon, 2 Jun 2025 at 17:06, Rémi Denis-Courmont wrote: > > > > > > > > Le 31 mai 2025 20:40:40 GMT+03:00, Marton Balint a écrit : > > > > > > > > >On Sat, 31 May 2025, Michael N

Re: [FFmpeg-devel] [PATCH 1/2] Replace FFMIN/FFMAX by type specific macros

2025-06-28 Thread Kacper Michajlow
On Mon, 2 Jun 2025 at 17:06, Rémi Denis-Courmont wrote: > > > > Le 31 mai 2025 20:40:40 GMT+03:00, Marton Balint a écrit : > > > > > >On Sat, 31 May 2025, Michael Niedermayer wrote: > > > >> This allows adjusting them to exactly match whatever is fastest on > >> a given CPU for each type. > > > >

Re: [FFmpeg-devel] [FATE PATCH] Properly list test errors when there are no failed tests

2025-06-27 Thread Kacper Michajlow
On Fri, Jun 27, 2025, 14:44 Martin Storsjö wrote: > On Wed, 18 Jun 2025, Michael Niedermayer wrote: > > > Hi Martin > > > > On Fri, Jun 13, 2025 at 01:57:05PM +0300, Martin Storsjö wrote: > >> If there were failures while running tests, e.g. if failing to > >> compile checkasm or any other of the

Re: [FFmpeg-devel] [PATCH v2] configure: add -Wl when linker is called indirectly

2025-06-26 Thread Kacper Michajlow
On Fri, 20 Jun 2025 at 01:52, Kacper Michajłow wrote: > > It's possible to call linker indirectly through driver like Clang. In > which cases linker args has to be prefixed with -Wl. > > Signed-off-by: Kacper Michajłow > --- > configure | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-

Re: [FFmpeg-devel] [PATCH] libavcodec/utils: Ensure allocated buffer is zero-initialized

2025-06-26 Thread Kacper Michajlow
n Thu, 26 Jun 2025 at 16:07, Zhao Zhili wrote: > > > > > On Jun 26, 2025, at 12:07, xjdeng wrote: > > > > In `av_fast_padded_mallocz`, the allocated buffer's zero-initialization is > > not guaranteed. > > This is because it calls `av_fast_malloc`, which in turn calls > > `fast_malloc` with `zer

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/mss2dsp: use FF_PTR_ADD to add offsets to a pointer

2025-06-22 Thread Kacper Michajlow
On Sun, 22 Jun 2025 at 15:54, James Almer wrote: > > Fixes: libavcodec/mss2dsp.c:59:14: runtime error: applying zero offset to > null pointer > > Signed-off-by: James Almer > --- > Untested, as gcc-usan on Linux x86_64 doesn't complain about it, but it can > be seen in > https://fate.ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc_template: use FF_PTR_ADD to add offsets to a pointer

2025-06-22 Thread Kacper Michajlow
On Sun, 22 Jun 2025 at 15:49, James Almer wrote: > > Fixes: libavcodec\ffv1enc_template.c:75:79: runtime error: applying zero > offset to null pointer > Signed-off-by: James Almer > --- > Untested, as gcc-usan on Linux x86_64 doesn't complain about it, but it can > be seen in clang-usan also re

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1enc_template: use FF_PTR_ADD to add offsets to a pointer

2025-06-22 Thread Kacper Michajlow
On Sun, 22 Jun 2025 at 16:50, Kacper Michajlow wrote: > > On Sun, 22 Jun 2025 at 15:49, James Almer > wrote: > > > > Fixes: libavcodec\ffv1enc_template.c:75:79: runtime error: applying zero > > offset to null pointer > > Signed-off-by: James Almer > >

Re: [FFmpeg-devel] [PATCH] configure: Make MSVC version grabbing more robust

2025-06-21 Thread Kacper Michajlow
ubject: Re: [FFmpeg-devel] [PATCH] configure: Make MSVC version grabbing > more robust > Hi Martin! > > On 2025-06-21 13:37 +0300, Martin Storsjö wrote: > > > On 21. Jun 2025, at 12.20, Alexander Strasser via ffmpeg-devel > > > wrote: > > > > > > > >

Re: [FFmpeg-devel] [PATCH] configure: Make MSVC version grabbing more robust

2025-06-21 Thread Kacper Michajlow
On Sat, 21 Jun 2025 at 12:34, Martin Storsjö wrote: > > On Sat, 21 Jun 2025, Kacper Michajlow wrote: > > > On Fri, 20 Jun 2025 at 22:26, Hendrik Leppkes > > wrote: > >> > >> On Fri, Jun 20, 2025 at 9:25 PM Timo Rothenpieler > >> wrote: > &g

Re: [FFmpeg-devel] [PATCH] configure: Make MSVC version grabbing more robust

2025-06-20 Thread Kacper Michajlow
On Fri, 20 Jun 2025 at 22:26, Hendrik Leppkes wrote: > > On Fri, Jun 20, 2025 at 9:25 PM Timo Rothenpieler > wrote: > > > > On 19.06.2025 22:21, Martin Storsjö wrote: > > > On Fri, 13 Jun 2025, Martin Storsjö wrote: > > > > > >> When running plain "cl", to get the MSVC version, it prints the > >

Re: [FFmpeg-devel] graph.{html,css} embed failure on Windows build

2025-06-17 Thread Kacper Michajlow
On Tue, 17 Jun 2025 at 20:54, softworkz . wrote: > > > > -Original Message- > > From: Kacper Michajlow > > Sent: Tuesday, June 17, 2025 6:36 PM > > To: softworkz . > > Cc: FFmpeg development discussions and patches > de...@ffmpeg.org> > >

Re: [FFmpeg-devel] [PATCH v5 3/3] lavc/dxvenc: improve compatibility with Resolume products

2025-06-17 Thread Kacper Michajlow
On Mon, 16 Jun 2025 at 00:25, Emma Worley wrote: > > I wasn't able to repro in a windows 11 arm64 VM. It seems the builds at > fate.ffmpeg.org are also unaffected. I was actually working on adding another build to fate and while at it, I made it run also MSVC, just to cross validate the configur

Re: [FFmpeg-devel] graph.{html,css} embed failure on Windows build

2025-06-17 Thread Kacper Michajlow
On Tue, 17 Jun 2025 at 18:07, softworkz . wrote: > > > > > -Original Message- > > From: Kacper Michajlow > > Sent: Tuesday, June 17, 2025 6:00 PM > > To: softworkz . > > Cc: FFmpeg development discussions and patches > de...@ffmpeg.org> &g

Re: [FFmpeg-devel] graph.{html,css} embed failure on Windows build

2025-06-17 Thread Kacper Michajlow
On Tue, 17 Jun 2025 at 17:29, softworkz . wrote: > > > -Original Message- > > From: ffmpeg-devel On Behalf Of > > softworkz . > > Sent: Tuesday, June 17, 2025 4:13 PM > > To: Kacper Michajlow > > Cc: FFmpeg development discussions and patch

Re: [FFmpeg-devel] graph.{html,css} embed failure on Windows build

2025-06-17 Thread Kacper Michajlow
On Tue, 17 Jun 2025 at 15:10, Kacper Michajlow wrote: > > On Tue, 17 Jun 2025 at 04:07, softworkz . wrote: > > > > > > > -Original Message- > > > From: Kacper Michajlow > > > Sent: Sunday, June 15, 2025 12:49 AM > > > To: FFmpeg dev

Re: [FFmpeg-devel] [PATCH 0/3] tests/fate: Improvements for running FATE on Windows/MSYS2

2025-06-17 Thread Kacper Michajlow
On Tue, 17 Jun 2025 at 03:46, softworkz . wrote: > > > > > -Original Message- > > From: Kacper Michajlow > > Sent: Tuesday, June 17, 2025 3:00 AM > > To: softworkz . > > Cc: FFmpeg development discussions and patches > de...@ffmpeg.org> >

Re: [FFmpeg-devel] graph.{html,css} embed failure on Windows build

2025-06-17 Thread Kacper Michajlow
On Tue, 17 Jun 2025 at 04:07, softworkz . wrote: > > > > -Original Message- > > From: Kacper Michajlow > > Sent: Sunday, June 15, 2025 12:49 AM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Cc: softwo...@hotma

Re: [FFmpeg-devel] [PATCH 0/3] tests/fate: Improvements for running FATE on Windows/MSYS2

2025-06-16 Thread Kacper Michajlow
On Tue, 17 Jun 2025 at 01:05, softworkz . wrote: > > > > > -Original Message- > > From: Kacper Michajlow > > Sent: Tuesday, June 17, 2025 12:44 AM > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Cc: softworkz >

Re: [FFmpeg-devel] [PATCH 0/3] tests/fate: Improvements for running FATE on Windows/MSYS2

2025-06-16 Thread Kacper Michajlow
On Mon, 12 May 2025 at 12:00, ffmpegagent wrote: > > When setting up the new Patchword builders I noticed some issues when > running FATE tests on Windows. Initially I had them suppressed on the > builders, but this patchset should finally fix it. > > softworkz (3): > tests/fate: Fix subtitle fa

Re: [FFmpeg-devel] [PATCH] configure: fix Microsoft tools detection

2025-06-16 Thread Kacper Michajlow
On Mon, 16 Jun 2025 at 09:40, Martin Storsjö wrote: > > On Sat, 14 Jun 2025, Kacper Michajlow wrote: > > > On Sat, 14 Jun 2025 at 03:03, Kacper Michajłow wrote: > >> > >> LLVM tools print installation path upon execution. If one uses LLVM > >>

Re: [FFmpeg-devel] [RFC] statictrac, trac and caching

2025-06-15 Thread Kacper Michajlow
On Sun, 15 Jun 2025 at 16:53, James Almer wrote: > > On 6/15/2025 10:35 AM, Michael Niedermayer wrote: > > Hi all > > > > As it seems someone figured out how to make AI solve anubis, which made trac > > rather slow due to the DDOS from 100 different IPs, which eventually > > we had to block. > > (

Re: [FFmpeg-devel] [PATCH v5 3/3] lavc/dxvenc: improve compatibility with Resolume products

2025-06-14 Thread Kacper Michajlow
On Fri, 25 Apr 2025 at 18:05, Emma Worley wrote: > > Improves compatibility with Resolume products by adding an additional > hashtable for DXT color+LUT combinations, and padding the DXT texture > dimensions to the next largest multiple of 16. Produces identical > packets to Resolume Alley in manu

[FFmpeg-devel] graph.{html,css} embed failure on Windows build

2025-06-14 Thread Kacper Michajlow
Hello, Since the recent addition of resman.c and embedding of graph.{html,css} some of the Windows builds fail. There seems to be a regression in path joining, caused by \ / mismatch. Generally those issues were never a problem and I would prefer to keep it this way. This configuration has always

Re: [FFmpeg-devel] [PATCH 4/4] Revert "fftools/resources: Add resource manager files with build-time compression"

2025-06-14 Thread Kacper Michajlow
On Sat, 17 May 2025 at 01:11, Marton Balint wrote: > > This reverts commit 517a8055655798970d94a4c5ea912511362520ea. > > Building resources directly in the ffmpeg util needs quite a bit of code, > increases binary size and makes it harder for the users to change those > resources at will. > > The

Re: [FFmpeg-devel] [PATCH] configure: fix Microsoft tools detection

2025-06-13 Thread Kacper Michajlow
On Sat, 14 Jun 2025 at 03:03, Kacper Michajłow wrote: > > LLVM tools print installation path upon execution. If one uses LLVM > tools bundled with Microsoft Visual Studio installation, they would be > incorrectly detected as Microsoft's ones. > > Microsoft tools can have localized names, so a more

Re: [FFmpeg-devel] [PATCH 1/2] avutil/intmath: use AV_HAS_BUILTIN to detect builtin availability

2025-06-11 Thread Kacper Michajlow
On Wed, 11 Jun 2025 at 20:45, Martin Storsjö wrote: > > On Wed, 11 Jun 2025, Kacper Michajlow wrote: > > > On Mon, 31 Mar 2025 at 14:03, Kacper Michajłow wrote: > >> > >> Fixes use of bultins on clang x86_64-pc-windows-msvc which does not > >> define an

Re: [FFmpeg-devel] [PATCH 1/2] avutil/intmath: use AV_HAS_BUILTIN to detect builtin availability

2025-06-11 Thread Kacper Michajlow
On Mon, 31 Mar 2025 at 14:03, Kacper Michajłow wrote: > > Fixes use of bultins on clang x86_64-pc-windows-msvc which does not > define any __GNUC__. Also on other targets __GNUC__ is defined to 4 by > default, so any feature testing based on version is not really valid. > > Signed-off-by: Kacper M

Re: [FFmpeg-devel] [PATCH 1/2] avutil/intmath: use AV_HAS_BUILTIN to detect builtin availability

2025-06-11 Thread Kacper Michajlow
On Wed, 11 Jun 2025 at 20:51, Kacper Michajlow wrote: > > On Wed, 11 Jun 2025 at 20:45, Martin Storsjö wrote: > > > > On Wed, 11 Jun 2025, Kacper Michajlow wrote: > > > > > On Mon, 31 Mar 2025 at 14:03, Kacper Michajłow wrote: > > >> > > >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/internal: add missing __clang__ check

2025-06-11 Thread Kacper Michajlow
On Mon, 31 Mar 2025 at 14:03, Kacper Michajłow wrote: > > Clang x86_64-pc-windows-msvc doesn't define __GNUC__. > > Signed-off-by: Kacper Michajłow > --- > libavformat/internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/internal.h b/libavformat/interna

Re: [FFmpeg-devel] [PATCH v4 05/17] swscale: add SWS_UNSTABLE flag

2025-06-08 Thread Kacper Michajlow
On Wed, 4 Jun 2025 at 12:24, Niklas Haas wrote: > > From: Niklas Haas > > Give users and developers a way to opt in to the new format conversion code, > and more code from the swscale rewrite in general, even while development is > still ongoing. > --- > doc/APIchanges | 3 +++ > doc/scale

Re: [FFmpeg-devel] [PATCH v2 1/4] tools/target_dec_fuzzer: move things to suppress Wdeclaration-after-statement

2025-06-07 Thread Kacper Michajlow
On Fri, 6 Jun 2025 at 23:49, Michael Niedermayer wrote: > > Hi Kacper > > On Fri, Jun 06, 2025 at 07:20:32PM +0200, Kacper Michajłow wrote: > > To avoid spam in log, each fuzzer is built separately so it's amplified > > a lot. > > > > Signed-off-by: Kacper Michajłow > > --- > > tools/target_dec_

Re: [FFmpeg-devel] [PATCH v3] avformat/dhav: fix backward scanning for get_duration and optimize seeking

2025-06-06 Thread Kacper Michajlow
On Wed, 21 May 2025 at 15:23, Derek Buitenhuis wrote: > > From: Justin Ruggles > > The backwards scanning done for incomplete final packets should not > assume a specific alignment at the end of the file. Truncated files > result in hundreds of thousands of seeks if the final packet does not > fa

Re: [FFmpeg-devel] [PATCH 1/2] avformat/demux: use io_close2 when closing avfromat

2025-05-17 Thread Kacper Michajlow
On Sat, 17 May 2025 at 15:03, Andreas Rheinhardt wrote: > > Andreas Rheinhardt: > > Kacper Michajłow: > >> It's not valid to call avio_close() on context that has not been open > >> with avio_open(). > >> > >> This fixes use of custom IO. (io_open / io_close2 callbacks) > >> > >> Note that by defa

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/cri, tdsc, tiff: Use ff_mjpeg_decoder directly

2025-04-24 Thread Kacper Michajlow
On Mon, 21 Apr 2025 at 20:40, Andreas Rheinhardt wrote: > > Patches attached. Patches make sense to me. - Kacper ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, o

Re: [FFmpeg-devel] [PATCH v2] w32pthreads: add support for setting thread name

2025-04-13 Thread Kacper Michajlow
On Mon, 31 Mar 2025 at 02:50, softworkz . wrote: > > > > > -Original Message- > > From: ffmpeg-devel On Behalf Of Jan > > Ekström > > Sent: Montag, 31. März 2025 00:05 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-devel] [PATCH v2] w32pthreads: add support f

Re: [FFmpeg-devel] Request for --disable-deprecated configure option

2025-04-03 Thread Kacper Michajlow
On Thu, 3 Apr 2025 at 11:39, Martin Storsjö wrote: > > On Thu, 3 Apr 2025, Kacper Michajlow wrote: > > > Hello, > > > > It would be nice to have configure time ability to disable all > > `FF_API_*` for testing purposes. > > > > As we know n

[FFmpeg-devel] Request for --disable-deprecated configure option

2025-04-03 Thread Kacper Michajlow
Hello, It would be nice to have configure time ability to disable all `FF_API_*` for testing purposes. As we know not all code can be marked to emit Wdeprecated. Specifically #defines doesn't emit any warning and it's easy to miss such depreciation before it's actually removed. The breakage of c

Re: [FFmpeg-devel] Misc mpegvideo patches

2025-03-09 Thread Kacper Michajlow
On Sun, 9 Mar 2025 at 14:55, Andreas Rheinhardt wrote: > > Kacper Michajlow: > > On Thu, 6 Mar 2025 at 14:31, Andreas Rheinhardt > > wrote: > >> > >> Andreas Rheinhardt: > >>> Ramiro Polla: > >>>> On Tue, Mar 4, 2025 at

Re: [FFmpeg-devel] Misc mpegvideo patches

2025-03-09 Thread Kacper Michajlow
On Thu, 6 Mar 2025 at 14:31, Andreas Rheinhardt wrote: > > Andreas Rheinhardt: > > Ramiro Polla: > >> On Tue, Mar 4, 2025 at 6:05 PM Andreas Rheinhardt > >> wrote: > >>> Ramiro Polla: > > On 3/4/25 14:42, Andreas Rheinhardt wrote: > > (Mostly trivial) patches attached. A branch is a

Re: [FFmpeg-devel] [PATCH] w32pthreads: add support for setting thread name

2025-03-04 Thread Kacper Michajlow
On Tue, 4 Mar 2025 at 15:57, Kacper Michajlow wrote: > > On Tue, 4 Mar 2025 at 15:50, James Almer wrote: > > > > On 3/4/2025 9:52 AM, Kacper Michajłow wrote: > > > Signed-off-by: Kacper Michajłow > > > --- > > > compat/w32pthreads.h | 30 +++

Re: [FFmpeg-devel] [PATCH] w32pthreads: add support for setting thread name

2025-03-04 Thread Kacper Michajlow
On Tue, 4 Mar 2025 at 15:50, James Almer wrote: > > On 3/4/2025 9:52 AM, Kacper Michajłow wrote: > > Signed-off-by: Kacper Michajłow > > --- > > compat/w32pthreads.h | 30 ++ > > libavutil/thread.h | 2 ++ > > 2 files changed, 32 insertions(+) > > > > diff --git

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: .ts is always ok even if its a mov/mp4

2025-02-04 Thread Kacper Michajlow
On Tue, 28 Jan 2025 at 22:44, Michael Niedermayer wrote: > > Hi > > On Tue, Jan 28, 2025 at 10:12:30PM +0200, Jan Ekström wrote: > > On Tue, Jan 28, 2025 at 4:24 PM Michael Niedermayer > > wrote: > > > > > > Maybe fixes: 11435 > > > > > > > Do I understand correctly that the root issue that's bei

Re: [FFmpeg-devel] [PATCH] avformat/mov: fix eof check after avio_skip()

2025-02-02 Thread Kacper Michajlow
On Mon, 3 Feb 2025 at 06:24, Kacper Michajłow wrote: > > This fix ensures that the loop stops early on EOF. The issue occurs > because mov_read_infe() performs a version check and skips unsupported > versions. The problem is that seeking within the stream clears the EOF > flag, causing avio_feof()

Re: [FFmpeg-devel] [PATCH] avcodec/h263dec: Check against previous dimensions instead of coded

2025-01-30 Thread Kacper Michajlow
On Thu, 30 Jan 2025 at 02:57, Michael Niedermayer wrote: > > Fixes: out of array access > Fixes: crash-a41ef3db699013f669b076f02f36942925f5a98c > > Found-by: Kacper Michajlow > Signed-off-by: Michael Niedermayer > --- > libavcodec/h263dec.c | 13 + > 1

Re: [FFmpeg-devel] [PATCH] avcodec/jpegxl_parse{, r}: fix integer overflow for some malformed files

2025-01-30 Thread Kacper Michajlow
ill > allow this to happen even if ctx->skip would overflow a signed int. > > Several other members are also changed to int64_t to avoid this problem > in other possible scenarios. > > Signed-off-by: Leo Izen > Reported-by: Kacper Michajlow > Fixes: clusterfuzz-testcase-m

  1   2   >