[FFmpeg-devel] [PATCH] avutil/avassert: always implement av_assume with av_unreachable (PR #20167)

PR #20167 opened by Kacper Michajłow (kasper93) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20167 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20167.patch One of the design goals of this macro is the ability to support static inline predicate functions. Which is emitting warning in

[FFmpeg-devel] [PATCH] avutil/avassert: use __builtin_assume if available (PR #20151)

PR #20151 opened by Kacper Michajłow (kasper93) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20151 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20151.patch From 888d807e9cb95419cac7d272bee7cc3ca00c2157 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kacper=20Michaj=C5=82ow?= Date: Thu, 7

[FFmpeg-devel] [PATCH] avcodec/mpc8: init avctx->sample_rate (PR #20144)

PR #20144 opened by Kacper Michajłow (kasper93) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20144 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20144.patch Fixes frame validation. Fixes: OSS-Fuzz/416134551 From b3f94d3da8a60fde592bd76bc61ba394c1f18aef Mon Sep 17 00:00:00 2001

[FFmpeg-devel] [PATCH] avcodec/vvc/ctu: check coeff before multiply (PR #20142)

PR #20142 opened by Kacper Michajłow (kasper93) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20142 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20142.patch ff_vvc_palette_escape_val() can return AVERROR in which case the coeff*scale will overflow. Fixes: runtime error: signed

[FFmpeg-devel] [PATCH] avcodec/cbs_h266_syntax_template: fix out of bounds access (PR #20139)

PR #20139 opened by Kacper Michajłow (kasper93) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20139 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20139.patch current->num_tile_columns is not updated in the loop, so the existing check was not working. Check current index instead

[FFmpeg-devel] [PATCH] avfilter/vf_colordetect: optimize C functions a bit (PR #20138)

PR #20138 opened by Kacper Michajłow (kasper93) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20138 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20138.patch They are used to process tail, so it's still good to have them faster. Even if AVX version are used. GCC 14.2.0 | x

[FFmpeg-devel] [PATCH] avformat/mov: clear old name from infe (PR #20126)

PR #20126 opened by Kacper Michajłow (kasper93) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20126 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20126.patch heif_items are reused and to avoid leaking memory or using stale name, clear it first. Signed-off-by: Kacper Michajłow From

[FFmpeg-devel] [PATCH] avformat/hls: fix handle_init_section_args callback type (PR #20124)

PR #20124 opened by Kacper Michajłow (kasper93) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20124 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20124.patch From 9e0c4693414bc97587d234b60c76a2470ee45e0d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kacper=20Michaj=C5=82ow?= Date: Mon, 4

[FFmpeg-devel] [PATCH] forgejo/ISSUE_TEMPLATE: ask for more information in issue template (PR #20123)

PR #20123 opened by Kacper Michajłow (kasper93) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20123 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20123.patch Signed-off-by: Kacper Michajłow From 8930558b83f69ced7b22813bf9271a06955e7dd5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q

[FFmpeg-devel] [FFFjo] Re: [FFmpeg/FFmpeg] forgejo/workflows: generate coverage report (PR #20027)

*kasper93* force-pushed the *cov_report* from *7e2f0cb9a2* ( https://code.ffmpeg.org/FFmpeg/FFmpeg/commit/7e2f0cb9a212ec5f82faa41bdb70f619c3d6c9f0 ) to *1d7ca722bd* ( https://code.ffmpeg.org/FFmpeg/FFmpeg/commit/1d7ca722bd7d2a31efc30fb9a635dedbb789af19 ). --- View it on FFmpeg Forgejo ( https

[FFmpeg-devel] [FFFjo] Re: [FFmpeg/FFmpeg] forgejo/workflows: generate coverage report (PR #20027)

*kasper93* force-pushed the *cov_report* from *af5e035c87* ( https://code.ffmpeg.org/FFmpeg/FFmpeg/commit/af5e035c8736b8f58657541eecaf347877d47f67 ) to *7e2f0cb9a2* ( https://code.ffmpeg.org/FFmpeg/FFmpeg/commit/7e2f0cb9a212ec5f82faa41bdb70f619c3d6c9f0 ). --- View it on FFmpeg Forgejo ( https

[FFmpeg-devel] [FFFjo] Re: [FFmpeg/FFmpeg] forgejo/workflows: generate coverage report (PR #20027)

*kasper93* force-pushed the *cov_report* from *ef39d2d144* ( https://code.ffmpeg.org/FFmpeg/FFmpeg/commit/ef39d2d144658a1fb37ea0fc2cc3ebb435a355fb ) to *af5e035c87* ( https://code.ffmpeg.org/FFmpeg/FFmpeg/commit/af5e035c8736b8f58657541eecaf347877d47f67 ). --- View it on FFmpeg Forgejo ( https

[FFmpeg-devel] [PATCH] {avcodec, avformat}/options_table: supress implicit conversion from 'long' to 'double' warnings

Signed-off-by: Kacper Michajłow --- libavcodec/options_table.h | 2 +- libavformat/options_table.h | 14 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index c525cde80a..25da169343 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 09/10] avcodec/x86/vc1: guard usage of undefined functions with preprocessor

The asumption is that DCE will remove references to those functions. However some compilers with certain instrumentation enabled doesn't DCE those at all, resulting in linking failure. Tested with cl.exe -RTCu -RTCs. Signed-off-by: Kacper Michajłow --- libavcodec/x86/vc1dsp.h

[FFmpeg-devel] [PATCH 08/10] avcodec/x86/fdct: guard usage of undefined functions with preprocessor

The asumption is that DCE will remove references to those functions. However some compilers with certain instrumentation enabled doesn't DCE those at all, resulting in linking failure. Tested with cl.exe -RTCu -RTCs. Signed-off-by: Kacper Michajłow --- libavcodec/x86/fdctdsp_init.c | 2

[FFmpeg-devel] [PATCH 07/10] avcodec/d3d12va_encode_hevc: remove unused variable

Signed-off-by: Kacper Michajłow --- libavcodec/d3d12va_encode_hevc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/d3d12va_encode_hevc.c b/libavcodec/d3d12va_encode_hevc.c index 938ba01f54..ce5d1bf110 100644 --- a/libavcodec/d3d12va_encode_hevc.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 06/10] avcodec/d3d12va_encode: don't return uninitialized value on error

When CreateEvent fails, err was not initialized. Signed-off-by: Kacper Michajłow --- libavcodec/d3d12va_encode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/d3d12va_encode.c b/libavcodec/d3d12va_encode.c index 64821da5f5..880002ce55 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 10/10] avformat/rtmpproto: guard usage of undefined functions with preprocessor

The asumption is that DCE will remove references to those functions. However some compilers with certain instrumentation enabled doesn't DCE those at all, resulting in linking failure. Tested with cl.exe -RTCu -RTCs. Signed-off-by: Kacper Michajłow --- libavformat/rtmpproto.c

[FFmpeg-devel] [PATCH 05/10] avcodec/d3d12va_encode: don't write garbage when there is no header

When codec->write_sequence_header is not defined, bit_len was undefined, and while data bufer was zeroed we could just overread it. Do nothing when we don't have anything to write. Signed-off-by: Kacper Michajłow --- libavcodec/d3d12va_encode.c | 25 - 1 file cha

[FFmpeg-devel] [PATCH 04/10] avcodec/d3d12va_encode: use correct none flag

NFC, it's still 0, but correct enum type so compilers won't complain. Signed-off-by: Kacper Michajłow --- libavcodec/d3d12va_encode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/d3d12va_encode.c b/libavcodec/d3d12va_encode.c index e24a5b8d24..d99e960

[FFmpeg-devel] [PATCH 03/10] avcodec/d3d12va_decode: remove unused variable

Signed-off-by: Kacper Michajłow --- libavcodec/d3d12va_decode.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/d3d12va_decode.c b/libavcodec/d3d12va_decode.c index 4645ffe122..4e714efb1a 100644 --- a/libavcodec/d3d12va_decode.c +++ b/libavcodec/d3d12va_decode.c @@ -50,7 +50,6

[FFmpeg-devel] [PATCH 02/10] avformat/vivo: fix sscanf specifer for double

Signed-off-by: Kacper Michajłow --- libavformat/vivo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/vivo.c b/libavformat/vivo.c index 76aa4a21c2..c20788f8bb 100644 --- a/libavformat/vivo.c +++ b/libavformat/vivo.c @@ -209,7 +209,7 @@ static int vivo_read_header

[FFmpeg-devel] [PATCH 01/10] avformat/os_support: check invalid socket value correctly on Windows

SOCKET defined in winsock2.h is unsigned and invalid value is defined as INVALID_SOCKET. Check this explicity to avoid compiler warnings. See: https://learn.microsoft.com/en-us/windows/win32/winsock/socket-data-type-2 Signed-off-by: Kacper Michajłow --- libavformat/os_support.c | 5 - 1

[FFmpeg-devel] [PATCH] configure: don't use dangling temp file state

There was implicit assumption that the $TMPC file is empty when doing --cpu=host checks. This breaks if any check is done before that. Since this is only for GCC/Clang instead of clearing the temp file, just use pipe input. Signed-off-by: Kacper Michajłow --- configure | 4 ++-- 1 file changed

[FFmpeg-devel] [PATCH] configure: filter link flags separately for MSVC

This avoids adding flags that cl.exe doesn't understand. Signed-off-by: Kacper Michajłow --- configure | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/configure b/configure index ed6430ea32..8a9a9c3c17 100755 --- a/configure +++ b/configure @@ -4924,7 +4

[FFmpeg-devel] [PATCH] configure: suppress Wmicrosoft-enum-forward-reference

Clang-CL complains about fwd references of enums, but we do use it everywhere, so ignore this. Signed-off-by: Kacper Michajłow --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index ed6430ea32..ac143f2fea 100755 --- a/configure +++ b/configure @@ -7575,6

[FFmpeg-devel] [PATCH] configure: treat unrecognized flags as errors on MSVC

upport for this flag. Clang-CL sets _MSC_FULL_VER as one example. Signed-off-by: Kacper Michajłow --- configure | 6 ++ 1 file changed, 6 insertions(+) diff --git a/configure b/configure index ed6430ea32..20276a3c4f 100755 --- a/configure +++ b/configure @@ -5276,6 +5276,12 @@ else ar_

[FFmpeg-devel] [PATCH] avutil/hmac: avoid calling functions through pointer of invalid type

Add type removed function wrappers to resolve UB of calling function through pointer to incorrect function type. Fixes: call to function av_md5_init through pointer to incorrect function type 'void (*)(void *)' and similar for others. Signed-off-by: Kacper Michajłow --- libavu

[FFmpeg-devel] [PATCH v2 5/5] configure: remove ossfuzz sanitizer flags

In OSS-Fuzz build environment flags are handled by CFLAGS and LDFLAGS. In local build use --toolchain=clang-fuzz-asan-ubsan or similar combination depending on requested sanitizers. Signed-off-by: Kacper Michajłow --- configure | 5 - 1 file changed, 5 deletions(-) diff --git a/configure b

[FFmpeg-devel] [PATCH v2 4/5] configure: add -fuzz support to --toolchain

libFuzzer is linked only for fuzzing targets. Signed-off-by: Kacper Michajłow --- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index bff0fe285b..4773a507d3 100755 --- a/configure +++ b/configure @@ -4616,6 +4616,11 @@ add_sanitizer_flags

[FFmpeg-devel] [PATCH v2 3/5] configure: allow -ubsan in toolchain

It's is commonly called UBSAN after all. Signed-off-by: Kacper Michajłow --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 11b2a93038..bff0fe285b 100755 --- a/configure +++ b/configure @@ -4628,7 +4628,7 @@ add_sanitizer_

[FFmpeg-devel] [PATCH v2 2/5] configure: add -fno-omit-frame-pointer when sanitizers are used

All sanitizers give better reports with frame pointers. And skip adding -fomit-frame-pointer. Signed-off-by: Kacper Michajłow --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 17a83dd873..11b2a93038 100755 --- a/configure +++ b

[FFmpeg-devel] [PATCH v2 1/5] configure: allow multiple sanitizers in --toolchain

For example this allows --toolchain=clang-asan-usan. Signed-off-by: Kacper Michajłow --- configure | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 10dafae8e2..17a83dd873 100755 --- a/configure +++ b/configure @@ -4638,14 +4638,23

[FFmpeg-devel] [PATCH 5/5] configure: remove ossfuzz sanitizer flags

In OSS-Fuzz build environment flags are handled by CFLAGS and LDFLAGS. In local build use --toolchain=clang-fuzz-asan-ubsan or similar combination depending on requested sanitizers. Signed-off-by: Kacper Michajłow --- configure | 5 - 1 file changed, 5 deletions(-) diff --git a/configure b

[FFmpeg-devel] [PATCH 4/5] configure: add -fuzz support to --toolchain

libFuzzer is linked only for fuzzing targets. Signed-off-by: Kacper Michajłow --- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index fd4a52fc5f..36f7ab8c7c 100755 --- a/configure +++ b/configure @@ -4616,6 +4616,11 @@ add_sanitizer_flags

[FFmpeg-devel] [PATCH 3/5] configure: allow -ubsan in toolchain

It's is commonly called UBSAN after all. Signed-off-by: Kacper Michajłow --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 3fe33b72ed..fd4a52fc5f 100755 --- a/configure +++ b/configure @@ -4628,7 +4628,7 @@ add_sanitizer_

[FFmpeg-devel] [PATCH 2/5] configure: add -fno-omit-frame-pointer when sanitizers are used

All sanitizers give better reports with frame pointers. Signed-off-by: Kacper Michajłow --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/configure b/configure index 85712380c0..3fe33b72ed 100755 --- a/configure +++ b/configure @@ -4643,6 +4643,9 @@ add_sanitizers(){ for

[FFmpeg-devel] [PATCH 1/5] configure: allow multiple sanitizers in --toolchain

For example this allows --toolchain=clang-asan-usan. Signed-off-by: Kacper Michajłow --- configure | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 10dafae8e2..85712380c0 100755 --- a/configure +++ b/configure @@ -4638,14 +4638,21

[FFmpeg-devel] [PATCH 5/5] avfilter/vaf_spectrumsynth: don't use uninitialized variable as scale

scale was never initialized. av_tx_init() will use default scale if we pass NULL. Fixes: b3117f376d1c50b3c39befe27cbba12d5c0f80da Signed-off-by: Kacper Michajłow --- libavfilter/vaf_spectrumsynth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter

[FFmpeg-devel] [PATCH 4/5] swscale/lut3d: remove unused function

Signed-off-by: Kacper Michajłow --- libswscale/lut3d.c | 13 - 1 file changed, 13 deletions(-) diff --git a/libswscale/lut3d.c b/libswscale/lut3d.c index f42958cd92..535694e61c 100644 --- a/libswscale/lut3d.c +++ b/libswscale/lut3d.c @@ -131,19 +131,6 @@ static av_always_inline

[FFmpeg-devel] [PATCH 3/5] avcodec/sonic: move code closer to use to avoid unused warnings

Put decoding and encoding code into thier respective #if blocks. Signed-off-by: Kacper Michajłow --- libavcodec/sonic.c | 257 +++-- 1 file changed, 129 insertions(+), 128 deletions(-) diff --git a/libavcodec/sonic.c b/libavcodec/sonic.c index acefbbdbfb

[FFmpeg-devel] [PATCH 2/5] avcodec/sonic: remove dead code

This was in else branch of `#if 1` since ever. No need to keep dead code like that, if anyone needs it they can get it from git history. Signed-off-by: Kacper Michajłow --- libavcodec/sonic.c | 299 - 1 file changed, 299 deletions(-) diff --git a

[FFmpeg-devel] [PATCH 1/5] avformat/udp: avoid warning about always false comparision

socklen_t underlying type can be signed or unsigned depending on platform. This is fine, just cast it to size_t before comparision. Fixes: warning: result of comparison of unsigned expression < 0 is always false [-Wtautological-unsigned-zero-compare] Signed-off-by: Kacper Michaj

[FFmpeg-devel] [PATCH] avformat/subfile: clip seek offset

Fixes: signed integer overflow: 9223372036854737920 + 1649410 cannot be represented in type 'int64_t' Fixes OSS-Fuzz: 410100610 Signed-off-by: Kacper Michajłow --- libavformat/subfile.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/s

[FFmpeg-devel] [PATCH] MAINTAINERS: add myself

Signed-off-by: Kacper Michajłow --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 07cea8afeb..650300dadc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -547,6 +547,7 @@ James Darnley Jan Ekström Joakim Plate Jun Zhao +Kacper Michajłow Kieran

[FFmpeg-devel] [PATCH] avformat/scd: ensure SCD_MIN_HEADER_SIZE bytes are read

Instead of accessing unintialized data when input is shorter than expected size. Fixes use of uninitialized value in MSAN build. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavformat/scd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/scd.c b

[FFmpeg-devel] [PATCH v2] avutil/avstring: shrink allocation from av_get_token to fit token

obtaining the return value, simply realloc the buffer to the actual size needed for output string. Fixes OOM when parsing filter graph string. Fixes OSS-Fuzz: 394983446 Signed-off-by: Kacper Michajłow --- libavutil/avstring.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH] avutil/avstring: shrink allocation from av_get_token to fit token

obtaining the return value, simply realloc the buffer to the actual size needed for output string. Fixes OOM when parsing filter graph string. Fixes OSS-Fuzz: 394983446 Signed-off-by: Kacper Michajłow --- libavutil/avstring.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[FFmpeg-devel] [PATCH] checkasm/swscale: fix function prototypes

This aligns declared function types in checkasm with real definition. Fixes FATE: checkasm-{sw_rgb,sw_scale,sw_yuv2rgb,sw_yuv2yuv} Fixes: runtime error: call to function through pointer to incorrect function type Fixes: c1a0e657638f7007dcc807a2d985c22631fcd6d3 Signed-off-by: Kacper Michajłow

[FFmpeg-devel] [PATCH 1/2] avcodec/opus: don't materialize buf pointer from null

Fixes: avcodec/opus/dec.c: runtime error: applying non-zero offset 10 to null pointer Signed-off-by: Kacper Michajłow --- libavcodec/opus/dec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/opus/dec.c b/libavcodec/opus/dec.c index 6c59dc1f46..dbefcddb0c 100644 --- a

[FFmpeg-devel] [PATCH] fftools/cmdutils: don't try to load arguments from file if not needed

Signed-off-by: Kacper Michajłow --- fftools/cmdutils.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index be21ed2c6c..e442935cae 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -255,9 +255,10 @@ static int write_option(void

[FFmpeg-devel] [PATCH v2] configure: add -Wl when linker is called indirectly

It's possible to call linker indirectly through driver like Clang. In which cases linker args has to be prefixed with -Wl. Signed-off-by: Kacper Michajłow --- configure | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configure b/configure index c57da316cc..0dede

[FFmpeg-devel] [PATCH 2/2] configure: add -Wl when linker is called indirectly

It's possible to call linker indirectly through driver like Clang. In which cases linker args has to be prefixed with -Wl. Signed-off-by: Kacper Michajłow --- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index c57da316cc..a5c3bd3917 100755

[FFmpeg-devel] [PATCH 1/2] configure: use proper Windows-style static library naming

ct mingw build. MSVC builds work the same, because there libraries are passed as files directly to linker command. This also removes LD_LIB from Win32/64 target as there is one type of .lib in practice. We cannot build both shared and static as noted by the next line. Signed-off-by: Kacper Micha

[FFmpeg-devel] [PATCH] configure: fix Microsoft tools detection

test if "Microsoft" is at the beginning of the line, as it is always the case. Signed-off-by: Kacper Michajłow --- configure | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/configure b/configure index 534b443f7d..5b2a04ae6a 100755 --- a/configure +++ b/confi

[FFmpeg-devel] [PATCH v2 4/4] tools/target_dem_fuzzer: remove unused fuzz_tag

Signed-off-by: Kacper Michajłow --- tools/target_dem_fuzzer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/target_dem_fuzzer.c b/tools/target_dem_fuzzer.c index 19bc1f09c1..e169438ceb 100644 --- a/tools/target_dem_fuzzer.c +++ b/tools/target_dem_fuzzer.c @@ -98,10 +98,7 @@ static

[FFmpeg-devel] [PATCH v2 3/4] tools/target_dem_fuzzer: make fuzz data pointer constant

Mostly to avoid warnings. Signed-off-by: Kacper Michajłow --- tools/target_dem_fuzzer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/target_dem_fuzzer.c b/tools/target_dem_fuzzer.c index 8e96fad7f8..19bc1f09c1 100644 --- a/tools/target_dem_fuzzer.c +++ b/tools

[FFmpeg-devel] [PATCH v2 2/4] tools/target_dec_fuzzer: suppress Wunused-function

Signed-off-by: Kacper Michajłow --- tools/target_dec_fuzzer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index 7afb23619e..6950d134d9 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzzer.c @@ -72,6 +72,8 @@ static

[FFmpeg-devel] [PATCH v2 1/4] tools/target_dec_fuzzer: move things to suppress Wdeclaration-after-statement

To avoid spam in log, each fuzzer is built separately so it's amplified a lot. Signed-off-by: Kacper Michajłow --- tools/target_dec_fuzzer.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/tools/target_dec_fuzzer.c b/

[FFmpeg-devel] [PATCH v2 0/4] Minor fixes and for fuzzing targets

Minor fixes and for fuzzing targets. Mostly motivated to reduce spam in the build log. v2 only for rebase only. Kacper Michajłow (4): tools/target_dec_fuzzer: move things to suppress Wdeclaration-after-statement tools/target_dec_fuzzer: suppress Wunused-function tools/target_dem_fuzzer

[FFmpeg-devel] [PATCH 2/2] avformat/imfdec: inherit opaque from parent AVFormatContext

io_open and io_close2 callbacks may use opaque pointer stored in the context. They are already inherited, so opaque should also be passed through. Fixes IMF playback in mpv. Signed-off-by: Kacper Michajłow --- libavformat/imfdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat

[FFmpeg-devel] [PATCH 1/2] avformat/demux: use io_close2 when closing avfromat

ff-by: Kacper Michajłow --- libavformat/demux.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index 2795863567..ecd4f40da9 100644 --- a/libavformat/demux.c +++ b/libavformat/demux.c @@ -383,11 +383,10 @@ void avformat_close_

[FFmpeg-devel] [PATCH 6/6] tools/target_dem_fuzzer: remove unused fuzz_tag

Signed-off-by: Kacper Michajłow --- tools/target_dem_fuzzer.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/target_dem_fuzzer.c b/tools/target_dem_fuzzer.c index 19bc1f09c1..e169438ceb 100644 --- a/tools/target_dem_fuzzer.c +++ b/tools/target_dem_fuzzer.c @@ -98,10 +98,7 @@ static

[FFmpeg-devel] [PATCH 5/6] tools/target_dem_fuzzer: make fuzz data pointer constant

Mostly to avoid warnings. Signed-off-by: Kacper Michajłow --- tools/target_dem_fuzzer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/target_dem_fuzzer.c b/tools/target_dem_fuzzer.c index 8e96fad7f8..19bc1f09c1 100644 --- a/tools/target_dem_fuzzer.c +++ b/tools

[FFmpeg-devel] [PATCH 4/6] tools/target_dec_fuzzer: suppress Wunused-function

Signed-off-by: Kacper Michajłow --- tools/target_dec_fuzzer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/target_dec_fuzzer.c b/tools/target_dec_fuzzer.c index a15f1a3f9c..7bbf1375d0 100644 --- a/tools/target_dec_fuzzer.c +++ b/tools/target_dec_fuzzer.c @@ -72,6 +72,8 @@ static

[FFmpeg-devel] [PATCH 3/6] tools/target_dec_fuzzer: suppress Wdeclaration-after-statement

To avoid spam in log, each fuzzer is built separately so it's amplified a lot. Signed-off-by: Kacper Michajłow --- tools/target_dec_fuzzer.c | 41 +++ 1 file changed, 24 insertions(+), 17 deletions(-) diff --git a/tools/target_dec_fuzzer.c b/

[FFmpeg-devel] [PATCH 2/6] tools/target_dec_fuzzer: fix tiff/tdsc check

Comparing `FFMPEG_DECODER == tiff` never worked because tiff is not defined. Original commit expected string compare, but C preprocesor doesn't work this way. Fixes: 3371d0611fcd31e0bc72553d88774512a58bd2ef Signed-off-by: Kacper Michajłow --- tools/target_dec_fuzzer.c | 2 +- 1 file chang

[FFmpeg-devel] [PATCH 1/6] tools/Makefile: add identifier macros for specific fuzzing targets

This will allow to add conditional code per target codec. Signed-off-by: Kacper Michajłow --- tools/Makefile | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/Makefile b/tools/Makefile index 7ae6e3cb75..3f99b337e5 100644 --- a/tools/Makefile +++ b/tools/Makefile

[FFmpeg-devel] [PATCH 0/6] Minor fixes and for fuzzing targets

Minor fixes and for fuzzing targets. Mostly motivated to reduce spam in the build log. While at it, tiff/tdsc check was fixed, which was real bug. Kacper Michajłow (6): tools/Makefile: add identifier macros for specific fuzzing targets tools/target_dec_fuzzer: fix tiff/tdsc check tools

[FFmpeg-devel] [PATCH 1/2] avutil/intmath: use AV_HAS_BUILTIN to detect builtin availability

Fixes use of bultins on clang x86_64-pc-windows-msvc which does not define any __GNUC__. Also on other targets __GNUC__ is defined to 4 by default, so any feature testing based on version is not really valid. Signed-off-by: Kacper Michajłow --- libavutil/intmath.h | 12

[FFmpeg-devel] [PATCH] tools/target_swr_fuzzer: fix memory leak on av_samples_fill_arrays() error

--- tools/target_swr_fuzzer.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/target_swr_fuzzer.c b/tools/target_swr_fuzzer.c index f154a11632..59fa24af64 100644 --- a/tools/target_swr_fuzzer.c +++ b/tools/target_swr_fuzzer.c @@ -79,7 +79,7 @@ int LLVMFuzzerTestOneIn

[FFmpeg-devel] [PATCH] tools/target_swr_fuzzer: fix memory leak on av_samples_fill_arrays() error

Signed-off-by: Kacper Michajłow --- tools/target_swr_fuzzer.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tools/target_swr_fuzzer.c b/tools/target_swr_fuzzer.c index f154a11632..59fa24af64 100644 --- a/tools/target_swr_fuzzer.c +++ b/tools/target_swr_fuzzer.c

[FFmpeg-devel] [PATCH 2/2] avformat/internal: add missing __clang__ check

Clang x86_64-pc-windows-msvc doesn't define __GNUC__. Signed-off-by: Kacper Michajłow --- libavformat/internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/internal.h b/libavformat/internal.h index fe428d85eb..bf83571430 100644 --- a/libavformat/inter

[FFmpeg-devel] [PATCH v2] w32pthreads: add support for setting thread name

Signed-off-by: Kacper Michajłow --- compat/w32pthreads.h | 30 ++ libavutil/thread.h | 2 ++ 2 files changed, 32 insertions(+) diff --git a/compat/w32pthreads.h b/compat/w32pthreads.h index fd6428e29f..8d5b4729fa 100644 --- a/compat/w32pthreads.h +++ b/compat

[FFmpeg-devel] [PATCH] w32pthreads: add support for setting thread name

Signed-off-by: Kacper Michajłow --- compat/w32pthreads.h | 30 ++ libavutil/thread.h | 2 ++ 2 files changed, 32 insertions(+) diff --git a/compat/w32pthreads.h b/compat/w32pthreads.h index fd6428e29f..83b4819205 100644 --- a/compat/w32pthreads.h +++ b/compat

[FFmpeg-devel] [PATCH] avutil/hwcontext_amf: fix crash on uninit after init failed

amf_device_create() calls amf_device_uninit() on errors, but if things were not initialized it will null deref amf_ctx->factory. Fixes: https://github.com/mpv-player/mpv/issues/15814 Signed-off-by: Kacper Michajłow --- libavutil/hwcontext_amf.c | 6 -- 1 file changed, 4 insertions(+)

[FFmpeg-devel] [PATCH v2] avformat/mov: fix eof check in mov_read_iinf()

EOF check after reading the size and type, ensuring the EOF flag is set when necessary. Signed-off-by: Kacper Michajłow --- libavformat/mov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2c8be51063..9a388bf723 100644 --- a

[FFmpeg-devel] [PATCH] avformat/mov: fix eof check after avio_skip()

EOF check after reading the size and type after seek, ensuring the EOF flag is set when necessary. Signed-off-by: Kacper Michajłow --- libavformat/mov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 2c8be51063..9a388bf723 100644

[FFmpeg-devel] [PATCH] avformat/vqf: fix memory leak in add_metadata()

Signed-off-by: Kacper Michajłow --- libavformat/vqf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/vqf.c b/libavformat/vqf.c index 58b1546f53..fbe54739cd 100644 --- a/libavformat/vqf.c +++ b/libavformat/vqf.c @@ -66,10 +66,10 @@ static int add_metadata

[FFmpeg-devel] [PATCH] avutil/file: fix av_file_map file mapping on Windows

when trying to write to a read-only memory page. Signed-off-by: Kacper Michajłow --- libavutil/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/file.c b/libavutil/file.c index db8507286b..4ef940a6c3 100644 --- a/libavutil/file.c +++ b/libavutil/file.c @@ -112,7

[FFmpeg-devel] [PATCH v2] avfilter/af_ashowinfo: fix scaling factor of replaygain peak values

Commit 8542f9c4f17125d483c40c0c5723842f1c982f81 changed replaygain peak values to use 100k instead of UINT32_MAX as peak, with possibility of overflow. af_ashowinfo was never updated to reflect this, so we update it now. Fixes: 8542f9c4f17125d483c40c0c5723842f1c982f81 Signed-off-by: Kacper

[FFmpeg-devel] [PATCH] avfilter/af_ashowinfo: fix scaling factor of replaygain peak values

Fixes: 8542f9c4f17125d483c40c0c5723842f1c982f81 Signed-off-by: Kacper Michajłow --- libavfilter/af_ashowinfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_ashowinfo.c b/libavfilter/af_ashowinfo.c index b83847b866..de94d4c7c2 100644 --- a/libavfilter

[FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: check entropy_decoder_read_symbol return value

Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavcodec/jpegxl_parser.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c index 8c45e1a1b7..746c429b9c 100644 --- a/libavcodec/jpegxl_parser.c +++ b

[FFmpeg-devel] [PATCH] avformat/mov: ensure required number of bytes is read

Fixes: use-of-uninitialized-value Found by OSS-Fuzz. --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 1052691936..f2d8aee766 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -7096,7 +7096,7 @@ static int

[FFmpeg-devel] [PATCH] avformat/vpk: fix divide by zero

Can happen after calling avformat_find_stream_info() when the codec fails to open, but return value is 0 and subsequent uses of this context have zero value in channel number. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavformat/vpk.c | 2 ++ 1 file changed, 2 insertions(+) diff

[FFmpeg-devel] [PATCH] avcodec/wmavoice: use av_clipd for double values

Fixes Clang warning. Signed-off-by: Kacper Michajłow --- libavcodec/wmavoice.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wmavoice.c b/libavcodec/wmavoice.c index 258c71330c..3db73773b7 100644 --- a/libavcodec/wmavoice.c +++ b/libavcodec/wmavoice.c @@ -655,7

[FFmpeg-devel] [PATCH] avfilter/vf_scale: validate values before converting to integer

Fixes the conversion of double values to integer, which may be out of the representable range. Also, bail out on overflow check instead of printing an error only. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavfilter/vf_scale.c | 33 +++-- 1 file

[FFmpeg-devel] [PATCH 4/4] avformat/jpegxl_anim_dec: ensure input padding is zeroed

Fixes use of uninitialized value, reported by MSAN. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavformat/jpegxl_anim_dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/jpegxl_anim_dec.c b/libavformat/jpegxl_anim_dec.c index ac95d3b961..2338a2e8c0 100644 --- a

[FFmpeg-devel] [PATCH 3/4] avformat/img2dec: ensure input padding is zeroed

Fixes use of uninitialized value, reported by MSAN. Specifically in jpegxl parser. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavformat/img2dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index ba52353074..c667d8574c

[FFmpeg-devel] [PATCH 2/4] avcodec/parser: ensure input padding is zeroed

Fixes use of uninitialized value, reported by MSAN. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavcodec/parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/parser.c b/libavcodec/parser.c index af17ee9c15..426cc314fb 100644 --- a/libavcodec/parser.c +++ b

[FFmpeg-devel] [PATCH 1/4] avcodec/jpegxl_parser: ensure input padding is zeroed

Fixes use of uninitialized value, reported by MSAN. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavcodec/jpegxl_parser.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c index 8c45e1a1b7..f833f844c4 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH] avcodec/jpegxl_parser: check remaining data buffer size

Fixes use of uninitialized value, reported by MSAN. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavcodec/jpegxl_parser.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/jpegxl_parser.c b/libavcodec/jpegxl_parser.c index 8c45e1a1b7..8371d78a45

[FFmpeg-devel] [PATCH] avformat/nuv: return early if header id fails to read

Fixes use of uninitialized value in memcmp below, reported by MSAN. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavformat/nuv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/nuv.c b/libavformat/nuv.c index 507a73b0fe..49915ecf16 100644 --- a

[FFmpeg-devel] [PATCH] avcodec/vp9mvs: fix misaligned access when clearing VP9mv

Fixes runtime error: member access within misaligned address for type 'av_alias64', which requires 8 byte alignment. VP9mv is aligned to 4 bytes, so instead doing 8 bytes clear, let's do 2 times 4 bytes. Signed-off-by: Kacper Michajłow --- libavcodec/vp9mvs.c | 3 ++- 1

[FFmpeg-devel] [PATCH] avcodec/decode: use avcodec_get_hw_config()

Fixes libavcodec/decode.c:1035:61: runtime error: member access within null pointer of type 'const struct AVCodecHWConfigInternal'. This can happen when hwaccel fails to initialize and hw_configs[i] is NULL. Signed-off-by: Kacper Michajłow --- libavcodec/decode.c | 2 +- 1 file

[FFmpeg-devel] [PATCH v2] avformat/data_uri: Fix base64 decode buffer size calculation

Signed-off-by: Kacper Michajłow --- libavformat/data_uri.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/data_uri.c b/libavformat/data_uri.c index 3868a19630..5991ad4ed4 100644 --- a/libavformat/data_uri.c +++ b/libavformat/data_uri.c @@ -73,7 +73,7 @@ static

[FFmpeg-devel] [PATCH] avformat/rpl: reject invalid sample rate

Fixes overflow check for bit_rate multiplication few lines below. Found by OSS-Fuzz. Signed-off-by: Kacper Michajłow --- libavformat/rpl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rpl.c b/libavformat/rpl.c index 09d0b68f74..32a762b60a 100644 --- a/libavformat/rpl.c

[FFmpeg-devel] [PATCH] avformat/rtsp: Set timeouts also when reading header

Signed-off-by: Kacper Michajłow --- libavformat/rtsp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index b0c61ee00a..4b067ee76b 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -135,6 +135,8 @@ static AVDictionary *map_to_opts

[FFmpeg-devel] [PATCH v2] avformat/hls: update current segment reference before use

It may be invalidated by the time it is used. Fixes use after free when accessing current segment. Fixes: #10825 Signed-off-by: Kacper Michajłow --- libavformat/hls.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index 214a99c7ba..62473a15dd

[FFmpeg-devel] [PATCH v2 3/3] avcodec/libzvbi-teletextdec: change new lines to \n in ASS header

Fixes remaining \r\n is ASS header after 57c545090d. Fixes AVERROR_BUG error during init as this decoder expected `\r\n` in default ASS header. strstr(..., "\r\n[Events]\r\n") failed after changes in 57c545090d. Fixes: 57c545090d Signed-off-by: Kacper Michajłow --- libavcod

  1   2   >