Re: [FFmpeg-devel] [PATCH 2/3] lavf/timecode: document SMPTE struct

2018-10-11 Thread Joshua de Kock
On 9 October 2018 at 21:21, Devin Heitmueller wrote: > >> On Oct 9, 2018, at 4:07 PM, Carl Eugen Hoyos wrote: >> >> 2018-10-09 15:32 GMT+02:00, jos...@ob-encoder.com : >>> From: Devin Heitmueller >>> >>> There are a number of different binary representations in which >>> SMPTE timecodes can use.

Re: [FFmpeg-devel] [PATCH 3/3] h264/pic_timing: support multiple timecodes

2018-10-11 Thread Joshua de Kock
On 9 October 2018 at 21:03, Carl Eugen Hoyos wrote: > 2018-10-09 15:32 GMT+02:00, jos...@ob-encoder.com : >> From: Josh de Kock > >> [...] > > If the first patch gets committed as-is, please split this one > in a functional and a cosmetic patch, above is unreviewable. > > Thank you, Carl Eugen I

Re: [FFmpeg-devel] [PATCH v3] h264: Support multi-field closed captions by using AVBufferRef and not resetting per field

2018-08-17 Thread Joshua de Kock
On 17 August 2018 at 15:12, wrote: > From: Kieran Kunhya > > Signed-off-by: Josh de Kock > --- > libavcodec/h264_sei.c | 15 --- > libavcodec/h264_sei.h | 3 +-- > libavcodec/h264_slice.c | 22 ++ > libavcodec/h264dec.c| 5 +++-- > 4 files changed, 26