Re: [FFmpeg-devel] [PATCH] libavformat/amr.c: Check return value from avio_read()

Updated to return AVERROR_INVALIDDATA. On Wed, Apr 1, 2020 at 12:33 PM Michael Niedermayer wrote: > On Mon, Mar 30, 2020 at 09:48:13PM -0700, John Rummell wrote: > > Hit send too soon. Patch attached. > > > > On Mon, Mar 30, 2020 at 9:44 PM John Rummell > wrote: > &g

Re: [FFmpeg-devel] [PATCH] libavformat/mov.c: Free aes_decrypt to avoid leaking memory

Thanks. Updated. On Tue, Mar 31, 2020 at 5:23 AM Moritz Barsnick wrote: > On Mon, Mar 30, 2020 at 15:27:46 -0700, John Rummell wrote: > > +if (c->aes_decrypt) > > +av_free(c->aes_decrypt); > > av_free() already does the NULL pointe

[FFmpeg-devel] [PATCH] libavformat/amr.c: Check return value from avio_read()

Another uninitialized memory access detected by the Chromium fuzzers. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with s

Re: [FFmpeg-devel] [PATCH] libavformat/amr.c: Check return value from avio_read()

Hit send too soon. Patch attached. On Mon, Mar 30, 2020 at 9:44 PM John Rummell wrote: > Another uninitialized memory access detected by the Chromium fuzzers. > 0001-libavformat-amr.c-Check-return-value-from-avio_read.patch Description: Binar

[FFmpeg-devel] [PATCH] libavformat/mov.c: Free aes_decrypt to avoid leaking memory

Another one found by the Chromium fuzzers. 0001-libavformat-mov.c-Free-aes_decrypt-to-avoid-leaking-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, v

[FFmpeg-devel] [PATCH] libavformat/oggdec.c: Check return value from avio_read()

Refactoring my previous patch into smaller items. Starting with the one found by the Chromium fuzzers. 0001-libavformat-oggdec.c-Check-return-value-from-avio_re.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https:/

Re: [FFmpeg-devel] [PATCH] Check return value from avio_read() to verify data actually read

0 at 05:52:01PM -0700, John Rummell wrote: > > Chromium fuzzers have caught places where uninitialized data was used due > > to calls to avio_read() not verifying that the number of bytes expected > was > > actually read. So updating the code to check the result from

[FFmpeg-devel] [PATCH] Check return value from avio_read() to verify data actually read

Chromium fuzzers have caught places where uninitialized data was used due to calls to avio_read() not verifying that the number of bytes expected was actually read. So updating the code to check the result from avio_read(). 0001-Check-return-value-from-avio_read-to-verify-data-act.patch Descripti

[FFmpeg-devel] [PATCH] libavformat/mov: Always use av_realloc() for AVCodecParameters.extradata

; -if (!st->codecpar->extradata) -return AVERROR(ENOMEM); +uint64_t size = sc->extradata_size[0] + AV_INPUT_BUFFER_PADDING_SIZE; +if ((ret = av_reallocp(&st->codecpar->extradata, size)) < 0) + return ret; memcpy(st->code

Re: [FFmpeg-devel] [PATCH] Update decode_simple_internal() to get the side data correctly.

Using avci->last_pkt_props works. Chromium tests work, "make fate" passes. Updated patch: From 0fd3c5c9abd3cea943b12f65f219d479b5949e4b Mon Sep 17 00:00:00 2001 From: John Rummell Date: Wed, 14 Jun 2017 14:43:04 -0700 Subject: [PATCH] Update decode_simple_internal() to get

[FFmpeg-devel] [PATCH] Update decode_simple_internal() to get the side data correctly.

From 6418fc43b06cea4cf49e410d474ae92022c4dbd1 Mon Sep 17 00:00:00 2001 From: John Rummell Date: Wed, 14 Jun 2017 14:43:04 -0700 Subject: [PATCH] Update decode_simple_internal() to get the side data correctly. When FF_API_MERGE_SD is set, the compressed side data is expanded into |tmp|, leaving