> On Jul 30, 2025, at 04:02, Kieran Kunhya via ffmpeg-devel
> wrote:
>
> Hello,
>
> It seem there is strong evidence that AI wrote TLS code as part of the
> WHIP patch. It goes without saying why this is bad. Further discussion
> here:
> https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20053
Hello
> On Jul 25, 2025, at 12:18, Gyan Doshi wrote:
>
>
>
> On 2025-07-25 03:29 am, Jack Lau wrote:
>> Signed-off-by: Jack Lau
>> ---
>> Changelog | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Changelog b/Changelog
>&g
Signed-off-by: Jack Lau
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index 228029ea00..27531ad0ab 100644
--- a/Changelog
+++ b/Changelog
@@ -25,6 +25,7 @@ version :
- APV in MP4/ISOBMFF muxing and demuxing
- OpenHarmony hardware decoder/encoder
*JackLau* force-pushed the *whip* from *d0d5c8ddde* (
https://code.ffmpeg.org/FFmpeg/FFmpeg/commit/d0d5c8dddef1c958596cb920559f3b27fb5ff4ed
) to *3d7807e03f* (
https://code.ffmpeg.org/FFmpeg/FFmpeg/commit/3d7807e03f17fb6222d15c452978f445720549cc
).
---
View it on FFmpeg Forgejo (
https://code
This patchset mainly add NACK, RTX, DTLS active support, fix some issues and
optimize the ICE and DTLS code
This version fix issue:
* fix https://ffmpeg.org/pipermail/ffmpeg-devel/2025-July/346906.html
* fix build error when openssl is 1.1.0, log:
libavformat/tls_openssl.c: In function ‘tls_writ
> On Jul 22, 2025, at 20:43, Timo Rothenpieler wrote:
>
> On 22/07/2025 14:36, Jack Lau wrote:
>> Openssl 1.1.0 version haven't DTLS_get_data_mtu API
>> Signed-off-by: Jack Lau
>> ---
>> libavformat/tls_openssl.c | 2 +-
>> 1 file changed, 1
Signed-off-by: Jack Lau
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index 228029ea00..1c6c27919f 100644
--- a/Changelog
+++ b/Changelog
@@ -2,6 +2,7 @@ Entries are sorted chronologically from oldest to youngest
within each release,
releases are
Signed-off-by: Jack Lau
---
doc/muxers.texi| 29 ++---
doc/protocols.texi | 78 ++
2 files changed, 103 insertions(+), 4 deletions(-)
diff --git a/doc/muxers.texi b/doc/muxers.texi
index d2ee90bf33..393e606e12 100644
--- a/doc
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 236 +++---
1 file changed, 118 insertions(+), 118 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 9a8456c438..d42c5c95cf 100644
--- a/libavformat/tls_openssl.c
+++ b
Signed-off-by: Jack Lau
---
libavformat/tls.h | 2 ++
libavformat/tls_openssl.c | 24
libavformat/whip.c| 1 +
3 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/libavformat/tls.h b/libavformat/tls.h
index 157c0d0256..a11f8d6afb 100644
Openssl 1.1.0 version haven't DTLS_get_data_mtu API
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index fa852aac18..54860857c0 100644
--- a/libavformat/tls_open
Fmpeg's request to ensure candidate pair become valid in both directions.
Then the peer does nomination, and ICE is done.
Signed-off-by: Jack Lau
---
libavformat/whip.c | 135 +
1 file changed, 62 insertions(+), 73 deletions(-)
diff --git a/
This value is only useful when dtls handshake is NONBLOCK mode,
dtls handshake just need to call ffurl_handshake once since it
force block mode.
Signed-off-by: Jack Lau
---
libavformat/whip.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/libavformat
See RFC 5245 Section 4.3:
If an agent is a lite implementation, it MUST include an "a=ice-lite"
session-level attribute in its SDP. If an agent is a full
implementation, it MUST NOT include this attribute.
Signed-off-by: Jack Lau
---
libavformat/whip.c | 3 +++
1 file changed, 3
This patch aims to simplify the dtls handshake process
since dtls handshake use force block mode
We can just use the return code instead of DTLSState enum
Signed-off-by: Jack Lau
---
libavformat/tls.h | 15 --
libavformat/tls_openssl.c | 7 -
libavformat/tls_schannel.c
master key plus salt.
Signed-off-by: Jack Lau
---
libavformat/whip.c | 32
1 file changed, 20 insertions(+), 12 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index 094d3a0a4c..e02ed7a8a4 100644
--- a/libavformat/whip.c
+++ b/libavformat/whip.c
Signed-off-by: Jack Lau
---
libavformat/whip.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index 5907865d22..094d3a0a4c 100644
--- a/libavformat/whip.c
+++ b/libavformat/whip.c
@@ -2090,13 +2090,13 @@ static int
Garcia Murillo
Signed-off-by: Jack Lau
---
libavformat/whip.c | 206 -
1 file changed, 202 insertions(+), 4 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index 4de8eb2601..5907865d22 100644
--- a/libavformat/whip.c
+++ b
From: winlin
See RFC5280 4.1.2.2
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 0a7998210f..2689aa5090 100644
--- a/libavformat/tls_openssl.c
+++ b
AVCodecParameters::profile only contains constraint_set1_flag
(AV_PROFILE_H264_CONSTRAINED 1<<9).
So add H264 constraints flag fully parse refer to hlsenc
write_codec_attr
Signed-off-by: Jack Lau
---
libavformat/whip.c | 47 --
1 file chang
mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate,
preventing “No route to host” errors on devices without IPv6 connectivity.
Signed-off-by: Jack Lau
---
libavformat/whip.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/libavformat/whip.c b
Remove redundant "WHIP: " prefix in log context
since it already add whip context.
Fix grammers in whip options descriptions
Signed-off-by: Jack Lau
---
libavformat/whip.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/wh
~
3. clean up dtls code
4. add doc for whip and dtls
Jack Lau (14):
avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates
avformat/whip: fix typos
avformat/whip: fix H264 profile_iop bit map for SDP
avformat/whip: implement NACK and RTX suppport
avformat/whip: reindent w
Fmpeg's request to ensure candidate pair become valid in both directions.
Then the peer does nomination, and ICE is done.
Signed-off-by: Jack Lau
---
libavformat/whip.c | 135 +
1 file changed, 62 insertions(+), 73 deletions(-)
diff --git a/
This value is only useful when dtls handshake is NONBLOCK mode,
dtls handshake just need to call ffurl_handshake once since it
force block mode.
Signed-off-by: Jack Lau
---
libavformat/whip.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/libavformat
See RFC 5245 Section 4.3:
If an agent is a lite implementation, it MUST include an "a=ice-lite"
session-level attribute in its SDP. If an agent is a full
implementation, it MUST NOT include this attribute.
Signed-off-by: Jack Lau
---
libavformat/whip.c | 3 +++
1 file changed, 3
This patch aims to simplify the dtls handshake process
since dtls handshake use force block mode
We can just use the return code instead of DTLSState enum
Signed-off-by: Jack Lau
---
libavformat/tls.h | 15 --
libavformat/tls_openssl.c | 7 -
libavformat/tls_schannel.c
master key plus salt.
Signed-off-by: Jack Lau
---
libavformat/whip.c | 32
1 file changed, 20 insertions(+), 12 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index 094d3a0a4c..e02ed7a8a4 100644
--- a/libavformat/whip.c
+++ b/libavformat/whip.c
Signed-off-by: Jack Lau
---
libavformat/whip.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index 5907865d22..094d3a0a4c 100644
--- a/libavformat/whip.c
+++ b/libavformat/whip.c
@@ -2090,13 +2090,13 @@ static int
From: winlin
See RFC5280 4.1.2.2
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index a6b358d8f9..778595c721 100644
--- a/libavformat/tls_openssl.c
+++ b
Garcia Murillo
Signed-off-by: Jack Lau
---
libavformat/whip.c | 206 -
1 file changed, 202 insertions(+), 4 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index 4de8eb2601..5907865d22 100644
--- a/libavformat/whip.c
+++ b
AVCodecParameters::profile only contains constraint_set1_flag
(AV_PROFILE_H264_CONSTRAINED 1<<9).
So add H264 constraints flag fully parse refer to hlsenc
write_codec_attr
Signed-off-by: Jack Lau
---
libavformat/whip.c | 47 --
1 file chang
Remove redundant "WHIP: " prefix in log context
since it already add whip context.
Fix grammers in whip options descriptions
Signed-off-by: Jack Lau
---
libavformat/whip.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/wh
mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate,
preventing “No route to host” errors on devices without IPv6 connectivity.
Signed-off-by: Jack Lau
---
libavformat/whip.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/libavformat/whip.c b
This version add DTLS active support, cleanup the ICE and DTLS code
Jack Lau (10):
avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates
avformat/whip: fix typos
avformat/whip: fix H264 profile_iop bit map for SDP
avformat/whip: implement NACK and RTX suppport
avformat
> On Jul 14, 2025, at 03:24, Timo Rothenpieler wrote:
>
> There is no sensible way to handle this otherwise anyway, one just has
> to loop over this function until it succeeds.
> ---
> libavformat/tls_openssl.c | 18 --
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 344b152902..4874260b6b 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat/tls_openssl.c
@@ -787,7 +787,7
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 1c4d114205..344b152902 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat/tls_openssl.c
@@ -465,6 +465,8
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 8
1 file changed, 8 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 4f950a2fde..1c4d114205 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat/tls_openssl.c
@@ -731,10 +731,6 @@ static
the SSL_shutdown in tls_close need call the url_bio_bwrite
so we should keep udp still alive
Signed-off-by: Jack Lau
---
libavformat/whip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index e272254a6f..17a3cd0ea8 100644
--- a
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 3ed4585ecf..4f950a2fde 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat/tls_openssl.c
@@ -695,7 +695,7
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index c824c5452b..3ed4585ecf 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 25318d5fca..c824c5452b 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat
If the handshake is still in progress, dtls_handshake should
return a status code.
init ret=AVERROR(EAGAIN) to match most of FFmpeg code
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/libavformat/tls_openssl.c b
Refer to RFC 5246, RFC 6347
Signed-off-by: Jack Lau
---
libavformat/tls.c | 56 +++
libavformat/tls.h | 2 ++
libavformat/tls_openssl.c | 8 --
3 files changed, 64 insertions(+), 2 deletions(-)
diff --git a/libavformat/tls.c b
dtls_handshake can't return positive code when it still in progressing
2. udp server mode haven't dest_addr so we need set it through last_recv_addr
3. some code cleanup
This patchset depends on Timo's latest schannel patchset
More details: https://github.com/BtbN/FFmpeg/pull/3
Jac
From: winlin
See RFC5280 4.1.2.2
Co-authored-by: Jack Lau
Signed-off-by: winlin
---
libavformat/tls_openssl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 2a01fb387d..285ea166ac 100644
--- a/libavformat
Signed-off-by: Jack Lau
---
libavformat/whip.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index d954e80830..f7eb6e1323 100644
--- a/libavformat/whip.c
+++ b/libavformat/whip.c
@@ -2089,13 +2089,13 @@ static int
Garcia Murillo
Signed-off-by: Jack Lau
---
libavformat/whip.c | 206 -
1 file changed, 202 insertions(+), 4 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index f1f8d1b4ad..d954e80830 100644
--- a/libavformat/whip.c
+++ b
AVCodecParameters::profile only contains constraint_set1_flag
(AV_PROFILE_H264_CONSTRAINED 1<<9).
So add H264 constraints flag fully parse refer to hlsenc
write_codec_attr
Signed-off-by: Jack Lau
---
libavformat/whip.c | 47 --
1 file chang
Remove redundant "WHIP: " prefix in log context
since it already add whip context.
Fix grammers in whip options descriptions
Signed-off-by: Jack Lau
---
libavformat/whip.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/wh
mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate,
preventing “No route to host” errors on devices without IPv6 connectivity.
Signed-off-by: Jack Lau
---
libavformat/whip.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/libavformat/whip.c b
Version 3 of https://ffmpeg.org/pipermail/ffmpeg-devel/2025-July/346052.html
This patchset rebase latest commit
Jack Lau (5):
avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates
avformat/whip: fix typos
avformat/whip: fix H264 profile_iop bit map for SDP
avformat/whip
> On Jul 11, 2025, at 23:05, Steven Liu
> wrote:
>
> Jack Lau <mailto:jacklau1222gm-at-gmail@ffmpeg.org>> 于2025年7月11日周五 21:22写道:
>>
>> If the handshake is still in progress, dtls_handshake should
>> return a positive status code.
>>
>
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index ffd9cd51d2..a519c8c880 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat
If udp is in server mode(init local addr and port through url),
then it maybe haven't dest_addr, so we should set it after udp_read
get the client addr and port
This feature only enable when the new udp option autodetect_dest is specified
Signed-off-by: Jack Lau
---
libavformat/udp.
If the handshake is still in progress, dtls_handshake should
return a positive status code.
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 8639ac9758
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 51 +--
1 file changed, 49 insertions(+), 2 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 2a01fb387d..8639ac9758 100644
--- a/libavformat/tls_openssl.c
+++ b
:
1. dtls_handshake can't return positive code when it still in progressing
2. udp server mode haven't dest_addr so we need set it through last_recv_addr
3. some code cleanup
This patchset depends on Timo's latest schannel patchset
More details: https://github.com/BtbN/FFmpeg/pull
> On Jul 10, 2025, at 06:16, Michael Niedermayer wrote:
>
> On Wed, Jul 09, 2025 at 09:36:26PM +0800, Jack Lau wrote:
>> Signed-off-by: Jack Lau
>> ---
>> libavformat/tls_openssl.c | 51 +--
>> 1 file changed, 49 insertio
> On Jul 9, 2025, at 22:16, Timo Rothenpieler wrote:
>
> On 09/07/2025 15:36, Jack Lau wrote:
>> If udp is in server mode(init local addr and port through url),
>> then it maybe haven't dest_addr, so we should set it after udp_read
>> get the client addr and po
> On Jul 9, 2025, at 22:14, Timo Rothenpieler wrote:
>
> On 09/07/2025 15:36, Jack Lau wrote:
>> If the handshake is still in progress, dtls_handshake should
>> return a positive status code.
>
> Shouldn't dtls_open/start also be calling it in a loop then?
&g
If udp is in server mode(init local addr and port through url),
then it maybe haven't dest_addr, so we should set it after udp_read
get the client addr and port
Signed-off-by: Jack Lau
---
libavformat/udp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavformat/udp.c b/libavf
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index ffd9cd51d2..a519c8c880 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat
If the handshake is still in progress, dtls_handshake should
return a positive status code.
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 8639ac9758
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 51 +--
1 file changed, 49 insertions(+), 2 deletions(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 2a01fb387d..8639ac9758 100644
--- a/libavformat/tls_openssl.c
+++ b
ll in progressing
2. udp server mode haven't dest_addr so we need set it through last_recv_addr
3. some code cleanup
This patchset depends Timo's latest schannel patchset
More details: https://github.com/BtbN/FFmpeg/pull/3
Jack Lau (4):
avformat/tls_openssl: add record trace function
avfor
> On Jul 7, 2025, at 19:28, Timo Rothenpieler wrote:
>
> On 07/07/2025 10:03, Jack Lau wrote:
>>> On Jul 7, 2025, at 02:36, Timo Rothenpieler wrote:
>>>
>>> ---
>>> libavformat/network.h | 2 ++
>>> libavformat/udp.c | 25
> On Jul 7, 2025, at 19:26, Timo Rothenpieler wrote:
>
> On 07/07/2025 08:30, Jack Lau wrote:
>>> On Jul 7, 2025, at 02:36, Timo Rothenpieler wrote:
>>>
>>> ---
>>> libavformat/tls.c | 9 -
>>> libavformat/tls_openssl.
> On Jul 7, 2025, at 02:36, Timo Rothenpieler wrote:
>
> ---
> libavformat/network.h | 2 ++
> libavformat/udp.c | 25 +
> 2 files changed, 19 insertions(+), 8 deletions(-)
>
> diff --git a/libavformat/network.h b/libavformat/network.h
> index ca214087fc..48bb75a758
> On Jul 7, 2025, at 02:36, Timo Rothenpieler wrote:
>
> ---
> libavformat/tls.c | 9 -
> libavformat/tls_openssl.c | 12
> libavformat/whip.c| 5 +
> 3 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/libavformat/tls.c b/libavformat/tls
> On Jul 3, 2025, at 00:56, Timo Rothenpieler wrote:
>
> ---
> libavformat/network.h | 2 ++
> libavformat/udp.c | 25 +
> 2 files changed, 19 insertions(+), 8 deletions(-)
>
> diff --git a/libavformat/network.h b/libavformat/network.h
> index ca214087fc..48bb75a758
> On Jul 4, 2025, at 00:41, Timo Rothenpieler wrote:
>
> On 03.07.2025 17:22, Jack Lau wrote:
>>> On Jul 3, 2025, at 22:24, Timo Rothenpieler wrote:
>>>
>>> On 03.07.2025 03:07, Jack Lau wrote:
>>>>> On Jul 3, 2025, at 00:56, Timo Rothenpiel
> On Jul 3, 2025, at 22:24, Timo Rothenpieler wrote:
>
> On 03.07.2025 03:07, Jack Lau wrote:
>>> On Jul 3, 2025, at 00:56, Timo Rothenpieler wrote:
>>>
>>> ---
>>> libavformat/tls.c | 9 -
>>> libavformat/tls_openssl.c | 3
Garcia Murillo
Signed-off-by: Jack Lau
---
libavformat/whip.c | 206 -
1 file changed, 202 insertions(+), 4 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index e287a3062f..b86e343419 100644
--- a/libavformat/whip.c
+++ b
> On Jul 3, 2025, at 00:56, Timo Rothenpieler wrote:
>
> ---
> libavformat/tls.c | 9 -
> libavformat/tls_openssl.c | 3 +++
> 2 files changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/libavformat/tls.c b/libavformat/tls.c
> index 5ec4cca58a..f888970969 100644
> --- a/lib
Hi
> On Jul 2, 2025, at 21:46, Steven Liu
> wrote:
>
> Jack Lau <mailto:jacklau1222gm-at-gmail@ffmpeg.org>> 于2025年7月2日周三 20:09写道:
>>
>> RTP retransmission described in RFC4588 (RTX) is an effective packet
>> loss recovery technique for real-time
> On Jul 2, 2025, at 13:10, Steven Liu
> wrote:
>
> Jack Lau 于2025年7月2日周三 12:25写道:
>>
>> Signed-off-by: Jack Lau
>> ---
>> libavformat/whip.c | 21 ++---
>> 1 file changed, 14 insertions(+), 7 deletions(-)
>>
>> diff --
Garcia Murillo
Signed-off-by: Jack Lau
---
libavformat/whip.c | 198 -
1 file changed, 195 insertions(+), 3 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index e287a3062f..fa6e3855d3 100644
--- a/libavformat/whip.c
+++ b
Signed-off-by: Jack Lau
---
libavformat/whip.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index fa6e3855d3..0c44ef6c73 100644
--- a/libavformat/whip.c
+++ b/libavformat/whip.c
@@ -2081,13 +2081,13 @@ static int
From: winlin
See RFC5280 4.1.2.2
Co-authored-by: winlin
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 2a3905891d..4733faec9c 100644
--- a/libavformat
AVCodecParameters::profile only contains constraint_set1_flag
(AV_PROFILE_H264_CONSTRAINED 1<<9).
So add H264 constraints flag fully parse refer to hlsenc
write_codec_attr
Signed-off-by: Jack Lau
---
libavformat/whip.c | 47 --
1 file chang
Remove redundant "WHIP: " prefix in log context
since it already add whip context.
Fix grammers in whip options descriptions
Signed-off-by: Jack Lau
---
libavformat/whip.c | 152 ++---
1 file changed, 76 insertions(+), 76 deletions(-)
di
mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate,
preventing “No route to host” errors on devices without IPv6 connectivity.
Signed-off-by: Jack Lau
---
libavformat/whip.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/libavformat/whip.c b
to avoid misunderstanding
* add rtx_history_size option which can set the size of rtp packet history
buffer
Jack Lau (5):
avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates
avformat/whip: fix typos
avformat/whip: fix H264 profile_iop bit map for SDP
avformat/whip: implem
> On Jul 2, 2025, at 13:16, Steven Liu
> wrote:
>
> Jack Lau <mailto:jacklau1222gm-at-gmail@ffmpeg.org>> 于2025年7月2日周三 12:35写道:
>>
>> RTP retransmission described in RFC4588 (RTX) is an effective packet
>> loss recovery technique for real-time
Garcia Murillo
Signed-off-by: Jack Lau
---
libavformat/whip.c | 198 -
1 file changed, 195 insertions(+), 3 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index 15d1de691e..a32177e0b4 100644
--- a/libavformat/whip.c
+++ b
AVCodecParameters::profile only contains constraint_set1_flag
(AV_PROFILE_H264_CONSTRAINED 1<<9).
So add H264 constraints flag fully parse refer to hlsenc
write_codec_attr
Signed-off-by: Jack Lau
---
libavformat/whip.c | 47 --
1 file chang
From: winlin
See RFC5280 4.1.2.2
Co-authored-by: winlin
Signed-off-by: Jack Lau
---
libavformat/tls_openssl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index 2a3905891d..4733faec9c 100644
--- a/libavformat
Remove redundant "WHIP: " prefix in log context
since it already add whip context.
Fix grammers in whip options descriptions
Signed-off-by: Jack Lau
---
libavformat/whip.c | 152 ++---
1 file changed, 76 insertions(+), 76 deletions(-)
di
mark this ignore_ipv6 flag could ignore any IPv6 ICE candidate,
preventing “No route to host” errors on devices without IPv6 connectivity.
Signed-off-by: Jack Lau
---
libavformat/whip.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/libavformat/whip.c b/libavformat/whip.c
Signed-off-by: Jack Lau
---
libavformat/whip.c | 21 ++---
1 file changed, 14 insertions(+), 7 deletions(-)
diff --git a/libavformat/whip.c b/libavformat/whip.c
index be6ee9c951..8d1be90f32 100644
--- a/libavformat/whip.c
+++ b/libavformat/whip.c
@@ -1904,13 +1904,20 @@ static
testing that patchset until it can really work.
I've been test this patch with Pion, Janus and it works well.
Jack Lau (5):
avformat/whip: add whip_flags ignore_ipv6 to skip IPv6 ICE candidates
avformat/whip: reindent whip options
avformat/whip: fix typos
avformat/whip: fix H264 profil
> On Jun 29, 2025, at 19:47, Timo Rothenpieler wrote:
>
> On 29.06.2025 05:14, Jack Lau wrote:
>>> On Jun 29, 2025, at 11:11, Jack Lau wrote:
>>>
>>> Hi Timo,
>>>> On Jun 29, 2025, at 06:49, Timo Rothenpieler wrote:
>>>>
>&g
> On Jun 29, 2025, at 11:11, Jack Lau wrote:
>
> Hi Timo,
>> On Jun 29, 2025, at 06:49, Timo Rothenpieler wrote:
>>
>> I've actually cleaned this up a bit while trying to implement DTLS via
>> schannel, and effectively removed the whole section:
>>
Hi Timo,
> On Jun 29, 2025, at 06:49, Timo Rothenpieler wrote:
>
> I've actually cleaned this up a bit while trying to implement DTLS via
> schannel, and effectively removed the whole section:
>
>> https://github.com/BtbN/FFmpeg/commit/b6794f1373fb07b791cfacd2189c7efc4d6bdbcc
>
> There's also
> On Jun 28, 2025, at 22:15, Marvin Scholz
> wrote:
>
> On 28 Jun 2025, at 4:17, Jack Lau via ffmpeg-devel wrote:
>
>> AV_OPT_TYPE_INT,{ .i64 = 1200 },-1,
>> INT_MAX, ENC },
>> -{ "authorization"
--- Begin Message ---
Remove redundant "WHIP: " prefix in log context
since it already add whip context.
Fix grammers in whip options descriptions
Signed-off-by: Jack Lau
---
libavformat/tls.c | 2 +-
libavformat/whip.c | 152 ++---
2 fil
> On Jun 27, 2025, at 22:03, Marvin Scholz
> wrote:
>
> On 13 Jun 2025, at 10:56, Jack Lau via ffmpeg-devel wrote:
>
>> mark this ignore_ipv6 flag could ignore any ipv6 ICE candidate,
>> preventing “No route to host” errors on devices without IPv6 connectivity.
>
--- Begin Message ---
Remove redundant "WHIP: " prefix in log context
since it already add whip context.
Fix grammers in whip options "The Optional" > "(Optional)"
Signed-off-by: Jack Lau
---
libavformat/tls.c | 2 +-
libavformat/whip.c | 152 +++
1 - 100 of 174 matches
Mail list logo