[FFmpeg-devel] [PATCH] avformat/dashdec: just make seg->url in absolute path once

2025-04-09 Thread Jack Lau via ffmpeg-devel
Should fix ticket 11543 if input url is relative path, the seg-url would make absolute url twice in get_content_url and open_input function but it doesn't need make absolute url in open_input since we set it already Signed-off-by: Jack Lau --- libavformat/dashdec.c | 2 +- 1 file chang

[FFmpeg-devel] [PATCH] avformat/rtpdec_mpeg4: add need_parsing for rtsp AAC

2025-04-08 Thread Jack Lau via ffmpeg-devel
patch add it Signed-off-by: Jack Lau --- libavformat/rtpdec_mpeg4.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/rtpdec_mpeg4.c b/libavformat/rtpdec_mpeg4.c index 6531632b2d..c506bcbed1 100644 --- a/libavformat/rtpdec_mpeg4.c +++ b/libavformat/rtpdec_mpeg4.c @@ -363,6 +363,7

Re: [FFmpeg-devel] [PATCH] avformat/dashenc: add hevc codec attributes parse

2025-03-27 Thread Jack Lau
> On Mar 12, 2025, at 15:06, Jack Lau via ffmpeg-devel > wrote: > > fix ticket: 11316 > add set_hevc_codec_str function refer to hlsenc.c but do some necessary > changes > Signed-off-by: Jack Lau > --- > libavformat/dashenc.c | 81 +

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: calculate bitrate for segments with duration < 0.5

2025-03-23 Thread Jack Lau
> On Mar 24, 2025, at 08:11, Steven Liu wrote: > > Jack Lau via ffmpeg-devel <mailto:ffmpeg-devel@ffmpeg.org>> 于2025年3月24日周一 07:13写道: >> >> The previous code sets the bitrate to be calculated only when duration>0.5, >> which is obviously not general e

[FFmpeg-devel] [PATCH] avformat/hlsenc: calculate bitrate for segments with duration < 0.5

2025-03-23 Thread Jack Lau via ffmpeg-devel
mpty, and ff_hls_write_stream_info cannot write stream info normally, causing master_pl to be unavailable. Signed-off-by: Jack Lau --- libavformat/hlsenc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index c6ffdb99e5..223c516103 100

[FFmpeg-devel] [PATCH] avformat/dashenc: add hevc codec attributes parse

2025-03-12 Thread Jack Lau via ffmpeg-devel
fix ticket: 11316 add set_hevc_codec_str function refer to hlsenc.c but do some necessary changes Signed-off-by: Jack Lau --- libavformat/dashenc.c | 81 +++ 1 file changed, 81 insertions(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-02 Thread Jack Lau via ffmpeg-devel
fix ticket: 10786 parse the SPS from extradata and get profile_compatibility, tier, constraints which was been hard code before. HEVC CODECS Attribute reference to: ISO/IEC14496-15 Signed-off-by: Jack Lau --- libavformat/hlsenc.c | 38 +++--- 1 file changed, 35

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-02 Thread Jack Lau
> On Mar 3, 2025, at 09:08, Steven Liu wrote: > > Jack Lau via ffmpeg-devel <mailto:ffmpeg-devel@ffmpeg.org>> 于2025年3月2日周日 21:31写道: >> >> fix ticket: 10786 >> parse the SPS from extradata and get profile_compatibility, tier, >> constraints which was

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-02 Thread Jack Lau via ffmpeg-devel
fix ticket: 10786 parse the SPS from extradata and get profile_compatibility, tier, constraints which was been hard code before. HEVC CODECS Attribute reference to: ISO/IEC14496-15 Signed-off-by: Jack Lau --- libavformat/hlsenc.c | 38 +++--- 1 file changed, 35

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-02 Thread Jack Lau
> On Mar 2, 2025, at 15:47, Jack Lau via ffmpeg-devel > wrote: > > fix ticket: 10786 > parse the SPS from extradata and get profile_compatibility, tier, constraints > which was been hard code before. > > HEVC CODECS Attribute reference to: ISO/IEC14496-15 &

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-02 Thread Jack Lau via ffmpeg-devel
fix ticket: 10786 parse the SPS from extradata and get profile_compatibility, tier, constraints which was been hard code before. HEVC CODECS Attribute reference to: ISO/IEC14496-15 Signed-off-by: Jack Lau --- libavformat/hlsenc.c | 41 ++--- 1 file changed

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS Attribute hard code in hevc EXT-X-STREAM-INF

2025-03-01 Thread Jack Lau via ffmpeg-devel
fix ticket: 10786 parse the SPS from extradata and get profile_compatibility, tier, constraints which was been hard code before. HEVC CODECS Attribute reference to: ISO/IEC14496-15 Signed-off-by: Jack Lau --- libavformat/hlsenc.c | 37 ++--- 1 file changed, 34

[FFmpeg-devel] avoption: make the avoption like seekable more general

2025-02-11 Thread Jack Lau
Hi everyone, I’m trying to solve this issue https://trac.ffmpeg.org/ticket/11394. This ticket shows that we need use `-seekable` and `-http_seekable` to control the range header if send. Because these options belong to different file(hls.c and http.c) So I try to modify the http_seekable to se

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Jack Lau
> On Feb 10, 2025, at 11:08, Marth64 wrote: > > I don't think its fair to shoot this down, its a simple but valid tidy up > work. > I find typos and such when browsing code distracting and readability > important down the road. > Not everyone's first language is English and grammar correction

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Jack Lau
> On Feb 10, 2025, at 09:36, Soft Works > wrote: > > > >> -Original Message- >> From: ffmpeg-devel > <mailto:ffmpeg-devel-boun...@ffmpeg.org>> On Behalf Of >> Jack Lau >> Sent: Monday, February 10, 2025 2:13 AM >> To: FFmp

Re: [FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Jack Lau
rtant patches. Best wishes Jack > On Feb 10, 2025, at 08:54, Soft Works > wrote: > > > >> -Original Message- >> From: ffmpeg-devel > <mailto:ffmpeg-devel-boun...@ffmpeg.org>> On Behalf Of >> Jack Lau via ffmpeg-devel >> Sent: Monday,

[FFmpeg-devel] [PATCH] avformat/hls: fix typo There is an extra space in the original comment

2025-02-09 Thread Jack Lau via ffmpeg-devel
--- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 3bdc1bc848..c2130bb883 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1993,7 +1993,7 @@ static int hls_read_header(AVFormatContext *s) return r

[FFmpeg-devel] [PATCH] avformat/mpegenc: increase the default size of the VBV buffer

2025-02-08 Thread Jack Lau via ffmpeg-devel
Increase the default buffer size to match more modern encoding scenarios. --- libavformat/mpegenc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/mpegenc.c b/libavformat/mpegenc.c index 6b6763c30f..2b3b98b894 100644 --- a/libavformat/mpegenc.c +++ b/libavform

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Jack Lau
Hi softworkz, Thank you very much for your patient reply and kind suggestions. I am new to the FFmpeg devel mailing list, and English is not my native language, so there is still a lot for me to learn. May I ask a question? How long does it usually take for a patch to be reviewed? A few days a

Re: [FFmpeg-devel] Captions SCC

2025-02-07 Thread Jack Lau
> > Hi Jack, > > "paying attention next time"? That's not the right answer. > > Please make sure that there won't be a next time. > > The big evil with LLVMs is not the fact they are making mistakes but the > extreme level of confidence at which they are presenting these mistakes - > like n

Re: [FFmpeg-devel] Captions SCC

2025-02-06 Thread Jack Lau
> > > Hi Zack, > > that message from "Jack" had confused me for a moment, but on re-reading it > appears to be an AI response. > The content is total nonsense. There is no "SCC" encoder in ffmpeg, and if > there was one, it wouldn't help much because the CC data needs to get into > the video

Re: [FFmpeg-devel] Captions SCC

2025-02-06 Thread Jack Lau
> I have been absent from the list for a few years, so I would appreciate it > if someone could catch me up a bit. I am needing to extract and embed scc > files with 608 captions. I am pleased to see that transcoding without > frame rate changes now preserves 608 intact, and there appear to be

Re: [FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-05 Thread Jack Lau
. Could any one give me some advice please so that i can fix it? On Wed, Feb 5, 2025 at 11:25 AM Jack Lau wrote: > To be clear, i want to give an example, i use a 10s duration, 30fps video. > The ifmt_ctx->streams[stream_index]->time_base is same as > ofmt_ctx->streams[stream

[FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-05 Thread Jack Lau via ffmpeg-devel
From: Jack Lau The `dec_ctx->time_base` was incorrectly default set by avcodec_open2(), while `enc_ctx->time_base` was derived from `dec_ctx->framerate`. This mismatch could cause incorrect video duration in the output. This patch corrects the issue by adjusting the `enc_ctx-&

[FFmpeg-devel] [PATCH v2] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau via ffmpeg-devel
culation to account for `ticks_per_frame`, ensuring that the time base is consistent between the decoder and encoder contexts. --- Begin Message --- From 6a02fbaf6c6068040640ff105ad70115fb81b5d2 Mon Sep 17 00:00:00 2001 From: Jack Lau Date: Tue, 4 Feb 2025 21:39:20 +0800 Subject: [PATCH] examples/tran

Re: [FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
tb: 60 output pkt in_tb: 30 out_tb: 15360 so i get one 20s duration and 15fps video(audio duration is normal because the input's audio sample ratio is 44100) So i think the problem is that the enc_ctx->time_base shouldn't set to av_inv_q(dec_ctx->frame

Re: [FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
> > AVCodecContext.time_base is not used for decoding. Thank you for your reply. I understand that time_base is not used during decoding, but the transcoding code calls av_packet_rescale_ts twice, once before decoding and once after encoding, as shown below: 540 if (filter_ctx[stream_

Re: [FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
> > AVCodecContext.time_base is not used for decoding. Thank you for your reply. I understand that time_base is not used during decoding, but the transcoding code calls av_packet_rescale_ts twice, once before decoding and once after encoding, as shown below: 540 if (filter_ctx[stream_

[FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
ling issues and ensure correct video duration. Signed-off-by: Jack Lau --- doc/examples/transcoding.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcoding.c b/doc/examples/transcoding.c index 013f89fc7d..847bdb7e1a 100644 --- a/doc/examples/transcod

[FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
fix-time-base-handling.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubs

[FFmpeg-devel] [PATCHv3] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
--- Begin Message --- From bfd5500a5448ad468d32994816e8a55c0d4a2428 Mon Sep 17 00:00:00 2001 From: Jack Lau Date: Tue, 4 Feb 2025 21:39:20 +0800 Subject: [PATCH] examples/transcoding: Fix time_base handling X-Unsent: 1 To: ffmpeg-devel@ffmpeg.org The `dec_ctx->time_base` was incorrectly defa

[FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
The `dec_ctx->time_base` was incorrectly default set to 0/60, while `enc_ctx->time_base` was derived from `dec_ctx->framerate`. This mismatch could cause incorrect video duration in the output. This patch aligns `enc_ctx->time_base` with `dec_ctx->time_base` to prevent rescaling issues and ensu

[FFmpeg-devel] [PATCH] examples/transcoding: Fix time_base handling

2025-02-04 Thread Jack Lau
sues and ensure correct video duration. Signed-off-by: Jack Lau --- doc/examples/transcoding.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcoding.c b/doc/examples/transcoding.c index 013f89fc7d..847bdb7e1a 100644 --- a/doc/examples/transcoding.c +++