Hi Andreas,
You're right - apologies. So in fact there was an exchange of one kind of
undefined behaviour for another.
Thanks
Jack
On Thu, Aug 6, 2020 at 1:52 PM Andreas Rheinhardt <
andreas.rheinha...@gmail.com> wrote:
> Jack Haughton:
> > A NULL check in av_pars
Commit a500b975 removed NULL input handling from this function,
moving the check higher up the call tree in one branch. However,
there is another call to set_string_video_rate() which may pass
NULL, and future users of the function may not be clear that
a NULL check is required. This patch restores
much
certainly a segmentation fault, the documentation marks it as undefined
behaviour, which is, well, undefined - and therefore not to be relied upon
IMO.
Thanks
Jack
On Tue, Aug 4, 2020 at 2:58 PM Nicolas George wrote:
> Jack Haughton (12020-08-04):
> > Absolutely, he should fix his code.
; 0)
av_log(obj, AV_LOG_ERROR, "Unable to parse option value \"%s\" as
video rate\n", val);
return ret;
--
2.17.0.windows.1
On Wed, Aug 5, 2020 at 2:12 PM Jack Haughton
wrote:
> Fair enough, I agree an assert would be better - I'll send another patch.
>
>
d you explain why you
would not want to do that?
Thanks
Jack
On Mon, Aug 3, 2020 at 11:27 PM Michael Niedermayer
wrote:
> On Mon, Aug 03, 2020 at 02:07:36PM +0100, Jack Haughton wrote:
> > A NULL check in av_parse_video_rate() would certainly not be a bad idea.
> It
> > woul
t; On Sun, Aug 02, 2020 at 08:40:27PM +0100, Jack Haughton wrote:
> > Hello,
> >
> > Apologies for the delay in replying. This patch is not to address a
> > specific problem that currently exists, but rather to restore the
> > robustness to invalid input that previously
Hi
>
> On Fri, Jul 31, 2020 at 03:53:56PM +0100, Jack Haughton wrote:
> > Commit a500b975 removed NULL input handling from this function,
> > moving the check higher up the call tree in one branch. However,
> > there is another call to set_string_video_rate() which may pass
&g
Commit a500b975 removed NULL input handling from this function,
moving the check higher up the call tree in one branch. However,
there is another call to set_string_video_rate() which may pass
NULL, and future users of the function may not be clear that
a NULL check is required. This patch restores
