Re: [FFmpeg-devel] [PATCH] libavdevice: fix compilation for Mac OS X 10.7-10.12, iOS < 11

2024-08-20 Thread Gnattu OC via ffmpeg-devel
> On Aug 21, 2024, at 07:17, epira...@gmail.com wrote: > > > > On 21 Aug 2024, at 0:43, Erik Bråthen Solem wrote: > >> avfoundation.m uses constants prefixed with AVMediaType on Mac OS X > 10.6. >> In 10.7 through 10.12 their type was NSString*, but starting with 10.13 a >> new AVMediaType st

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: always release supported_props

2024-08-15 Thread Gnattu OC via ffmpeg-devel
> On Aug 15, 2024, at 19:59, Zhao Zhili wrote: > > > >> On Aug 10, 2024, at 14:06, gnattu via ffmpeg-devel >> wrote: >> >> In vtenc_populate_extradata, supported_props should always be released >> to avoid memory leak. >> >> Regression from cd2f8a22e94700c68b1de7968df11e8bebfd315b >> >>

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Allocate attachments dictionary

2024-08-01 Thread Gnattu OC via ffmpeg-devel
Replaced by: https://ffmpeg.org//pipermail/ffmpeg-devel/2024-August/331962.html > On Aug 2, 2024, at 06:47, epira...@gmail.com wrote: > > > > On 2 Aug 2024, at 0:25, gnattu via ffmpeg-devel wrote: > >> From: Gnattu OC >> >> Allocate a dedicated attachm

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix build with older SDKs

2024-07-21 Thread Gnattu OC via ffmpeg-devel
> On Jul 22, 2024, at 06:45, Gnattu OC via ffmpeg-devel > wrote: > > > >> On Jul 22, 2024, at 06:04, Sean McGovern wrote: >> >> Hi Marvin, >> >> >> On Tue, Jul 9, 2024, 10:47 Marvin Scholz wrote: >> >>> I've accid

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix build with older SDKs

2024-07-21 Thread Gnattu OC via ffmpeg-devel
> On Jul 22, 2024, at 06:04, Sean McGovern wrote: > > Hi Marvin, > > > On Tue, Jul 9, 2024, 10:47 Marvin Scholz wrote: > >> I've accidentally used API not available on the checked version. >> Additionally check for the SDK to be new enough to even have the >> CVImageBufferCreateColorSpaceF

Re: [FFmpeg-devel] videotoolbox increases min target to macOS 12

2024-07-08 Thread Gnattu OC via ffmpeg-devel
> On Jul 9, 2024, at 13:47, Helmut K. C. Tessarek wrote: > > I'm very sorry to bother the dev list with this, but this is the 2nd time in > less than a year that the min version of macOS was changed in videotoolbox. > > 2023-09-22: macOS 10.13 > now: macOS 12 > > Will ffmpeg soon only compil

Re: [FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Set proper CVBuffer colorspace

2024-05-20 Thread Gnattu OC via ffmpeg-devel
> On May 20, 2024, at 09:12, Marvin Scholz wrote: > > Fix #10884 > --- > libavutil/hwcontext_videotoolbox.c | 54 +- > 1 file changed, 38 insertions(+), 16 deletions(-) > > diff --git a/libavutil/hwcontext_videotoolbox.c > b/libavutil/hwcontext_videotoolbox.c > ind

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-17 Thread Gnattu OC via ffmpeg-devel
Can you try to change the `BD_PRIVATE` to `__attribute__((visibility("hidden")))` in the line defines `dec_init` src/libbluray/disc/dec.h then recompile libbluray to see if it fixes the linking issue? > On Mar 17, 2024, at 05:09, Helmut K. C. Tessarek wrote: > > Hi, > > On 2024-03-16 10:26,

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-16 Thread Gnattu OC via ffmpeg-devel
If you are using Xcode >= 15 then you will need to add `-Wl,-ld_classic` to LDFLAGS. During configure you will also need to set `--host-ldflags='-Wl,-ld_classic’`. > On Mar 16, 2024, at 09:04, Helmut K. C. Tessarek wrote: > > Hello, > > It's me again - the dude who compiles ffmpeg for macOS.

Re: [FFmpeg-devel] [PATCH v4] avfilter: add vf_overlay_videotoolbox

2024-03-05 Thread Gnattu OC via ffmpeg-devel
d, it will perform format > conversion automatically with hardware accelerated methods. > > Signed-off-by: Gnattu OC > --- > Changes from v3: > > - Fixes an issue that 8bit depth BGRA overlay frames are not correctly > converted to 16bit > - Added a constraint to input

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-23 Thread Gnattu OC via ffmpeg-devel
I’ve tested and confirmed to work, and `reverse=1` also works for chaining to other videotoolbox filters. > On Feb 23, 2024, at 22:25, Zhao Zhili wrote: > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] [PATCH v3] avfilter: add vf_overlay_videotoolbox

2024-02-23 Thread Gnattu OC via ffmpeg-devel
ally with hardware accelerated methods. > > Signed-off-by: Gnattu OC > --- > Changelog | 1 + > configure | 1 + > doc/filters.texi | 52 ++ > libavfilter/Makefile

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Gnattu OC via ffmpeg-devel
wrote: >>> >>> On 22/02/2024 18:46, gnattu via ffmpeg-devel wrote: >>>> There is no device context to be setup, nor devices to be >>>> selected with VideoToolbox. Just a simple return would allow >>>> us to use derived device in fi

[FFmpeg-devel] [PATCH] avformat/hls: Add option to retry failed segments for hls

2022-10-10 Thread Gnattu OC
Current HLS implementation simply skip a failed segment to catch up the stream, but this is not optimal for some use cases like livestream recording. Add an option to retry a failed segment to ensure the output file is a complete stream. Signed-off-by: gnattu --- libavformat/hls.c | 15 +