Re: [FFmpeg-devel] [PATCH 3.4] configure: add LIBDRM to Libs.private instead of Libs

2019-01-29 Thread Giulio Benetti
Hello, Il 21/10/2018 22:43, Giulio Benetti ha scritto: Currently LIBDRM is appended to Libs: in libavutil.pc. This causes every program linking with avutil to link with -ldrm in both shared and static linking cases. In shared linking case it makes no sense, since -ldrm is a dependency of

[FFmpeg-devel] [PATCH 3.4] configure: add LIBDRM to Libs.private instead of Libs

2018-10-21 Thread Giulio Benetti
privatelibs_avutil variable for explicit private libraries to be appended to Libs.private: - Add $LIBDRM to privatelibs_avutil. Signed-off-by: Giulio Benetti --- configure | 3 ++- ffbuild/pkgconfig_generate.sh | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff

Re: [FFmpeg-devel] [PATCH 3.4 0/2] configure: fix LIBDRM handling for static linking

2018-10-17 Thread Giulio Benetti
Il 17/10/2018 21:48, Hendrik Leppkes ha scritto: On Wed, Oct 17, 2018 at 9:45 PM Moritz Barsnick wrote: On Wed, Oct 17, 2018 at 21:40:58 +0200, Giulio Benetti wrote: PS: do I need to remove your e-mail on TO field every time I reply to you? It's not a problem, only to know. This ma

Re: [FFmpeg-devel] [PATCH 3.4 0/2] configure: fix LIBDRM handling for static linking

2018-10-17 Thread Giulio Benetti
Il 17/10/2018 21:45, Moritz Barsnick ha scritto: On Wed, Oct 17, 2018 at 21:40:58 +0200, Giulio Benetti wrote: PS: do I need to remove your e-mail on TO field every time I reply to you? It's not a problem, only to know. This mailing list uses a Reply-To: header, pointing at the list ad

Re: [FFmpeg-devel] [PATCH 3.4 0/2] configure: fix LIBDRM handling for static linking

2018-10-17 Thread Giulio Benetti
Il 17/10/2018 21:23, Carl Eugen Hoyos ha scritto: 2018-10-17 21:20 GMT+02:00, Giulio Benetti : Il 17/10/2018 18:51, Carl Eugen Hoyos ha scritto: I just meant that it was a mistake that above patch was backported although it neither fixes a security issue nor a regression. Ok, I understand

Re: [FFmpeg-devel] [PATCH 3.4 0/2] configure: fix LIBDRM handling for static linking

2018-10-17 Thread Giulio Benetti
x27;t add me in CC or TO, this confuses me and my email client;-) Ok, no problem. Thank you Best regards -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vigonza (PD) Tel. 049/8931563 - Fax 049/8931346 Cod.Fiscale - P.IVA 02663420285 Capitale Sociale € 26.000 i.v. Iscritta a

Re: [FFmpeg-devel] [PATCH 3.4 0/2] configure: fix LIBDRM handling for static linking

2018-10-17 Thread Giulio Benetti
Re-add everybody in Cc Il 17/10/2018 15:08, Carl Eugen Hoyos ha scritto: 2018-10-17 14:02 GMT+02:00, Giulio Benetti : Commit c50dc77ac708e98d02da7c422a6b9cbf9f565aa5 has a pitfall, it appends -ldrm to "Libs:" instead of "Libs.private:" in avutil.pc. Assuming this was not

[FFmpeg-devel] [PATCH 3.4 2/2] configure: add LIBDRM to Libs.private introducing privatelibs_avutil

2018-10-17 Thread Giulio Benetti
rm to Libs.private:. - Create LIBDRM and add -ldrm to it in case libdrm is enabled. - Add privatelibs_avutil variable for explicit private libraries to be appended to Libs.private: in pkgconfig_generate.sh. - Add $LIBDRM to privatelibs_avutil. Signed-off-by: Giulio Benetti --- conf

[FFmpeg-devel] [PATCH 3.4 0/2] configure: fix LIBDRM handling for static linking

2018-10-17 Thread Giulio Benetti
patch to handle explicit private libraries introducing privatelibs_avutil and handle it in pkgconfig_generate.sh. Giulio Benetti (2): Revert "configure: add LIBDRM to extralibs_avutil" configure: add LIBDRM to Libs.private introducing privatelibs_avutil configure

[FFmpeg-devel] [PATCH 3.4 1/2] Revert "configure: add LIBDRM to extralibs_avutil"

2018-10-17 Thread Giulio Benetti
This reverts commit c50dc77ac708e98d02da7c422a6b9cbf9f565aa5. The offending commit appends -ldrm to "Libs:" instead of "Libs.private:" in libavutil.pc. This makes no sense, since -ldrm must be listed in linking libraries list only when static linking. Signed-of

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread Giulio Benetti
Il 11/09/2018 23:38, Carl Eugen Hoyos ha scritto: 2018-09-11 23:34 GMT+02:00, Giulio Benetti : Il 11/09/2018 23:24, Giulio Benetti ha scritto: Hello, Il 11/09/2018 23:21, James Almer ha scritto: -lswscale -lavdevice -lavformat -lavcodec -lssl -lcrypto -lspeex -lmodplug -lstdc++ -lfontconfig

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread Giulio Benetti
Il 11/09/2018 23:34, James Almer ha scritto: On 9/11/2018 6:24 PM, Giulio Benetti wrote: Hello, Il 11/09/2018 23:21, James Almer ha scritto: -lswscale -lavdevice -lavformat -lavcodec -lssl -lcrypto -lspeex -lmodplug -lstdc++ -lfontconfig -lfreetype -lpng16 -lexpat -ldrm -lz -pthread -latomic

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread Giulio Benetti
Il 11/09/2018 23:24, Giulio Benetti ha scritto: Hello, Il 11/09/2018 23:21, James Almer ha scritto: -lswscale -lavdevice -lavformat -lavcodec -lssl -lcrypto -lspeex -lmodplug -lstdc++ -lfontconfig -lfreetype -lpng16 -lexpat -ldrm -lz -pthread -latomic -lswresample  -lavutil -lm What i&#

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread Giulio Benetti
equate fix. Can you point me the right way to fix this? It was the only way I've found to have it working. Thanks in advance Giulio Benetti ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread Giulio Benetti
Hello, Il 11/09/2018 22:49, James Almer ha scritto: On 9/11/2018 5:29 PM, Giulio Benetti wrote: When static linking programs using ffmpeg libraries, if linking against libavutil, -ldrm is listed before -lavutil. This leads to linking failure due to undefined reference of drmGetVersion() and

[FFmpeg-devel] [PATCH] configure: add LIBDRM to extralibs_avutil

2018-09-11 Thread Giulio Benetti
vutil. Create LIBDRM=-ldrm in case libdrm is enabled and add $LIBDRM to extralibs_avutil. Signed-off-by: Giulio Benetti --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index ef97c6b500..28bc3481bc 100755 --- a/configure +++ b/conf