Hi,
gentle ping about this patch I sent a few months ago, receiving no reply.
Thanks, Giovanni.
Il 31/07/24 11:45, Giovanni Mascellani ha scritto:
The specification says that if either the numerator or the
denominator is zero then the SAR is to be intended unspecified.
Internally ffmpeg
.
Signed-off-by: Giovanni Mascellani
---
libavcodec/h2645_vui.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/h2645_vui.c b/libavcodec/h2645_vui.c
index e5c7bf46f9..c8df733399 100644
--- a/libavcodec/h2645_vui.c
+++ b/libavcodec/h2645_vui.c
@@ -46,6 +46,8 @@ void
Hi,
Il 30/07/24 22:54, michael at niedermayer.cc (Michael Niedermayer) ha
scritto:
Why does playback fail ? > 1/1 and unspecified are different things, 0/0 would
be unspecified
where does 20480/0 turn into 20480/1 ? or did i misunderstand this?
It seems that denominator 0 is replaced with 1
The specification doesn't say what should happen in this case.
Other implementations (e.g., Microsoft's Media Foundations) seem
to interpret this as 1/1.
Signed-off-by: Giovanni Mascellani
---
libavcodec/evc_ps.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavcodec/
The specification doesn't say what should happen in this case.
Other implementations (e.g., Microsoft's Media Foundations) seem
to interpret this as 1/1.
Signed-off-by: Giovanni Mascellani
---
libavcodec/h2645_vui.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavcodec/h
y first contributing to ffmpeg and I am not very
experienced in the project architecture, I'm not sure this is the
right abstraction level at which this problem should be handled. If
it's not, I'd be grateful if you could direct me to the appropriate
place.
Giovanni Mascellani (2
