[FFmpeg-devel] [PATCH v2 2/2] avformat/hls: Add subtitle support

2017-02-05 Thread Franklin Phillips
Each subtile segment is a WebVTT file and needs to be demuxed separately. These segments also contain a header to synchronize their timing with the MPEG TS stream so those timestamps are requested from the WebVTT demuxer through an AVOption. Signed-off-by: Franklin Phillips --- libavformat

[FFmpeg-devel] [PATCH v2 1/2] avformat/webvttdec: Add support for HLS WebVTT MPEG timestamp map

2017-02-05 Thread Franklin Phillips
WebVTT subtitle files in HLS streams contain a header to synchronize the subtitles with the MPEG TS timestamps of the HLS stream. Add an AVOption to prefer MPEG TS style timestamps generated according to the mapping header, if available. Signed-off-by: Franklin Phillips --- libavformat

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2017-02-05 Thread Franklin Phillips
Sorry for the test failure, I didn't realise there were tests for HLS demuxer because the tests don't have HLS in their names. I am sending new patches which don't break the tests. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-30 Thread Franklin Phillips
On Fri, Dec 16, 2016 at 05:13:50PM +0100, wm4 wrote: > On Thu, 15 Dec 2016 22:01:46 + > Franklin Phillips wrote: > > > Hi, > > > > I tested this code by converting HLS streams into mp4 files and it > > seemed to work fine. However I recently compiled mpv

[FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-30 Thread Franklin Phillips
Each subtile segment is a WebVTT file and needs to be demuxed separately. These segments also contain a header to synchronize their timing with the MPEG TS stream so those timestamps are requested from the WebVTT demuxer through an AVOption. Signed-off-by: Franklin Phillips --- libavformat

[FFmpeg-devel] [PATCH 1/2] avformat/webvttdec: Add support for HLS WebVTT MPEG timestamp map

2016-12-30 Thread Franklin Phillips
WebVTT subtitle files in HLS streams contain a header to synchronize the subtitles with the MPEG TS timestamps of the HLS stream. Add an AVOption to prefer MPEG TS style timestamps generated according to the mapping header, if available. Signed-off-by: Franklin Phillips --- libavformat

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-15 Thread Franklin Phillips
Hi, I tested this code by converting HLS streams into mp4 files and it seemed to work fine. However I recently compiled mpv with these changes and when I play back the Apple example stream given in ticket #2833, it seems to skip a lot of subtitles. It works fine for the real world streams I'm usin

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-06 Thread Franklin Phillips
Assuming the reason why my patch wasn't being merged was because it didn't use the X-TIMESTAMP-MAP, I have included the changes for that. Those changes were basically a merge of work done by anssi.hann...@iki.fi which is why I've cc'd them. ___ ffmpeg-de

[FFmpeg-devel] [PATCH 2/2] avformat/hls: Add subtitle support

2016-12-06 Thread Franklin Phillips
Each subtile segment is a WebVTT file and needs to be demuxed separately. These segments also contain a header to synchronize their timing with the MPEG TS stream so those timestamps are requested from the WebVTT demuxer through an AVOption. Signed-off-by: Franklin Phillips --- libavformat

[FFmpeg-devel] [PATCH 1/2] avformat/webvttdec: Add support for HLS WebVTT MPEG timestamp map

2016-12-06 Thread Franklin Phillips
WebVTT subtitle files in HLS streams contain a header to synchronize the subtitles with the MPEG TS timestamps of the HLS stream. Add an AVOption to prefer MPEG TS style timestamps generated according to the mapping header, if available. Signed-off-by: Franklin Phillips --- libavformat

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

2016-11-29 Thread Franklin Phillips
On Tue, Nov 29, 2016 at 07:10:52PM +0100, wm4 wrote: > On Tue, 29 Nov 2016 17:44:15 + > Franklin Phillips wrote: > > > Hi, > > > > If there are no more comments can we look at merging this please? > > I think your previous post implied that subtitles are

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

2016-11-29 Thread Franklin Phillips
Hi, If there are no more comments can we look at merging this please? Thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

2016-11-16 Thread Franklin Phillips
On Wed, Nov 16, 2016 at 12:33:32PM +0100, wm4 wrote: > On Wed, 16 Nov 2016 11:21:59 + > Franklin Phillips wrote: > > > On Wed, Nov 16, 2016 at 11:41:41AM +0100, wm4 wrote: > > > On Wed, 16 Nov 2016 10:31:10 + > > > Franklin Phillips wrote: > > >

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

2016-11-16 Thread Franklin Phillips
On Wed, Nov 16, 2016 at 11:41:41AM +0100, wm4 wrote: > On Wed, 16 Nov 2016 10:31:10 + > Franklin Phillips wrote: > > > This patch is a fix for ticket #2833. > > > > Each subtitle segment is its own WebVTT file and has to demuxed > > individually. > >

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

2016-11-16 Thread Franklin Phillips
On Tue, Nov 15, 2016 at 09:56:39PM +0100, Henrik Gramner wrote: > On Tue, Nov 15, 2016 at 1:39 PM, Franklin Phillips > wrote: > > Sorry, I forgot to mention that my first attempt was using git send-email, > > when that didn't work, I tried mutt, same result using both clie

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

2016-11-16 Thread Franklin Phillips
On Tue, Nov 15, 2016 at 09:56:39PM +0100, Henrik Gramner wrote: > On Tue, Nov 15, 2016 at 1:39 PM, Franklin Phillips > wrote: > > Sorry, I forgot to mention that my first attempt was using git send-email, > > when that didn't work, I tried mutt, same result using both clie

[FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

2016-11-16 Thread Franklin Phillips
conform to the specification (https://tools.ietf.org/html/draft-pantos-http-live-streaming-20#section-3.5). Signed-off-by: Franklin Phillips --- libavformat/hls.c | 178 -- 1 file changed, 159 insertions(+), 19 deletions(-) diff --git a

[FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

2016-11-15 Thread Franklin Phillips
conform to the specification (https://tools.ietf.org/html/draft-pantos-http-live-streaming-20#section-3.5). Signed-off-by: Franklin Phillips --- libavformat/hls.c | 178 -- 1 file changed, 159 insertions(+), 19 deletions(-) diff --git a

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

2016-11-15 Thread Franklin Phillips
On Tue, Nov 15, 2016 at 10:01:01PM +0800, Steven Liu wrote: > 2016-11-15 20:39 GMT+08:00 Franklin Phillips : > > > On Tue, Nov 15, 2016 at 08:04:21PM +0800, Steven Liu wrote: > > > 2016-11-15 18:50 GMT+08:00 Franklin Phillips < > > franklinphillips...@inbox.lv>:

[FFmpeg-devel] [PATCH] avformat/hls: Add subtitle support

2016-11-15 Thread Franklin Phillips
conform to the specification (https://tools.ietf.org/html/draft-pantos-http-live-streaming-20#section-3.5). Signed-off-by: Franklin Phillips --- libavformat/hls.c | 178 -- 1 file changed, 159 insertions(+), 19 deletions(-) diff --git a

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

2016-11-15 Thread Franklin Phillips
On Tue, Nov 15, 2016 at 08:04:21PM +0800, Steven Liu wrote: > 2016-11-15 18:50 GMT+08:00 Franklin Phillips : > you can use git send-email, it maybe better, i have the same problem > before Sorry, I forgot to mention that my first attempt was using git send-email, when that didn't

Re: [FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

2016-11-15 Thread Franklin Phillips
Hi, I am having trouble getting my patch to show up in https://patchwork.ffmpeg.org/. This page (https://www.ffmpeg.org/developer.html#Submitting-patches-1) suggests it could be the mime type, however I used one of the recommended types, text/plain, and it is still not appearing on the patchwo

[FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

2016-11-14 Thread Franklin Phillips
conform to the specification (https://tools.ietf.org/html/draft-pantos-http-live-streaming-20#section-3.5). Signed-off-by: Franklin Phillips --- libavformat/hls.c | 178 -- 1 file changed, 159 insertions(+), 19 deletions(-) diff --git a

[FFmpeg-devel] [PATCH] avformat/hls: Added subtitle support

2016-11-08 Thread Franklin Phillips
conform to the specification (https://tools.ietf.org/html/draft-pantos-http-live-streaming-20#section-3.5). Signed-off-by: Franklin Phillips --- libavformat/hls.c | 178 -- 1 file changed, 159 insertions(+), 19 deletions(-) diff --git a

[FFmpeg-devel] [PATCH] avformat/hlsenc: fix incomplete write of subtitle HLS playlist

2016-09-02 Thread Franklin Phillips
n for this seem to be that the filename for the subtitle file is being freed too early. This solution is simply to free that memory after it's last use in the "hls_window" function. Signed-off-by: Franklin Phillips --- libavformat/hlsenc.c | 6 +++--- 1 file changed, 3 insertions