Hi,
Le 08/11/2018 à 20:50, Michael Niedermayer a écrit :
>> +line = av_malloc(line_size);
>> +if (!line)
>> +return AVERROR(ENOMEM);
>
> this would use alot of memory for large files, also avio_size() will not
> work with all inputs
Yes I thought so as well, that was a quick fix
When adding thumbnails to OGG files, the line can easily go up to 100kB.
We thus try to allocate the file size or SIZE_MAX to avoid truncation.
---
libavformat/ffmetadec.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/libavformat/ffmetadec.c b/libavfor
Le 07/11/2018 à 14:34, François Revol a écrit :
> When adding thumbnails to OGG files, the line can easily go up to 100kB.
>
> We thus try to allocate the file size or SIZE_MAX to avoid truncation.
[...]
> +if (line_size < 1 || line_size > SIZE_MAX)
> + line_size
It's not standard but mentionned on:
http://en.wikipedia.org/wiki/Gopher_%28protocol%29#Gopher_item_types
It's used at least on:
gopher://sdf.org/1/sdf/historical
(commercial.mp3)
---
libavformat/gopher.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/gopher.c b/libavformat/gophe