[FFmpeg-devel] [PATCH] avcodec/h265_metadata_bsf: Add vps/sps/pps id offset

--- doc/bitstream_filters.texi | 5 ++ libavcodec/h265_metadata_bsf.c | 106 +++-- 2 files changed, 105 insertions(+), 6 deletions(-) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 8fe5b3ad75..2e874bf6ff 100644 --- a/doc/bitstream_filt

Re: [FFmpeg-devel] [PATCH] Add vps/sps/pps id offset to hevc_metadata bsf

Yes. Fixing the identifier misprint On Wed, Jan 8, 2020 at 5:52 PM Limin Wang wrote: > On Wed, Jan 08, 2020 at 05:20:07PM +0200, Eran Gonen wrote: > > --- > > doc/bitstream_filters.texi | 5 ++ > > libavcodec/h265_metadata_bsf.c | 106 +

[FFmpeg-devel] [PATCH] Add vps/sps/pps id offset to hevc_metadata bsf

--- doc/bitstream_filters.texi | 5 ++ libavcodec/h265_metadata_bsf.c | 106 +++-- 2 files changed, 105 insertions(+), 6 deletions(-) diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi index 8fe5b3ad75..abd20e19d5 100644 --- a/doc/bitstream_filt

Re: [FFmpeg-devel] [PATCH] Add advance vps/sps/pps id to hevc_metadata bsf

Thanks for your feedback. @item vps_id_offset @item sps_id_offset @item pps_id_offset Replace the original VPS/SPS/PPS identifier by adding an offset. Offset sounds just as good to me. Is this clear? On Wed, Jan 8, 2020 at 4:46 PM Moritz Barsnick wrote: > On Wed, Jan 08, 2020 at 15:42:09 +0100

Re: [FFmpeg-devel] [PATCH] Add advance vps/sps/pps id to hevc_metadata bsf

It's limited to [0 - 16] (positive) On Wed, Jan 8, 2020 at 4:42 PM Anton Khirnov wrote: > Quoting Eran Gonen (2020-01-08 15:25:20) > > I will fix the style and documentation and resubmit. > > { "increase_vps_id", "Increase the vps id", > > Is

Re: [FFmpeg-devel] [PATCH] Add advance vps/sps/pps id to hevc_metadata bsf

I will fix the style and documentation and resubmit. { "increase_vps_id", "Increase the vps id", Is this naming more clear to you? On Wed, Jan 8, 2020 at 4:18 PM Moritz Barsnick wrote: > On Wed, Jan 08, 2020 at 16:10:12 +0200, Eran Gonen wrote: > > Advance pps

Re: [FFmpeg-devel] [PATCH] Add advance vps/sps/pps id to hevc_metadata bsf

It would, I'll change it. Thanks, Eran On Wed, Jan 8, 2020 at 3:32 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > On Wed, Jan 8, 2020 at 2:18 PM Eran Gonen > wrote: > > > --- > > libavcodec/h265_metadata_bsf.c | 117 ++

Re: [FFmpeg-devel] [PATCH] Add advance vps/sps/pps id to hevc_metadata bsf

Advance pps id means advance pps id. What would you suggest? On Wed, Jan 8, 2020 at 4:04 PM Hendrik Leppkes wrote: > On Wed, Jan 8, 2020 at 2:18 PM Eran Gonen > wrote: > > @@ -547,6 +642,16 @@ static const AVOption h265_metadata_options[] = { > > OFFSET(crop_bottom

[FFmpeg-devel] [PATCH] Add advance vps/sps/pps id to hevc_metadata bsf

--- libavcodec/h265_metadata_bsf.c | 117 +++-- 1 file changed, 111 insertions(+), 6 deletions(-) diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c index b3a1fda144..796046ac7f 100644 --- a/libavcodec/h265_metadata_bsf.c +++ b/libavcodec/h265

Re: [FFmpeg-devel] setting vps/sps/pps id via hevc_metadata

Would it make more sense if I'll change it to advance sps id? offering no risk for multiple ps On Tue, Jan 7, 2020 at 3:54 PM Eran Gonen wrote: > Hi, > This filter allows editing hevc headers and change metadata. Most > modifications doesn't make sense for all multiple PS st

Re: [FFmpeg-devel] setting vps/sps/pps id via hevc_metadata

tions and offer no decoding risk for most streams. On Mon, Jan 6, 2020 at 11:48 PM Mark Thompson wrote: > On 06/01/2020 19:24, Eran Gonen wrote:> On Mon, Jan 6, 2020 at 9:05 PM > Andreas Rheinhardt < > > andreas.rheinha...@gmail.com> wrote: > > > >> On Mon, Jan

Re: [FFmpeg-devel] [PATCH] Add vps/sps/pps id set to hevc_metadata bsf

Thanks, I will fix that. What's the formatter parameters for that? (AStyle or other) On Tue, Jan 7, 2020 at 2:02 PM Moritz Barsnick wrote: > On Tue, Jan 07, 2020 at 10:51:55 +0200, Eran Gonen wrote: > > Subject: Add vps/sps/pps id set to hevc_metadata bsf > > P

[FFmpeg-devel] [PATCH] Add vps/sps/pps id set to hevc_metadata bsf

--- libavcodec/h265_metadata_bsf.c | 147 + 1 file changed, 129 insertions(+), 18 deletions(-) diff --git a/libavcodec/h265_metadata_bsf.c b/libavcodec/h265_metadata_bsf.c index b3a1fda144..66ea369e0b 100644 --- a/libavcodec/h265_metadata_bsf.c +++ b/libavcodec/h26

[FFmpeg-devel] [PATCH] avcodec/h265_metadata_bsf: Setting vps/sps/pps id

Hi, Resending because it didn't get the patch list. Just one file this time. The attached patch allows setting vps/sps/pps id. Usage: /ffmpeg -i source -c:v libx265 -bsf:v hevc_metadata=sps_id=8:pps_id=12:vps_id=3 output Best, Eran Gonen 0001-Add-vps-sps-pps-id-set-to-hevc_metadata-bsf.

Re: [FFmpeg-devel] setting vps/sps/pps id via hevc_metadata

m> wrote: > On Mon, Jan 6, 2020 at 7:54 PM Eran Gonen > wrote: > > > Hi, > > > > The attached patch allows setting vps/sps/pps id > > > > Usage: > > /ffmpeg -i source -c:v libx265 -bsf:v > > hevc_metadata=sps_id=8:pps_id=12:vps_id=3 output >

[FFmpeg-devel] setting vps/sps/pps id via hevc_metadata

Hi, The attached patch allows setting vps/sps/pps id Usage: /ffmpeg -i source -c:v libx265 -bsf:v hevc_metadata=sps_id=8:pps_id=12:vps_id=3 output Best, Eran Gonen 0001-Add-vps-sps-pps-id-set-to-hevc_metadata-bsf.patch Description: Binary data 0001-Add-vps-sps-pps-id-set-to-hevc_metadata