Given the lack of feedback I'd like to request this changeset be merged :)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org w
Given that this is a correctness fix and has gone through a few
iterations of review, any objections to merging now and exploring
optimizations around the padding later?
On Sat, Apr 26, 2025 at 1:05 AM Emma Worley wrote:
>
> Improves compatibility with Resolume products by adding an addi
Offers a modest performance gain due to the switch from naive linear
probling to robin hood.
Signed-off-by: Emma Worley
---
libavcodec/dxvenc.c | 123
1 file changed, 34 insertions(+), 89 deletions(-)
diff --git a/libavcodec/dxvenc.c b/libavcodec
Adds a generic hash table with the DXV encoder as an initial use case.
Signed-off-by: Emma Worley
---
libavcodec/Makefile | 2 +
libavcodec/hashtable.c | 214 +++
libavcodec/hashtable.h | 91 +++
libavcodec/tests/hashtable.c
Improves compatibility with Resolume products by adding an additional
hashtable for DXT color+LUT combinations, and padding the DXT texture
dimensions to the next largest multiple of 16. Produces identical
packets to Resolume Alley in manual tests.
Signed-off-by: Emma Worley
---
libavcodec
Perhaps I can add a `mode` enum parameter to the FFHashtableContext to
control behavior? Then we can benchmark different behaviors on a
per-use-case basis.
On Tue, Apr 22, 2025 at 10:24 AM Nicolas George wrote:
>
> Emma Worley (HE12025-04-22):
> > Adds a generic hash table with the
On Tue, Apr 22, 2025 at 1:00 AM Andreas Rheinhardt
wrote:
> Did you try to avoid the above by modifying
> ff_texturedsp_exec_compress_threads()?
I considered it but adding support to substitute in padding seemed
like a rather large refactor.
___
ffmpeg-
Improves compatibility with Resolume products by adding an additional
hashtable for DXT color+LUT combinations, and padding the DXT texture
dimensions to the next largest multiple of 16. Produces identical
packets to Resolume Alley in manual tests.
Signed-off-by: Emma Worley
---
libavcodec
Offers a modest performance gain due to the switch from naive linear
probling to robin hood.
Signed-off-by: Emma Worley
---
libavcodec/dxvenc.c | 121
1 file changed, 33 insertions(+), 88 deletions(-)
diff --git a/libavcodec/dxvenc.c b/libavcodec
Adds a generic hash table with the DXV encoder as an initial use case.
Signed-off-by: Emma Worley
---
libavcodec/Makefile | 2 +
libavcodec/hashtable.c | 192 +++
libavcodec/hashtable.h | 91 +
libavcodec/tests/hashtable.c
On Mon, Apr 21, 2025 at 4:19 AM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Emma Worley:
> > Improves compatibility with Resolume products by adding an additional
> hashtable
> > for DXT color+LUT combinations, and padding the DXT texture to the next
>
Improves compatibility with Resolume products by adding an additional hashtable
for DXT color+LUT combinations, and padding the DXT texture to the next largest
16x16 multiple. Produces identical packets to Resolume Alley in manual tests.
Signed-off-by: Emma Worley
---
libavcodec/dxvenc.c
Offers a modest performance gain due to the switch from naive linear
probling to robin hood.
Signed-off-by: Emma Worley
---
libavcodec/dxvenc.c | 121
1 file changed, 33 insertions(+), 88 deletions(-)
diff --git a/libavcodec/dxvenc.c b/libavcodec
Adds a general purpose hash table with the DXV encoder as an initial use case.
Signed-off-by: Emma Worley
---
libavutil/Makefile | 2 +
libavutil/hashtable.c | 192
libavutil/hashtable.h | 91 +
libavutil/tests
Disregard, working on a fix for the FATE error.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Improves compatibility with Resolume products by adding an additional hashtable
for DXT color+LUT combinations, and padding the DXT texture to the next largest
16x16 multiple. Produces identical packets to Resolume Alley in manual tests.
Signed-off-by: Emma Worley
---
libavcodec/dxvenc.c
Offers a modest performance gain due to the switch from naive linear
probling to robin hood.
Signed-off-by: Emma Worley
---
libavcodec/dxvenc.c | 121
1 file changed, 33 insertions(+), 88 deletions(-)
diff --git a/libavcodec/dxvenc.c b/libavcodec
Adds a general purpose hash table with the DXV encoder as an initial use case.
Signed-off-by: Emma Worley
---
libavutil/Makefile | 2 +
libavutil/hashtable.c | 192
libavutil/hashtable.h | 91 +
libavutil/tests
Offers a modest performance gain due to the switch from naive linear
probling to robin hood, as well as improved compatibility with Resolume.
Signed-off-by: Emma Worley
---
libavcodec/dxvenc.c | 190 +---
tests/ref/fate/dxv3enc-dxt1 | 2 +-
2 files
Adds a general purpose hash table with the DXV encoder as an initial use case.
Signed-off-by: Emma Worley
---
libavutil/Makefile | 2 +
libavutil/hashtable.c | 192
libavutil/hashtable.h | 91 +
libavutil/tests
20 matches
Mail list logo
