Re: [FFmpeg-devel] [PATCH] libavdevice/avfoundation.m Add missing type AVMediaType for macOS < 10.13.

2024-01-01 Thread David Bohman
On Mon, Jan 1, 2024 at 9:26 AM wrote: > > > > On 1 Jan 2024, at 15:38, David Bohman wrote: > > > This is a build failure in the master branch as a result of commit > > e37b15e26fbc7bc31a86a4a2c7c798e20d4f4c2c: > > > > There is no type AVMediaType prior t

Re: [FFmpeg-devel] [PATCH] libavdevice/avfoundation.m Add missing type AVMediaType for macOS < 10.13.

2024-01-01 Thread David Bohman
On Mon, Jan 1, 2024 at 9:08 AM Michael Niedermayer wrote: > > error: corrupt patch at line 19 > Sorry, I have also attached the patch file to this message. --- libavdevice/avfoundation.m | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation

[FFmpeg-devel] [PATCH] libavdevice/avfoundation.m Add missing type AVMediaType for macOS < 10.13.

2024-01-01 Thread David Bohman
This is a build failure in the master branch as a result of commit e37b15e26fbc7bc31a86a4a2c7c798e20d4f4c2c: There is no type AVMediaType prior to macOS 10.13. --- libavdevice/avfoundation.m | 4 1 file changed, 4 insertions(+) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundat

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Only log the EncoderID on macOS >= 10.13.

2023-11-25 Thread David Bohman
On Fri, Nov 24, 2023 at 8:09 PM Zhao Zhili wrote: > > > > > On Nov 25, 2023, at 05:32, David Bohman wrote: > > > > On Fri, Nov 24, 2023 at 9:01 AM Zhao Zhili wrote: > >> > >>> On Nov 24, 2023, at 23:40, David Bohman wrote: > >&g

Re: [FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Only log the EncoderID on macOS >= 10.13.

2023-11-24 Thread David Bohman
On Fri, Nov 24, 2023 at 9:01 AM Zhao Zhili wrote: > > > On Nov 24, 2023, at 23:40, David Bohman wrote: > > > > This is to fix a build failure on macOS < 10.13. > > > It looks like kVTCompressionPropertyKey_EncoderID is the root cause of build > failure. >

[FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: Only log the EncoderID on macOS >= 10.13.

2023-11-24 Thread David Bohman
This is to fix a build failure on macOS < 10.13. This is a build failure in release 6.1. The issue also exists at the top of the master branch, and the patch applies there. --- libavcodec/videotoolboxenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/videotoolbox