Re: [FFmpeg-devel] [PATCH] libavformat/mov: limit nb_frames_for_fps to INT_MAX

2019-04-22 Thread Dan Sanders
It's this or add overflow detection in mov_read_header(). --- libavformat/mov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d5ce077e63..247a65ed11 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2940,7 +2940,7 @@ st

[FFmpeg-devel] [PATCH] libavformat/mov: limit nb_frames_for_fps to INT_MAX

2019-04-19 Thread Dan Sanders via ffmpeg-devel
--- Begin Message --- Fixes: UBSan runtime error Found-by: Clusterfuzz --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d5ce077e63..7e7de5962d 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -2940,7 +294

Re: [FFmpeg-devel] [PATCH] avformat/apetag: tag values are unsigned

2019-04-18 Thread Dan Sanders via ffmpeg-devel
> > +#define APE_TAG_FLAG_CONTAINS_HEADER (1U << 31) > > Isn't it enough with this one only? Yes, only APE_TAG_FLAG_CONTAINS_HEADER is problematic. I changed all of them because the tags are only used in unsigned contexts anyway. ___ ffmpeg-devel mailin

[FFmpeg-devel] [PATCH] avformat/apetag: tag values are unsigned

2019-04-18 Thread Dan Sanders via ffmpeg-devel
Fixes: UBSan runtime error Found-by: Clusterfuzz --- libavformat/apetag.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/apetag.c b/libavformat/apetag.c index cdc602e1a9..2991f57d5d 100644 --- a/libavformat/apetag.c +++ b/libavformat/apetag.c @@ -29,10 +29,

Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

2016-01-15 Thread Dan Sanders
Michael, I wanted to check if you have you looked into this playback issue, or were planning to? - Dan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

2015-12-12 Thread Dan Sanders
I took a look at the structure of this file, and the encoding appears to be correct. The frame order in the moof boxes matches the H.264 stream, and the durations of the moof boxes match with the sidx. Some notes to help with analysis: There are no per-frame durations specified, every frame is exa