>
> You mean the list at <
> http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavfilter/vf_colorkey.c;h=3d65e59d42c6fa480e00f4b7ab079677bcac876a;hb=HEAD#l113>?
> AV_PIX_FMT_NONE (-1) is the invalid enum AVPixelFormat value used as the
> sentinel for the end of the list passed to ff_make_format_list
On Wed, Apr 10, 2019 at 6:10 PM Mark Thompson wrote:
> The lack of checks in overlay_opencl generally leaves a lot to be
> desired. It's is intended for (and only really tested with) hardware video
> in YUV formats (primarily overlaying YUV or YUVA on YUV, for things like
> subtitles or pips), b
On Wed, Apr 10, 2019 at 4:30 PM Carl Eugen Hoyos wrote:
> 2019-04-10 5:37 GMT+02:00, Jarek Samic :
>
> > +// Make sure the input is a format we support
> > +if (fmt != AV_PIX_FMT_ARGB &&
> > +fmt != AV_PIX_FMT_RGBA &&
> > +fmt != AV_PIX_FMT_ABGR &&
> > +
>
> For P010, I guess that division needs to round up?
>
Yep, rounding the division up did the trick; thanks!
One last observation before I submit a new patch: I actually missed
previously that the order number is still not lining up for the ARGB format
(the order number that maps to ARGB in the
>
> Does anything go wrong if you unconditionally add comp->offset / (depth /
> 8)?
Yes. Occasionally there is a depth value less than 8:
[opencl_get_plane_format] depth is 2 < 8 for format: rgb8 on plane: 0
[AVHWDeviceContext @ _] Format yuva420p supported.
[opencl_get_plane_format] depth is 5
