[FFmpeg-devel] [PATCH] libavfilter/dnn/dnn_backend{openvino, tf}: check memory alloc non-NULL

2020-10-13 Thread Chris Miceli
These previously would not check that the return value was non-null meaning it was susceptible to a sigsegv. This checks those values. --- libavfilter/dnn/dnn_backend_openvino.c | 14 +- libavfilter/dnn/dnn_backend_tf.c | 16 +++- 2 files changed, 28 insertions(+), 2

[FFmpeg-devel] [PATCH] libavfilter/dnn_backend_native: check mem allocation

2020-10-13 Thread Chris Miceli
check that frame allocations return non-null. --- libavfilter/dnn/dnn_backend_native.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_native.c b/libavfilter/dnn/dnn_backend_native.c index d45e211f0c..4fc3ba2044 100644 --- a/libavf

Re: [FFmpeg-devel] [PATCH] dnn_backend_tf.c: add option sess_config for tf backend

2020-10-13 Thread Chris Miceli
Hi! With proto files they can be serialised to many different formats, is there a reason for it to use hex? The reason I ask is that it's not trivially readable for those debugging the command line. Perhaps something like json is better? Even if not using json, maybe a file is a little easier? In

[FFmpeg-devel] [PATCH] libavformat/hls: check new_init_section for null

2020-10-12 Thread Chris Miceli
new_init_section will return NULL under circumstances where the init failed and this code needed to check for that. ret and goto fail are how this is handled throughout the code. --- libavformat/hls.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c ind

[FFmpeg-devel] [PATCH] libavfilter/dnn_backend_native: check mem allocation

2020-10-12 Thread Chris Miceli
check that frame allocations return non-null. --- libavfilter/dnn/dnn_backend_native.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/libavfilter/dnn/dnn_backend_native.c b/libavfilter/dnn/dnn_backend_native.c index d45e211f0c..7958ceb4f7 100644 --- a/libavfilte

[FFmpeg-devel] [PATCH] libavformat/utils: Fix misleading indent

2020-10-12 Thread Chris Miceli
6f69f7a8bf6a0d013985578df2ef42ee6b1c7994 introduced this and it was part of a very large merging of refactoring. Current behaviour is what is reflected by this indenting change, however my understanding of timing is such that this correct behaviour. --- libavformat/utils.c | 3 +-- 1 file changed,

[FFmpeg-devel] [PATCH] libavfilter/dnn_backend_native: check mem allocation

2020-10-12 Thread Chris Miceli
check that frame allocations return non-null. --- libavfilter/dnn/dnn_backend_native.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_native.c b/libavfilter/dnn/dnn_backend_native.c index d45e211f0c..cda857a9c5 100644 --- a/libavfilter/dnn/dnn_backend_nat

[FFmpeg-devel] [PATCH] libavfilter/af_mcompand: Check for failure to allocate memory

2020-10-12 Thread Chris Miceli
This commit fixes some unchecked memory allocations from #8931. --- libavfilter/af_mcompand.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavfilter/af_mcompand.c b/libavfilter/af_mcompand.c index f142573bea..96293909de 100644 --- a/libavfilter/af_mcompand.c +++ b/libavfilter/af_

[FFmpeg-devel] [PATCH] libavfilter/af_mcompand: Check for failure to allocate memory

2020-10-12 Thread Chris Miceli
This commit fixes some unchecked memory allocations from #8931. --- libavfilter/af_mcompand.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavfilter/af_mcompand.c b/libavfilter/af_mcompand.c index f142573bea..96293909de 100644 --- a/libavfilter/af_mcompand.c +++ b/libavfilter/af_

[FFmpeg-devel] [PATCH] libavformat/avidec: check memory allocation

2020-10-12 Thread Chris Miceli
Memory allocation for AVIOContext should be checked. In this code, all error conditions are sent to the "goto error". --- libavformat/avidec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index 9765e5e7b2..33e50e9878 100644

Re: [FFmpeg-devel] [PATCH] libavfilter/dnn_backend_native: chk mem allocation

2020-10-12 Thread Chris Miceli
Please disregard this for the replacement titled: libavfilter/dnn_backend_native: check mem allocation. Thanks, *Chris Miceli* On Tue, Oct 13, 2020 at 1:34 PM Chris Miceli wrote: > A report on Trac came in about this failure scenario where there are > potential failures to allocate

[FFmpeg-devel] [PATCH] libavfilter/dnn_backend_native: check mem allocation

2020-10-12 Thread Chris Miceli
check that frame allocations return non-null. --- libavfilter/dnn/dnn_backend_native.c | 8 1 file changed, 8 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_native.c b/libavfilter/dnn/dnn_backend_native.c index d45e211f0c..d1eb992335 100644 --- a/libavfilter/dnn/dnn_backend_nati

[FFmpeg-devel] [PATCH] libavfilter/dnn_backend_native: chk mem allocation

2020-10-12 Thread Chris Miceli
A report on Trac came in about this failure scenario where there are potential failures to allocate memory which are going unchecked in the code. This should fix that error in the same way that other parts of the codebase already handle similar situations --- libavfilter/dnn/dnn_backend_native.c |

[FFmpeg-devel] [PATCH] libavfilter/af_mcompand: Check for failure to allocate memory

2020-10-12 Thread Chris Miceli
This commit fixes some unchecked memory allocations from #8931. --- libavfilter/af_mcompand.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavfilter/af_mcompand.c b/libavfilter/af_mcompand.c index f142573bea..5309d884a5 100644 --- a/libavfilter/af_mcompand.c +++ b/libavfilter/af_

[FFmpeg-devel] [PATCH] libavfilter/dnn_backend_native: chk mem allocation

2020-10-12 Thread Chris Miceli
A report on Trac came in about this failure scenario where there are potential failures to allocate memory which are going unchecked in the code. This should fix that error in the same way that other parts of the codebase already handle similar situations --- libavfilter/dnn/dnn_backend_native.c |

[FFmpeg-devel] [PATCH] libavfilter/af_mcompand: Check for failure to allocate memory

2020-10-12 Thread Chris Miceli
ticket 8931 mentions some missing null pointer checks and so this is one diff of a few which are for these fixes. There are previous code pieces which return ENOMEM, so this should work as intended. --- libavfilter/af_mcompand.c | 12 1 file changed, 12 insertions(+) diff --git a/lib

Re: [FFmpeg-devel] autofate system

2020-10-06 Thread Chris Miceli
es and the tip of git on a wide range of these will help ensure that bugs are caught quickly and effectively. Happy to help integrate whichever system we think would work best for this, just want to ideally have a good means to know that origin/master is constantly well tested! Thanks, *Chris Micel

[FFmpeg-devel] [PATCH] Convert logfile to AVIOContext to fix file parser

2020-10-06 Thread Chris Miceli
The lack of AVIOContext means that ffmpeg was attempting to open logfiles for two pass encoding with the "protocol" part of the url on the first pass. This manifested mainly when a user needed to have a colon in the filename as they would require a url style path (according to #8898). --- fftools/

[FFmpeg-devel] [PATCH] Add atsc_a53 dependency to h264/hevc decoders

2020-10-05 Thread Chris Miceli
As per ticket #8901 there is a compilation issue where there is an undefined reference when compiled with a minimal set of filters. This commit remedies that by ensuring decoders which have SEI parsers import the relevent caption object and hence functionality. --- libavcodec/Makefile | 6 +++---

Re: [FFmpeg-devel] [PATCH] Document community process

2020-10-05 Thread Chris Miceli
ailing list or similar). Thank you for this work, I think that it will help this ffmpeg community thrive. *Chris Miceli* On Tue, Oct 6, 2020 at 8:12 AM Jean-Baptiste Kempf wrote: > General Assembly + Main Elections > --- > doc/dev_community/community.md | 60 ++

[FFmpeg-devel] autofate system

2020-10-05 Thread Chris Miceli
s from the community, have a great day. Thanks, Chris Miceli ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] libavformat/dashenc: Reduce confusion in par error message

2020-08-30 Thread Chris Miceli
In ticket #8754 there is discourse surrounding the error message which is printed upon a mismatched aspect ratio in derived encodings. This should make it clearer to the user as to the issues which they are experiencing. --- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

Re: [FFmpeg-devel] [RFC] Built-in documentation API

2020-08-23 Thread Chris Miceli
ed to spend unnecessary time maintaining the documentation system, concentrating instead on the code itself. Another benefit being that if there are other fixes you wish to make, the entire doxygen community can benefit as well. *Chris Miceli* On Sun, Aug 23, 2020 at 8:39 PM Jim DeLaHunt