Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-13 Thread Carotti, Elias via ffmpeg-devel
On Fri, 2023-10-13 at 16:16 +0200, Anton Khirnov wrote: > CAUTION: This email originated from outside of the organization. Do > not click links or open attachments unless you can confirm the sender > and know the content is safe. > > > > Quoting Carotti, Elias via ffmpeg-de

Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-11 Thread Carotti, Elias via ffmpeg-devel
Hi Anton, On Tue, 2023-10-10 at 12:54 +0200, Anton Khirnov wrote: > > Quoting Carotti, Elias via ffmpeg-devel (2023-10-02 19:35:09) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > > index 77a9f173b4..4c643c9066 100644 > > --- a/libavcodec/libx264.c > &

Re: [FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-10-02 Thread Carotti, Elias via ffmpeg-devel
> Hi, > please find attached a patch to propagate the SSE for a frame into > the > encoder stats. > Since libx264 already provides PSNR values, this is done by basically > inverting the formula to recover the SSE values. > > Would it be possible to also append other values to the errors > vector?

[FFmpeg-devel] libavc/libx264: add support to propagate SSE values through encoder stats

2023-09-23 Thread Carotti, Elias via ffmpeg-devel
Hi, please find attached a patch to propagate the SSE for a frame into the encoder stats. Since libx264 already provides PSNR values, this is done by basically inverting the formula to recover the SSE values. Would it be possible to also append other values to the errors vector? E.g., libx264 also

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-09-05 Thread Carotti, Elias via ffmpeg-devel
-Original Message- From: ffmpeg-devel On Behalf Of Stefano Sabatini Sent: Saturday, September 2, 2023 5:45 PM To: ffmpeg-devel@ffmpeg.org Cc: kier...@obe.tv; Carotti, Elias Subject: RE: [EXTERNAL] [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-09-02 Thread Carotti, Elias via ffmpeg-devel
On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote: > > > > In particular why are you turning on fast_pskip silently based on a > > completely different setting? > > The patch is fixing the regression introduced by the unconditional > setting of b_fast_pskip. > > Now the question is if

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-08-31 Thread Carotti, Elias via ffmpeg-devel
Hi -Original Message- From: ffmpeg-devel On Behalf Of Stefano Sabatini Sent: Friday, August 25, 2023 12:01 PM To: FFmpeg development discussions and patches Cc: Stefano Sabatini Subject: [EXTERNAL] [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info