users to override this.
Signed-off-by: Cameron Gutman
---
v2: Changed cbr_padding default to 0 and rewrote commit text
---
libavcodec/nvenc.c | 16 +---
libavcodec/nvenc.h | 2 ++
libavcodec/nvenc_av1.c | 2 ++
libavcodec/nvenc_h264.c | 4
libavcodec/nvenc_hevc.c
AVBR does not use VAEncMiscParameterTypeHRD, so attempting to set
rc_buffer_size and bit_rate together will cause the rc_buffer_size
to be ignored if the VAAPI driver supports AVBR. We should prefer
regular VBR for that case.
Signed-off-by: Cameron Gutman
---
libavcodec/vaapi_encode.c | 5
On Sun, Mar 30, 2025 at 10:46 AM Zhao Zhili
wrote:
>
>
>
> > On Mar 30, 2025, at 23:33, Kieran Kunhya via ffmpeg-devel
> > wrote:
> >
> > On Sun, Mar 30, 2025 at 12:04 AM Cameron Gutman > <mailto:aicomman...@gmail.com>> wrote:
> >>
>
On Sun, Mar 30, 2025 at 11:41 AM Timo Rothenpieler
wrote:
>
> On 30.03.2025 17:33, Kieran Kunhya wrote:
> > On Sun, Mar 30, 2025 at 12:04 AM Cameron Gutman
> > wrote:
> >>
> >> Previously, AV1 used filler data with CBR by default while H.264
> >> an
On Sat, Mar 29, 2025 at 4:02 PM Timo Rothenpieler wrote:
>
> On 29.03.2025 21:58, Cameron Gutman wrote:
> > Some scenarios (such as game streaming or videoconferencing) may use CBR
> > to strictly cap the maximum encoded bitrate, but they don't mind the
> > bitrate fa
: Cameron Gutman
---
libavcodec/nvenc.c | 16 +---
libavcodec/nvenc.h | 2 ++
libavcodec/nvenc_av1.c | 2 ++
libavcodec/nvenc_h264.c | 4
libavcodec/nvenc_hevc.c | 4
5 files changed, 25 insertions(+), 3 deletions(-)
diff --git a/libavcodec/nvenc.c b/libavcodec
On Sat, Mar 29, 2025 at 4:42 PM Timo Rothenpieler wrote:
>
> On 29.03.2025 22:37, Cameron Gutman wrote:
> > On Sat, Mar 29, 2025 at 4:26 PM Timo Rothenpieler
> > wrote:
> >>
> >> On 29.03.2025 22:17, Cameron Gutman wrote:
> >>> On Sat, Mar 29,
On Sat, Mar 29, 2025 at 4:26 PM Timo Rothenpieler wrote:
>
> On 29.03.2025 22:17, Cameron Gutman wrote:
> > On Sat, Mar 29, 2025 at 4:02 PM Timo Rothenpieler
> > wrote:
> >>
> >> On 29.03.2025 21:58, Cameron Gutman wrote:
> >>> Some scenarios (
e usecases
where it is unwanted.
Signed-off-by: Cameron Gutman
---
v2: Rebased to resolve conflicts against master
---
libavcodec/nvenc.c | 2 +-
libavcodec/nvenc.h | 1 +
libavcodec/nvenc_av1.c | 2 ++
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavcodec/nvenc.c b/
out which one to
use when creating our decoder.
The new RExt profiles are supported with DXVA2 and D3D11VA (depending on
driver support).
Signed-off-by: Cameron Gutman
---
v2 addresses some off-list feedback regarding the duplicate definition
of some DXVA GUIDs and incorrect handling of the pixel
out which one to
use when creating our decoder.
Signed-off-by: Cameron Gutman
---
libavcodec/d3d12va_hevc.c | 21 +++---
libavcodec/dxva2.c | 59 +++--
libavcodec/dxva2_hevc.c | 125 ++--
libavcodec/dxva2_internal.h | 39
This option, which is also available on other FFmpeg hardware encoders,
allows the user to trade throughput for reduced output latency. This is
useful for ultra low latency applications like game streaming.
Signed-off-by: Cameron Gutman
---
libavcodec/amfenc.c | 3 +--
libavcodec
AVBR does not use VAEncMiscParameterTypeHRD, so attempting to set
rc_buffer_size and bit_rate together will cause the rc_buffer_size
to be ignored if the VAAPI driver supports AVBR. We should prefer
regular VBR for that case.
Signed-off-by: Cameron Gutman
---
libavcodec/vaapi_encode.c | 5
e usecases
where it is unwanted.
Signed-off-by: Cameron Gutman
---
libavcodec/nvenc.c | 2 +-
libavcodec/nvenc.h | 1 +
libavcodec/nvenc_av1.c | 2 ++
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c
index 2cce478be0..17dc8ff6ba 10
On Wed, Oct 16, 2024 at 5:49 AM Lynne via ffmpeg-devel
wrote:
>
> On 15/10/2024 17:51, Lynne via ffmpeg-devel wrote:
> > On 15/10/2024 16:49, David Rosca wrote:
> >> Fixes leaking recon surfaces with VAAPI.
> >> ---
> >> libavcodec/hw_base_encode.c | 5 +
> >> 1 file changed, 5 insertions(+
> behaviour.
>
> Reported-by: Cameron Gutman
> ---
Thanks for the quick patch. Looks good here.
Tested-by: Cameron Gutman
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit lin
On Sun, Sep 1, 2024 at 5:43 AM Anton Khirnov wrote:
>
> Quoting Dale Curtis (2024-08-01 01:18:14)
> > diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c
> > index 214dca4566..f189263ff9 100644
> > --- a/libavcodec/avcodec.c
> > +++ b/libavcodec/avcodec.c
> > @@ -174,6 +174,14 @@ int attribut
VideoToolbox doesn't allow us to specify an exact number of ref frames,
but it does allow an upper limit to be specified which is better than
nothing.
Signed-off-by: Cameron Gutman
---
libavcodec/videotoolboxenc.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --
The RGB->YUV color conversion hardware available on current AMD GPUs
only supports BT.709 and BT.2020+PQ, but YUV input can be accepted
without restrictions since no color conversion is taking place.
Signed-off-by: Cameron Gutman
---
I think this should address the concerns with my previ
On Sat, Sep 28, 2024 at 9:04 AM Dmitrii Ovchinnikov
wrote:
>
> Thanks for the fix. Merged.
Thanks Dmitrii, can you cherry-pick this bugfix and the fix for
supported HEVC color ranges to release/7.1 (if you agree they are
suitable for backporting)?
___
f
On Thu, Sep 26, 2024 at 4:25 PM Martin Storsjö wrote:
>
> From: Jan Ekström
>
> Use AV1DecContext's current_obu to access the original OBUs, and
> feed them to videotoolbox, rather than the bare slice data passed
> via decode_slice.
>
> This requires a small addition to AV1DecContext, for keeping
On Tue, Sep 24, 2024 at 7:16 AM Martin Storsjö wrote:
>
> On Mon, 23 Sep 2024, Cameron Gutman wrote:
>
> > On Mon, Sep 23, 2024 at 12:43 PM Zhao Zhili wrote:
> >>
> >>
> >>
> >> > On Sep 24, 2024, at 01:24, Cameron Gutman wrote:
&g
On Mon, Sep 23, 2024 at 12:43 PM Zhao Zhili wrote:
>
>
>
> > On Sep 24, 2024, at 01:24, Cameron Gutman wrote:
> >
> > On Mon, Sep 23, 2024 at 6:07 AM Zhao Zhili wrote:
> >>
> >>
> >>
> >>> On Sep 21, 2024, at 05:39, Martin Stor
On Mon, Sep 23, 2024 at 6:07 AM Zhao Zhili wrote:
>
>
>
> > On Sep 21, 2024, at 05:39, Martin Storsjö wrote:
> >
> > From: Jan Ekström
> >
> > Co-authored-by: Ruslan Chernenko
> > Co-authored-by: Martin Storsjö
> > ---
> > This is a touched up version of Jan and Ruslan's patches for
> > AV1 hw
cking filter on
flags -loop => deblocking filter off
Signed-off-by: Cameron Gutman
---
libavcodec/amfenc_hevc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/amfenc_hevc.c b/libavcodec/amfenc_hevc.c
index 71e7d8aa61..7b4b2f722d 100644
--- a/libavcodec/a
We properly set AMF_VIDEO_ENCODER_HEVC_NOMINAL_RANGE since fb4dd4b6f48.
Signed-off-by: Cameron Gutman
---
libavcodec/amfenc_hevc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/amfenc_hevc.c b/libavcodec/amfenc_hevc.c
index 4898824f3a..71e7d8aa61 100644
--- a
On Mon, Sep 9, 2024 at 9:24 AM Araz wrote:
>
> > Apologies for missing this prior to merge, but you can't safely make these
> > assumptions about primaries and TRC just based on the input bit depth. Just
> > because it's 8-bit content doesn't mean it will be BT.709 and likewise for
> > 10-bit and
AMF_VIDEO_ENCODER_AV1_INPUT_HDR_METADATA was set above in the normal
input case but forgotten for the same in the delayed surface codepath.
Signed-off-by: Cameron Gutman
---
libavcodec/amfenc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c
index
On Mon, Sep 9, 2024 at 6:48 PM Cameron Gutman wrote:
>
> On Mon, Sep 9, 2024 at 11:05 AM Araz wrote:
> >>
> >> > I took a look at this using AMD's AMF EncoderLatency sample and found
> >> > that
> >> > setting the QUERY_TIMEOUT option to
On Mon, Sep 9, 2024 at 11:05 AM Araz wrote:
>>
>> > I took a look at this using AMD's AMF EncoderLatency sample and found that
>> > setting the QUERY_TIMEOUT option to 50 ms (as is default for the new AMF
>> > HQ and HQLL usage values) results in latency that is better than the
>> > current AMF co
v2: Use forced_idr option instead of AV_FRAME_FLAG_KEY
Signed-off-by: Cameron Gutman
---
In response to the feedback from Anton on the previous patch, I opted to
switch to a new codec option plus pict_type rather than triggering IDR
frames on AV_FRAME_FLAG_KEY. However, I chose to use
Fixes incorrect colors in AMF encoding of 10-bit SDR content in HEVC and AV1.
Signed-off-by: Cameron Gutman
---
libavcodec/amfenc_av1.c | 13 -
libavcodec/amfenc_hevc.c | 13 -
2 files changed, 8 insertions(+), 18 deletions(-)
diff --git a/libavcodec/amfenc_av1.c b
On Fri, Sep 6, 2024 at 1:57 AM Anton Khirnov wrote:
>
> Quoting Lynne via ffmpeg-devel (2024-09-05 23:27:40)
> > On 05/09/2024 07:16, Cameron Gutman wrote:
> > > Signed-off-by: Cameron Gutman
> > > ---
> > > libavcodec/amfenc.c | 34 ++
Signed-off-by: Cameron Gutman
---
libavcodec/amfenc.c | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c
index 41eaef9758..6f2b211d14 100644
--- a/libavcodec/amfenc.c
+++ b/libavcodec/amfenc.c
On Thu, Aug 1, 2024 at 6:51 AM Araz Iusubov wrote:
>
> From: Michael Fabian 'Xaymar' Dirks
>
> added 10 bit support for amf hevc.
>
> before:
>
> command - ffmpeg.exe -hide_banner -y -hwaccel d3d11va -hwaccel_output_format
> d3d11 -i test_10bit_file.mkv -an -c:v h264_amf res.dx11_hw_h264.mkv
> o
drivers without support for the QUERY_TIMEOUT property, they
will still have the current non-blocking QueryOutput() which results in
the same polling behavior as today.
Fixes poor encoding performance with low resolution video as
reported in #10622.
Signed-off-by: Cameron Gutman
---
libavcodec/am
On Wed, Aug 21, 2024 at 12:02 PM Kieran Kunhya via ffmpeg-devel
wrote:
>
> On Mon, Aug 19, 2024 at 7:31 PM Timo Rothenpieler
> wrote:
> >
> > On 19.08.2024 16:23, Araz Iusubov wrote:
> > > From: Evgeny Pavlov
> > >
> > > This commit increase precision of Sleep() function on Windows.
> > > This
On Mon, Aug 19, 2024 at 9:31 AM Araz Iusubov wrote:
>
> From: Evgeny Pavlov
>
> This commit increase precision of Sleep() function on Windows.
> This fix reduces the sleep time on Windows to improve AMF encoding
> performance on low resolution input videos.
>
> Fix for issue #10622
>
> We evaluat
This allows applications to preferentially select OpenMAX IL codecs
over software-only codecs using the standard AV_CODEC_CAP_HARDWARE
capability flag rather than requiring custom codec-specific logic.
Signed-off-by: Cameron Gutman
---
libavcodec/omx.c | 4 ++--
1 file changed, 2 insertions
On Mon, May 6, 2024 at 3:45 PM Черненко Руслан wrote:
>
> Signed-off-by: Chernenko Ruslan
> ---
> libavcodec/videotoolbox_av1.c | 102 --
> 1 file changed, 72 insertions(+), 30 deletions(-)
>
> diff --git a/libavcodec/videotoolbox_av1.c b/libavcodec/videotoolbox
mfenc sets FF_CODEC_CAP_INIT_CLEANUP, so calling mf_close() on
failure inside mf_init() results in a double-free.
Signed-off-by: Cameron Gutman
---
libavcodec/mfenc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c
index 36a6d8482d..f3415df10b 100644
> On Jan 17, 2022, at 3:07 AM, Anton Khirnov wrote:
>
> Quoting Cameron Gutman (2022-01-10 09:17:37)
>>
>>> On Jan 9, 2022, at 3:24 AM, Anton Khirnov wrote:
>>>
>>> Quoting Cameron Gutman (2022-01-03 01:33:19)
>>>>
> On Jan 9, 2022, at 3:24 AM, Anton Khirnov wrote:
>
> Quoting Cameron Gutman (2022-01-03 01:33:19)
>> Signed-off-by: Cameron Gutman
>> ---
>> libavutil/hwcontext_videotoolbox.c | 25 +
>> 1 file changed, 25 insertions
command failed with exit code 1 (use -v to see
> invocation)
>
> Reported-by: Cameron Gutman
> Signed-off-by: Limin Wang
> ---
Thanks, this fixes the build break for me. Please merge it into 5.0 if possible.
Tested-by: Cameron Gutman
> libavcodec/videotoolbox.c | 2 ++
&
I am building minimal ffmpeg libraries for my application using the following
configure command:
./configure --enable-shared --disable-all --enable-avcodec
--enable-decoder=h264 --enable-hwaccel=h264_videotoolbox
libavcodec.dylib now fails to link after the following commit:
commit a41a2efc85f8
av_hwframe_map() is documented to work with a blank dst frame, but
hwcontext_drm currently fails if dst->format == AV_PIX_FMT_NONE.
Signed-off-by: Cameron Gutman
---
libavutil/hwcontext_drm.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavutil/hwcontext_drm.
On 1/2/22 19:21, Aman Karmani wrote:
>
>
> On Sun, Jan 2, 2022 at 4:33 PM Cameron Gutman <mailto:aicomman...@gmail.com>> wrote:
>
> Signed-off-by: Cameron Gutman <mailto:aicomman...@gmail.com>>
> ---
> libavutil/hwcontext_videotoolbox.c
Signed-off-by: Cameron Gutman
---
libavutil/hwcontext_videotoolbox.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/libavutil/hwcontext_videotoolbox.c
b/libavutil/hwcontext_videotoolbox.c
index 0a8dbe9f33..026127d412 100644
--- a/libavutil
On 12/27/21 00:17, Andriy Gelman wrote:
> On Tue, 14. Dec 02:12, Cameron Gutman wrote:
>> The V4L2M2M API operates asynchronously, so multiple packets can
>> be enqueued before getting a batch of frames back. Since it was
>> only possible to receive a frame by submitting ano
ERROR(EAGAIN).
In my testing, this change reduced decode latency of a real-time
60 FPS H.264 stream by approximately 10x (200ms -> 20ms) on a
Raspberry Pi 4.
Signed-off-by: Cameron Gutman
---
libavcodec/v4l2_m2m_dec.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff
AVOption to set MAX_DELAYED_FRAMES rather than hardcoding it?
In any case, this is a _major_ improvement for my use so feel free to add
my Tested-by to this patch series:
Tested-by: Cameron Gutman
Regards,
Cam
[0]:
https://github.com/cgutman/FFmpeg/commit/193a0320afd5f316da407208eb2fdceea888
pp_frame: check_is_mpp_frame pointer (nil) failed on check
mpp_frame: check_is_mpp_frame pointer (nil) failed on check
Tested on RK3288 (Asus Tinkerboard)
Signed-off-by: Cameron Gutman
---
libavcodec/rkmppdec.c | 4
1 file changed, 4 deletions(-)
diff --git a/libavcodec/rkmppdec.c b/libavcodec/rkmppdec
52 matches
Mail list logo
