[FFmpeg-devel] Minor warning found by VC++ /analyze

2017-03-30 Thread Bruce Dawson
execution continues, including a likely read from got_frame before the function exits. I'm not sure if anything really bad can happen, but uninitialized reads are undefined behavior. FWIW -- Bruce Dawson ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-05-11 Thread Bruce Dawson
want to be able to report bugs and make suggestions while it's not too late, and adding w64.c was a simple way to unblock this testing. Anyway, thought the ffmpeg team should know. On Wed, May 11, 2016 at 10:51 AM, Hendrik Leppkes wrote: > On Wed, May 11, 2016 at 4:19 PM, Bruce Dawson >

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-05-11 Thread Bruce Dawson
rote: > On Tue, May 10, 2016 at 01:22:53PM -0400, Bruce Dawson wrote: > > BTW, the reason I suggested the CONFIG_W64_DEMUXER patch that started > this > > email thread is because the pre-release version of VS 2015 Update 3 can't > > handle that code as-is. Microsof

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-05-10 Thread Bruce Dawson
result can > suffer from similar issues. > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > -- Bruce Dawson ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-22 Thread Bruce Dawson
+= wavenc.o OBJS-$(CONFIG_WC3_DEMUXER) += wc3movie.o OBJS-$(CONFIG_WEBM_MUXER)+= matroskaenc.o matroska.o \ Any thoughts/preferences on this particular fix? I might be interested in cleaning up all instances of this in order to allow usage of /

Re: [FFmpeg-devel] Workaround for VS 2015 Update 1 bug

2016-01-28 Thread Bruce Dawson
16 at 1:52 PM, Hendrik Leppkes wrote: > Am 28.01.2016 22:14 schrieb "Bruce Dawson" : > > > > I hit a VS 2015 Update 1 code-gen bug that causes an string array to not > be > > null-terminated. I've already landed a patch in Chromium's downstream > copy, >

Re: [FFmpeg-devel] VS 2015 patch

2015-11-26 Thread Bruce Dawson
I don't scare that easily. :-) On Thu, Nov 26, 2015 at 12:39 PM, compn wrote: > On Wed, 25 Nov 2015 11:21:55 -0800 > Bruce Dawson wrote: > > I'm mentioning this just in case some other lost soul shows up trying > > to contribute a patch to a Chromium only file. I&#

Re: [FFmpeg-devel] VS 2015 patch

2015-11-25 Thread Bruce Dawson
h landed in the right place. Thanks for the help. On Wed, Nov 25, 2015 at 5:46 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 11/25/2015 12:05 AM, Bruce Dawson wrote: > > This would make ffmpeg fail on VS versions prior to VS 2013, for those > > using the BUILD

Re: [FFmpeg-devel] VS 2015 patch

2015-11-24 Thread Bruce Dawson
m not sure why - perhaps there were other gn based projects using ffmpeg. On Tue, Nov 24, 2015 at 4:36 PM, wm4 wrote: > On Tue, 24 Nov 2015 16:02:01 -0800 > Bruce Dawson wrote: > > > Interesting. I grabbed the code with: > > > > git clone https://chromium.googlesource

Re: [FFmpeg-devel] VS 2015 patch

2015-11-24 Thread Bruce Dawson
work automatically, which is why I did the conditional as shown. On Tue, Nov 24, 2015 at 4:01 PM, compn wrote: > On Tue, 24 Nov 2015 14:18:47 -0800 > Bruce Dawson wrote: > > > The attached patch lets ffmpeg build with both VS 2013 and VS 2015. > > > > Comments? > > > &

Re: [FFmpeg-devel] VS 2015 patch

2015-11-24 Thread Bruce Dawson
Chromium needs the patch landed and it shouldn't affect anyone else. On Tue, Nov 24, 2015 at 3:12 PM, Hendrik Leppkes wrote: > On Tue, Nov 24, 2015 at 11:18 PM, Bruce Dawson > wrote: > > I've been working on getting Chromium compiling with VS 2015 and there > are > &g