LGTM
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On 2016-01-18 15:46, Nicolas George wrote:
EOVERFLOW does not exist on some windows versions. IIRC, we usually use
EINVAL in this kind of case.
Thanks. I'll change that to EINVAL and apply the patch tomorrow if there
are no other issues.
- Arttu
On 2016-01-16 03:31, Michael Niedermayer wrote:
its probably rather unlikely but the multiplication could overflow
Thanks for taking a look. I attached an updated patch which checks for
overflow before multiplying.
- Arttu
>From 0a8a1a1fffd008d43ec601b7e0a5ed22c2c1f784 Mon Sep 17 00:00:00
Updates libkvazaar to pass the exact frame rate to Kvazaar by setting
the numerator and denominator separately instead of a single floating
point number. The exact frame rate is needed for writing timing info to
the bitstream.
Requires Kvazaar version 0.8.1.
Signed-off-by: Arttu Ylä-Outinen
On 2015-10-14 13:19, Carl Eugen Hoyos wrote:
> Hi!
>
> Attached patch for release/2.8 is supposed to fix ticket #4925, completely
> untested.
>
> Please comment, Carl Eugen
> +enabled libkvazaar&& require_pkg_config "kvazaar < 0.7.0" kvazaar
> kvazaar.h kvz_api_get
There is an extra "k
On 2015-09-29 16:29, Arttu Ylä-Outinen wrote:
These patches fix some problems in libkvazaar encoder and update it to work
with the latest git version of Kvazaar. Most notable changes are setting
pts, dts and keyframe flag on the output packets and fixing the calculation
of the framerate.
v2
Signed-off-by: Arttu Ylä-Outinen
---
v3: Use pkg-config for checking the version.
v2: Add this patch.
---
configure |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 361c024..ad4d71c 100755
--- a/configure
+++ b/configure
@@ -5272,7 +5272,7
On 2015-09-29 22:42, Hendrik Leppkes wrote:
On Tue, Sep 29, 2015 at 9:39 PM, Carl Eugen Hoyos wrote:
Clément Bœsch pkh.me> writes:
+ { check_cpp_condition kvazaar.h "KVZ_API_VERSION >= 7" ||
+ die "ERROR: kvazaar API version must be at least 7."; }
Can you do somet
Signed-off-by: Arttu Ylä-Outinen
---
libavcodec/libkvazaar.c |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c
index a15700a..9c59cad 100644
--- a/libavcodec/libkvazaar.c
+++ b/libavcodec/libkvazaar.c
@@ -141,6 +141,7
Replaces a for loop for copying pixels by a call to av_image_copy.
Signed-off-by: Arttu Ylä-Outinen
---
libavcodec/libkvazaar.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c
index 9c59cad
Changes function libkvazaar_encode to return proper error codes instead
of crashing when the video dimensions or pixel format change in the
middle of encoding.
Signed-off-by: Arttu Ylä-Outinen
---
libavcodec/libkvazaar.c | 24 +---
1 file changed, 21 insertions(+), 3
The -threads option is ignored with libkvazaar since it does not have
any of the AV_CODEC_CAP_{FRAME,SLICE,AUTO}_THREADS capabilities. This
commit removes the incorrect documentation as well as the no-op of
setting the number of threads in libkvazaar encoder.
Signed-off-by: Arttu Ylä-Outinen
The divisor and dividend in the equation had been swapped, making the
result the inverse of the actual framerate.
Signed-off-by: Arttu Ylä-Outinen
---
v2: Fix error in the commit message (bitrate --> framerate).
---
libavcodec/libkvazaar.c |2 +-
1 file changed, 1 insertion(+), 1 delet
Signed-off-by: Arttu Ylä-Outinen
---
libavcodec/libkvazaar.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c
index 7430e0a..aaaf1f7 100644
--- a/libavcodec/libkvazaar.c
+++ b/libavcodec/libkvazaar.c
@@ -106,8 +106,8
Signed-off-by: Arttu Ylä-Outinen
---
v2: Add this patch.
---
configure |2 ++
1 file changed, 2 insertions(+)
diff --git a/configure b/configure
index b572d59..30576c1 100755
--- a/configure
+++ b/configure
@@ -5272,6 +5272,8 @@ enabled libgsm&& { for gsm_hdr in "
of patches
"libkvazaar: Fix setting target bitrate" and
"doc/encoders: Fix libkvazaar documentation."
Thanks for the comments!
Arttu Ylä-Outinen (8):
libkvazaar: Update to work with the latest version
configure: Add version check for libkvazaar
libkvazaar: Rem
Function encoder_encode in Kvazaar API was changed to have new output
parameters: source picture and frame info. Frame info is used to set the
keyframe flag and source picture is ignored.
Signed-off-by: Arttu Ylä-Outinen
---
libavcodec/libkvazaar.c | 16 +++-
1 file changed, 15
On 2015-09-28 15:09, Carl Eugen Hoyos wrote:
I believe the patch is missing a change to configure:
Please make sure that configure --enable-libkvazaar
fails if compilation would fail later because a too
old version of libkvazaar is installed.
Okay, I'll add a version check.
- Arttu
___
On 2015-09-28 15:12, Carl Eugen Hoyos wrote:
Arttu Ylä-Outinen tut.fi> writes:
Removes the -threads option from libkvazaar documentation
since it does not work with libkvazaar.
Why?
(Is this something that has to be fixed in FFmpeg?)
The -threads option is ignored and the thread_co
On 2015-09-28 15:11, Carl Eugen Hoyos wrote:
Arttu Ylä-Outinen tut.fi> writes:
The divisor and dividend in the equation had been swapped,
making the result the inverse of the actual bitrate.
cfg->framerate =
- (double)(avctx->time_base.num * avctx->ticks_per_fr
Removes the -threads option from libkvazaar documentation since it does
not work with libkvazaar.
Signed-off-by: Arttu Ylä-Outinen
---
doc/encoders.texi |3 ---
libavcodec/libkvazaar.c |1 -
2 files changed, 4 deletions(-)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index
The divisor and dividend in the equation had been swapped, making the
result the inverse of the actual bitrate.
Signed-off-by: Arttu Ylä-Outinen
---
libavcodec/libkvazaar.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c
Replaces a for loop for copying pixels by a call to av_image_copy.
Signed-off-by: Arttu Ylä-Outinen
---
libavcodec/libkvazaar.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c
index 9c59cad
Signed-off-by: Arttu Ylä-Outinen
---
libavcodec/libkvazaar.c |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c
index a15700a..9c59cad 100644
--- a/libavcodec/libkvazaar.c
+++ b/libavcodec/libkvazaar.c
@@ -141,6 +141,7
Changes function libkvazaar_encode to return proper error codes instead
of crashing when the video dimensions or pixel format change in the
middle of encoding.
Signed-off-by: Arttu Ylä-Outinen
---
libavcodec/libkvazaar.c | 24 +---
1 file changed, 21 insertions(+), 3
Signed-off-by: Arttu Ylä-Outinen
---
libavcodec/libkvazaar.c |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/libavcodec/libkvazaar.c b/libavcodec/libkvazaar.c
index 7430e0a..aaaf1f7 100644
--- a/libavcodec/libkvazaar.c
+++ b/libavcodec/libkvazaar.c
@@ -106,8 +106,8
Function encoder_encode in Kvazaar API was changed to have new output
parameters: source picture and frame info. Frame info is used to set the
keyframe flag and source picture is ignored.
Signed-off-by: Arttu Ylä-Outinen
---
libavcodec/libkvazaar.c | 16 +++-
1 file changed, 15
These patches fix some problems in libkvazaar encoder and update it to work
with the latest git version of Kvazaar. Most notable changes are setting
pts, dts and keyframe flag on the output packets and fixing the calculation
of the target bitrate.
Arttu Ylä-Outinen (7):
libkvazaar: Update to
Signed-off-by: Arttu Ylä-Outinen
---
configure |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 55cc7fb..3fa37b7 100755
--- a/configure
+++ b/configure
@@ -5226,7 +5226,7 @@ enabled libgsm&& { for gsm_hdr in "gsm.h"
Signed-off-by: Arttu Ylä-Outinen
---
MAINTAINERS |1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index fa9e966..c5c6572 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -200,6 +200,7 @@ Codecs:
libcelt_dec.c Nicolas George
libdirac
Signed-off-by: Arttu Ylä-Outinen
---
Changelog |1 +
configure |4 +
doc/encoders.texi | 24 +
doc/general.texi| 10 +-
libavcodec/Makefile |1 +
libavcodec/allcodecs.c |1 +
libavcodec/libkvazaar.c | 248
31 matches
Mail list logo
