Re: [FFmpeg-devel] [PATCH v2] Use AVBufferPool in MOV

2024-12-11 Thread Arnaud Masserann
Hi, any feedback on this patch ? Thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2] Use AVBufferPool in MOV

2024-12-02 Thread Arnaud MASSERANN
it possible to read the media at 60Hz. Signed-off-by: Arnaud Masserann --- libavformat/demux.h | 11 +++ libavformat/isom.h | 2 ++ libavformat/mov.c | 20 ++-- libavformat/utils.c | 30 ++ 4 files changed, 61 insertions(+), 2 deletions

Re: [FFmpeg-devel] [PATCH] Use AVBufferPool in MOV

2024-12-02 Thread Arnaud Masserann
n Sun, 24 Nov 2024 18:14:03 +0100 > Arnaud Masserann wrote: > > > Good question. I just benchmarked all the .mov files in the samples repo. > > On average, there is a 1.3x speedup. A few files are slower, but 75% > > of the files have at least a 1.11x speedup, and 25% of

Re: [FFmpeg-devel] [PATCH] Use AVBufferPool in MOV

2024-11-28 Thread Arnaud Masserann
AVBufferPool is actually super lazy. It does not allocate N buffers at initialization. So for images, in all three cases (per-stream, per-media, and no pool), the behaviour is the same : 1 av_malloc per stream. To be sure, I ran more tests: On image1.heic (48-streams), as reported by massif with `

Re: [FFmpeg-devel] [PATCH] Use AVBufferPool in MOV

2024-11-24 Thread Arnaud Masserann
like some more detailed analysis ? Arnaud On Sat, Nov 23, 2024 at 1:46 PM Ronald S. Bultje wrote: > > Hi Arnaud, > > On Fri, Nov 22, 2024 at 1:08 PM Arnaud Masserann > wrote: > > > - Should the pools be per-stream (in MOVStreamContext) or per file (in > > MOVContext)

Re: [FFmpeg-devel] [PATCH] Use AVBufferPool in MOV

2024-11-24 Thread Arnaud Masserann
:46:19 +0100 > Arnaud Masserann wrote: > > > Most demuxers allocate a new buffer for each packet. > > For MOV, this can be problematic, because of some high-bitrate > > codecs like ProRes/HAPQ/NotchLC. > > > > Use pools of buffer instead. > > > > For

Re: [FFmpeg-devel] [PATCH] Use AVBufferPool in MOV

2024-11-22 Thread Arnaud Masserann
Arnaud Masserann wrote: > > Most demuxers allocate a new buffer for each packet. > For MOV, this can be problematic, because of some high-bitrate > codecs like ProRes/HAPQ/NotchLC. > > Use pools of buffer instead. > > For some test media, demuxing goes from 20ms/frame to 11

[FFmpeg-devel] [PATCH] Use AVBufferPool in MOV

2024-11-22 Thread Arnaud Masserann
it possible to read the media at 60Hz. Signed-off-by: Arnaud Masserann --- libavformat/avformat.h | 12 libavformat/isom.h | 2 ++ libavformat/mov.c | 20 ++-- libavformat/utils.c| 29 + 4 files changed, 61 insertions(+), 2