Re: [FFmpeg-devel] [PATCH v7 4/4] doc/examples/transcode_aac: Bump date

2022-05-02 Thread Andreas Unterweger
On Mon, 2 May 2022 at 11:38, Gyan Doshi wrote: > Removed whitespace errors in first two patches and pushed the set as > > e13429c9c4...40f2ea971f Thank you. Any hints on how I can avoid these types of errors in the future? Best, Andreas ___ ffmpeg-deve

Re: [FFmpeg-devel] [PATCH v7 4/4] doc/examples/transcode_aac: Bump date

2022-05-02 Thread Andreas Unterweger
On Mon, 2 May 2022 at 10:39, Gyan Doshi wrote: > The error is > > error: patch fragment without header at line 6: @@ -675,18 +677,17 @@ static > int encode_audio_frame(AVFrame *frame, > > > The patch on PW only shows the first two hunks. > > Ideally, send your path using git send-email, or upload

Re: [FFmpeg-devel] [PATCH v7 4/4] doc/examples/transcode_aac: Bump date

2022-05-02 Thread Andreas Unterweger
On Mon, 2 May 2022 at 09:31, Andreas Unterweger wrote: > > Signed-off-by: Andreas Unterweger > --- > doc/examples/transcode_aac.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c > inde

[FFmpeg-devel] [PATCH v7 4/4] doc/examples/transcode_aac: Bump date

2022-05-02 Thread Andreas Unterweger
Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c index 909aa1cb73..1b372782ab 100644 --- a/doc/examples/transcode_aac.c +++ b/doc/examples

[FFmpeg-devel] [PATCH v7 3/4] doc/examples/transcode_aac: AAC encoder is no longer experimental

2022-05-02 Thread Andreas Unterweger
Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c index 52548f080d..909aa1cb73 100644 --- a/doc/examples/transcode_aac.c +++ b/doc/examples/transcode_aac.c @@ -211,9

[FFmpeg-devel] [PATCH v7 2/4] doc/examples/transcode_aac: Set decoder packet timebase

2022-05-02 Thread Andreas Unterweger
Previously, the default timebase caused two warnings during decoding about not being able to update timestamps for skipped and discarded samples, respectively. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions

[FFmpeg-devel] [PATCH v7 1/4] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-05-02 Thread Andreas Unterweger
The last encoded frame is now fetched on EOF. It was previously left in the encoder and caused a "1 frame left in queue" warning. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff -

Re: [FFmpeg-devel] [PATCH v4 2/2] doc/examples/transcode_aac: Set decoder packet timebase

2022-04-28 Thread Andreas Unterweger
On Thu, 28 Apr 2022 at 05:23, Andreas Rheinhardt wrote: > > Andreas Unterweger: > > Previously, the default timebase caused two warnings during decoding > > about not being able to update timestamps for skipped and discarded > > samples, respectively. > > > &g

[FFmpeg-devel] [PATCH v6 4/4] doc/examples/transcode_aac: Bump date

2022-04-28 Thread Andreas Unterweger
Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c index 909aa1cb73..1b372782ab 100644 --- a/doc/examples/transcode_aac.c +++ b/doc/examples

[FFmpeg-devel] [PATCH v6 3/4] doc/examples/transcode_aac: AAC encoder is no longer experimental

2022-04-28 Thread Andreas Unterweger
Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c index 52548f080d..909aa1cb73 100644 --- a/doc/examples/transcode_aac.c +++ b/doc/examples/transcode_aac.c @@ -211,9

[FFmpeg-devel] [PATCH v6 2/4] doc/examples/transcode_aac: Set decoder packet timebase

2022-04-28 Thread Andreas Unterweger
Previously, the default timebase caused two warnings during decoding about not being able to update timestamps for skipped and discarded samples, respectively. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions

[FFmpeg-devel] [PATCH v6 1/4] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-04-28 Thread Andreas Unterweger
The last encoded frame is now fetched on EOF. It was previously left in the encoder and caused a "1 frame left in queue" warning. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff -

[FFmpeg-devel] [PATCH v5 4/4] doc/examples/transcode_aac: Bump date

2022-04-28 Thread Andreas Unterweger
Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c index 909aa1cb73..1b372782ab 100644 --- a/doc/examples/transcode_aac.c +++ b/doc/examples

[FFmpeg-devel] [PATCH v5 3/4] doc/examples/transcode_aac: AAC encoder is no longer experimental

2022-04-28 Thread Andreas Unterweger
Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/doc/examples/transcode_aac.c b/doc/examples/transcode_aac.c index 52548f080d..909aa1cb73 100644 --- a/doc/examples/transcode_aac.c +++ b/doc/examples/transcode_aac.c @@ -211,9

[FFmpeg-devel] [PATCH v5 2/4] doc/examples/transcode_aac: Set decoder packet timebase

2022-04-28 Thread Andreas Unterweger
Previously, the default timebase caused two warnings during decoding about not being able to update timestamps for skipped and discarded samples, respectively. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions

[FFmpeg-devel] [PATCH v5 1/4] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-04-28 Thread Andreas Unterweger
The last encoded frame is now fetched on EOF. It was previously left in the encoder and caused a "1 frame left in queue" warning. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff -

Re: [FFmpeg-devel] [PATCH v4 2/2] doc/examples/transcode_aac: Set decoder packet timebase

2022-04-27 Thread Andreas Unterweger
On Wed, 27 Apr 2022 at 16:07, Andreas Unterweger wrote: > > Previously, the default timebase caused two warnings during decoding > about not being able to update timestamps for skipped and discarded > samples, respectively. > > Signed-off-by: Andreas Unterweger >

[FFmpeg-devel] [PATCH v4 2/2] doc/examples/transcode_aac: Set decoder packet timebase

2022-04-27 Thread Andreas Unterweger
Previously, the default timebase caused two warnings during decoding about not being able to update timestamps for skipped and discarded samples, respectively. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH v4 1/2] doc/examples/transcode_aac: Don't ignore last encoded

2022-04-27 Thread Andreas Unterweger
The last encoded frame is now fetched on EOF. It was previously left in the encoder and caused a "1 frame left in queue" warning. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff -

Re: [FFmpeg-devel] [PATCH v3 2/2] doc/examples/transcode_aac: Set decoder packet timebase

2022-04-27 Thread Andreas Unterweger
Am 27.04.2022 um 15:35 schrieb Andreas Unterweger: Previously, the default timebase caused two warnings during decoding about not being able to update timestamps for skipped and discarded samples, respectively. Signed-off-by: Andreas Unterweger ---  doc/examples/transcode_aac.c | 6

[FFmpeg-devel] [PATCH v3 2/2] doc/examples/transcode_aac: Set decoder packet timebase

2022-04-27 Thread Andreas Unterweger
Previously, the default timebase caused two warnings during decoding about not being able to update timestamps for skipped and discarded samples, respectively. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH v3 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-04-27 Thread Andreas Unterweger
The last encoded frame is now fetched on EOF. It was previously left in the encoder and caused a "1 frame left in queue" warning. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff -

Re: [FFmpeg-devel] [PATCH v2 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-04-24 Thread Andreas Unterweger
Am 24.04.2022 um 14:38 schrieb James Almer: On 4/24/2022 9:36 AM, Andreas Unterweger wrote: Am 11.04.2022 um 08:46 schrieb Paul B Mahol: On Tue, Mar 22, 2022 at 6:47 PM Andreas Unterweger wrote: The last encoded frame is now fetched on EOF. It was previously left in the encoder and caused a

Re: [FFmpeg-devel] [PATCH v2 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-04-24 Thread Andreas Unterweger
Am 11.04.2022 um 08:46 schrieb Paul B Mahol: On Tue, Mar 22, 2022 at 6:47 PM Andreas Unterweger wrote: The last encoded frame is now fetched on EOF. It was previously left in the encoder and caused a "1 frame left in queue" warning. Signed-off-by: Andreas Unterweger --- do

Re: [FFmpeg-devel] [PATCH v2 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-04-05 Thread Andreas Unterweger
Am 22.03.2022 um 18:47 schrieb Andreas Unterweger: The last encoded frame is now fetched on EOF. It was previously left in the encoder and caused a "1 frame left in queue" warning. Signed-off-by: Andreas Unterweger ---  doc/examples/transcode_aac.c | 22 +++--

[FFmpeg-devel] [PATCH v2 2/2] doc/examples/transcode_aac: Set decoder packet timebase

2022-03-22 Thread Andreas Unterweger
Previously, the default timebase caused two warnings during decoding about not being able to update timestamps for skipped and discarded samples, respectively. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH v2 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-03-22 Thread Andreas Unterweger
The last encoded frame is now fetched on EOF. It was previously left in the encoder and caused a "1 frame left in queue" warning. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff -

Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-03-22 Thread Andreas Unterweger
Am 14.03.2022 um 07:41 schrieb Andreas Unterweger: Am 02.03.2022 um 15:07 schrieb Paul B Mahol: The patch on patchwork looks fine. Good morning. Can this patch be merged? Thanks and best regards Andreas ___ Since other commits have been merged in

Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-03-13 Thread Andreas Unterweger
Am 02.03.2022 um 15:07 schrieb Paul B Mahol: The patch on patchwork looks fine. Good morning. Can this patch be merged? Thanks and best regards Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-de

Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-03-02 Thread Andreas Unterweger
> On 02.03.2022 13:27 Paul B Mahol wrote: > > > On Wed, Mar 2, 2022 at 1:18 PM Andreas Unterweger > wrote: > > > > On 02.03.2022 12:55 Paul B Mahol wrote: > > > > > do { > > > > > -

Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-03-02 Thread Andreas Unterweger
> On 02.03.2022 12:55 Paul B Mahol wrote: > > > do { > > > -data_written = 0; > > > > why this is removed ? > > > > > if (encode_audio_frame(NULL, output_format_context, > > > output_codec_context, > > &data_w

Re: [FFmpeg-devel] [PATCH 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-03-01 Thread Andreas Unterweger
> On 23.02.2022 15:58 Andreas Unterweger wrote: > > > The last encoded frame is now fetched on EOF. It was previously left in the > encoder and caused a "1 frame left in queue" warning. > > Signed-off-by: Andreas Unterweger > --- >

[FFmpeg-devel] [PATCH 2/2] doc/examples/transcode_aac: Set decoder packet timebase

2022-02-23 Thread Andreas Unterweger
Previously, the default timebase caused two warnings during decoding about not being able to update timestamps for skipped and discarded samples, respectively. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff

[FFmpeg-devel] [PATCH 1/2] doc/examples/transcode_aac: Don't ignore last encoded frame

2022-02-23 Thread Andreas Unterweger
The last encoded frame is now fetched on EOF. It was previously left in the encoder and caused a "1 frame left in queue" warning. Signed-off-by: Andreas Unterweger --- doc/examples/transcode_aac.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff -