Re: [FFmpeg-devel] [PATCH v7 0/6] Add FLIF decoding and demuxing support

2020-08-28 Thread Anamitra Ghorui
On Sat, 29 Aug 2020 00:15:25 +0530 Anamitra Ghorui wrote: > v2: Fix faulty patch > v3: Fix addressed errors, Add interlaced decoding support > v4: Fix Further cosmetics, C.Bucket Transform reading errors, Atomise patch > v5: Fix faulty patch > v6: Address pointed out error

[FFmpeg-devel] [PATCH v7 6/6] doc/demuxers: add entry for FLIF

2020-08-28 Thread Anamitra Ghorui
Signed-off-by: Anamitra Ghorui --- doc/demuxers.texi | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index 3c15ab9eee..69b2ce5025 100644 --- a/doc/demuxers.texi +++ b/doc/demuxers.texi @@ -243,6 +243,15 @@ which streams to actually receive

[FFmpeg-devel] [PATCH v7 4/6] doc/general: add entry for FLIF

2020-08-28 Thread Anamitra Ghorui
Signed-off-by: Anamitra Ghorui --- doc/general.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/general.texi b/doc/general.texi index d618565347..e9ae535c34 100644 --- a/doc/general.texi +++ b/doc/general.texi @@ -904,6 +904,8 @@ following image formats are supported: @item Flash

[FFmpeg-devel] [PATCH v7 2/6] avformat: add FLIF demuxing support

2020-08-28 Thread Anamitra Ghorui
Signed-off-by: Anamitra Ghorui --- configure| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/flifdec.c| 445 +++ libavformat/version.h| 4 +- 5 files changed, 450 insertions(+), 2 deletions

[FFmpeg-devel] [PATCH v7 5/6] doc/decoders: add entry for FLIF

2020-08-28 Thread Anamitra Ghorui
Signed-off-by: Anamitra Ghorui --- doc/decoders.texi | 8 1 file changed, 8 insertions(+) diff --git a/doc/decoders.texi b/doc/decoders.texi index 9005714e3c..77e93ab80a 100644 --- a/doc/decoders.texi +++ b/doc/decoders.texi @@ -86,6 +86,14 @@ AVS2-P2/IEEE1857.4 video decoder wrapper

[FFmpeg-devel] [PATCH v7 0/6] Add FLIF decoding and demuxing support

2020-08-28 Thread Anamitra Ghorui
style errors, make only atomised rangecoder functions inline. Test files are available here: https://0x0.st/iYs_.zip Co-authored-by: Anamitra Ghorui Co-authored-by: Kartik K Khullar Anamitra Ghorui (6): avcodec: add FLIF decoding support avformat: add FLIF demuxing support changelog: add

[FFmpeg-devel] [PATCH v7 3/6] changelog: add entries for FLIF

2020-08-28 Thread Anamitra Ghorui
Signed-off-by: Anamitra Ghorui --- Changelog | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Changelog b/Changelog index 7467e73306..b55f322963 100644 --- a/Changelog +++ b/Changelog @@ -15,6 +15,8 @@ version : - Argonaut Games ASF muxer - AV1 Low overhead bitstream format demuxer

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

2020-08-27 Thread Anamitra Ghorui
On Thu, 27 Aug 2020 08:46:00 +0530 Anamitra Ghorui wrote: > (I apologise if this mail gets sent to the wrong thread and other > errors. I'm trying out a new mail client) > > On Wed, 26 Aug 2020 16:31:46 + > "Anamitra Ghorui" wrote: > > [...] > >

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

2020-08-27 Thread Anamitra Ghorui
(I apologise if this mail gets sent to the wrong thread and other errors. I'm trying out a new mail client) On Wed, 26 Aug 2020 16:31:46 +0000 "Anamitra Ghorui" wrote: [...] > I agree that the case statements between if statements and while > statements are not very g

Re: [FFmpeg-devel] [PATCH v6 3/4] configure: add FLIF dependencies

2020-08-26 Thread Anamitra Ghorui
On 26/08/2020 18:57, Moritz Barsnick wrote: > On Sun, Aug 23, 2020 at 00:09:34 +0530, Anamitra Ghorui wrote: >> --- a/configure >> +++ b/configure >> @@ -3307,6 +3307,7 @@ fifo_muxer_deps="threads" >> flac_demuxer_select="flac_parser

Re: [FFmpeg-devel] [PATCH v6 1/4] lavc: add FLIF decoding support

2020-08-26 Thread Anamitra Ghorui
Hello, Thanks for the review. Please see replies below. On 26/08/2020 18:44, Moritz Barsnick wrote: > On Sun, Aug 23, 2020 at 00:09:32 +0530, Anamitra Ghorui wrote: >> v2: Fix faulty patch >> v3: Fix addressed errors, Add interlaced decoding support >> v4: Fix Furthe

[FFmpeg-devel] [PATCH v6 3/4] configure: add FLIF dependencies

2020-08-22 Thread Anamitra Ghorui
Signed-off-by: Anamitra Ghorui --- configure | 1 + 1 file changed, 1 insertion(+) diff --git a/configure b/configure index 6faff9bc7b..a80e300cdb 100755 --- a/configure +++ b/configure @@ -3307,6 +3307,7 @@ fifo_muxer_deps="threads" flac_demuxer_select="flac_parser&quo

[FFmpeg-devel] [PATCH v6 2/4] lavfmt: add FLIF demuxing support

2020-08-22 Thread Anamitra Ghorui
Signed-off-by: Anamitra Ghorui --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/flifdec.c| 431 +++ libavformat/version.h| 2 +- 4 files changed, 434 insertions(+), 1 deletion(-) create mode 100644 libavformat

[FFmpeg-devel] [PATCH v6 4/4] doc: add documentation entries for FLIF

2020-08-22 Thread Anamitra Ghorui
Signed-off-by: Anamitra Ghorui --- Changelog| 3 ++- doc/general.texi | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Changelog b/Changelog index 7467e73306..cfa21c280b 100644 --- a/Changelog +++ b/Changelog @@ -15,7 +15,8 @@ version : - Argonaut Games ASF muxer

Re: [FFmpeg-devel] [PATCH v5 1/3] [RFC] lavc: add FLIF decoding support

2020-08-21 Thread Anamitra Ghorui
August 21, 2020 8:27 PM, "Paul B Mahol" wrote: > On 8/20/20, Anamitra Ghorui wrote: > >> Hello, >> >> On Wed, 19 Aug 2020 21:05:41 +0200 >> Paul B Mahol wrote: >> >> [...] >> >>>> >>>> >>>> All

Re: [FFmpeg-devel] [PATCH v5 1/3] [RFC] lavc: add FLIF decoding support

2020-08-20 Thread Anamitra Ghorui
Hello, On Wed, 19 Aug 2020 21:05:41 +0200 Paul B Mahol wrote: [...] > > > > > > All these corrections have been made by me locally, but I would > > like to wait for some further review (self and otherwise) before > > posting again. > > Please make use of av_clip and FFMIN/FFMAX macros. > We

Re: [FFmpeg-devel] [PATCH v5 1/3] [RFC] lavc: add FLIF decoding support

2020-08-17 Thread Anamitra Ghorui
On Sat, 15 Aug 2020 00:29:10 +0530 Anamitra Ghorui wrote: > This patch fixes a few cosmetic errors mentioned in v3, an error in the > ColorBuckets reading function and removes a few redundancies in the > rangecoder initialisation. > > Co-authored-by: Anamitra Ghorui > Co-aut

[FFmpeg-devel] [PATCH v5 3/3] [RFC] Update documentation and configure script for FLIF

2020-08-14 Thread Anamitra Ghorui
Signed-off-by: Anamitra Ghorui --- Changelog| 3 ++- configure| 1 + doc/general.texi | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Changelog b/Changelog index 1efc768387..77b8f46a19 100644 --- a/Changelog +++ b/Changelog @@ -14,7 +14,8 @@ version

[FFmpeg-devel] [PATCH v5 2/3] [RFC] lavfmt: add FLIF demuxing support

2020-08-14 Thread Anamitra Ghorui
This patch removes a redundant class member mentioned in v3, and skips iCCP metadata segments. Signed-off-by: Anamitra Ghorui --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/flifdec.c| 431 +++ libavformat/version.h

Re: [FFmpeg-devel] [PATCH v4 1/3] [RFC] lavc: add FLIF decoding support

2020-08-14 Thread Anamitra Ghorui
Patches need to be self contained. Didn't notice that before. Will repost. Regards, Anamitra ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-

[FFmpeg-devel] [PATCH v4 2/3] [RFC] lavfmt: add FLIF demuxing support

2020-08-14 Thread Anamitra Ghorui
This patch removes a redundant class member mentioned in v3, and skips iCCP metadata segments. Signed-off-by: Anamitra Ghorui --- Changelog| 3 +- configure| 250 --- doc/general.texi | 2 + libavformat/Makefile | 1

[FFmpeg-devel] [PATCH v4 3/3] [RFC] lavc: add codec entries for FLIF

2020-08-14 Thread Anamitra Ghorui
Signed-off-by: Anamitra Ghorui --- libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + 2 files changed, 8 insertions(+) diff --git a/libavcodec/codec_desc.c b/libavcodec/codec_desc.c index 0ae6aee63b..11acb91b76 100644 --- a/libavcodec/codec_desc.c +++ b/libavcodec/codec_desc.c

Re: [FFmpeg-devel] [PATCH v3] [RFC] lavc, lavfmt: add FLIF decoding support

2020-08-12 Thread Anamitra Ghorui
On Tue, 11 Aug 2020 23:38:21 +0530 Anamitra Ghorui wrote: > This patch adds support for non animated, animated, non interlaced and > interlaced FLIF images. > Hopefully, all previously mentioned mistakes have been resolved. > However, there are a few things I want to ask: > >

Re: [FFmpeg-devel] [PATCH v2] [RFC] lavc, lavfmt: add FLIF decoding support

2020-08-02 Thread Anamitra Ghorui
multiple spaces) in the blockquotes. I apologise for that. August 2, 2020 5:58 PM, "Nicolas George" wrote: > Anamitra Ghorui (12020-07-30): > >> Visible errors have been fixed in libavformat/flifdec.c, however the >> problem regarding metadata decoding still exists. Th

Re: [FFmpeg-devel] [PATCH] [RFC] lavc, lavfmt: add FLIF decoding support

2020-07-30 Thread Anamitra Ghorui
July 30, 2020 1:08 AM, "Andreas Rheinhardt" wrote: > Anamitra Ghorui: > >> This patch implements non interlaced decoding of FLIF16 images with all >> transforms except for one, FrameLookback which is being tested. >> >> Several test files have been

Re: [FFmpeg-devel] [PATCH] [RFC] lavc, lavfmt: add FLIF decoding support

2020-07-29 Thread Anamitra Ghorui
It appears that the patch is faulty. I will be reposting it. Sorry for the inconvenience. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ

Re: [FFmpeg-devel] Project orientation

2020-07-05 Thread Anamitra Ghorui
July 5, 2020 11:43 PM, "Manolis Stamatogiannakis" wrote: > On Sun, 5 Jul 2020 at 19:01, Kieran Kunhya wrote: > >> For new contributors git send-email is annoying. For people wanting to >> push, the .mbox format is annoying, Gmail doesn't support it any more. >> And you can't get new contributor

Re: [FFmpeg-devel] Question Regarding Outputting Frames on Image/Video Formats with Non-Contiguous Storage of Frames

2020-07-03 Thread Anamitra Ghorui
The solution was simple. Only needed to add the flag AV_CODEC_CAP_DELAY[1] to the decoder to enable the draining condition. [1]: https://ffmpeg.org/doxygen/trunk/group__lavc__core.html#ga3f55f5bcfbb12e06c7cb1195028855e6 Regards, Anamitra ___ ffm

[FFmpeg-devel] Question Regarding Outputting Frames on Image/Video Formats with Non-Contiguous Storage of Frames

2020-07-02 Thread Anamitra Ghorui
Hello, I have written a decoder for a video (gif-like) format[1] which, due to the nature of the format, is fed packets until it detects the end of stream[2]. Until then, no frames are outputted and AVERROR(EAGAIN) is returned. After the stream is completely processed, the decoder starts to try t

Re: [FFmpeg-devel] [WIP][RFC] [PATCH] FLIF16 Decoder

2020-05-29 Thread Anamitra Ghorui
Just to clarify, the raangecoded bitstream is decoded in function flif16_read_second_header in libavcodec/flif16dec.c. Here the aforementioned switch statement - segment variable system is used. Regards, Anamitra ___ ffmpeg-devel mailing list ffmpeg-dev

[FFmpeg-devel] [WIP][RFC] [PATCH] FLIF16 Decoder

2020-05-29 Thread Anamitra Ghorui
ut is incorrect) Regards, Anamitra [1]: https://flif.info/spec.html [2]: https://github.com/FLIF-hub/FLIF [3]: https://flif.info/spec.html#_uniform_symbol_coding [4]: https://github.com/daujerrine/ffmpeg/blob/master/libavcodec/flif16_rangecoder.h Signed-off-by: Anamitra Ghorui --- Changelog

[FFmpeg-devel] [GSOC] FLIF16 Decoder (and Encoder)

2020-05-04 Thread Anamitra Ghorui
" (or closely following) the FLIF reference implementation, which I really don't want to do. I want to do it with the full knowledge of how the codec works. Although reading through the reference implementation will also inevitably include review of the sourcecode and hence chanves. Regards

Re: [FFmpeg-devel] [RFC] Question Regarding Parsing Files with Sections of Unknown Length and No Delimiters

2020-03-16 Thread Anamitra Ghorui
March 16, 2020 3:25 PM, "Anton Khirnov" wrote: > Quoting Anamitra Ghorui (2020-03-15 13:40:58) > >> Hello, >> >> I am dealing dealing with a video (gif-like) file format in which there >> are compressed (entropy coded) segments of unknown length. Howeve

[FFmpeg-devel] [RFC] Question Regarding Parsing Files with Sections of Unknown Length and No Delimiters

2020-03-15 Thread Anamitra Ghorui
Hello, I am dealing dealing with a video (gif-like) file format in which there are compressed (entropy coded) segments of unknown length. However, the length of the uncompressed segment of the file is already known. Please check the previous mail by thread if context is required. There are no m

Re: [FFmpeg-devel] [PATCH V3] [RFC] GSoC: FLIF16 Image format parser

2020-03-14 Thread Anamitra Ghorui
Hello, March 15, 2020 2:15 AM, "Jai Luthra" wrote: >On Fri, Mar 06, 2020 at 06:10:04PM +0000, Anamitra Ghorui wrote: >>The parser has been tested and is able to correctly identify the start >>of the compressed bitstream. The patch has a set of printf statements >>w

Re: [FFmpeg-devel] [PATCH V3] [RFC] GSoC: FLIF16 Image format parser

2020-03-06 Thread Anamitra Ghorui
I just realised that there is a range coder implementation already present in libavcodec. I'll look into it. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or ema

[FFmpeg-devel] [PATCH V3] [RFC] GSoC: FLIF16 Image format parser

2020-03-06 Thread Anamitra Ghorui
pe = AVMEDIA_TYPE_VIDEO, +.name = "flif16", +.long_name = NULL_IF_CONFIG_SMALL("FLIF16 (Free Lossless Image Format)"), +.props = AV_CODEC_PROP_LOSSLESS, +}, /* various PCM "codecs" */ { diff --git a/libavco

Re: [FFmpeg-devel] [PATCH V2] [RFC] GSoC: FLIF16 Image format parser

2020-03-02 Thread Anamitra Ghorui
Hello, > Is there an upper bound for the size of these integers? In my > experience, varints in multimedia code are used to save a few bits in > the file than to allow very large integers. You could make the code much > simpler if you had an upper bound. > > Also, there is probably already simila

[FFmpeg-devel] [PATCH V2] [RFC] GSoC: FLIF16 Image format parser

2020-03-01 Thread Anamitra Ghorui
if16.c new file mode 100644 index 00..2201951d91 --- /dev/null +++ b/libavcodec/flif16.c @@ -0,0 +1,97 @@ +/* + * FLIF16 Component functions + * Copyright (c) 2020 Anamitra Ghorui + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it

Re: [FFmpeg-devel] GSoC: Regarding Parsing and FLIF16 Frame Encoding

2020-02-29 Thread Anamitra Ghorui
Oh, sorry about that. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] GSoC: Regarding Parsing and FLIF16 Frame Encoding

2020-02-28 Thread Anamitra Ghorui
Hello, I have been reading through the parsing API and other things and here's what I've managed to gather (I will be ignoring overruns in these functions for now). Please tell me if I am right or wrong: 1. As long as the parse function determines next == END_NOT_FOUND, ff_combine_frame will

Re: [FFmpeg-devel] [PATCH] [RFC] GSoC: FLIF16 Image format parser

2020-02-27 Thread Anamitra Ghorui
February 27, 2020 6:15 PM, "Moritz Barsnick" wrote: >> OBJS-$(CONFIG_FLAC_PARSER) += flac_parser.o flacdata.o flac.o \ >> vorbis_data.o >> +OBJS-$(CONFIG_FLAC_PARSER) += flif16_parser.o > > > > This looks wrong. You are adding this object to a compile of the FLAC > parser, not your new par

[FFmpeg-devel] [PATCH] [RFC] GSoC: FLIF16 Image format parser

2020-02-25 Thread Anamitra Ghorui
id pointing at the start of audio codecs diff --git a/libavcodec/flif16_parser.c b/libavcodec/flif16_parser.c new file mode 100644 index 00..54bd93d499 --- /dev/null +++ b/libavcodec/flif16_parser.c @@ -0,0 +1,51 @@ +/* + * FLIF16 parser + * Copyright (c) 2020 Anamitra Ghorui + * + *

[FFmpeg-devel] [PATCH] Removed bogus/duplicate PNG parser subsystem entry.

2020-02-24 Thread Anamitra Ghorui
--- libavcodec/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 0de585279c..f1c032b456 100644 --- a/libavcodec/Makefile +++ b/libavcodec/Makefile @@ -1059,7 +1059,6 @@ OBJS-$(CONFIG_MLP_PARSER) += mlp_parse.o mlp_parser.o mlp