Re: [FFmpeg-devel] [PATCH 3/3] Adds a new hls_flag avg_bw

Thanks for your feedback. Will soon make these changes and re-submit. -Amit On Fri, Sep 28, 2018 at 7:02 PM Jeyapal, Karthick wrote: > Please find my comments inlined below. > On 9/28/18 11:36 AM, Amit Kale wrote: > > If this flag is set, AVERAGE-BANDWIDTH value will be added

Re: [FFmpeg-devel] [PATCH 1/3] Fix computation of vs->start_pos

On Friday 28 September 2018 11:40 AM, Steven Liu wrote: Amit Kale 于2018年9月28日周五 下午2:01写道： Reset vs->start_pos when beginning a new file. Signed-off-by: Amit Kale --- libavformat/hlsenc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: ffmpeg/libavformat/hlsen

[FFmpeg-devel] [PATCH 3/3] Adds a new hls_flag avg_bw

If this flag is set, AVERAGE-BANDWIDTH value will be added to a master playlist entry. This flag implies peak_segment_bw. Signed-off-by: Amit Kale --- doc/muxers.texi | 4 libavformat/dashenc.c | 2 +- libavformat/hlsenc.c | 20 libavformat

[FFmpeg-devel] [PATCH 2/3] Adds a new hls_flag peak_segment_bw

If this flag is set, BANDWIDTH value in a master playlist entry will be set to the peak segment bandwidth. This patch also delays freeing of hls stream data, so that it's available for bandwidth calculation. Signed-off-by: Amit Kale --- doc/muxers.texi | 4 libavformat/hls

[FFmpeg-devel] [PATCH 1/3] Fix computation of vs->start_pos

Reset vs->start_pos when beginning a new file. Signed-off-by: Amit Kale --- libavformat/hlsenc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: ffmpeg/libavformat/hlsenc.c === --- ffmpeg.orig/libavformat/hlsen

[FFmpeg-devel] [PATCH 0/3] Enable peak and average bandwidth to be added to HLS manifest files

Hi, I am sending patches correct bandwidth values in the HLS manifest files output by ffmpeg. These are currently based on average bandwidth. These patches enable the bandwidth values to be calculated based on the number of bytes present in each stream in each segment file. 1/3 - Fix computati

[FFmpeg-devel] [PATCH 4/4] Delay freeing of hls stream data

This patch delays freeing of hls stream data, so that it's available for bandwidth calculation. Otherwise the previous patches would cause a segfault in this code. Signed-off-by: Amit Kale --- Index: ffmpeg/libavformat/hls

[FFmpeg-devel] [PATCH 1/4] Reset vs->start_pos when beginning a new file

Reset vs->start_pos when beginning a new file. Signed-off-by: Amit Kale --- libavformat/hlsenc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: ffmpeg/libavformat/hlsenc.c === --- ffmpeg.orig/libavformat/hlsen

[FFmpeg-devel] [PATCH 3/4] Adds a new hls_flag avg_bw

If this flag is set, AVERAGE-BANDWIDTH value will be added to a master playlist entry. This flag implies peak_segment_bw. Signed-off-by: Amit Kale --- doc/muxers.texi | 4 libavformat/dashenc.c | 2 +- libavformat/hlsenc.c | 20 libavformat

[FFmpeg-devel] [PATCH 2/4] Add a new hls_flag peak_segment_bw

If this flag is set, BANDWIDTH value in a master playlist entry will be set to the peak segment bandwidth. Signed-off-by: Amit Kale --- doc/muxers.texi | 4 libavformat/hlsenc.c | 29 + 2 files changed, 25 insertions(+), 8 deletions(-) Index: ffmpeg/doc

[FFmpeg-devel] PATCH[0/4]

Hi, I am sending an HLS manifest file output patch containing fixes broken down in four parts as follows 0001-Fix-computation-of-vs-start_pos.patch 0002-Add-a-new-hls_flag-peak_segment_bw.patch 0003-Adds-a-new-hls_flag-avg_bw.patch 0004-fix-master_pl-segfault.patch The overall description is th

[FFmpeg-devel] [PATCH 3/3] Adds a new hls_flag avg_bw

If this flag is set, AVERAGE-BANDWIDTH value will be added to a master playlist entry. This flag implies peak_segment_bw. ---  doc/muxers.texi   |  4  libavformat/dashenc.c |  2 +-  libavformat/hlsenc.c  | 20  libavformat/hlsplaylist.c |  6 --  libavf

[FFmpeg-devel] [PATCH 1/3] Fix computation of vs->start_pos

Reset vs->start_pos when beginning a new file. ---  libavformat/hlsenc.c | 5 -  1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index cc13c94e97..9970c4c575 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2227,7 +2227,10

[FFmpeg-devel] [PATCH 2/3] Add a new hls_flag peak_segment_bw

If this flag is set, BANDWIDTH value in a master playlist entry will be set to the peak segment bandwidth. ---  doc/muxers.texi  |  4  libavformat/hlsenc.c | 29 +  2 files changed, 25 insertions(+), 8 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.tex

Re: [FFmpeg-devel] [PATCH] HLS master playlist - peak and average bandwidth settings

On Mon, Feb 5, 2018 at 5:52 PM, Carl Eugen Hoyos wrote: > 2018-02-05 11:11 GMT+01:00 Amit Kale : > > Kindly below a patch to add peak and average bandwidth settings for HLS > > master playlist. It adds two hls_flags as described below. > > > > peak_segment_bw > &g

[FFmpeg-devel] [PATCH] HLS master playlist - peak and average bandwidth settings

parameter is non-null AVERAGE-BANDWIDTH is emitted. Thanks. -Amit Signed-off-by: Amit Kale -- diff --git a/doc/muxers.texi b/doc/muxers.texi index d9a5cc03dc..428d4009b3 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -741,6 +741,14 @@ subdirectories. Possible values: @table @samp +@item

Re: [FFmpeg-devel] hls BANDWIDTH field in master playlist

Thanks for this info. Will soon get back with a patch. -Amit On 01-Feb-2018 3:58 PM, "Jeyapal, Karthick" wrote: > On 2/1/18 3:12 PM, Amit Kale wrote: > > Hi All, > > > > When emitting a master playlist, BANDWIDTH field is computed in > > libavformat/hlse

[FFmpeg-devel] hls BANDWIDTH field in master playlist

Hi All, When emitting a master playlist, BANDWIDTH field is computed in libavformat/hlsenc.c by adding video and audio stream bitrates and then adding 10% to account for container overhead. However HLS specification (RFC8216) says that BANDWIDTH represents the peak segment bit rate. AVERAGE-BANDWI