Re: [FFmpeg-devel] [PATCH] avformat/rtpdec: Fix prft wallclock time.

2021-03-30 Thread Alok Priyadarshi
Ping. Could someone please review this patch. Thanks. On Thu, Mar 25, 2021, 6:40 AM Alok Priyadarshi wrote: > In effect the patch does replace that one line. But it also adds the steps > to illustrate how the wallclock is calculated. Adding all the calculations > in a single line wil

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec: Fix prft wallclock time.

2021-03-25 Thread Alok Priyadarshi
addition to missing timebase scaling. On Thu, Mar 25, 2021 at 2:23 AM Carl Eugen Hoyos wrote: > Am Do., 25. März 2021 um 05:47 Uhr schrieb Alok Priyadarshi < > alo...@gmail.com>: > > > > Timestamp difference is available in media timebase (1/90K) where as > &g

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec: attach producer reference time if available

2021-03-24 Thread Alok Priyadarshi
Hi James, This patch had a bug in the calculation of prft time. I did not account for the timebase differences between media timestamp and wall clock. I have sent a new patch for review. -Alok On Tue, Mar 23, 2021 at 3:04 PM James Almer wrote: > On 3/23/2021 6:29 PM, Alok Priyadarshi wr

[FFmpeg-devel] [PATCH] avformat/rtpdec: Fix prft wallclock time.

2021-03-24 Thread Alok Priyadarshi
Timestamp difference is available in media timebase (1/90K) where as rtcp time is in the default microseconds timebase. This patch fixes the calculated prft wallclock time by rescaling the timestamp delta to the microseconds timebase. --- libavformat/rtpdec.c | 9 +++-- 1 file changed, 7 inser

[FFmpeg-devel] [PATCH] avformat/rtpdec: attach producer reference time if available

2021-03-23 Thread Alok Priyadarshi
This produces true wallclock time at rtp source instead of the local wallclock time at rtp client. --- libavformat/internal.h | 8 libavformat/rtpdec.c | 20 libavformat/utils.c| 9 + 3 files changed, 37 insertions(+) diff --git a/libavformat/internal

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec: attach producer reference time if available

2021-03-23 Thread Alok Priyadarshi
-f mp4 pipe:1 Without this patch, the prft box contains the local wallclock time instead of that at the rtsp source. On Mon, Mar 22, 2021 at 11:46 AM James Almer wrote: > On 3/17/2021 9:28 PM, Alok Priyadarshi wrote: > > This produces true wallclock time at rtp source instead of the

[FFmpeg-devel] [PATCH] avformat/rtpdec: attach producer reference time if available

2021-03-23 Thread Alok Priyadarshi
This produces true wallclock time at rtp source instead of the local wallclock time at rtp client. --- libavformat/internal.h | 8 libavformat/rtpdec.c | 27 +++ libavformat/utils.c| 9 + 3 files changed, 44 insertions(+) diff --git a/libavformat/i

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec: attach producer reference time if available

2021-03-22 Thread Alok Priyadarshi
This is my first ffmpeg patch, so I am not sure what else I need to do to get it reviewed and submitted. Could someone please let me know? Thanks! On Wed, Mar 17, 2021 at 5:28 PM Alok Priyadarshi wrote: > This produces true wallclock time at rtp source instead of the > local wallclock t

[FFmpeg-devel] [PATCH] avformat/rtpdec: attach producer reference time if available

2021-03-17 Thread Alok Priyadarshi
This produces true wallclock time at rtp source instead of the local wallclock time at rtp client. --- libavformat/internal.h | 8 libavformat/rtpdec.c | 10 ++ libavformat/utils.c| 9 + 3 files changed, 27 insertions(+) diff --git a/libavformat/internal.h b/libav