Hi everybody.
Let me explain reasons here.
About AMF:
1) AMF is a light-weight, portable multimedia framework that provides access to
AMD hardware accelerated encoder, decoder, converters/filters.
2) AMF abstracts away most of the platform and API-specific details and allows
for easy implementat
Jaikrishnan Menon
alsdec.c Thilo Borgmann, Umair Khan
+ amf* Alexander Kravchenko
aptx.cAurelien Jacobs
ass* Aurelien Jacobs
asv
0001-MAINTAINERS-add-myself-to-the-AMF-section.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpe
0001-MAINTAINERS-add-myself-to-the-AMF-section.patch
Description: Binary data
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg
] [PATCH] amfenc: Add support for pict_type field
2019-02-01 19:39 GMT+01:00, Alexander Kravchenko :
I could take manteinership and one person from my team, hopefully
it could help to move pending patches which are required to be
applied and have been waiting for a long time
A good
.
Thanks,
Alexander Kravchenko
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hi guys,
I could take manteinership and one person from my team, hopefully it could help
to move pending patches which are required to be applied and have been waiting
for a long time
Thanks
Alexander
От: ffmpeg-devel от имени Carl Eugen Hoyos
Обратный адрес: FFmpeg development di
Hi Mark,
see my comments bellow.
вт, 30 окт. 2018 г. в 0:23, Mark Thompson :
> On 29/10/18 11:45, Alexander Kravchenko wrote:
> > Hi, Mark.
> > Thanks for review.
> > Could you please check the following comments/questions?
> >
> >> +
>
Hi, Mark.
Thanks for review.
Could you please check the following comments/questions?
> +
> > +static const AVClass amflib_class = {
> > +.class_name = "amf",
> > +.item_name = av_default_item_name,
> > +.version = LIBAVUTIL_VERSION_INT,
> > +};
>
> This class shouldn't be needed - the
Hi Mark,
did you have a chance to review the patches?
I did send them 10 July, and no feedback from you
Could you please review it and send feedback to continue process?
Thanks,
Alexander
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://f
Hello.
It is reminder.
Could you please review the patch? if it is ok, could you please apply it?
It was published 1 month ago (10 July) and it is required for further updates
Thanks,
Alexander
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http
Hello.
It is reminder.
Could you please review the patch? if it is ok, could you apply it?
It was published 2 weeks ago and it is required for further updates
Thanks,
Alexander
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http
---
libavcodec/amfenc.c| 247 +
libavcodec/amfenc.h| 27 +---
libavutil/Makefile | 2 +
libavutil/hwcontext.c | 4 +
libavutil/hwcontext.h | 1 +
libavutil/hwcontext_amf.c | 271 ++
---
Sending updated patch based on Mark's review
1) added RGBA/BGRA
2) in case is device_ctx is set there is only the device hw format will be
allowed as input and output
3) extended amf properties removed for now to have usual for ffmpeg
scaler&format converter interface
4) input frame colorspac
Hi Mark.
Thanks for your review and comments.
See my comments and question bellow
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark
> Thompson
> Sent: Tuesday, June 19, 2018 2:20 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-dev
This patch moves AMF common parts from amfenc to hwcontext_amf.
Now av_hwdevice_ctx API is used for AMF context creation/destroying.
This patch does not change component behaviour.
it contains only restructurization for further patches with new amf components
---
libavcodec/amfenc.c|
---
configure | 1 +
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/vf_scale_amf.c | 620 +
4 files changed, 623 insertions(+)
create mode 100644 libavfilter/vf_scale_amf.c
diff --git a/configure
V12 and P010 textures - split planes
>
> On 27/05/18 07:57, Alexander Kravchenko wrote:
> > сб, 26 мая 2018 г. в 19:45, Mark Thompson :
> >
> >> On 24/05/18 15:26, Mironov, Mikhail wrote:
> >>> AMD has published OpenCL extension which allows split D3D11 te
Hi Mark.
This extension was implemented while ago, so it can be used now.
Thanks,
Alexander
сб, 26 мая 2018 г. в 19:45, Mark Thompson :
> On 24/05/18 15:26, Mironov, Mikhail wrote:
> > AMD has published OpenCL extension which allows split D3D11 texture
> interoped as a single 2D image into two 2D
This patch moves AMF common parts from amfenc to hwcontext_amf.
Now av_hwdevice_ctx API is used for AMF context creation/destroying.
This patch does not change component behaviour.
it contains only restructurization for further patches with new amf components
---
Sending updated patch based on Mar
This patch moves AMF common parts from amfenc to hwcontext_amf.
Now av_hwdevice_ctx API is used for AMF context creation/destroying.
This patch does not change component behaviour.
it contains only restructurization for further patches with new amf components
---
Sending updated patch based on Mar
mpeg-devel] [PATCH] lavc/amfenc: moving amf common code
> (library and context) to lavu/hwcontext_amf from
> amfenc to be reused in other amf components
>
> On 12/05/18 09:48, Alexander Kravchenko wrote:
> > This patch moves AMF common parts from amfenc to hwcontext_amf.
> &g
This patch moves AMF common parts from amfenc to hwcontext_amf.
Now av_hwdevice_ctx API is used for AMF context creation/destroying.
This patch does not change component behaviour.
it contains only restructurization for further patches with new amf components
---
Sending updated patch based on Mar
Hi Mark,
Thank you for your comments.
Could you see my comments and questions bellow
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark
> Thompson
> Sent: Thursday, May 10, 2018 11:43 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpe
This patch moves AMF common parts from amfenc to hwcontext_amf.
Now av_hwdevice_ctx API is used for AMF context creation/destroying.
This patch does not change component behaviour.
it contains only restructurization for further patches with new amf components
---
sending patch one more time in May
This patch moves AMF common parts from amfenc to hwcontext_amf.
Now av_hwdevice_ctx API is used for AMF context creation/destroying
This patch does not change component behaviour,
it contains only restructurization for further patches with new amf components
---
sending patch one more time in May
> -Original Message-
> From: Alexander Kravchenko [mailto:akravchenko...@gmail.com]
> Sent: Thursday, April 26, 2018 10:01 PM
> To: ffmpeg-devel@ffmpeg.org
> Cc: Alexander Kravchenko
> Subject: [PATCH] lavu,lavc/amf: hwcontext_amf phase 1. move AMF library and
>
This patch moves AMF library and AMF device management from amfenc to
hwcontext_amf.
Now av_hwdevice_ctx API is used for AMF library/context creation/destroying
Phase 2 probably will include frame interop/map functions using hwframe_ctx API
---
libavcodec/amfenc.c| 250 --
c: Remove spurious
> initialisations
>
> On 24 April 2018 at 12:29, Alexander Kravchenko
> wrote:
>
> >
> >
> > > -Original Message-
> > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On
> > > Behalf
> > Of Mark Thompso
s
>
> On 15/04/18 20:45, Alexander Kravchenko wrote:
> >> -Original Message-
> >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf
> >> Of Mark Thompson
> >> Sent: Sunday, April 15, 2018 7:31 PM
> >> To: ffmpeg-deve
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark
> Thompson
> Sent: Sunday, April 22, 2018 6:49 PM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/amfenc: DXVA2 textures support
> implementa
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark
> Thompson
> Sent: Sunday, April 15, 2018 7:31 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 5/5] amfenc: Remove spurious
> initialisations
>
>
> > I am waiting
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark
> Thompson
> Sent: Saturday, April 14, 2018 6:54 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: [FFmpeg-devel] [PATCH 5/5] amfenc: Remove spurious initialisations
>
Hi Mark,
I reviewed and
> -Original Message-
> From: Alexander Kravchenko [mailto:akravchenko...@gmail.com]
> Sent: Sunday, April 15, 2018 12:02 AM
> To: 'FFmpeg development discussions and patches'
> Subject: RE: [FFmpeg-devel] [PATCH] lavc/amfenc: DXVA2 textures support
> i
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark
> Thompson
> Sent: Saturday, April 14, 2018 7:15 PM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/amfenc: DXVA2 textures support
> implementation by AMF encode
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark
> Thompson
> Sent: Friday, April 13, 2018 1:27 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/amfenc: device type
> AV_HWDEVICE_TYPE_DXVA2 support
>
Hi Mar
This patch contains DXVA2 textures support implementation by AMF encoder (in
addition of D3D11 textures)
Samples of usage:
DXVA2 decoder -> dxva2_vld texture -> AMF Encoder:
ffmpeg -hwaccel dxva2 -hwaccel_output_format dxva2_vld -extra_hw_frames 16 -i
input.mp4 -an -c:v h264_amf out.mkv
D3D11v
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Carl
> Eugen Hoyos
> Sent: Friday, April 13, 2018 1:24 AM
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/amfenc: DXVA2 textures support
> impleme
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark
> Thompson
> Sent: Friday, April 13, 2018 1:27 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/amfenc: device type
> AV_HWDEVICE_TYPE_DXVA2 support
>
>
> Te
Thread was moved to
[FFmpeg-devel] [PATCH] lavc/amfenc: DXVA2 textures support implementation by
AMF encoder
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
2 textures support
> implementation by AMF encoder
>
> 2018-04-12 23:42 GMT+02:00, Alexander Kravchenko :
> >
> > This patch contains DXVA2 textures support implementation by AMF
> > encoder (in addition of D3D11 textures)
>
> > +if (frames_ctx->device
> -Original Message-
> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark
> Thompson
> Sent: Wednesday, April 11, 2018 2:13 AM
> To: ffmpeg-devel@ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH] lavc/amfenc: Retain a reference to D3D
> frames used as input dur
This patch contains DXVA2 textures support implementation by AMF encoder (in
addition of D3D11 textures)
Samples of usage:
DXVA2 decoder -> dxva2_vld texture -> AMF Encoder:
ffmpeg -hwaccel dxva2 -hwaccel_output_format dxva2_vld -extra_hw_frames 16 -i
input.mp4 -an -c:v h264_amf out.mkv
D3D11v
I am sorry, sending patch one more time. Outlook was wrapping text.
Sending patch in message body and in attachment
---
libavcodec/amfenc.c | 123 +++-
1 file changed, 102 insertions(+), 21 deletions(-)
diff --git a/libavcodec/amfenc.c b/libavcodec
Resending patch (mailer mangled the patch)
---
libavcodec/amfenc.c | 123 +++-
1 file changed, 102 insertions(+), 21 deletions(-)
diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c
index b9418b6791..c1f65f909d 100644
--- a/libavcodec/amfenc.c
+
---
libavcodec/amfenc.c | 123
+++-
1 file changed, 102 insertions(+), 21 deletions(-)
diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c
index b9418b6791..c1f65f909d 100644
--- a/libavcodec/amfenc.c
+++ b/libavcodec/amfenc.c
@@ -24,6 +24,9 @@
Hi, could you please review updated patch?
Fixes according on Mark's review:
* Macroses changed to functions
* error level of AMF_RETURN_IF_FALSE changed to fatal (all cases it returns are
fatal according on fatal error level description)
* used AMF_RETURN_IF_FALSE for case if a frame reference h
used as input during the encoding process
>
> On 06/04/18 11:25, Alexander Kravchenko wrote:
> >>
> >> This breaks the testcase described in
> >> https://trac.ffmpeg.org/ticket/6990 which is basically the same as
> >> the one you described
> >> This breaks the testcase described in
> >> https://trac.ffmpeg.org/ticket/6990 which is basically the same as the
> >> one you described in this patch.
> >>
> >> I get the following spammed repeatedly:
> >>
> >> [AVHWFramesContext @ 0502d340] Static surface pool size exceeded.
> >> [m
>
> This breaks the testcase described in
> https://trac.ffmpeg.org/ticket/6990 which is basically the same as the
> one you described in this patch.
>
> I get the following spammed repeatedly:
>
> [AVHWFramesContext @ 0502d340] Static surface pool size exceeded.
> [mpeg2video @
>
> This breaks the testcase described in
> https://trac.ffmpeg.org/ticket/6990 which is basically the same as the
> one you described in this patch.
>
> I get the following spammed repeatedly:
>
> [AVHWFramesContext @ 0502d340] Static surface pool size exceeded.
> [mpeg2video @
This fixes frame corruption issue when decoder started reusing frames while
they are still in use of encoding process
Issue with frame corruption was reproduced using:
ffmpeg.exe -y -hwaccel d3d11va -hwaccel_output_format d3d11 -i input.h264 -an
-c:v h264_amf output.mkv
Previous questions and
Hello, Mark,
Did you have a chance to review the latest version patch?
Thanks,
Alexander
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Hello.
I fixed couple of issues in previous patch.
So if it is possible to use newer one, could you please review the following
patch.
Subject: amfenc: Retain a reference to D3D frames used as input during the
encoding process
---
libavcodec/amfenc.c | 91 +++
Fixed issues of previous patch
---
libavcodec/amfenc.c | 82 ++---
1 file changed, 78 insertions(+), 4 deletions(-)
diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c
index 89a10ff253..5f3440a9f3 100644
--- a/libavcodec/amfenc.c
+++ b/libavcode
ncy modes?
yes
> Put the * in the right place - it's part of the declarator, not the
> declaration-specifiers.
> "if (", and in all places below too.
I have fixed these issues in whole file (Hopefully you don’t mind if it put to
same commit. There aren't many
56 matches
Mail list logo
