Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback

2022-12-15 Thread Alessandro Di Nepi
Ping on this, Can I contribute somehow either to fix calling `av_videotoolbox_default_init` or at least update the docs? Best Regards, Alessandro On 11 Dec 2022, 11:57 +0200, Alessandro Di Nepi , wrote: > On 9 Dec 2022, 6:45 +0200, FFmpeg development discussions and patches > , wrote: &

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback

2022-12-11 Thread Alessandro Di Nepi
On 9 Dec 2022, 6:45 +0200, FFmpeg development discussions and patches , wrote: > Did you call av_videotoolbox_default_init() or > av_videotoolbox_default_init2()? Actually yes, I call `av_videotoolbox_default_init(context);` > I think that’s why avctx->internal->hwaccel_priv_data is NULL. That co

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback

2022-12-06 Thread Alessandro Di Nepi
change, reverting is not an option. Looking forward to hear feedback on this. Best Regards Alessandro On 6 Dec 2022, 7:20 +0200, "zhilizhao(赵志立)" , wrote: > > > On Dec 5, 2022, at 21:36, Rick Kern wrote: > > > > On Sun, Dec 4, 2022 at 12:51 PM Alessandro Di Nepi < &

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback

2022-12-04 Thread Alessandro Di Nepi
On 4 Dec 2022, 17:01 +0200, FFmpeg development discussions and patches , wrote: > When this happens, does it continue happening, or is it transient? My main > concern is log spamming. Good question: this is just a transient state, so that it won't continue happening. To give you some context: whe

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback

2022-12-04 Thread Alessandro Di Nepi
A gentle reminder for this patch: it's a simple fix that prevents crashing on iOS. Thanks ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-req

Re: [FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback

2022-11-29 Thread Alessandro Di Nepi
Just to add that this fix, once approved, should be cherry-picked to all the release branches where d7f4ad88a0df3c1339e142957bf2c40cd056b8ce has been cherry-picked. Basically, 4.4, 5.0, and 5.1. Thanks On 27 Nov 2022, 19:34 +0200, Alessandro Di Nepi , wrote: > The com

[FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback

2022-11-27 Thread Alessandro Di Nepi
The commit d7f4ad88a0df3c1339e142957bf2c40cd056b8ce introduced a race condition where the passed opaque pointer reference might be NULL, when the decoding process starts. This patch checks that vtctx has a value before accessing it. This patch fixes #10079. Signed-off-by: Alessandro Di Nepi

[FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback

2022-11-27 Thread Alessandro Di Nepi
The commit d7f4ad88a0df3c1339e142957bf2c40cd056b8ce introduced a race condition where the passed opaque pointer reference might be NULL, when the decoding process starts. This patch checks that vtctx has a value before accessing it. This patch fixes #10079. Signed-off-by: Alessandro Di Nepi