[FFmpeg-devel] Initialize `layout_map` on declaration

2020-08-28 Thread
Resend with @chromium.org account. Sorry for the noise. From 3f9a085802bec62c9c7d35efcd30107e348c54d4 Mon Sep 17 00:00:00 2001 From: Xiaohan Wang Date: Fri, 28 Aug 2020 12:51:19 -0700 Subject: [PATCH] Initialize `layout_map` on declaration Without this change, it'll cause use-of-uninitialized-var

Re: [FFmpeg-devel] Fix stts_data memory allocation

2018-03-06 Thread
kingly ping! On Tue, Feb 13, 2018 at 4:08 PM, Xiaohan Wang (王消寒) wrote: > "unsigned" is perfectly fine. Just trying to be consistent with the line > above. > > On Tue, Feb 13, 2018 at 4:06 PM, Carl Eugen Hoyos > wrote: > >> 2018-02-13 23:48 GMT+01:00 Xiaoha

Re: [FFmpeg-devel] Fix memset size on ctts_data in mov_read_trun()

2018-02-27 Thread
Sure. Updated! On Tue, Feb 27, 2018 at 2:38 AM, Michael Niedermayer wrote: > On Mon, Feb 26, 2018 at 10:37:51AM -0800, Xiaohan Wang (王消寒) wrote: > > Thanks! Updated the patch. Please take a look again. > > > > On Sat, Feb 24, 2018 at 7:04 PM, Michael Niedermayer > >

Re: [FFmpeg-devel] Fix memset size on ctts_data in mov_read_trun()

2018-02-26 Thread
Thanks! Updated the patch. Please take a look again. On Sat, Feb 24, 2018 at 7:04 PM, Michael Niedermayer wrote: > On Fri, Feb 23, 2018 at 05:12:05PM -0800, Xiaohan Wang (王消寒) wrote: > > Michael: Dale and I dig into history a bit more and we don't understand > why > > the

Re: [FFmpeg-devel] Fix memset size on ctts_data in mov_read_trun()

2018-02-23 Thread
e new patch. Thanks! On Wed, Feb 21, 2018 at 1:14 PM, Xiaohan Wang (王消寒) wrote: > jstebbins: kindly ping! > > On Fri, Feb 16, 2018 at 2:42 PM, Xiaohan Wang (王消寒) > wrote: > >> +jstebbins@ who wrote that code. >> >> On Fri, Feb 16, 2018 at 12:30 PM, Michael Niederma

Re: [FFmpeg-devel] Fix memset size on ctts_data in mov_read_trun()

2018-02-21 Thread
jstebbins: kindly ping! On Fri, Feb 16, 2018 at 2:42 PM, Xiaohan Wang (王消寒) wrote: > +jstebbins@ who wrote that code. > > On Fri, Feb 16, 2018 at 12:30 PM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > >> On Thu, Feb 15, 2018 at 12:10:33PM -080

Re: [FFmpeg-devel] Fix memset size on ctts_data in mov_read_trun()

2018-02-16 Thread
+jstebbins@ who wrote that code. On Fri, Feb 16, 2018 at 12:30 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Thu, Feb 15, 2018 at 12:10:33PM -0800, Xiaohan Wang (王消寒) wrote: > > > > > mov.c |3 ++- > > 1 file change

[FFmpeg-devel] Fix memset size on ctts_data in mov_read_trun()

2018-02-15 Thread
From 7c1e6b50ebe35b2a38c4f1d0a988e31eccbd0ead Mon Sep 17 00:00:00 2001 From: Xiaohan Wang Date: Thu, 15 Feb 2018 12:05:53 -0800 Subject: [PATCH] ffmpeg: Fix memset size on ctts_data in mov_read_trun() The allocated size of sc->ctts_data is (st->nb_index_entries + entries) * sizeof(*sc->ctts_data

Re: [FFmpeg-devel] Fix stts_data memory allocation

2018-02-13 Thread
"unsigned" is perfectly fine. Just trying to be consistent with the line above. On Tue, Feb 13, 2018 at 4:06 PM, Carl Eugen Hoyos wrote: > 2018-02-13 23:48 GMT+01:00 Xiaohan Wang (王消寒) : > > Thank you for the fix! > (What's wrong with

[FFmpeg-devel] Fix stts_data memory allocation

2018-02-13 Thread
From 241d5e45eb8750521d07d07aa55ea637359ab55d Mon Sep 17 00:00:00 2001 From: Xiaohan Wang Date: Tue, 13 Feb 2018 14:45:14 -0800 Subject: [PATCH] ffmpeg: Fix stts_data memory allocation In this loop, |i| is the "index". And the memory allocated should be at least the current "count", which is |i

Re: [FFmpeg-devel] Abort early on decode_slice error

2018-02-13 Thread
New patch as discussed offline: On Sat, Feb 3, 2018 at 2:29 AM, Xiaohan Wang (王消寒) wrote: > > From e8ad6159640c913773583a8b551ecebcff6b9c63 Mon Sep 17 00:00:00 2001 From: Xiaohan Wang Date: Sat, 3 Feb 2018 01:43:35 -0800 Subject: [PATCH] ffmpeg: Set valid qscale va

Re: [FFmpeg-devel] Fix ctts_index calculation

2018-02-09 Thread
p;ct=xref_jump_to_ > def&gsn=index&rcl=184932376> > >= 0 && (*ctts_index > <https://cs.corp.google.com/piper///depot/google3/third_ > party/ffmpeg/next/libavformat/mov.c?l=3124&ct=xref_jump_to_ > def&gsn=ctts_index&rcl=184932376>) > >= 0) { > we a

[FFmpeg-devel] Abort early on decode_slice error

2018-02-03 Thread
0001-ffmpeg-Abort-early-on-decode_slice-error.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Fix ctts_index calculation

2018-02-02 Thread
From bb376fd2de5da5f9ecdef41621a579252b899d7d Mon Sep 17 00:00:00 2001 From: Xiaohan Wang Date: Fri, 2 Feb 2018 17:33:56 -0800 Subject: [PATCH] Fix ctts_index calculation An index should never be equal to the count. Hence we must make sure *ctts_index < ctts_count. --- libavformat/mov.c | 2 +-

[FFmpeg-devel] Remove carriage return ('\r') in Windows CC_IDENT

2018-01-31 Thread
From 07e33b2aa09b8b224ac35a5b56b29490a6486bdf Mon Sep 17 00:00:00 2001 From: Xiaohan Wang Date: Wed, 31 Jan 2018 14:20:02 -0800 Subject: [PATCH] Remove carriage return ('\r') in Windows CC_IDENT Currently the Windows CC_IDENT is ended with '\r\n'. "head -n1" will not remove the '\r' and this is

[FFmpeg-devel] Fix read-after-free in matroska_read_seek()

2014-11-07 Thread
Hello ffmpeg-devel: This is my first patch to FFmpeg, let me know if I am doing anything wrong :) This is a small patch to fix a read-after-free error in matroskadec.c. Please take a look. Xiaohan From 45a523e9213cc887aa90cdf4953e66918b34f689 Mon Sep 17 00:00:00 2001 From: Xiaohan Wang Date: Th