Re: [FFmpeg-devel] Plugins architecture

2025-08-11 Thread Lynne
On 11/08/2025 22:10, Michael Niedermayer wrote: Hi Lynne On Mon, Aug 11, 2025 at 09:22:26PM +0900, Lynne wrote: [...] To me, at least, I can imagine five options: Option 1 - we have an official binary plugin interface, free for everyone to use with no limitation. That requires so

Re: [FFmpeg-devel] Plugins architecture

2025-08-11 Thread Lynne
On 11/08/2025 21:43, Michael Niedermayer wrote: Hi Lynne On Mon, Aug 11, 2025 at 09:22:26PM +0900, Lynne wrote: Recently, the issue of plugins was raised. Michael pushed a patch to enable out of tree branches to be freely added to FFmpeg. I did not very much like the option of having officiall

[FFmpeg-devel] [PATCH] avcodec/x86/vc1dsp: add missing header for HAVE_6REGS (PR #20221)

2025-08-11 Thread Kacper Michajłow
PR #20221 opened by Kacper Michajłow (kasper93) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20221 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20221.patch x86/vc1dsp_init.c already includes asm.h before, so this is mostly cosmetic change and only to clean checkheaders warning. Sign

Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-08-11 Thread Romain Beauxis
Le lun. 11 août 2025 à 19:21, Romain Beauxis a écrit : > > Le lun. 11 août 2025 à 17:31, Yalda a écrit : > > > > Hi Romain, > > Hi! > > > I can try to help out here. > > I am not familiar with the OGG spec but I can at least help with > > reviews/facilitate to a degree, and it's free so I can rea

Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-08-11 Thread Romain Beauxis
Le lun. 11 août 2025 à 17:31, Yalda a écrit : > > Hi Romain, Hi! > I can try to help out here. > I am not familiar with the OGG spec but I can at least help with > reviews/facilitate to a degree, and it's free so I can read if needed. > > It seems you are trying to fix issues in and improve OGG

Re: [FFmpeg-devel] [PATCH v2.1 2/2] avformat/udp: Select output interfaces for ipv6 multicast

2025-08-11 Thread Michael Niedermayer
Hi Peter On Fri, Aug 08, 2025 at 09:27:35AM +0200, Peter Enderborg wrote: > This fixes two old TODO's in ipv6 multicast handling. > If the system as SIOCGIFINDEX ioctl a helper function to iterate over > all interfaces added to join the multicast group on interface if approperite. > > The default

Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.

2025-08-11 Thread Yalda
Hi Romain, I can try to help out here. I am not familiar with the OGG spec but I can at least help with reviews/facilitate to a degree, and it's free so I can read if needed. It seems you are trying to fix issues in and improve OGG support. Can you give me a brief summary of your goals? (i.e. wha

Re: [FFmpeg-devel] [PATCH v2.1 1/2] configure: Add test_ioctl and test for SIOCGIFINDEX

2025-08-11 Thread Michael Niedermayer
Hi Peter On Fri, Aug 08, 2025 at 09:27:34AM +0200, Peter Enderborg wrote: > Adds a generic ioctl tester and a specific test SIOCGIFINDEX > that sets ioctl_gifindex. It is a network specific feature > and the tests are run only in network context. > > Signed-off-by: Peter Enderborg > --- > conf

Re: [FFmpeg-devel] [PATCH] libavutil/tests/lzo: Add check to avoid potential NULL pointer dereference

2025-08-11 Thread Michael Niedermayer
On Fri, Aug 08, 2025 at 02:08:42AM +, Jiasheng Jiang wrote: > Add av_free() if qf_vid is NULL to avoid potential memory leak. > > Fixes: 5d48e4eafa ("Merge commit 'a6a750c7ef240b72ce01e9653343a0ddf247d196'") > Signed-off-by: Jiasheng Jiang > --- > libavutil/tests/lzo.c | 6 ++ > 1 file c

[FFmpeg-devel] [PATCH] configure: use proper Windows-style static library naming (PR #20220)

2025-08-11 Thread Kacper Michajłow
PR #20220 opened by Kacper Michajłow (kasper93) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20220 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20220.patch On Windows, static libraries are typically named with a .lib extension. An exception to this is MinGW targets, which are treated

[FFmpeg-devel] [PATCH v2] tests/api/api-h264-test: Add proper error handling to avoid potential memory leaks

2025-08-11 Thread Jiasheng Jiang
Add proper error handling to free allocated memory to avoid potential memory leaks. Fixes: ca3b274552 ("api-h264-test: build with another api test") Signed-off-by: Jiasheng Jiang --- Changelog: v1 -> v2: 1. Fix the goto labels. --- tests/api/api-h264-test.c | 49 +-

Re: [FFmpeg-devel] [PATCH] tools/scale_slice_test: Add av_frame_free() to avoid potential memory leaks

2025-08-11 Thread Michael Niedermayer
On Sat, Aug 09, 2025 at 03:10:20AM +, Jiasheng Jiang wrote: > Add av_frame_free() to release frame to avoid potential memory leaks. > > Fixes: 5fdb5ed613 ("FATE: add a test for sliced scaling") > Signed-off-by: Jiasheng Jiang > --- > tools/scale_slice_test.c | 2 ++ > 1 file changed, 2 inser

Re: [FFmpeg-devel] [PATCH] tests/api/api-h264-test: Add proper error handling to avoid potential memory leaks

2025-08-11 Thread Michael Niedermayer
On Fri, Aug 08, 2025 at 07:22:29PM +, Jiasheng Jiang wrote: [...] > @@ -69,44 +70,49 @@ static int video_decode_example(const char > *input_filename) > codec = avcodec_find_decoder(origin_par->codec_id); > if (!codec) { > av_log(NULL, AV_LOG_ERROR, "Can't find decoder\n"); >

Re: [FFmpeg-devel] Forgejo entry threshold

2025-08-11 Thread Michael Niedermayer
Hi Remi On Fri, Aug 08, 2025 at 10:14:52AM +0700, Rémi Denis-Courmont wrote: > > > Le 7 août 2025 19:37:32 GMT+07:00, Nicolas George a écrit : > >Rémi Denis-Courmont (HE12025-08-07): > >> Sure. You can send a list of patch files... And make it even more > >> difficult to review, > > > >What? A

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Michael Niedermayer
On Mon, Aug 11, 2025 at 08:04:02PM +0800, Zhao Zhili wrote: > > > > On Aug 11, 2025, at 18:51, Michael Niedermayer > > wrote: > > > > On Mon, Aug 11, 2025 at 11:37:55AM +0300, quink wrote: > >> PR #20212 opened by quink > >> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212 > >> Patch URL

Re: [FFmpeg-devel] Plugins architecture

2025-08-11 Thread Jacob Lifshay
On August 11, 2025 6:10:52 AM PDT, Michael Niedermayer wrote: > On Mon, Aug 11, 2025 at 09:22:26PM +0900, Lynne wrote: > > Option 3 - we have an official source plugin interface, free for > >everyone to use, with license limitations. All source plugins > >The list of so

Re: [FFmpeg-devel] Plugins architecture

2025-08-11 Thread Jacob Lifshay
On August 11, 2025 5:22:26 AM PDT, Lynne wrote: > I would like to hear other options or suggestions that developers may have, > and ultimately, if there's a consensus on the amount of options that that the > project would benefit from having a plugins interface, a vote on the type of > interfac

[FFmpeg-devel] [PATCH] avcodec/mjpegdec: decode only SOF fields when finding stream info (PR #20219)

2025-08-11 Thread ramiro
PR #20219 opened by ramiro URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20219 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20219.patch When called from avformat_find_stream_info(), we are only interested in decoding SOF fields. This patch makes the decoder skip all other fields (inc

[FFmpeg-devel] [PATCH] forgejo/workflows: make linter only run on changed files in a PR (PR #20218)

2025-08-11 Thread Timo Rothenpieler
PR #20218 opened by Timo Rothenpieler (BtbN) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20218 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20218.patch >From ca8f1a6a88958c07d94a972e62a0f74a78eee681 Mon Sep 17 00:00:00 2001 From: Timo Rothenpieler Date: Mon, 11 Aug 2025 18:47:48 +

[FFmpeg-devel] [PATCH] avfilter: use AVFilterContext for logging (PR #20217)

2025-08-11 Thread Niklas Haas
PR #20217 opened by Niklas Haas (haasn) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20217 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20217.patch The vast majority of av_log() calls use the `AVFilterContext *ctx` for logging, which enables custom logic such as printing the specifi

[FFmpeg-devel] [PATCH] avcodec/cbs_apv: store derived tile information in a per frame basis (PR #20216)

2025-08-11 Thread James Almer
PR #20216 opened by James Almer (jamrial) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20216 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20216.patch If a single fragment contains more than one frame unit, the tile information stored in the private context will only correspond to on

[FFmpeg-devel] [PATCH] aacdec_usac: use RefStruct to track unfinished extension buffers (PR #20215)

2025-08-11 Thread Lynne
PR #20215 opened by Lynne URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20215 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20215.patch Extensions in AAC USAC can be stored across multiple frames (mainly to keep CBR compliance). This means that we need to reallocate a buffer when new

[FFmpeg-devel] [PATCH] aacdec_usac: use RefStruct to track unfinished extension buffers

2025-08-11 Thread Lynne
Extensions in AAC USAC can be stored across multiple frames (mainly to keep CBR compliance). This means that we need to reallocate a buffer when new data is received, accumulate the bitstream data, and so on until the end of extension flag is signalled and the extension can be decoded. This is

Re: [FFmpeg-devel] Plugins architecture

2025-08-11 Thread Michael Niedermayer
Hi Lynne On Mon, Aug 11, 2025 at 09:22:26PM +0900, Lynne wrote: [...] > To me, at least, I can imagine five options: > > Option 1 - we have an official binary plugin interface, free for >everyone to use with no limitation. That requires someone to create that "binary plugin interface

Re: [FFmpeg-devel] Plugins architecture

2025-08-11 Thread Michael Niedermayer
Hi Lynne On Mon, Aug 11, 2025 at 09:22:26PM +0900, Lynne wrote: > Recently, the issue of plugins was raised. > > Michael pushed a patch to enable out of tree branches to be freely added to > FFmpeg. I did not very much like the option of having officially-endorsed > source plugins, as to me, it m

[FFmpeg-devel] Plugins architecture

2025-08-11 Thread Lynne
Recently, the issue of plugins was raised. Michael pushed a patch to enable out of tree branches to be freely added to FFmpeg. I did not very much like the option of having officially-endorsed source plugins, as to me, it moved all the burden of maintenance to FFmpeg maintainers. The commit wa

Re: [FFmpeg-devel] [PATCH] Revert "doc/developer: Basic documentation for Source Plugins" (PR #20213)

2025-08-11 Thread Nicolas George
Nicolas George (HE12025-08-11): > I do not like it either, especially because it weakens the intent to > bring libpostproc back properly, but Michael made the decision and the > time to object it was before > “12b853530a Add tools/merge-all-source-plugins”. I see it has been pushed depite this and

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Zhao Zhili
> On Aug 11, 2025, at 18:51, Michael Niedermayer wrote: > > On Mon, Aug 11, 2025 at 11:37:55AM +0300, quink wrote: >> PR #20212 opened by quink >> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212 >> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212.patch >> >> A set of files

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec/libaom: Add test for HDR10+ metadata support

2025-08-11 Thread Maryla Ustarroz via ffmpeg-devel
On Mon, Aug 11, 2025 at 1:57 PM Maryla Ustarroz-Calonge wrote: > > Signed-off-by: Maryla Ustarroz-Calonge > --- > tests/Makefile | 1 + > tests/fate/av1.mak | 7 + > tests/ref/fate/libaom-hdr10-plus | 44 > 3 files changed, 5

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/libaom: Add HDR10+ metadata support

2025-08-11 Thread Maryla Ustarroz via ffmpeg-devel
On Mon, Aug 11, 2025 at 1:57 PM Maryla Ustarroz-Calonge wrote: > > Signed-off-by: Maryla Ustarroz-Calonge > --- > Changelog | 1 + > libavcodec/libaomdec.c | 63 ++ > libavcodec/libaomenc.c | 55 > libavco

[FFmpeg-devel] [PATCH v3 2/2] avcodec/libaom: Add test for HDR10+ metadata support

2025-08-11 Thread Maryla Ustarroz-Calonge via ffmpeg-devel
Signed-off-by: Maryla Ustarroz-Calonge --- tests/Makefile | 1 + tests/fate/av1.mak | 7 + tests/ref/fate/libaom-hdr10-plus | 44 3 files changed, 52 insertions(+) create mode 100644 tests/fate/av1.mak create mode 100644 tes

[FFmpeg-devel] [PATCH v3 1/2] avcodec/libaom: Add HDR10+ metadata support

2025-08-11 Thread Maryla Ustarroz-Calonge via ffmpeg-devel
Signed-off-by: Maryla Ustarroz-Calonge --- Changelog | 1 + libavcodec/libaomdec.c | 63 ++ libavcodec/libaomenc.c | 55 libavcodec/version.h | 2 +- 4 files changed, 120 insertions(+), 1 deletion(-) di

[FFmpeg-devel] [PATCH] fate: Fix the sub-mcc tests on Windows in eastern time zones (PR #20214)

2025-08-11 Thread Martin Storsjö
PR #20214 opened by Martin Storsjö (mstorsjo) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20214 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20214.patch Previously, these tests failed when running on Windows, if the system is configured with a time zone east of Greenwich, i.e. with

Re: [FFmpeg-devel] [PATCH] Revert "doc/developer: Basic documentation for Source Plugins" (PR #20213)

2025-08-11 Thread Nicolas George
Lynne (HE12025-08-11): > PR #20213 opened by Lynne > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20213 > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20213.patch > > This reverts commit 67320e0627a3b0210794c8f58e3e6acceb074b5c. > > We do not want random forks or features. I do not

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Zhao Zhili
> Zhao Zhili (HE12025-08-11): > > Commit has been updated as: >  > Thanks. But we still need to know if some other software recognizes > these files. FFmpeg is not in the business to decide to recognize widely > invalid files on its own. >  > If no other software already recognizes these files with

[FFmpeg-devel] [PATCH, v7] avcodec/d3d12va_encode: texture array support for HEVC

2025-08-11 Thread Araz Iusubov
This patch adds support for the texture array feature used by AMD boards in the D3D12 HEVC encoder. In texture array mode, a single texture array is shared for all reference and reconstructed pictures using different subresources. The implementation ensures compatibility and has been successfully t

[FFmpeg-devel] [PATCH] Revert "doc/developer: Basic documentation for Source Plugins" (PR #20213)

2025-08-11 Thread Lynne
PR #20213 opened by Lynne URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20213 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20213.patch This reverts commit 67320e0627a3b0210794c8f58e3e6acceb074b5c. We do not want random forks or features. >From 85e8e590015e918462031cac21c9c5862a1776

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Nicolas George
Zhao Zhili (HE12025-08-11): > I think you missed this line: > > > Chrome recognize these files as valid. I missed it indeed. Sorry. Add the missing s at the end of the verb and I have no objection. > And I think it's not uncommon for FFmpeg being the only known (opensource) > software to support

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Michael Niedermayer
On Mon, Aug 11, 2025 at 11:37:55AM +0300, quink wrote: > PR #20212 opened by quink > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212 > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212.patch > > A set of files begins with the following byte sequence. > > 4c 41 4d 45 33

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Nicolas George
Zhao Zhili (HE12025-08-11): > Commit has been updated as: Thanks. But we still need to know if some other software recognizes these files. FFmpeg is not in the business to decide to recognize widely invalid files on its own. If no other software already recognizes these files without forcing the

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Zhao Zhili
> On Aug 11, 2025, at 17:51, Nicolas George wrote: > > Zhao Zhili (HE12025-08-11): >> Any suggestions? > > “Recognize files …ing with … as MP3 with score …” > >>> What other software manages to recognize these files as valid? >> ffplay -f mp3 works as expected. > > ffplay is not other softwa

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Nicolas George
Zhao Zhili (HE12025-08-11): > Any suggestions? “Recognize files …ing with … as MP3 with score …” > > What other software manages to recognize these files as valid? > ffplay -f mp3 works as expected. ffplay is not other software, and it cannot be said to recognize the file if you have to specify

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Zhao Zhili
> On Aug 11, 2025, at 16:40, Nicolas George wrote: > > quink (HE12025-08-11): >> PR #20212 opened by quink >> URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212 >> Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212.patch >> >> A set of files begins with the following byte sequen

Re: [FFmpeg-devel] [PATCH] lavfi: protection against premultiplied alpha (was: The patch series about premultiplied alpha)

2025-08-11 Thread Nicolas George
Niklas Haas (HE12025-08-11): > I still think this series overall is a step in the wrong direction; and that > our goal should be to move towards negotiation, and not towards some IMO hacky > flag that is already deprecated on arrival. In terms of work, this patch series is 5% trivial code easily r

Re: [FFmpeg-devel] [PATCH] lavfi: protection against premultiplied alpha (was: The patch series about premultiplied alpha)

2025-08-11 Thread Niklas Haas
On Mon, 11 Aug 2025 11:18:12 +0200 Niklas Haas wrote: > On Sun, 03 Aug 2025 20:15:09 +0200 Nicolas George wrote: > > Nicolas George (HE12025-08-03): > > > I will send the series here in a few hours. > > > > Here is a series of patch. I am absolutely not sure I found all the > > filters that could

Re: [FFmpeg-devel] [PATCH] lavfi: protection against premultiplied alpha (was: The patch series about premultiplied alpha)

2025-08-11 Thread Niklas Haas
On Sun, 03 Aug 2025 20:15:09 +0200 Nicolas George wrote: > Nicolas George (HE12025-08-03): > > I will send the series here in a few hours. > > Here is a series of patch. I am absolutely not sure I found all the > filters that could be flagged, but the rest can be done as the need > arises. > > Not

Re: [FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread Nicolas George
quink (HE12025-08-11): > PR #20212 opened by quink > URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212 > Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212.patch > > A set of files begins with the following byte sequence. > > 4c 41 4d 45 33 2e 31 30 30 aa aa aa aa aa aa

[FFmpeg-devel] [PATCH] avformat/mp3dec: Workaround mp3 detection failure (PR #20212)

2025-08-11 Thread quink
PR #20212 opened by quink URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20212.patch A set of files begins with the following byte sequence. 4c 41 4d 45 33 2e 31 30 30 aa aa aa aa aa aa aa |LAME3.100...| 0010 aa a

[FFmpeg-devel] [PATCH] avfilter/vf_libplacebo: fix possible segfault when frame mixing (PR #20211)

2025-08-11 Thread Niklas Haas
PR #20211 opened by Niklas Haas (haasn) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20211 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20211.patch pl_frame_mix_current() will return NULL if all frames are in the future, but when libplacebo is using a frame mixer with a radius greate